zynq: ignore ps7_init.h
PATCH 1/1 zynq: ignore ps7_init.h
ps_init.h should be ignored because it is supposed to be copied from an external project.
--- board/xilinx/zynq/.gitignore | 1 + 1 file changed, 1 insertion(+) create mode 100644 board/xilinx/zynq/.gitignore
board/xilinx/zynq/.gitignore new file +1 -0
@@ -0,0 +1 @@ +ps7_init.h
Signature · 1 line
1.8.3.2
PATCH 1/1 zynq: ignore ps7_init.h
Quoted 17 lines · Masahiro Yamada
ps_init.hshould be ignored because it is supposed to be copied from an external project.Signed-off-by Masahiro Yamada <[email protected]>Cc Michal Simek <[email protected]>--- board/xilinx/zynq/.gitignore | 1 + 1 file changed, 1 insertion(+) create mode 100644 board/xilinx/zynq/.gitignoreboard/xilinx/zynq/.gitignore new file +0
-0
board/xilinx/zynq/.gitignore line 1
Quoted 1 line
board/xilinx/zynq/.gitignore new file +1
-0@@ -0,0 +1 @@ +ps7_init.h
Here is just one question if we should also ignore ps7_init.c too. It means move current ps7_init weak function to spl.c in mach-zynq and just compile ps7_init.c in board file if it is available there.
Is there any nice hook in Kbuild to compile file if it is available?
Something like
[ -f ps7_init.c ] && compile it
Then we can just move weak function
and ignore ps7_init.c/h files in board file.
Thanks,
Michal
Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 263 bytes Desc: OpenPGP digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140508/15ebd4c3/attachment.pgp>
PATCH 1/1 zynq: ignore ps7_init.h
Hi Michal,
Quoted 9 lines
Here is just one question if we should also ignore
ps7_init.ctoo. It means move currentps7_initweak function tospl.cin mach-zynq and just compileps7_init.cin board file if it is available there.Is there any nice hook in
Kbuildto compile file if it is available?Something like
[ -fps7_init.c] && compile it
Nice suggestion!
Quoted 3 lines
Then we can just move weak function
and ignore ps7_init.c/h files in board file.
This might not be beautiful very much, but we can write board/xilinx/zynq/Makefile like this:
obj-y := board.o
obj-$(CONFIG_SPL_BUILD) += $(if $(wildcard $(srctree)/$(src)/ps7_init.c),ps7_init.o)
Best Regards
Masahiro Yamada
PATCH 1/1 zynq: ignore ps7_init.h
Quoted 19 lines · Masahiro Yamada
Hi Michal,
Quoted 9 lines
Here is just one question if we should also ignore
ps7_init.ctoo. It means move currentps7_initweak function tospl.cin mach-zynq and just compileps7_init.cin board file if it is available there.Is there any nice hook in
Kbuildto compile file if it is available?Something like
[ -fps7_init.c] && compile itNice suggestion!
Quoted 3 lines
Then we can just move weak function
and ignore ps7_init.c/h files in board file.
Quoted 5 lines
This might not be beautiful very much, but we can write board/xilinx/zynq/Makefile like this:
obj-y := board.o
obj-$(CONFIG_SPL_BUILD) += $(if $(wildcard $(srctree)/$(src)/ps7_init.c),ps7_init.o)
If this is acceptable by others I am quite happy to use it because it seems to me like a good way how to handle it.
In future when everything is ready I expect that these ps7_init.c/h files will go away and information will be read directly from DTS but we are not there yet.
Anyway: Can you please prepare that patches? I am quite happy to test them and adding it to my zynq queue and send it to Albert.
Or do you want me to prepare them?
Thanks,
Michal
Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 263 bytes Desc: OpenPGP digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140508/e17bb3c5/attachment.pgp>
PATCH 1/1 zynq: ignore ps7_init.h
Hi Michal,
Quoted 11 lines
Quoted 2 lines
obj-y := board.o
obj-$(CONFIG_SPL_BUILD) += $(if $(wildcard $(srctree)/$(src)/ps7_init.c),ps7_init.o)If this is acceptable by others I am quite happy to use it because it seems to me like a good way how to handle it.
In future when everything is ready I expect that these ps7_init.c/h files will go away and information will be read directly from DTS but we are not there yet.
Anyway: Can you please prepare that patches?
Sure.
Please check out
http://patchwork.ozlabs.org/patch/347023/
Best Regards
Masahiro Yamada