ARM: EXYNOS: Map SYSRAM through generic SRAM bindings

PATCH New Sachin Kamat 6 participants 11 messages May 8, 2014 – May 14, 2014

Subsystems (4)

Device tree bindings Arm (32-bit) Arm sub-architectures Arm Samsung Exynos

lore

Share & tools

lore

Sachin Kamat

author

2014-05-08 04:16 UTC #0 lore raw

PATCH v3 1/2 ARM: EXYNOS: Map SYSRAM through generic SRAM bindings

Instead of hardcoding the SYSRAM details for each SoC, pass this information through device tree (DT) and make the code SoC agnostic. Generic SRAM bindings are used for achieving this.

Signed-off-by Sachin Kamat <[email protected]>

Acked-by Arnd Bergmann <[email protected]>

Acked-by Heiko Stuebner <[email protected]>

---
Changes since v2.
* Updated sysram node for Universal C210 board - Thanks to Tomasz Figa for testing and updating the same.
* Added error handling code.
* Break if matching node found.
* Remove unnecessary error messages.

This patch is based on linux next (next-20140501) on top of my Kconfig consolidation patch
http://comments.gmane.org/gmane.linux.kernel.samsung-soc/28642

Tested on 4210/4412 Origen, 5250/5420 Arndale and SMDK5420 boards.

---
 arch/arm/Kconfig                                |    1 +
 arch/arm/boot/dts/exynos4210-universal_c210.dts |   15 ++++++
 arch/arm/boot/dts/exynos4210.dtsi               |   18 +++++++
 arch/arm/boot/dts/exynos4x12.dtsi               |   18 +++++++
 arch/arm/boot/dts/exynos5250.dtsi               |   18 +++++++
 arch/arm/boot/dts/exynos5420.dtsi               |   18 +++++++
 arch/arm/mach-exynos/common.h                   |    1 +
 arch/arm/mach-exynos/exynos.c                   |   64 -----------------------
 arch/arm/mach-exynos/firmware.c                 |    8 ++-
 arch/arm/mach-exynos/include/mach/map.h         |    7 ---
 arch/arm/mach-exynos/platsmp.c                  |   56 ++++++++++++++++++--
 11 files changed, 148 insertions(+), 76 deletions(-)

arch/arm/Kconfig +1 -0

index a6aaaad19b1a..f66ea9453df9 100644
@@ -855,6 +855,7 @@ config ARCH_EXYNOS
 	select S5P_DEV_MFC
 	select SAMSUNG_DMADEV
 	select SPARSE_IRQ
+	select SRAM
 	select USE_OF
 	help
 	  Support for SAMSUNG's EXYNOS SoCs (EXYNOS4/5)

arch/arm/boot/dts/exynos4210-universal_c210.dts +15 -0

index 63e34b24b04f..a62c0ff25917 100644
@@ -28,6 +28,21 @@
 		bootargs = "console=ttySAC2,115200N8 root=/dev/mmcblk0p5 rw rootwait earlyprintk panic=5 maxcpus=1";
 	};
 
+	sram at 02020000 {
+		smp-sram at 0 {
+			status = "disabled";
+		};
+
+		smp-sram at 5000 {
+			compatible = "samsung,exynos4210-sram";
+			reg = <0x5000 0x1000>;
+		};
+
+		smp-sram at 1f000 {
+			status = "disabled";
+		};
+	};
+
 	mct at 10050000 {
 		compatible = "none";
 	};

arch/arm/boot/dts/exynos4210.dtsi +18 -0

index cacf6140dd2f..d3d727b0c263 100644
@@ -31,6 +31,24 @@
 		pinctrl2 = &pinctrl_2;
 	};
 
+	sram at 02020000 {
+		compatible = "mmio-sram";
+		reg = <0x02020000 0x20000>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges = <0 0x02020000 0x20000>;
+
+		smp-sram at 0 {
+			compatible = "samsung,exynos4210-sram";
+			reg = <0x0 0x1000>;
+		};
+
+		smp-sram at 1f000 {
+			compatible = "samsung,exynos4210-sram-ns";
+			reg = <0x1f000 0x1000>;
+		};
+	};
+
 	pd_lcd1: lcd1-power-domain at 10023CA0 {
 		compatible = "samsung,exynos4210-pd";
 		reg = <0x10023CA0 0x20>;

arch/arm/boot/dts/exynos4x12.dtsi +18 -0

index c4a9306f8529..75fb3e7e3999 100644
@@ -37,6 +37,24 @@
 		interrupts = <2 2>, <3 2>, <18 2>, <19 2>;
 	};
 
+	sram at 02020000 {
+		compatible = "mmio-sram";
+		reg = <0x02020000 0x40000>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges = <0 0x02020000 0x40000>;
+
+		smp-sram at 0 {
+			compatible = "samsung,exynos4210-sram";
+			reg = <0x0 0x1000>;
+		};
+
+		smp-sram at 2f000 {
+			compatible = "samsung,exynos4210-sram-ns";
+			reg = <0x2f000 0x1000>;
+		};
+	};
+
 	pd_isp: isp-power-domain at 10023CA0 {
 		compatible = "samsung,exynos4210-pd";
 		reg = <0x10023CA0 0x20>;

arch/arm/boot/dts/exynos5250.dtsi +18 -0

index 37423314a028..8d724d56a5c6 100644
@@ -72,6 +72,24 @@
 		};
 	};
 
+	sram at 02020000 {
+		compatible = "mmio-sram";
+		reg = <0x02020000 0x30000>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges = <0 0x02020000 0x30000>;
+
+		smp-sram at 0 {
+			compatible = "samsung,exynos4210-sram";
+			reg = <0x0 0x1000>;
+		};
+
+		smp-sram at 2f000 {
+			compatible = "samsung,exynos4210-sram-ns";
+			reg = <0x2f000 0x1000>;
+		};
+	};
+
 	pd_gsc: gsc-power-domain at 10044000 {
 		compatible = "samsung,exynos4210-pd";
 		reg = <0x10044000 0x20>;

arch/arm/boot/dts/exynos5420.dtsi +18 -0

index c3a9a66c5767..ff496adfabde 100644
@@ -110,6 +110,24 @@
 		};
 	};
 
+	sram at 02020000 {
+		compatible = "mmio-sram";
+		reg = <0x02020000 0x54000>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges = <0 0x02020000 0x54000>;
+
+		smp-sram at 0 {
+			compatible = "samsung,exynos4210-sram";
+			reg = <0x0 0x1000>;
+		};
+
+		smp-sram at 53000 {
+			compatible = "samsung,exynos4210-sram-ns";
+			reg = <0x53000 0x1000>;
+		};
+	};
+
 	clock: clock-controller at 10010000 {
 		compatible = "samsung,exynos5420-clock";
 		reg = <0x10010000 0x30000>;

arch/arm/mach-exynos/common.h +1 -0

index 9ef3f83efaff..47cbab0f008e 100644
@@ -18,6 +18,7 @@
 void mct_init(void __iomem *base, int irq_g0, int irq_l0, int irq_l1);
 
 struct map_desc;
+extern void __iomem *sram_ns_base_addr;
 void exynos_init_io(void);
 void exynos_restart(enum reboot_mode mode, const char *cmd);
 void exynos_cpuidle_init(void);

arch/arm/mach-exynos/exynos.c +0 ~~-64~~

82 lines not on this page · raw message

arch/arm/mach-exynos/firmware.c +7 -1

index 932129ef26c6..dcd99ed81452 100644
@@ -18,6 +18,7 @@
 
 #include <mach/map.h>
 
+#include "common.h"
 #include "smc.h"
 
 static int exynos_do_idle(void)

@@ -34,7 +35,12 @@ static int exynos_cpu_boot(int cpu)
 
 static int exynos_set_cpu_boot_addr(int cpu, unsigned long boot_addr)
 {
-	void __iomem *boot_reg = S5P_VA_SYSRAM_NS + 0x1c + 4*cpu;
+	void __iomem *boot_reg;
+
+	if (!sram_ns_base_addr)
+		return -ENODEV;
+
+	boot_reg = sram_ns_base_addr + 0x1c + 4*cpu;
 
 	__raw_writel(boot_addr, boot_reg);
 	return 0;

arch/arm/mach-exynos/include/mach/map.h +0 -7

index 7b046b59d9ec..548269a60634 100644
@@ -23,13 +23,6 @@
 
 #include <plat/map-s5p.h>
 
-#define EXYNOS4_PA_SYSRAM0		0x02025000
-#define EXYNOS4_PA_SYSRAM1		0x02020000
-#define EXYNOS5_PA_SYSRAM		0x02020000
-#define EXYNOS4210_PA_SYSRAM_NS		0x0203F000
-#define EXYNOS4x12_PA_SYSRAM_NS		0x0204F000
-#define EXYNOS5250_PA_SYSRAM_NS		0x0204F000
-
 #define EXYNOS_PA_CHIPID		0x10000000
 
 #define EXYNOS4_PA_SYSCON		0x10010000

arch/arm/mach-exynos/platsmp.c +52 -4

116 lines not on this page · raw message

Signature · 1 line

1.7.9.5

Sachin Kamat

author

2014-05-08 04:16 UTC #1 lore raw

PATCH v3 2/2 Documentation: DT: Exynos: Bind SRAM though DT

Add SRAM binding documentation.

Signed-off-by Sachin Kamat <[email protected]>

Acked-by Arnd Bergmann <[email protected]>

---
No changes since v1.

---
 .../devicetree/bindings/arm/exynos/smp-sram.txt    |   38 ++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/exynos/smp-sram.txt

Documentation/devicetree/bindings/arm/exynos/smp-sram.txt new file +38 -0

new file mode 100644
index 000000000000..c9ff2f58f9b6
@@ -0,0 +1,38 @@
+Samsung Exynos SRAM for SMP bringup:
+------------------------------------
+
+Samsung SMP-capable Exynos SoCs use part of the SRAM for the bringup
+of the secondary cores. Once the core gets powered up it executes the
+code that is residing at some specific location of the SRAM.
+
+Therefore reserved section sub-nodes have to be added to the mmio-sram
+declaration. These nodes are of two types depending upon secure or
+non-secure execution environment.
+
+Required sub-node properties:
+- compatible : depending upon boot mode, should be
+		"samsung,exynos4210-sram" : for Secure SYSRAM
+		"samsung,exynos4210-sram-ns" : for Non-secure SYSRAM
+
+The rest of the properties should follow the generic mmio-sram discription
+found in ../../misc/sram.txt
+
+Example:
+
+	sram at 02020000 {
+		compatible = "mmio-sram";
+		reg = <0x02020000 0x54000>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges = <0 0x02020000 0x54000>;
+
+		smp-sram at 0 {
+			compatible = "samsung,exynos4210-sram";
+			reg = <0x0 0x1000>;
+		};
+
+		smp-sram at 53000 {
+			compatible = "samsung,exynos4210-sram-ns";
+			reg = <0x53000 0x1000>;
+		};
+	};

Signature · 1 line

1.7.9.5

Tomasz Figa

2014-05-08 16:19 UTC #2 lore raw

PATCH v3 2/2 Documentation: DT: Exynos: Bind SRAM though DT

Hi Sachin,

Quoted 10 lines · Sachin Kamat

Add SRAM binding documentation.
Signed-off-by Sachin Kamat <[email protected]>
Acked-by Arnd Bergmann <[email protected]>
---
No changes since v1.
---
 .../devicetree/bindings/arm/exynos/smp-sram.txt    |   38 ++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/exynos/smp-sram.txt

Reviewed-by Tomasz Figa <[email protected]>

--
Best regards,
Tomasz

Tomasz Figa

2014-05-08 16:18 UTC #3 lore raw

PATCH v3 1/2 ARM: EXYNOS: Map SYSRAM through generic SRAM bindings

In reply to Sachin Kamat

Hi Sachin,

Quoted 21 lines · Sachin Kamat

Instead of hardcoding the SYSRAM details for each SoC, pass this information through device tree (DT) and make the code SoC agnostic. Generic SRAM bindings are used for achieving this.
Signed-off-by Sachin Kamat <[email protected]>
Acked-by Arnd Bergmann <[email protected]>
Acked-by Heiko Stuebner <[email protected]>
---
Changes since v2.
* Updated sysram node for Universal C210 board - Thanks to Tomasz Figa for testing and updating the same.
* Added error handling code.
* Break if matching node found.
* Remove unnecessary error messages.
This patch is based on linux next (next-20140501) on top of my Kconfig consolidation patch
http://comments.gmane.org/gmane.linux.kernel.samsung-soc/28642
Tested on 4210/4412 Origen, 5250/5420 Arndale and SMDK5420 boards.

Quoted 14 lines

---
 arch/arm/Kconfig                                |    1 +
 arch/arm/boot/dts/exynos4210-universal_c210.dts |   15 ++++++
 arch/arm/boot/dts/exynos4210.dtsi               |   18 +++++++
 arch/arm/boot/dts/exynos4x12.dtsi               |   18 +++++++
 arch/arm/boot/dts/exynos5250.dtsi               |   18 +++++++
 arch/arm/boot/dts/exynos5420.dtsi               |   18 +++++++
 arch/arm/mach-exynos/common.h                   |    1 +
 arch/arm/mach-exynos/exynos.c                   |   64 -----------------------
 arch/arm/mach-exynos/firmware.c                 |    8 ++-
 arch/arm/mach-exynos/include/mach/map.h         |    7 ---
 arch/arm/mach-exynos/platsmp.c                  |   56 ++++++++++++++++++--
 11 files changed, 148 insertions(+), 76 deletions(-)

Looks good, thanks.

Reviewed-by Tomasz Figa <[email protected]>

--
Best regards,
Tomasz

Kukjin Kim

2014-05-09 02:14 UTC #4 lore raw

PATCH v3 1/2 ARM: EXYNOS: Map SYSRAM through generic SRAM bindings

Quoted 34 lines · Tomasz Figa

Hi Sachin,
Quoted 30 lines · Sachin Kamat
Instead of hardcoding the SYSRAM details for each SoC, pass this information through device tree (DT) and make the code SoC agnostic. Generic SRAM bindings are used for achieving this.
Signed-off-by Sachin Kamat <[email protected]>
Acked-by Arnd Bergmann <[email protected]>
Acked-by Heiko Stuebner <[email protected]>
---
Changes since v2.
* Updated sysram node for Universal C210 board - Thanks to Tomasz Figa for testing and updating the same.
* Added error handling code.
* Break if matching node found.
* Remove unnecessary error messages.
This patch is based on linux next (next-20140501) on top of my Kconfig consolidation patch
http://comments.gmane.org/gmane.linux.kernel.samsung-soc/28642
Tested on 4210/4412 Origen, 5250/5420 Arndale and SMDK5420 boards.
---
 arch/arm/Kconfig                                |    1 +
 arch/arm/boot/dts/exynos4210-universal_c210.dts |   15 ++++++
 arch/arm/boot/dts/exynos4210.dtsi               |   18 +++++++
 arch/arm/boot/dts/exynos4x12.dtsi               |   18 +++++++
 arch/arm/boot/dts/exynos5250.dtsi               |   18 +++++++
 arch/arm/boot/dts/exynos5420.dtsi               |   18 +++++++
 arch/arm/mach-exynos/common.h                   |    1 +
 arch/arm/mach-exynos/exynos.c                   |   64

----------------------

Quoted 4 lines

Quoted 3 lines

 arch/arm/mach-exynos/firmware.c                 |    8 ++-
 arch/arm/mach-exynos/include/mach/map.h         |    7 ---
 arch/arm/mach-exynos/platsmp.c                  |   56

++++++++++++++++++--

Quoted 7 lines

Quoted 2 lines
 11 files changed, 148 insertions(+), 76 deletions(-)
Looks good, thanks.
Reviewed-by Tomasz Figa <[email protected]>

Looks good to me but I think, we need to change the name of 'sram' because it can cause some confusing, actually it is not matching _real_ sram area on the SoCs. When we upstreamed regarding patch, I decided the name to use 'SYSRAM', it was called another name in datasheet though. So, I'd like to use 'sysram' instead of 'sram' as we used before.

I will change the name when I apply this series in this weekend, if you guys have no objection.

Thanks,
Kukjin

Tomasz Figa

2014-05-09 04:49 UTC #5 lore raw

PATCH v3 1/2 ARM: EXYNOS: Map SYSRAM through generic SRAM bindings

Hi Kukjin,

Quoted 48 lines · Kukjin Kim

Quoted 34 lines · Tomasz Figa
Hi Sachin,
Quoted 30 lines · Sachin Kamat
Instead of hardcoding the SYSRAM details for each SoC, pass this information through device tree (DT) and make the code SoC agnostic. Generic SRAM bindings are used for achieving this.
Signed-off-by Sachin Kamat <[email protected]>
Acked-by Arnd Bergmann <[email protected]>
Acked-by Heiko Stuebner <[email protected]>
---
Changes since v2.
* Updated sysram node for Universal C210 board - Thanks to Tomasz Figa for testing and updating the same.
* Added error handling code.
* Break if matching node found.
* Remove unnecessary error messages.
This patch is based on linux next (next-20140501) on top of my Kconfig consolidation patch
http://comments.gmane.org/gmane.linux.kernel.samsung-soc/28642
Tested on 4210/4412 Origen, 5250/5420 Arndale and SMDK5420 boards.
---
  arch/arm/Kconfig                                |    1 +
  arch/arm/boot/dts/exynos4210-universal_c210.dts |   15 ++++++
  arch/arm/boot/dts/exynos4210.dtsi               |   18 +++++++
  arch/arm/boot/dts/exynos4x12.dtsi               |   18 +++++++
  arch/arm/boot/dts/exynos5250.dtsi               |   18 +++++++
  arch/arm/boot/dts/exynos5420.dtsi               |   18 +++++++
  arch/arm/mach-exynos/common.h                   |    1 +
  arch/arm/mach-exynos/exynos.c                   |   64
----------------------
Quoted 4 lines
-
Quoted 3 lines
  arch/arm/mach-exynos/firmware.c                 |    8 ++-
  arch/arm/mach-exynos/include/mach/map.h         |    7 ---
  arch/arm/mach-exynos/platsmp.c                  |   56
++++++++++++++++++--
Quoted 7 lines
Quoted 2 lines
  11 files changed, 148 insertions(+), 76 deletions(-)
Looks good, thanks.
Reviewed-by Tomasz Figa <[email protected]>

Quoted 8 lines

Looks good to me but I think, we need to change the name of 'sram' because it can cause some confusing, actually it is not matching _real_ sram area on the SoCs. When we upstreamed regarding patch, I decided the name to use 'SYSRAM', it was called another name in datasheet though. So, I'd like to use 'sysram' instead of 'sram' as we used before.
I will change the name when I apply this series in this weekend, if you guys have no objection.

You mean s/sram/sysram/ in compatible strings of Exynos-specific reserved areas? If yes, I'm fine, it might be even better. Just remember to update documentation in patch 2/2 as well.

Best regards,
Tomasz

Kukjin Kim

2014-05-09 13:46 UTC #6 lore raw

PATCH v3 1/2 ARM: EXYNOS: Map SYSRAM through generic SRAM bindings

Quoted 2 lines · Tomasz Figa

Hi Kukjin,

Hi Tomasz,

Quoted 57 lines · Kukjin Kim

Quoted 56 lines
Quoted 34 lines · Tomasz Figa
Hi Sachin,
Quoted 30 lines · Sachin Kamat
Instead of hardcoding the SYSRAM details for each SoC, pass this information through device tree (DT) and make the code SoC agnostic. Generic SRAM bindings are used for achieving this.
Signed-off-by Sachin Kamat <[email protected]>
Acked-by Arnd Bergmann <[email protected]>
Acked-by Heiko Stuebner <[email protected]>
---
Changes since v2.
* Updated sysram node for Universal C210 board - Thanks to Tomasz Figa for testing and updating the same.
* Added error handling code.
* Break if matching node found.
* Remove unnecessary error messages.
This patch is based on linux next (next-20140501) on top of my Kconfig consolidation patch
http://comments.gmane.org/gmane.linux.kernel.samsung-soc/28642
Tested on 4210/4412 Origen, 5250/5420 Arndale and SMDK5420 boards.
---
arch/arm/Kconfig | 1 + arch/arm/boot/dts/exynos4210-universal_c210.dts | 15 ++++++
arch/arm/boot/dts/exynos4210.dtsi | 18 +++++++
arch/arm/boot/dts/exynos4x12.dtsi | 18 +++++++
arch/arm/boot/dts/exynos5250.dtsi | 18 +++++++
arch/arm/boot/dts/exynos5420.dtsi | 18 +++++++
arch/arm/mach-exynos/common.h | 1 +
arch/arm/mach-exynos/exynos.c | 64
----------------------
Quoted 4 lines
-
Quoted 3 lines
arch/arm/mach-exynos/firmware.c | 8 ++-
arch/arm/mach-exynos/include/mach/map.h | 7 ---
arch/arm/mach-exynos/platsmp.c | 56
++++++++++++++++++--
Quoted 7 lines
Quoted 2 lines
11 files changed, 148 insertions(+), 76 deletions(-)
Looks good, thanks.
Reviewed-by Tomasz Figa <[email protected]>
Looks good to me but I think, we need to change the name of 'sram' because
it can cause some confusing, actually it is not matching _real_ sram area on
the SoCs. When we upstreamed regarding patch, I decided the name to use 'SYSRAM', it was called another name in datasheet though. So, I'd like to use 'sysram' instead of 'sram' as we used before.

Quoted 8 lines

Quoted 3 lines
I will change the name when I apply this series in this weekend, if you guys
have no objection.
You mean s/sram/sysram/ in compatible strings of Exynos-specific reserved areas? If yes, I'm fine, it might be even better. Just remember to update documentation in patch 2/2 as well.

Yes, of course ;-)

- Kukjin

Kukjin Kim

2014-05-13 03:12 UTC #7 lore raw

PATCH v3 1/2 ARM: EXYNOS: Map SYSRAM through generic SRAM bindings

In reply to Tomasz Figa

Quoted 3 lines · Tomasz Figa

Hi Kukjin,

Hi,

Quoted 58 lines · Kukjin Kim

Quoted 41 lines
Quoted 34 lines · Tomasz Figa
Hi Sachin,
Quoted 30 lines · Sachin Kamat
Instead of hardcoding the SYSRAM details for each SoC, pass this information through device tree (DT) and make the code SoC agnostic. Generic SRAM bindings are used for achieving this.
Signed-off-by Sachin Kamat <[email protected]>
Acked-by Arnd Bergmann <[email protected]>
Acked-by Heiko Stuebner <[email protected]>
---
Changes since v2.
* Updated sysram node for Universal C210 board - Thanks to Tomasz Figa for testing and updating the same.
* Added error handling code.
* Break if matching node found.
* Remove unnecessary error messages.
This patch is based on linux next (next-20140501) on top of my Kconfig consolidation patch
http://comments.gmane.org/gmane.linux.kernel.samsung-soc/28642
Tested on 4210/4412 Origen, 5250/5420 Arndale and SMDK5420 boards.
---
  arch/arm/Kconfig                                |    1 +
  arch/arm/boot/dts/exynos4210-universal_c210.dts |   15 ++++++
  arch/arm/boot/dts/exynos4210.dtsi               |   18 +++++++
  arch/arm/boot/dts/exynos4x12.dtsi               |   18 +++++++
  arch/arm/boot/dts/exynos5250.dtsi               |   18 +++++++
  arch/arm/boot/dts/exynos5420.dtsi               |   18 +++++++
  arch/arm/mach-exynos/common.h                   |    1 +
  arch/arm/mach-exynos/exynos.c                   |   64
----------------------
Quoted 4 lines
-
Quoted 3 lines
  arch/arm/mach-exynos/firmware.c                 |    8 ++-
  arch/arm/mach-exynos/include/mach/map.h         |    7 ---
  arch/arm/mach-exynos/platsmp.c                  |   56
++++++++++++++++++--
Quoted 8 lines
Quoted 7 lines
Quoted 2 lines
  11 files changed, 148 insertions(+), 76 deletions(-)
Looks good, thanks.
Reviewed-by Tomasz Figa <[email protected]>
Looks good to me but I think, we need to change the name of 'sram'
because
Quoted 1 line
it can cause some confusing, actually it is not matching _real_ sram
area on
Quoted 2 lines
the SoCs. When we upstreamed regarding patch, I decided the name to use 'SYSRAM', it was called another name in datasheet though. So, I'd like
to
Quoted 2 lines
use 'sysram' instead of 'sram' as we used before.

Quoted 8 lines

Quoted 1 line
I will change the name when I apply this series in this weekend, if you
guys
Quoted 1 line
have no objection.
You mean s/sram/sysram/ in compatible strings of Exynos-specific reserved areas? If yes, I'm fine, it might be even better. Just remember to update documentation in patch 2/2 as well.

Done. If any problems in my tree, please let me know.

Thanks,
Kukjin

Paul Bolle

2014-05-13 10:07 UTC #8 lore raw

PATCH v3 1/2 ARM: EXYNOS: Map SYSRAM through generic SRAM bindings

Kukjin,

Quoted 6 lines · Kukjin Kim

Quoted 4 lines · Tomasz Figa
You mean s/sram/sysram/ in compatible strings of Exynos-specific reserved areas? If yes, I'm fine, it might be even better. Just remember to update documentation in patch 2/2 as well.
Done. If any problems in my tree, please let me know.

It seems this one just hit linux-next (in next-20140513) as "ARM:
EXYNOS: Map SYSRAM through generic DT bindings". Its commit now contains this hunk:
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -843,6 +843,7 @@ config ARCH_EXYNOS
select HAVE_S3C_RTC if RTC_CLASS
select NEED_MACH_MEMORY_H
select SPARSE_IRQ
+ select SYSRAM
select USE_OF
help
Support for SAMSUNG's EXYNOS SoCs (EXYNOS4/5)

But there's no Kconfig symbol SYSRAM. However, there is a Kconfig symbol SRAM. Did you perhaps do one s/sram/sysram/ too many on the original patch?

Paul Bolle

Tushar Behera

2014-05-14 03:14 UTC #9 lore raw

PATCH v3 1/2 ARM: EXYNOS: Map SYSRAM through generic SRAM bindings

Quoted 24 lines · Paul Bolle

Kukjin,
Quoted 6 lines · Kukjin Kim
Quoted 4 lines · Tomasz Figa
You mean s/sram/sysram/ in compatible strings of Exynos-specific reserved areas? If yes, I'm fine, it might be even better. Just remember to update documentation in patch 2/2 as well.
Done. If any problems in my tree, please let me know.
It seems this one just hit linux-next (in next-20140513) as "ARM:
EXYNOS: Map SYSRAM through generic DT bindings". Its commit now contains this hunk:
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -843,6 +843,7 @@ config ARCH_EXYNOS
select HAVE_S3C_RTC if RTC_CLASS
select NEED_MACH_MEMORY_H
select SPARSE_IRQ
+ select SYSRAM
select USE_OF
help
Support for SAMSUNG's EXYNOS SoCs (EXYNOS4/5)

Quoted 4 lines

But there's no Kconfig symbol SYSRAM. However, there is a Kconfig symbol SRAM. Did you perhaps do one s/sram/sysram/ too many on the original patch?

Also the compatible string name should be 'mmio-sram' on the DTS files.

Quoted 8 lines

Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 1 line

Tushar Behera

Kukjin Kim

2014-05-14 04:08 UTC #10 lore raw

PATCH v3 1/2 ARM: EXYNOS: Map SYSRAM through generic SRAM bindings

Quoted 27 lines · Tushar Behera

Quoted 6 lines · Paul Bolle
Kukjin,
Quoted 3 lines · Kukjin Kim
Quoted 2 lines · Tomasz Figa
You mean s/sram/sysram/ in compatible strings of Exynos-specific reserved areas? If yes, I'm fine, it might be even better. Just
remember
Quoted 18 lines
Quoted 3 lines
Quoted 2 lines
to update documentation in patch 2/2 as well.
Done. If any problems in my tree, please let me know.
It seems this one just hit linux-next (in next-20140513) as "ARM:
EXYNOS: Map SYSRAM through generic DT bindings". Its commit now contains this hunk:
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -843,6 +843,7 @@ config ARCH_EXYNOS
select HAVE_S3C_RTC if RTC_CLASS
select NEED_MACH_MEMORY_H
select SPARSE_IRQ
+ select SYSRAM
select USE_OF
help
Support for SAMSUNG's EXYNOS SoCs (EXYNOS4/5)

Quoted 7 lines

Quoted 4 lines
But there's no Kconfig symbol SYSRAM. However, there is a Kconfig symbol SRAM. Did you perhaps do one s/sram/sysram/ too many on the original patch?
Also the compatible string name should be 'mmio-sram' on the DTS files.

Paul and Tushar,

Thanks for the pointing out.
Let me fix them, config name and compatible string.

- Kukjin