ARM: dts: sun6i-a31-app4-evb1.dts: Use sunxi-common-regulators.dtsi
Subsystems (2)
PATCH 1/1 ARM: dts: sun6i-a31-app4-evb1.dts: Use sunxi-common-regulators.dtsi
--- arch/arm/boot/dts/sun6i-a31-app4-evb1.dts | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)
arch/arm/boot/dts/sun6i-a31-app4-evb1.dts +1 -7
@@ -13,6 +13,7 @@ /dts-v1/; /include/ "sun6i-a31.dtsi" +/include/ "sunxi-common-regulators.dtsi" / { model = "Allwinner A31 APP4 EVB1 Evaluation Board";
@@ -49,15 +50,8 @@ }; reg_usb1_vbus: usb1-vbus { - compatible = "regulator-fixed"; - pinctrl-names = "default"; pinctrl-0 = <&usb1_vbus_pin_a>; - regulator-name = "usb1-vbus"; - regulator-min-microvolt = <5000000>; - regulator-max-microvolt = <5000000>; - enable-active-high; gpio = <&pio 7 27 0>; status = "okay"; }; - };
Signature · 1 line
1.9.0
PATCH 1/1 ARM: dts: sun6i-a31-app4-evb1.dts: Use sunxi-common-regulators.dtsi
Quoted 21 lines · Hans de Goede
Signed-off-by Hans de Goede <[email protected]>--- arch/arm/boot/dts/sun6i-a31-app4-evb1.dts | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)arch/arm/boot/dts/sun6i-a31-app4-evb1.dts +1
-0@@ -13,6 +13,7 @@ /dts-v1/; /include/ "sun6i-a31.dtsi" +/include/ "sunxi-common-regulators.dtsi" / { model = "Allwinner A31 APP4 EVB1 Evaluation Board";@@ -49,15 +50,8 @@ }; reg_usb1_vbus: usb1-vbus {
arch/arm/boot/dts/sun6i-a31-app4-evb1.dts line 56
Quoted 10 lines
arch/arm/boot/dts/sun6i-a31-app4-evb1.dts +0
-6- compatible = "regulator-fixed"; - pinctrl-names = "default"; pinctrl-0 = <&usb1_vbus_pin_a>; - regulator-name = "usb1-vbus"; - regulator-min-microvolt = <5000000>; - regulator-max-microvolt = <5000000>; - enable-active-high; gpio = <&pio 7 27 0>; status = "okay"; };
I guess we could do the same for usb1_vbus_pin_a (keep the common definition and change the allwinner,pins property).
Apart from that,
Best Regards,
Boris
Quoted 2 lines
arch/arm/boot/dts/sun6i-a31-app4-evb1.dts +0
-1- };
Signature · 3 lines
Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Hi,
Quoted 22 lines · Boris BREZILLON
Quoted 20 lines · Hans de Goede
Signed-off-by Hans de Goede <[email protected]>--- arch/arm/boot/dts/sun6i-a31-app4-evb1.dts | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)arch/arm/boot/dts/sun6i-a31-app4-evb1.dts +1
-0@@ -13,6 +13,7 @@ /dts-v1/; /include/ "sun6i-a31.dtsi" +/include/ "sunxi-common-regulators.dtsi" / { model = "Allwinner A31 APP4 EVB1 Evaluation Board";@@ -49,15 +50,8 @@ };
Quoted 14 lines
arch/arm/boot/dts/sun6i-a31-app4-evb1.dts line 56
Quoted 11 lines
arch/arm/boot/dts/sun6i-a31-app4-evb1.dts +0
-6reg_usb1_vbus: usb1-vbus { - compatible = "regulator-fixed"; - pinctrl-names = "default"; pinctrl-0 = <&usb1_vbus_pin_a>; - regulator-name = "usb1-vbus"; - regulator-min-microvolt = <5000000>; - regulator-max-microvolt = <5000000>; - enable-active-high; gpio = <&pio 7 27 0>; status = "okay"; };I guess we could do the same for
usb1_vbus_pin_a(keep the common definition and change the allwinner,pins property).
Hmm, what we do with other boards when the pin does not match the default is change the node name to something baord specific, ie usb1_vbus_pin_app4_evb1
Which is why I did not remove the common bits from the pin, I did not notice you did not use a board specific name here.
Regards,
Hans
Quoted 37 lines · Hans de Goede
Hi,
Quoted 21 lines · Boris BREZILLON
Quoted 20 lines · Hans de Goede
Signed-off-by Hans de Goede <[email protected]>--- arch/arm/boot/dts/sun6i-a31-app4-evb1.dts | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)arch/arm/boot/dts/sun6i-a31-app4-evb1.dts +1
-0@@ -13,6 +13,7 @@ /dts-v1/; /include/ "sun6i-a31.dtsi" +/include/ "sunxi-common-regulators.dtsi" / { model = "Allwinner A31 APP4 EVB1 Evaluation Board";@@ -49,15 +50,8 @@ };Quoted 13 lines
arch/arm/boot/dts/sun6i-a31-app4-evb1.dts line 56
Quoted 11 lines
arch/arm/boot/dts/sun6i-a31-app4-evb1.dts +0
-6reg_usb1_vbus: usb1-vbus { - compatible = "regulator-fixed"; - pinctrl-names = "default"; pinctrl-0 = <&usb1_vbus_pin_a>; - regulator-name = "usb1-vbus"; - regulator-min-microvolt = <5000000>; - regulator-max-microvolt = <5000000>; - enable-active-high; gpio = <&pio 7 27 0>; status = "okay"; };I guess we could do the same for
usb1_vbus_pin_a(keep the common definition and change the allwinner,pins property).
Quoted 3 lines
Hmm, what we do with other boards when the pin does not match the default is change the node name to something baord specific, ie
usb1_vbus_pin_app4_evb1
Okay.
How did you decide which pins should be put in the default definitions (the most used ones among available boards ?) ?
I'm not sure defining new pin states for each board is a good solution, because you'll embed unneeded pin states in your DTB. Anyway, this is your call :-).
Quoted 2 lines
Which is why I did not remove the common bits from the pin, I did not notice you did not use a board specific name here.
Then I guess it should be fixed in the same series.
BTW, AFAIK the original patch adding support for the APP4 EVB1 board has not been applied yet, so I think we can fix it send a v2 of this patch.
Quoted 8 lines
Regards,
Hans
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 3 lines
Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Hi,
Quoted 39 lines · Boris BREZILLON
Quoted 37 lines · Hans de Goede
Hi,
Quoted 34 lines · Boris BREZILLON
Quoted 21 lines · Hans de Goede
Signed-off-by Hans de Goede <[email protected]>--- arch/arm/boot/dts/sun6i-a31-app4-evb1.dts | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)arch/arm/boot/dts/sun6i-a31-app4-evb1.dts +1
-0@@ -13,6 +13,7 @@ /dts-v1/; /include/ "sun6i-a31.dtsi" +/include/ "sunxi-common-regulators.dtsi" / { model = "Allwinner A31 APP4 EVB1 Evaluation Board";@@ -49,15 +50,8 @@ }; reg_usb1_vbus: usb1-vbus {arch/arm/boot/dts/sun6i-a31-app4-evb1.dts line 56
Quoted 10 lines
arch/arm/boot/dts/sun6i-a31-app4-evb1.dts +0
-6- compatible = "regulator-fixed"; - pinctrl-names = "default"; pinctrl-0 = <&usb1_vbus_pin_a>; - regulator-name = "usb1-vbus"; - regulator-min-microvolt = <5000000>; - regulator-max-microvolt = <5000000>; - enable-active-high; gpio = <&pio 7 27 0>; status = "okay"; };I guess we could do the same for
usb1_vbus_pin_a(keep the common definition and change the allwinner,pins property).
Quoted 7 lines
Quoted 3 lines
Hmm, what we do with other boards when the pin does not match the default is change the node name to something baord specific, ie
usb1_vbus_pin_app4_evb1Okay.
How did you decide which pins should be put in the default definitions (the most used ones among available boards ?) ?
The pins used there are used on all-most all A10 and A20 boards, the sun5i (A10s / A13) boards seem to not really have any standard gpio they use, and I have not seen enough A31 boards yet to say anything sensible.
We may need to rename the standard pins to include the platform name if A31 also uses the same pin everywhere (but a different one from A10).
Quoted 10 lines
I'm not sure defining new pin states for each board is a good solution, because you'll embed unneeded pin states in your DTB. Anyway, this is your call :-).
Quoted 2 lines
Which is why I did not remove the common bits from the pin, I did not notice you did not use a board specific name here.
Then I guess it should be fixed in the same series.
BTW, AFAIK the original patch adding support for the APP4 EVB1 board has not been applied yet, so I think we can fix it send a v2 of this patch.
It is already in Maxime's dt-for-3.16 tree, so it is probably better to fix this with a followup patch.
Regards,
Hans
Quoted 64 lines · Hans de Goede
Hi,
Quoted 39 lines · Boris BREZILLON
Quoted 37 lines · Hans de Goede
Hi,
Quoted 34 lines · Boris BREZILLON
Quoted 21 lines · Hans de Goede
Signed-off-by Hans de Goede <[email protected]>--- arch/arm/boot/dts/sun6i-a31-app4-evb1.dts | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)arch/arm/boot/dts/sun6i-a31-app4-evb1.dts +1
-0@@ -13,6 +13,7 @@ /dts-v1/; /include/ "sun6i-a31.dtsi" +/include/ "sunxi-common-regulators.dtsi" / { model = "Allwinner A31 APP4 EVB1 Evaluation Board";@@ -49,15 +50,8 @@ }; reg_usb1_vbus: usb1-vbus {arch/arm/boot/dts/sun6i-a31-app4-evb1.dts line 56
Quoted 10 lines
arch/arm/boot/dts/sun6i-a31-app4-evb1.dts +0
-6- compatible = "regulator-fixed"; - pinctrl-names = "default"; pinctrl-0 = <&usb1_vbus_pin_a>; - regulator-name = "usb1-vbus"; - regulator-min-microvolt = <5000000>; - regulator-max-microvolt = <5000000>; - enable-active-high; gpio = <&pio 7 27 0>; status = "okay"; };I guess we could do the same for
usb1_vbus_pin_a(keep the common definition and change the allwinner,pins property).Quoted 7 lines
Quoted 3 lines
Hmm, what we do with other boards when the pin does not match the default is change the node name to something baord specific, ie
usb1_vbus_pin_app4_evb1Okay.
How did you decide which pins should be put in the default definitions (the most used ones among available boards ?) ?The pins used there are used on all-most all A10 and A20 boards, the sun5i (A10s / A13) boards seem to not really have any standard gpio they use, and I have not seen enough A31 boards yet to say anything sensible.
We may need to rename the standard pins to include the platform name if A31 also uses the same pin everywhere (but a different one from A10).
Quoted 7 lines
I'm not sure defining new pin states for each board is a good solution, because you'll embed unneeded pin states in your DTB. Anyway, this is your call :-).
Quoted 2 lines
Which is why I did not remove the common bits from the pin, I did not notice you did not use a board specific name here.
Quoted 6 lines
Quoted 3 lines
Then I guess it should be fixed in the same series.
BTW, AFAIK the original patch adding support for the APP4 EVB1 board has not been applied yet, so I think we can fix it send a v2 of this patch.It is already in Maxime's dt-for-3.16 tree, so it is probably better to fix this with a followup patch.
Actually, it's not (yet). I'll squash it into my serie.
Thanks!
Maxime
Signature · 10 lines
Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140509/a9f071da/attachment.sig>