Skip to contentSkip to conversation

imx6: ventana: fix system-serial dt property

PATCH New Tim Harvey 2 participants 2 messages Apr 25, 2014 – May 9, 2014

lore
Share & tools
lore

Tim Harvey

author
#0 lore raw

PATCH 1/1 imx6: ventana: fix system-serial dt property

Fix typo in setting of system-serial property causing the prop len to be off by 1.

---
 board/gateworks/gw_ventana/gw_ventana.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/gateworks/gw_ventana/gw_ventana.c +1 -1
index f38a777..79b3e01 100644
@@ -1278,7 +1278,7 @@ void ft_board_setup(void *blob, bd_t *bd)
 
 	/* board serial number */
 	fdt_setprop(blob, 0, "system-serial", getenv("serial#"),
-		    strlen(getenv("serial#") + 1));
+		    strlen(getenv("serial#")) + 1);
 
 	/* board (model contains model from device-tree) */
 	fdt_setprop(blob, 0, "board", info->model,
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 imx6: ventana: fix system-serial dt property

Quoted 14 lines · Tim Harvey

Fix typo in setting of system-serial property causing the prop len to be off by 1.

---
 board/gateworks/gw_ventana/gw_ventana.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/gateworks/gw_ventana/gw_ventana.c +0 -0
index f38a777..79b3e01 100644

board/gateworks/gw_ventana/gw_ventana.c void ft_board_setup(void *blob, bd_t *bd) · line 1284

Quoted 8 lines
board/gateworks/gw_ventana/gw_ventana.c +1 -1
@@ -1278,7 +1278,7 @@ void ft_board_setup(void *blob, bd_t *bd)
 
 	/* board serial number */
 	fdt_setprop(blob, 0, "system-serial", getenv("serial#"),
-		    strlen(getenv("serial#") + 1));
+		    strlen(getenv("serial#")) + 1);
 
 	/* board (model contains model from device-tree) */
 	fdt_setprop(blob, 0, "board", info->model,

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================