Skip to contentSkip to conversation

wpa_supplicant: detect readline support in wpa_cli

PATCH New Oscar Hellström 4 participants 5 messages May 12, 2014 – May 13, 2014

lore
Share & tools
lore

Oscar Hellström

author
#0 lore raw

PATCH 1/1 wpa_supplicant: detect readline support in wpa_cli

Signed-off-by Oscar Hellstr?m <[email protected]>
---
 package/wpa_supplicant/wpa_supplicant.mk | 5 +++++
 1 file changed, 5 insertions(+)
package/wpa_supplicant/wpa_supplicant.mk +5 -0
index 9fcda2e..9321f08 100644
@@ -105,6 +105,11 @@ define WPA_SUPPLICANT_DEBUG_CONFIG
 endef
 endif
 
+ifeq ($(BR2_PACKAGE_READLINE),y)
+	WPA_SUPPLICANT_DEPENDENCIES += readline
+	WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_READLINE
+endif
+
 define WPA_SUPPLICANT_CONFIGURE_CMDS
 	cp $(@D)/wpa_supplicant/defconfig $(WPA_SUPPLICANT_CONFIG)
 	sed -i $(patsubst %,-e 's/^#\(%\)/\1/',$(WPA_SUPPLICANT_CONFIG_ENABLE)) \
Signature · 1 line
1.9.1
#2 lore raw

PATCH 1/1 wpa_supplicant: detect readline support in wpa_cli

In reply to Oscar Hellström
Quoted 10 lines · Oscar Hellstr?m
Signed-off-by Oscar Hellstr?m <[email protected]>
---
 package/wpa_supplicant/wpa_supplicant.mk | 5 +++++
 1 file changed, 5 insertions(+)
package/wpa_supplicant/wpa_supplicant.mk +0 -0
index 9fcda2e..9321f08 100644

package/wpa_supplicant/wpa_supplicant.mk define WPA_SUPPLICANT_DEBUG_CONFIG · line 110

Quoted 6 lines
package/wpa_supplicant/wpa_supplicant.mk +3 -0
@@ -105,6 +105,11 @@ define WPA_SUPPLICANT_DEBUG_CONFIG
 endef
 endif
 
+ifeq ($(BR2_PACKAGE_READLINE),y)
+	WPA_SUPPLICANT_DEPENDENCIES += readline
+	WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_READLINE

In package .mk file, we don't indent within if... constructs; we only use
indentation for commands and for continuation lines. I admit that that coding style is objectionable, but it is what it is.

Regards,
Arnout

Quoted 6 lines
package/wpa_supplicant/wpa_supplicant.mk +2 -0
+endif
+
 define WPA_SUPPLICANT_CONFIGURE_CMDS
 	cp $(@D)/wpa_supplicant/defconfig $(WPA_SUPPLICANT_CONFIG)
 	sed -i $(patsubst %,-e 's/^#\(%\)/\1/',$(WPA_SUPPLICANT_CONFIG_ENABLE)) \
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#3 lore raw

PATCH 1/1 wpa_supplicant: detect readline support in wpa_cli

Quoted 16 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Quoted 13 lines · Oscar Hellstr?m
Signed-off-by Oscar Hellstr?m <[email protected]>

---
package/wpa_supplicant/wpa_supplicant.mk | 5 +++++

1 file changed, 5 insertions(+)
package/wpa_supplicant/wpa_supplicant.mk +0 -0
index 9fcda2e..9321f08 100644
@@ -105,6 +105,11 @@ define WPA_SUPPLICANT_DEBUG_CONFIG

endef
endif

Quoted 7 lines

package/wpa_supplicant/wpa_supplicant.mk define WPA_SUPPLICANT_DEBUG_CONFIG · line 110

Quoted 3 lines
package/wpa_supplicant/wpa_supplicant.mk +3 -0
+ifeq ($(BR2_PACKAGE_READLINE),y)
+	WPA_SUPPLICANT_DEPENDENCIES += readline
+	WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_READLINE

In package .mk file, we don't indent within if... constructs; we only use
indentation for commands and for continuation lines. I admit that that coding style is objectionable, but it is what it is.

True, but this is atleast consistent with the rest of the file, so I will leave it like this for now.

Signature · 1 line
Bye, Peter Korsgaard