Skip to contentSkip to conversation

dccp: make the request_retries minimum is 1

PATCH Applied Wang Weidong 3 participants 3 messages May 13, 2014 – May 14, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dccp: make the request_retries minimum is 1

In Documentation/networking/dccp.txt points that request_retries should be greater than 0. So make the extra1 to be &one instead of &zero.

---
 net/dccp/sysctl.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
net/dccp/sysctl.c +2 -1
index 607ab71..53731e4 100644
@@ -20,6 +20,7 @@
 
 /* Boundary values */
 static int		zero     = 0,
+			one      = 1,
 			u8_max   = 0xFF;
 static unsigned long	seqw_min = DCCPF_SEQ_WMIN,
 			seqw_max = 0xFFFFFFFF;		/* maximum on 32 bit */
@@ -58,7 +59,7 @@ static struct ctl_table dccp_default_table[] = {
 		.maxlen		= sizeof(sysctl_dccp_request_retries),
 		.mode		= 0644,
 		.proc_handler	= proc_dointvec_minmax,
-		.extra1		= &zero,
+		.extra1		= &one,
 		.extra2		= &u8_max,
 	},
 	{
Signature · 1 line
1.7.12
#1 lore raw
Quoted 1 line
Quoted 25 lines
---
 net/dccp/sysctl.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
net/dccp/sysctl.c +2 -1
index 607ab71..53731e4 100644
@@ -20,6 +20,7 @@
 
 /* Boundary values */
 static int		zero     = 0,
+			one      = 1,
 			u8_max   = 0xFF;
 static unsigned long	seqw_min = DCCPF_SEQ_WMIN,
 			seqw_max = 0xFFFFFFFF;		/* maximum on 32 bit */
@@ -58,7 +59,7 @@ static struct ctl_table dccp_default_table[] = {
 		.maxlen		= sizeof(sysctl_dccp_request_retries),
 		.mode		= 0644,
 		.proc_handler	= proc_dointvec_minmax,
-		.extra1		= &zero,
+		.extra1		= &one,
 		.extra2		= &u8_max,
 	},
 	{