Skip to contentSkip to conversation

powerpc/fman/memac: use default MDIO_HOLD value

PATCH New shh.xie at gmail.com 2 participants 2 messages Apr 22, 2014 – May 13, 2014 Network drivers

lore
Share & tools
lore

shh.xie at gmail.com

author
#0 lore raw

PATCH 1/1 powerpc/fman/memac: use default MDIO_HOLD value

From: Shaohui Xie <[email protected]>

Current driver uses a Maximum value for MDIO_HOLD when doing 10G MDIO access, this is due to an errata A-006260 on T4 rev1.0 which is fixed on rev2.0, so remove the maximum value to use the default value for rev2.0.

Signed-off-by Shaohui Xie <[email protected]>
---
 drivers/net/fm/memac_phy.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
drivers/net/fm/memac_phy.c +2 -6
index 2f4bc11..de9c0e9 100644
@@ -29,10 +29,8 @@ int memac_mdio_write(struct mii_dev *bus, int port_addr, int dev_addr,
 		c45 = 0; /* clause 22 */
 		dev_addr = regnum & 0x1f;
 		clrbits_be32(&regs->mdio_stat, MDIO_STAT_ENC);
-	} else {
+	} else
 		setbits_be32(&regs->mdio_stat, MDIO_STAT_ENC);
-		setbits_be32(&regs->mdio_stat, MDIO_STAT_HOLD_15_CLK);
-	}
 
 	/* Wait till the bus is free */
 	while ((in_be32(&regs->mdio_stat)) & MDIO_STAT_BSY)

@@ -76,10 +74,8 @@ int memac_mdio_read(struct mii_dev *bus, int port_addr, int dev_addr,
 		c45 = 0; /* clause 22 */
 		dev_addr = regnum & 0x1f;
 		clrbits_be32(&regs->mdio_stat, MDIO_STAT_ENC);
-	} else {
+	} else
 		setbits_be32(&regs->mdio_stat, MDIO_STAT_ENC);
-		setbits_be32(&regs->mdio_stat, MDIO_STAT_HOLD_15_CLK);
-	}
 
 	/* Wait till the bus is free */
 	while ((in_be32(&regs->mdio_stat)) & MDIO_STAT_BSY)
Signature · 1 line
1.8.0
#1 lore raw

PATCH 1/1 powerpc/fman/memac: use default MDIO_HOLD value

Quoted 8 lines · shh.xie at gmail.com

From: Shaohui Xie <[email protected]>

Current driver uses a Maximum value for MDIO_HOLD when doing 10G MDIO access, this is due to an errata A-006260 on T4 rev1.0 which is fixed on rev2.0, so remove the maximum value to use the default value for rev2.0.

Signed-off-by Shaohui Xie <[email protected]>

---

Applied to u-boot-mpc85xx/master.

Thanks,

York