Skip to contentSkip to conversation

net: fix test_bpf build to depend on NET

PATCH Applied Randy Dunlap 3 participants 3 messages May 13, 2014

Subsystems (4)
Networking Network drivers Linux-next tree Library code
lore
Share & tools
lore

Randy Dunlap

author
#0 lore raw

PATCH 1/1 net: fix test_bpf build to depend on NET

From: Randy Dunlap <[email protected]>

Fix build when CONFIG_NET is not enabled.
Fixes these build errors:

WARNING: "sk_unattached_filter_destroy" [lib/test_bpf.ko] undefined!
WARNING: "kfree_skb" [lib/test_bpf.ko] undefined!
WARNING: "sk_unattached_filter_create" [lib/test_bpf.ko] undefined!
WARNING: "sk_run_filter_int_skb" [lib/test_bpf.ko] undefined!
WARNING: "__alloc_skb" [lib/test_bpf.ko] undefined!

Signed-off-by Randy Dunlap <[email protected]>
---
 lib/Kconfig.debug |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/Kconfig.debug +1 -1
@@ -1639,7 +1639,7 @@ config TEST_USER_COPY
 config TEST_BPF
 	tristate "Test BPF filter functionality"
 	default n
-	depends on m
+	depends on m && NET
 	help
 	  This builds the "test_bpf" module that runs various test vectors
 	  against the BPF interpreter or BPF JIT compiler depending on the
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix build when CONFIG_NET is not enabled.
Fixes these build errors:

Quoted 7 lines

WARNING: "sk_unattached_filter_destroy" [lib/test_bpf.ko] undefined!
WARNING: "kfree_skb" [lib/test_bpf.ko] undefined!
WARNING: "sk_unattached_filter_create" [lib/test_bpf.ko] undefined!
WARNING: "sk_run_filter_int_skb" [lib/test_bpf.ko] undefined!
WARNING: "__alloc_skb" [lib/test_bpf.ko] undefined!

Signed-off-by Randy Dunlap <[email protected]>

ohh. yes. sorry about that.

Acked-by Alexei Starovoitov <[email protected]>
Quoted 19 lines
---
 lib/Kconfig.debug |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/Kconfig.debug +1 -2
@@ -1639,7 +1639,7 @@ config TEST_USER_COPY
 config TEST_BPF
        tristate "Test BPF filter functionality"
        default n
-       depends on m
+       depends on m && NET
        help
          This builds the "test_bpf" module that runs various test vectors
          against the BPF interpreter or BPF JIT compiler depending on the
--

To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

maintainer Applied
#2 lore raw
In reply to Randy Dunlap

From: Randy Dunlap <[email protected]>
Date: Tue, 13 May 2014 09:58:44 -0700

Quoted 5 lines

From: Randy Dunlap <[email protected]>

Fix build when CONFIG_NET is not enabled.
Fixes these build errors:

Quoted 7 lines

WARNING: "sk_unattached_filter_destroy" [lib/test_bpf.ko] undefined!
WARNING: "kfree_skb" [lib/test_bpf.ko] undefined!
WARNING: "sk_unattached_filter_create" [lib/test_bpf.ko] undefined!
WARNING: "sk_run_filter_int_skb" [lib/test_bpf.ko] undefined!
WARNING: "__alloc_skb" [lib/test_bpf.ko] undefined!

Signed-off-by Randy Dunlap <[email protected]>

Applied, thanks Randy.