Skip to contentSkip to conversation

ARM: OMAP5: add cm-t54 board support

PATCH Superseded Dmitry Lifshitz 3 participants 12 messages Apr 27, 2014 – May 23, 2014 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

cover ARM: OMAP5: add cm-t54 board support

Add support for CompuLab cm-t54 CoM, based on OMAP5432 CPU.

http://compulab.co.il/products/computer-on-modules/cm-t54/

Basic support includes:

* Boot from MMC/SD and eMMC
* USB
* LAN

Dmitry Lifshitz (4):
ARM: OMAP5: add UART4 support
ARM: OMAP5: Power: add LDO2 support for Palmas driver
ARM: OMAP5: add CKO buffer control mask
cm-t54: add cm-t54 board support

 arch/arm/include/asm/arch-omap5/clock.h |    3 +
 arch/arm/include/asm/arch-omap5/omap.h  |    1 +
 board/compulab/cm_t54/Makefile          |   10 ++
 board/compulab/cm_t54/cm_t54.c          |  177 +++++++++++++++++++++++++++++++
 board/compulab/cm_t54/mux.c             |   94 ++++++++++++++++
 board/compulab/cm_t54/spl.c             |   66 ++++++++++++
 boards.cfg                              |    1 +
 include/configs/cm_t54.h                |  144 +++++++++++++++++++++++++
 include/palmas.h                        |    4 +
 9 files changed, 500 insertions(+), 0 deletions(-)
 create mode 100644 board/compulab/cm_t54/Makefile
 create mode 100644 board/compulab/cm_t54/cm_t54.c
 create mode 100644 board/compulab/cm_t54/mux.c
 create mode 100644 board/compulab/cm_t54/spl.c
 create mode 100644 include/configs/cm_t54.h
Signature · 1 line
1.7.5.4
#1 lore raw

PATCH 1/4 ARM: OMAP5: add UART4 support

Add UART4 base address.

---
 arch/arm/include/asm/arch-omap5/omap.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/include/asm/arch-omap5/omap.h +1 -0
index 19fdece..e35a81a 100644
@@ -50,6 +50,7 @@
 #define UART1_BASE		(OMAP54XX_L4_PER_BASE + 0x6a000)
 #define UART2_BASE		(OMAP54XX_L4_PER_BASE + 0x6c000)
 #define UART3_BASE		(OMAP54XX_L4_PER_BASE + 0x20000)
+#define UART4_BASE		(OMAP54XX_L4_PER_BASE + 0x6e000)
 
 /* General Purpose Timers */
 #define GPT1_BASE		(OMAP54XX_L4_WKUP_BASE + 0x18000)
Signature · 1 line
1.7.5.4
#2 lore raw

PATCH 1/4 ARM: OMAP5: add UART4 support

Quoted 3 lines · Dmitry Lifshitz

Add UART4 base address.

Applied to u-boot-ti/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140513/cafcab1a/attachment.pgp>
#3 lore raw

PATCH 2/4 ARM: OMAP5: Power: add LDO2 support for Palmas driver

In reply to Dmitry Lifshitz

Add defines required to turn on LDO2 regulator.

---
 include/palmas.h |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
include/palmas.h +4 -0
index eaf3670..cca3f9a 100644
@@ -24,6 +24,10 @@
 #define LDO1_CTRL		0x50
 #define LDO1_VOLTAGE		0x51
 
+/* LDO2 control/voltage */
+#define LDO2_CTRL		0x52
+#define LDO2_VOLTAGE		0x53
+
 /* LDO9 control/voltage */
 #define LDO9_CTRL		0x60
 #define LDO9_VOLTAGE		0x61
Signature · 1 line
1.7.5.4
#4 lore raw

PATCH 2/4 ARM: OMAP5: Power: add LDO2 support for Palmas driver

Quoted 3 lines · Dmitry Lifshitz

Add defines required to turn on LDO2 regulator.

Applied to u-boot-ti/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140513/a570cb96/attachment.pgp>
#5 lore raw

PATCH 3/4 ARM: OMAP5: add CKO buffer control mask

In reply to Dmitry Lifshitz

Add CKOBUFFER_CLK_EN bit mask enabling FREF_XTAL_CLK clock.

---
 arch/arm/include/asm/arch-omap5/clock.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
arch/arm/include/asm/arch-omap5/clock.h +3 -0
index 2dfe4ef..30d9de2 100644
@@ -322,6 +322,9 @@
 
 #define V_SCLK	V_OSCK
 
+/* CKO buffer control */
+#define CKOBUFFER_CLK_ENABLE_MASK	(1 << 28)
+
 /* AUXCLKx reg fields */
 #define AUXCLK_ENABLE_MASK		(1 << 8)
 #define AUXCLK_SRCSELECT_SHIFT		1
Signature · 1 line
1.7.5.4
#6 lore raw

PATCH 3/4 ARM: OMAP5: add CKO buffer control mask

Quoted 3 lines · Dmitry Lifshitz

Add CKOBUFFER_CLK_EN bit mask enabling FREF_XTAL_CLK clock.

Applied to u-boot-ti/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140513/fa1319a1/attachment.pgp>
#7 lore raw

PATCH 4/4 cm-t54: add cm-t54 board support

In reply to Dmitry Lifshitz

Add cm-t54 board directory, config file. Enable build.

Basic support includes:

Serial console
SD/MMC
eMMC
USB
Ethernet

---
 board/compulab/cm_t54/Makefile |   10 ++
 board/compulab/cm_t54/cm_t54.c |  177 ++++++++++++++++++++++++++++++++++++++++
 board/compulab/cm_t54/mux.c    |   94 +++++++++++++++++++++
 board/compulab/cm_t54/spl.c    |   66 +++++++++++++++
 boards.cfg                     |    1 +
 include/configs/cm_t54.h       |  144 ++++++++++++++++++++++++++++++++
 6 files changed, 492 insertions(+), 0 deletions(-)
 create mode 100644 board/compulab/cm_t54/Makefile
 create mode 100644 board/compulab/cm_t54/cm_t54.c
 create mode 100644 board/compulab/cm_t54/mux.c
 create mode 100644 board/compulab/cm_t54/spl.c
 create mode 100644 include/configs/cm_t54.h
board/compulab/cm_t54/Makefile new file +10 -0
new file mode 100644
index 0000000..bd8bc51
@@ -0,0 +1,10 @@
+#
+# Copyright (C) 2014 Compulab Ltd - http://compulab.co.il/
+#
+# Author: Dmitry Lifshitz <[email protected]>
+#
+# SPDX-License-Identifier:	GPL-2.0+
+#
+
+obj-y += $(BOARD).o
+obj-$(CONFIG_SPL_BUILD) += mux.o spl.o
board/compulab/cm_t54/cm_t54.c new file +177 -0

177 lines not on this page · raw message

board/compulab/cm_t54/mux.c new file +94 -0

94 lines not on this page · raw message

board/compulab/cm_t54/spl.c new file +66 -0

66 lines not on this page · raw message

boards.cfg +1 -0
index b4203f1..0f3a0bd 100644
@@ -359,6 +359,7 @@ Active  arm         armv7          omap3       ti              sdp3430
 Active  arm         armv7          omap3       timll           devkit8000          devkit8000                           -                                                                                                                                 Thomas Weber <[email protected]>
 Active  arm         armv7          omap4       ti              panda               omap4_panda                          -                                                                                                                                 Sricharan R <[email protected]>
 Active  arm         armv7          omap4       ti              sdp4430             omap4_sdp4430                        -                                                                                                                                 Sricharan R <[email protected]>
+Active  arm         armv7          omap5       compulab        cm_t54              cm_t54                               -                                                                                                                                 Dmitry Lifshitz <[email protected]>
 Active  arm         armv7          omap5       ti              dra7xx              dra7xx_evm                           dra7xx_evm:CONS_INDEX=1                                                                                                           Lokesh Vutla <[email protected]>
 Active  arm         armv7          omap5       ti              dra7xx              dra7xx_evm_uart3                     dra7xx_evm:CONS_INDEX=3,SPL_YMODEM_SUPPORT                                                                                        Lokesh Vutla <[email protected]>
 Active  arm         armv7          omap5       ti              omap5_uevm          omap5_uevm                           -                                                                                                                                 -
include/configs/cm_t54.h new file +144 -0

144 lines not on this page · raw message

Signature · 1 line
1.7.5.4
#8 lore raw

PATCH 4/4 cm-t54: add cm-t54 board support

Quoted 1 line · Dmitry Lifshitz

Add cm-t54 board directory, config file. Enable build.

[snip]

Quoted 6 lines
board/compulab/cm_t54/Makefile new file +0 -0
new file mode 100644
index 0000000..bd8bc51

board/compulab/cm_t54/Makefile line 9

Quoted 9 lines
board/compulab/cm_t54/Makefile new file +9 -0
@@ -0,0 +1,10 @@
+#
+# Copyright (C) 2014 Compulab Ltd - http://compulab.co.il/
+#
+# Author: Dmitry Lifshitz <[email protected]>
+#
+# SPDX-License-Identifier:	GPL-2.0+
+#
+
+obj-y += $(BOARD).o

Please don't use $(BOARD) here, just went and changed the other users of this convention.

board/compulab/cm_t54/Makefile

Quoted 10 lines
board/compulab/cm_t54/Makefile new file +10 -0
+/*
+ * Routine: board_init
+ * Description: hardware init.
+ */
+int board_init(void)
+{
+	gd->bd->bi_boot_params = (0x80000000 + 0x100); /* boot param addr */
+
+	return 0;
+}

CONFIG_SYS_SDRAM_BASE + 0x100

board/compulab/cm_t54/Makefile

Quoted 5 lines
board/compulab/cm_t54/Makefile new file +5 -0
+#define CONFIG_EXTRA_ENV_SETTINGS \
+	"loadaddr=0x82000000\0" \
+	"fdtaddr=0x80F80000\0" \
+	"fdt_high=0xffffffff\0" \
+	"rdaddr=0x81000000\0" \

Can you use DEFAULT_LINUX_BOOT_ENV here (see u-boot-ti) ? I really don't like disabling fdt relocation with it being below 128MB (I'd prefer what we do with DEFAULT_LINUX_BOOT_ENV and bootm_size, please see the various ML threads about that).

Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140506/06f19a06/attachment.pgp>
#9 lore raw

PATCH 4/4 cm-t54: add cm-t54 board support

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Tom,

Quoted 36 lines · Tom Rini
Quoted 1 line · Dmitry Lifshitz

Add cm-t54 board directory, config file. Enable build.

[snip]

Quoted 6 lines
board/compulab/cm_t54/Makefile new file +0 -0
new file mode 100644
index 0000000..bd8bc51

board/compulab/cm_t54/Makefile line 9

Quoted 9 lines
board/compulab/cm_t54/Makefile new file +9 -0
@@ -0,0 +1,10 @@
+#
+# Copyright (C) 2014 Compulab Ltd - http://compulab.co.il/
+#
+# Author: Dmitry Lifshitz <[email protected]>
+#
+# SPDX-License-Identifier:	GPL-2.0+
+#
+
+obj-y += $(BOARD).o

Please don't use $(BOARD) here, just went and changed the other users of this convention.

board/compulab/cm_t54/Makefile

Quoted 10 lines
board/compulab/cm_t54/Makefile new file +10 -0
+/*
+ * Routine: board_init
+ * Description: hardware init.
+ */
+int board_init(void)
+{
+	gd->bd->bi_boot_params = (0x80000000 + 0x100); /* boot param addr */
+
+	return 0;
+}

CONFIG_SYS_SDRAM_BASE + 0x100

Quoted 10 lines

board/compulab/cm_t54/Makefile

Quoted 5 lines
board/compulab/cm_t54/Makefile new file +5 -0
+#define CONFIG_EXTRA_ENV_SETTINGS \
+	"loadaddr=0x82000000\0" \
+	"fdtaddr=0x80F80000\0" \
+	"fdt_high=0xffffffff\0" \
+	"rdaddr=0x81000000\0" \

Can you use DEFAULT_LINUX_BOOT_ENV here (see u-boot-ti) ? I really don't like disabling fdt relocation with it being below 128MB (I'd prefer what we do with DEFAULT_LINUX_BOOT_ENV and bootm_size, please see the various ML threads about that).

Thanks Tom,

We will fix the comments and repost v2 in a couple of days.

- --
Regards,
Igor.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQIcBAEBAgAGBQJTcwroAAoJEBDE8YO64EfaxQoP/2GKp8kJErMdiMZs8TdIhkGp De1T6qw+qoTsA/91nFQUq4AMv5lfApghTgjmU/zx5oI4Uo8IPE8uMtZw9VSwTucu Zfy1BrhGj8kbVe9u6oOf2uZiqvzyaEqdi9a/EwmB69cYu8QcQFP+nbPPMqmxgA2i B9aUP/+54PluWcBDN0Z5btPfeRBgodyHLJlOtNWCwy4SmzgoARYbS+wrrKqiZApJ NPYdH1wtgVcrsqiBFGILCktgVkUl4ncC7oa0MTzQfzAPKaKvbhbuwT98lhgUNcsZ xf7QS3KSGD6/H8xZS0VTAmC5frf7/IAHzSFJsb25OMfi8gwrL8a1Nf9XA+UaAB0I cpv53xxEoTvdAP/gmBz0sKdC0YKLvYin/OqY0PeFl1itPrKJ1CiKBXL60l0u7wkT J4HtxsUUfl/nbZc/KbB9cnYCf57V1nnDw3KesRR2nwWaBf0dTWFiPIKCHpZjyUKg OUinqCjRIbL6KTLEkcipPYXHuFGVNqcE3a+uRDn7jLW0+XcU2zKi04Djpn7F84TM LXUhnJX8UC59AZuseMqi3yK26OOmTFcIOMcRDi45Zri3qsaYIi7TrD9offwlxb6/ +JEP3YROi0fm8jrC//0GUjx8idmjeZYlx0U4EDjLxKBqnABVlTjrBoiheB+rr+f0 t2HoJHgnV89Dtu26mZi5
=C1e2
-----END PGP SIGNATURE-----

#10 lore raw

PATCH v2 4/4 cm-t54: add cm-t54 board support

In reply to Tom Rini

Add cm-t54 board directory, config file. Enable build.

Basic support includes:

Serial console
SD/MMC
eMMC
USB
Ethernet

---

v2: * Fixed Makefile to use board file name explicitely instead of $(BOARD).o
* Use CONFIG_SYS_SDRAM_BASE
* Use DEFAULT_LINUX_BOOT_ENV in default environment
* Misc changes in default environment and bootcmd

 board/compulab/cm_t54/Makefile |   10 ++
 board/compulab/cm_t54/cm_t54.c |  177 ++++++++++++++++++++++++++++++++++++++++
 board/compulab/cm_t54/mux.c    |   94 +++++++++++++++++++++
 board/compulab/cm_t54/spl.c    |   66 +++++++++++++++
 boards.cfg                     |    1 +
 include/configs/cm_t54.h       |  139 +++++++++++++++++++++++++++++++
 6 files changed, 487 insertions(+), 0 deletions(-)
 create mode 100644 board/compulab/cm_t54/Makefile
 create mode 100644 board/compulab/cm_t54/cm_t54.c
 create mode 100644 board/compulab/cm_t54/mux.c
 create mode 100644 board/compulab/cm_t54/spl.c
 create mode 100644 include/configs/cm_t54.h
board/compulab/cm_t54/Makefile new file +10 -0
new file mode 100644
index 0000000..298ddd2
@@ -0,0 +1,10 @@
+#
+# Copyright (C) 2014 Compulab Ltd - http://compulab.co.il/
+#
+# Author: Dmitry Lifshitz <[email protected]>
+#
+# SPDX-License-Identifier:	GPL-2.0+
+#
+
+obj-y += cm_t54.o
+obj-$(CONFIG_SPL_BUILD) += mux.o spl.o
board/compulab/cm_t54/cm_t54.c new file +177 -0

177 lines not on this page · raw message

board/compulab/cm_t54/mux.c new file +94 -0

94 lines not on this page · raw message

board/compulab/cm_t54/spl.c new file +66 -0

66 lines not on this page · raw message

boards.cfg +1 -0
index 8aaf749..7344c93 100644
@@ -362,6 +362,7 @@ Active  arm         armv7          omap3       ti              sdp3430
 Active  arm         armv7          omap3       timll           devkit8000          devkit8000                           -                                                                                                                                 Thomas Weber <[email protected]>
 Active  arm         armv7          omap4       ti              panda               omap4_panda                          -                                                                                                                                 Sricharan R <[email protected]>
 Active  arm         armv7          omap4       ti              sdp4430             omap4_sdp4430                        -                                                                                                                                 Sricharan R <[email protected]>
+Active  arm         armv7          omap5       compulab        cm_t54              cm_t54                               -                                                                                                                                 Dmitry Lifshitz <[email protected]>
 Active  arm         armv7          omap5       ti              dra7xx              dra7xx_evm                           dra7xx_evm:CONS_INDEX=1                                                                                                           Lokesh Vutla <[email protected]>
 Active  arm         armv7          omap5       ti              dra7xx              dra7xx_evm_uart3                     dra7xx_evm:CONS_INDEX=3,SPL_YMODEM_SUPPORT                                                                                        Lokesh Vutla <[email protected]>
 Active  arm         armv7          omap5       ti              dra7xx              dra7xx_evm_qspiboot                  dra7xx_evm:CONS_INDEX=1,QSPI_BOOT                                                                                                 Lokesh Vutla <[email protected]>
include/configs/cm_t54.h new file +139 -0

139 lines not on this page · raw message

Signature · 1 line
1.7.5.4
#11 lore raw

PATCH v2 4/4 cm-t54: add cm-t54 board support

Quoted 4 lines · Dmitry Lifshitz

Add cm-t54 board directory, config file. Enable build.

Basic support includes:

Quoted 8 lines

Serial console
SD/MMC
eMMC
USB
Ethernet

Applied to u-boot-ti/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140523/c24ef945/attachment.pgp>