ARM: dts: enable hdmi for exynos5 based peach and snow boards

PATCH Superseded Rahul Sharma 3 participants 8 messages May 15, 2014

Subsystems (2)

Device tree bindings Arm Samsung Exynos

lore

Share & tools

lore

Rahul Sharma

author

2014-05-15 15:04 UTC #0 lore raw

v5 cover ARM: dts: enable hdmi for exynos5 based peach and snow boards

From: Rahul Sharma <[email protected]>

Enable hdmi for exynos5250 based snow board, exynos5420 based peach pit board and 5800 based peach-pi board.

V5:
1) Moved hdmi_hpd_irq pin back to board files.
2) Replaced 0 with GPIO_ACTIVE_HIGH while adding gpio property to HDMI node.

V4:
1) Removed hdmi_hpd_irq pin from peach-pi board as it already present in exynos5420-pinctrl.dtsi.

V3:
1) Re-spin on dependent patches.
2) Added patch to enable hdmi for Peach-pi board.

V2:
1) Re-spin on dependent patches.
2) Added patch to remove chip specific hdmi hpd gpio from board file top SoC file.

This series is based on Kukjin Kims, for-next branch.

It is dependent on

1) Sachin's patch: "ARM: dts: exynos5250-snow: add tps65090 power regulator" at https://patches.linaro.org/28325/ : [Reviewed-by: Doug Anderson]

All other dependent patches are already landed in maintainers tree.

Rahul Sharma (4):
ARM: dts: enable hdmi for exynos5250 based snow board
ARM: dts: change to correct compatible string for exynos5420 hdmi
ARM: dts: enable hdmi for exynos5420 based peach-pit board
ARM: dts: enable hdmi for exynos5800 based peach-pi board

 arch/arm/boot/dts/exynos5250-cros-common.dtsi |    6 +++++-
 arch/arm/boot/dts/exynos5250-snow.dts         |   14 ++++++++++++++
 arch/arm/boot/dts/exynos5420-peach-pit.dts    |   22 ++++++++++++++++++++++
 arch/arm/boot/dts/exynos5420.dtsi             |    7 ++++++-
 arch/arm/boot/dts/exynos5800-peach-pi.dts     |   22 ++++++++++++++++++++++
 5 files changed, 69 insertions(+), 2 deletions(-)

Signature · 1 line

1.7.9.5

Rahul Sharma

author

2014-05-15 15:04 UTC #1 lore raw

PATCH v5 1/4 ARM: dts: enable hdmi for exynos5250 based snow board

From: Rahul Sharma <[email protected]>

Enable support for HDMI for exynos5250 based Snow board.

Signed-off-by Rahul Sharma <[email protected]>

---
 arch/arm/boot/dts/exynos5250-cros-common.dtsi |    6 +++++-
 arch/arm/boot/dts/exynos5250-snow.dts         |   14 ++++++++++++++
 2 files changed, 19 insertions(+), 1 deletion(-)

arch/arm/boot/dts/exynos5250-cros-common.dtsi +5 -1

index 2c1560d..89ac90f 100644
@@ -240,7 +240,7 @@
 		samsung,i2c-sda-delay = <100>;
 		samsung,i2c-max-bus-freq = <378000>;
 
-		hdmiphy at 38 {
+		hdmiphy: hdmiphy at 38 {
 			compatible = "samsung,exynos4212-hdmiphy";
 			reg = <0x38>;
 		};

@@ -304,6 +304,10 @@
 
 	hdmi {
 		hpd-gpio = <&gpx3 7 0>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&hdmi_hpd_irq>;
+		phy = <&hdmiphy>;
+		ddc = <&i2c_2>;
 	};
 
 	gpio-keys {

arch/arm/boot/dts/exynos5250-snow.dts +14 -0

index 1ce1088..7aa5d11 100644
@@ -37,6 +37,13 @@
 		sd3_bus4: sd3-bus-width4 {
 			samsung,pin-drv = <0>;
 		};
+
+		hdmi_hpd_irq: hdmi-hpd-irq {
+			samsung,pins = "gpx3-7";
+			samsung,pin-function = <0>;
+			samsung,pin-pud = <1>;
+			samsung,pin-drv = <0>;
+		};
 	};
 
 	gpio-keys {

@@ -206,4 +213,11 @@
 			clock-frequency = <24000000>;
 		};
 	};
+
+	hdmi {
+		hdmi-en-supply = <&tps65090_fet7>;
+		vdd-supply = <&ldo8_reg>;
+		vdd_osc-supply = <&ldo10_reg>;
+		vdd_pll-supply = <&ldo8_reg>;
+	};
 };

Signature · 1 line

1.7.9.5

Rahul Sharma

author

2014-05-15 15:04 UTC #2 lore raw

PATCH v5 2/4 ARM: dts: change to correct compatible string for exynos5420 hdmi

In reply to Rahul Sharma

From: Rahul Sharma <[email protected]>

Replace compatible string for HDMI node in Exynos5420. Since latest restructring in Drm hdmi driver, it is agreed to use a seperate compatible string for Exynos5420 HDMI IP siince it uses APB mapped Phy.

Signed-off-by Rahul Sharma <[email protected]>

Acked-by Tomasz Figa <[email protected]>

---
 arch/arm/boot/dts/exynos5420.dtsi |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

arch/arm/boot/dts/exynos5420.dtsi +1 -1

index a802f74..016992c 100644
@@ -640,7 +640,7 @@
 	};
 
 	hdmi: hdmi at 14530000 {
-		compatible = "samsung,exynos4212-hdmi";
+		compatible = "samsung,exynos5420-hdmi";
 		reg = <0x14530000 0x70000>;
 		interrupts = <0 95 0>;
 		clocks = <&clock CLK_HDMI>, <&clock CLK_SCLK_HDMI>,

Signature · 1 line

1.7.9.5

Rahul Sharma

author

2014-05-15 15:04 UTC #3 lore raw

PATCH v5 3/4 ARM: dts: enable hdmi for exynos5420 based peach-pit board

In reply to Rahul Sharma

From: Rahul Sharma <[email protected]>

Enable hdmi for exynos5420 based peach-pit board.

Signed-off-by Rahul Sharma <[email protected]>

---
 arch/arm/boot/dts/exynos5420-peach-pit.dts |   22 ++++++++++++++++++++++
 arch/arm/boot/dts/exynos5420.dtsi          |    5 +++++
 2 files changed, 27 insertions(+)

arch/arm/boot/dts/exynos5420-peach-pit.dts +22 -0

index fae33dd..84f1a35 100644
@@ -74,6 +74,13 @@
 		samsung,pin-pud = <0>;
 		samsung,pin-drv = <0>;
 	};
+
+	hdmi_hpd_irq: hdmi-hpd-irq {
+		samsung,pins = "gpx3-7";
+		samsung,pin-function = <0>;
+		samsung,pin-pud = <1>;
+		samsung,pin-drv = <0>;
+	};
 };
 
 &rtc {

@@ -137,6 +144,21 @@
 	};
 };
 
+&i2c_2	{
+	status = "okay";
+	samsung,i2c-sda-delay = <100>;
+	samsung,i2c-max-bus-freq = <66000>;
+	samsung,i2c-slave-addr = <0x50>;
+};
+
+&hdmi {
+	status = "okay";
+	hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&hdmi_hpd_irq>;
+	ddc = <&i2c_2>;
+};
+
 /*
  * Use longest HW watchdog in SoC (32 seconds) since the hardware
  * watchdog provides no debugging information (compared to soft/hard

arch/arm/boot/dts/exynos5420.dtsi +5 -0

index 016992c..df4422c 100644
@@ -648,9 +648,14 @@
 			 <&clock CLK_MOUT_HDMI>;
 		clock-names = "hdmi", "sclk_hdmi", "sclk_pixel",
 			"sclk_hdmiphy", "mout_hdmi";
+		phy = <&hdmiphy>;
 		status = "disabled";
 	};
 
+	hdmiphy: hdmiphy at 145D0000 {
+		reg = <0x145D0000 0x20>;
+	};
+
 	mixer: mixer at 14450000 {
 		compatible = "samsung,exynos5420-mixer";
 		reg = <0x14450000 0x10000>;

Signature · 1 line

1.7.9.5

Rahul Sharma

author

2014-05-15 15:04 UTC #4 lore raw

PATCH v5 4/4 ARM: dts: enable hdmi for exynos5800 based peach-pi board

In reply to Rahul Sharma

From: Rahul Sharma <[email protected]>

Enable hdmi for peach-pi board.

Signed-off-by Rahul Sharma <[email protected]>

---
 arch/arm/boot/dts/exynos5800-peach-pi.dts |   22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

arch/arm/boot/dts/exynos5800-peach-pi.dts +22 -0

index 742655b..5a44871 100644
@@ -72,6 +72,13 @@
 		samsung,pin-pud = <0>;
 		samsung,pin-drv = <0>;
 	};
+
+	hdmi_hpd_irq: hdmi-hpd-irq {
+		samsung,pins = "gpx3-7";
+		samsung,pin-function = <0>;
+		samsung,pin-pud = <1>;
+		samsung,pin-drv = <0>;
+	};
 };
 
 &rtc {

@@ -134,6 +141,21 @@
 	};
 };
 
+&i2c_2 {
+	status = "okay";
+	samsung,i2c-sda-delay = <100>;
+	samsung,i2c-max-bus-freq = <66000>;
+	samsung,i2c-slave-addr = <0x50>;
+};
+
+&hdmi {
+	status = "okay";
+	hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&hdmi_hpd_irq>;
+	ddc = <&i2c_2>;
+};
+
 /*
  * Use longest HW watchdog in SoC (32 seconds) since the hardware
  * watchdog provides no debugging information (compared to soft/hard

Signature · 1 line

1.7.9.5

Tomasz Figa

2014-05-15 19:25 UTC #5 lore raw

v5 cover ARM: dts: enable hdmi for exynos5 based peach and snow boards

In reply to Rahul Sharma

Hi Rahul,

Quoted 39 lines · Rahul Sharma

From: Rahul Sharma <[email protected]>
Enable hdmi for exynos5250 based snow board, exynos5420 based peach pit board and 5800 based peach-pi board.
V5:
1) Moved hdmi_hpd_irq pin back to board files.
2) Replaced 0 with GPIO_ACTIVE_HIGH while adding gpio property to HDMI node.
V4:
1) Removed hdmi_hpd_irq pin from peach-pi board as it already present in exynos5420-pinctrl.dtsi.
V3:
1) Re-spin on dependent patches.
2) Added patch to enable hdmi for Peach-pi board.
V2:
1) Re-spin on dependent patches.
2) Added patch to remove chip specific hdmi hpd gpio from board file top SoC file.
This series is based on Kukjin Kims, for-next branch.
It is dependent on
1) Sachin's patch: "ARM: dts: exynos5250-snow: add tps65090 power regulator" at https://patches.linaro.org/28325/ : [Reviewed-by: Doug Anderson]
All other dependent patches are already landed in maintainers tree.
Rahul Sharma (4):
ARM: dts: enable hdmi for exynos5250 based snow board
ARM: dts: change to correct compatible string for exynos5420 hdmi
ARM: dts: enable hdmi for exynos5420 based peach-pit board
ARM: dts: enable hdmi for exynos5800 based peach-pi board

Quoted 7 lines

 arch/arm/boot/dts/exynos5250-cros-common.dtsi |    6 +++++-
 arch/arm/boot/dts/exynos5250-snow.dts         |   14 ++++++++++++++
 arch/arm/boot/dts/exynos5420-peach-pit.dts    |   22 ++++++++++++++++++++++
 arch/arm/boot/dts/exynos5420.dtsi             |    7 ++++++-
 arch/arm/boot/dts/exynos5800-peach-pi.dts     |   22 ++++++++++++++++++++++
 5 files changed, 69 insertions(+), 2 deletions(-)

For the whole series:

Acked-by Tomasz Figa <[email protected]>

Best regards,
Tomasz

Kukjin Kim

2014-05-15 20:02 UTC #6 lore raw

v5 cover ARM: dts: enable hdmi for exynos5 based peach and snow boards

Quoted 50 lines · Tomasz Figa

Hi Rahul,
Quoted 39 lines · Rahul Sharma
From: Rahul Sharma<[email protected]>
Enable hdmi for exynos5250 based snow board, exynos5420 based peach pit board and 5800 based peach-pi board.
V5:
1) Moved hdmi_hpd_irq pin back to board files.
2) Replaced 0 with GPIO_ACTIVE_HIGH while adding gpio property to HDMI node.
V4:
1) Removed hdmi_hpd_irq pin from peach-pi board as it already present in exynos5420-pinctrl.dtsi.
V3:
1) Re-spin on dependent patches.
2) Added patch to enable hdmi for Peach-pi board.
V2:
1) Re-spin on dependent patches.
2) Added patch to remove chip specific hdmi hpd gpio from board file top SoC file.
This series is based on Kukjin Kims, for-next branch.
It is dependent on
1) Sachin's patch: "ARM: dts: exynos5250-snow: add tps65090 power regulator" at https://patches.linaro.org/28325/ : [Reviewed-by: Doug Anderson]
All other dependent patches are already landed in maintainers tree.
Rahul Sharma (4):
ARM: dts: enable hdmi for exynos5250 based snow board
ARM: dts: change to correct compatible string for exynos5420 hdmi
ARM: dts: enable hdmi for exynos5420 based peach-pit board
ARM: dts: enable hdmi for exynos5800 based peach-pi board
Quoted 7 lines
  arch/arm/boot/dts/exynos5250-cros-common.dtsi |    6 +++++-
  arch/arm/boot/dts/exynos5250-snow.dts         |   14 ++++++++++++++
  arch/arm/boot/dts/exynos5420-peach-pit.dts    |   22 ++++++++++++++++++++++
  arch/arm/boot/dts/exynos5420.dtsi             |    7 ++++++-
  arch/arm/boot/dts/exynos5800-peach-pi.dts     |   22 ++++++++++++++++++++++
  5 files changed, 69 insertions(+), 2 deletions(-)

Quoted 4 lines

For the whole series:
Acked-by Tomasz Figa<[email protected]>

Looks good to me too.

Applied but not for-next yet because need to check the status of the tps65090 related patches you mentioned...

Thanks,
Kukjin

Kukjin Kim

2014-05-15 20:28 UTC #7 lore raw

v5 cover ARM: dts: enable hdmi for exynos5 based peach and snow boards

Quoted 52 lines · Kukjin Kim

Quoted 51 lines · Tomasz Figa
Hi Rahul,
Quoted 47 lines · Rahul Sharma
From: Rahul Sharma<[email protected]>
Enable hdmi for exynos5250 based snow board, exynos5420 based peach pit board and 5800 based peach-pi board.
V5:
1) Moved hdmi_hpd_irq pin back to board files.
2) Replaced 0 with GPIO_ACTIVE_HIGH while adding gpio property to HDMI node.
V4:
1) Removed hdmi_hpd_irq pin from peach-pi board as it already present in exynos5420-pinctrl.dtsi.
V3:
1) Re-spin on dependent patches.
2) Added patch to enable hdmi for Peach-pi board.
V2:
1) Re-spin on dependent patches.
2) Added patch to remove chip specific hdmi hpd gpio from board file top SoC file.
This series is based on Kukjin Kims, for-next branch.
It is dependent on
1) Sachin's patch: "ARM: dts: exynos5250-snow: add tps65090 power regulator"
at https://patches.linaro.org/28325/ : [Reviewed-by: Doug Anderson]
All other dependent patches are already landed in maintainers tree.
Rahul Sharma (4):
ARM: dts: enable hdmi for exynos5250 based snow board
ARM: dts: change to correct compatible string for exynos5420 hdmi
ARM: dts: enable hdmi for exynos5420 based peach-pit board
ARM: dts: enable hdmi for exynos5800 based peach-pi board
arch/arm/boot/dts/exynos5250-cros-common.dtsi | 6 +++++- arch/arm/boot/dts/exynos5250-snow.dts | 14 ++++++++++++++ arch/arm/boot/dts/exynos5420-peach-pit.dts | 22 ++++++++++++++++++++++ arch/arm/boot/dts/exynos5420.dtsi | 7 ++++++- arch/arm/boot/dts/exynos5800-peach-pi.dts | 22 ++++++++++++++++++++++
5 files changed, 69 insertions(+), 2 deletions(-)

Quoted 9 lines

Quoted 4 lines
For the whole series:
Acked-by Tomasz Figa<[email protected]>
Looks good to me too.
Applied but not for-next yet because need to check the status of the tps65090 related patches you mentioned...

Done.

Thanks,
Kukjin