drivers: net: ethernet: mellanox: mlx4: let mlx4 depend on SMP
Subsystems (5)
PATCH 1/1 drivers: net: ethernet: mellanox: mlx4: let mlx4 depend on SMP
'struct irq_affinity_notify' and the related functions are only defined when SMP enabled, so at present, mlx4 has to only run under SMP.
The related error (allmodconfig under unicore32):
CC [M] drivers/net/ethernet/mellanox/mlx4/eq.o
drivers/net/ethernet/mellanox/mlx4/eq.c:58: error: field ‘notify’ has incomplete type drivers/net/ethernet/mellanox/mlx4/eq.c: In function ‘mlx4_irq_notifier_notify’:
drivers/net/ethernet/mellanox/mlx4/eq.c:1094: error: type defaults to ‘int’ in declaration of ‘__mptr’ drivers/net/ethernet/mellanox/mlx4/eq.c:1094: warning: initialization from incompatible pointer type drivers/net/ethernet/mellanox/mlx4/eq.c:1104: error: dereferencing pointer to incomplete type drivers/net/ethernet/mellanox/mlx4/eq.c: In function ‘mlx4_release_irq_notifier’:
drivers/net/ethernet/mellanox/mlx4/eq.c:1111: error: type defaults to ‘int’ in declaration of ‘__mptr’ drivers/net/ethernet/mellanox/mlx4/eq.c:1111: warning: initialization from incompatible pointer type drivers/net/ethernet/mellanox/mlx4/eq.c: In function ‘mlx4_assign_irq_notifier’:
drivers/net/ethernet/mellanox/mlx4/eq.c:1133: error: implicit declaration of function ‘irq_set_affinity_notifier’ make[5]: *** [drivers/net/ethernet/mellanox/mlx4/eq.o] Error 1
make[4]: *** [drivers/net/ethernet/mellanox/mlx4] Error 2
make[3]: *** [drivers/net/ethernet/mellanox] Error 2
make[2]: *** [drivers/net/ethernet] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2
--- drivers/infiniband/hw/mlx4/Kconfig | 2 +- drivers/net/ethernet/mellanox/mlx4/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/infiniband/hw/mlx4/Kconfig +1 -1
@@ -1,6 +1,6 @@ config MLX4_INFINIBAND tristate "Mellanox ConnectX HCA support" - depends on NETDEVICES && ETHERNET && PCI && INET + depends on NETDEVICES && ETHERNET && PCI && INET && SMP select NET_VENDOR_MELLANOX select MLX4_CORE ---help---
drivers/net/ethernet/mellanox/mlx4/Kconfig +1 -1
@@ -4,7 +4,7 @@ config MLX4_EN tristate "Mellanox Technologies 1/10/40Gbit Ethernet support" - depends on PCI + depends on PCI && SMP select MLX4_CORE select PTP_1588_CLOCK ---help---
Signature · 5 lines
1.9.2.459.g68773ac -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
David Miller
maintainerFrom: Chen Gang <[email protected]>
Date: Sat, 17 May 2014 13:26:16 +0800
Quoted 4 lines
'struct
irq_affinity_notify' and the related functions are only defined when SMP enabled, so at present, mlx4 has to only run under SMP.The related error (allmodconfig under unicore32):
Making the entire driver depend upon SMP is not the answer, other Mellanox developers said that a proper fix is pending so please be patient.
Quoted 12 lines · David Miller
From: Chen Gang <[email protected]>
Date: Sat, 17 May 2014 13:26:16 +0800Quoted 4 lines
'struct
irq_affinity_notify' and the related functions are only defined when SMP enabled, so at present, mlx4 has to only run under SMP.The related error (allmodconfig under unicore32):
Making the entire driver depend upon SMP is not the answer, other Mellanox developers said that a proper fix is pending so please be patient.
OK, thank you for your information. I shall bypass it, and continue.
Thanks.
Signature · 7 lines
Chen Gang Open, share, and attitude like air, water, and life which God blessed -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 10 lines · David Miller
From: Chen Gang <[email protected]>
Date: Sat, 17 May 2014 13:26:16 +0800Quoted 4 lines
'struct
irq_affinity_notify' and the related functions are only defined when SMP enabled, so at present, mlx4 has to only run under SMP.The related error (allmodconfig under unicore32):
Making the entire driver depend upon SMP is not the answer,
Indeed, we would do that just for the relevant portion,
Quoted 3 lines
other Mellanox developers said that a proper fix is pending so please be patient.
Quoted 8 lines · Or Gerlitz
Quoted 7 lines · David Miller
From: Chen Gang <[email protected]>
Date: Sat, 17 May 2014 13:26:16 +0800Quoted 3 lines
'struct
irq_affinity_notify' and the related functions are only defined when SMP enabled, so at present, mlx4 has to only run under SMP.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
The related error (allmodconfig under unicore32):
Making the entire driver depend upon SMP is not the answer,
Indeed, we would do that just for the relevant portion,
Thank you for your work.
And next, when I meet the case like this again, instead of sending patch, I shall send suggestion message to the related members/experts.
Thanks.
Signature · 3 lines
Chen Gang Open, share and attitude like air, water and life which God blessed
Quoted 8 lines · Or Gerlitz
Quoted 7 lines · David Miller
From: Chen Gang <[email protected]>
Date: Sat, 17 May 2014 13:26:16 +0800Quoted 3 lines
'struct
irq_affinity_notify' and the related functions are only defined when SMP enabled, so at present, mlx4 has to only run under SMP.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
The related error (allmodconfig under unicore32):
Making the entire driver depend upon SMP is not the answer,
Indeed, we would do that just for the relevant portion,
Thank you for your work.
And next, when I meet the case like this again, instead of sending patch, I shall send suggestion message to the related members/experts.
Thanks.
Signature · 3 lines
Chen Gang Open, share and attitude like air, water and life which God blessed