Skip to contentSkip to conversation

mx6sabre_common: Avoid console hang due to small CONFIG_SYS_PBSIZE

PATCH New Fabio Estevam 3 participants 3 messages May 19, 2014 – Jun 6, 2014

lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/1 mx6sabre_common: Avoid console hang due to small CONFIG_SYS_PBSIZE

From: Fabio Estevam <[email protected]>

Entering the maximum number of characters defined by CONFIG_SYS_CBSIZE into the console and hitting enter afterwards, causes a hang in the system because CONFIG_SYS_PBSIZE is not capable of storing the characters of the error message:
"Unknown command '' - try 'help'"

Increase the size of CONFIG_SYS_PBSIZE so that it can store the error message and allows the error message to be printed correctly with no hang.

Signed-off-by Fabio Estevam <[email protected]>

---
This problem affects many boards.

Maybe a global fix is to add a CONFIG_SYS_PBSIZE entry into config_fallbacks and remove its definition from the board config files when it is defined as:
#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)

or even when it is equal to CONFIG_SYS_CBSIZE.

 include/configs/mx6sabre_common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/mx6sabre_common.h +1 -1
index e59a3b4..6017a20 100644
@@ -217,7 +217,7 @@
 #define CONFIG_SYS_CBSIZE              256
 
 /* Print Buffer Size */
-#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)
+#define CONFIG_SYS_PBSIZE		384
 #define CONFIG_SYS_MAXARGS             16
 #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 mx6sabre_common: Avoid console hang due to small CONFIG_SYS_PBSIZE

Hi, Dear Fabio

Quoted 7 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Entering the maximum number of characters defined by CONFIG_SYS_CBSIZE into the console and hitting enter afterwards, causes a hang in the system because CONFIG_SYS_PBSIZE is not capable of storing the characters of the error message:
"Unknown command '' - try 'help'"

Quoted 6 lines

Increase the size of CONFIG_SYS_PBSIZE so that it can store the error message and allows the error message to be printed correctly with no hang.

Signed-off-by Fabio Estevam <[email protected]>

---
This problem affects many boards.

This hang up can be reproduced in at91sam9m10g45ek board.

Quoted 3 lines

Maybe a global fix is to add a CONFIG_SYS_PBSIZE entry into config_fallbacks and remove its definition from the board config files when it is defined as:

I think this way is a really fix for the issue. So it's better to generate such a patch to fix it for many boards in U-Boot.

Best Regards,
Josh Wu

Quoted 20 lines

#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)

or even when it is equal to CONFIG_SYS_CBSIZE.

  include/configs/mx6sabre_common.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/mx6sabre_common.h +1 -1
index e59a3b4..6017a20 100644
@@ -217,7 +217,7 @@
  #define CONFIG_SYS_CBSIZE              256
 
  /* Print Buffer Size */
-#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)
+#define CONFIG_SYS_PBSIZE		384
  #define CONFIG_SYS_MAXARGS             16
  #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
#2 lore raw

PATCH 1/1 mx6sabre_common: Avoid console hang due to small CONFIG_SYS_PBSIZE

In reply to Fabio Estevam

Hi Fabio,

Quoted 10 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Entering the maximum number of characters defined by CONFIG_SYS_CBSIZE into the console and hitting enter afterwards, causes a hang in the system because CONFIG_SYS_PBSIZE is not capable of storing the characters of the error message:
"Unknown command '' - try 'help'"

Increase the size of CONFIG_SYS_PBSIZE so that it can store the error message and allows the error message to be printed correctly with no hang.

Quoted 8 lines
Signed-off-by Fabio Estevam <[email protected]>

---
This problem affects many boards.

Maybe a global fix is to add a CONFIG_SYS_PBSIZE entry into config_fallbacks and remove its definition from the board config files when it is defined as:
#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)

IMHO this is much better as fixing each single board.

Quoted 1 line

or even when it is equal to CONFIG_SYS_CBSIZE.

I would not add any further check : if a board maintainer add CONFIG_SYS_PBSIZE to each own config file, he must know what he is doing. If it is not set, config_fallbacks defines CONFIG_SYS_PBSIZE

Regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================