Support d-link dns320 (arch kirkwood)
v2 cover Support d-link dns320 (arch kirkwood)
Hi,
A rebase of an old patch set from Jamie Lentin.
Source is available here:
http://jamie.lentin.co.uk/devices/dlink-dns325/
Please apply
Changelog:
[V2] Use git option -M
Jamie Lentin (4):
kirkwood: Rename dns325 to dnskw
kirkwood: Add support for the D-Link DNS-320
kirkwood: Set unused SD pins back to GPIO for DNS-320 & DNS-325
kirkwood: Shorten DNS-325 IDENT_STRING to match DNS-320
board/d-link/dns325/dns325.h | 32 ----
board/d-link/{dns325 => dnskw}/Makefile | 2 +-
board/d-link/{dns325/dns325.c => dnskw/dnskw.c} | 30 +--
board/d-link/dnskw/dnskw.h | 42 +++++
board/d-link/dnskw/kwbimage.dns320.cfg | 207 +++++++++++++++++++++
.../kwbimage.cfg => dnskw/kwbimage.dns325.cfg} | 0
boards.cfg | 1 +
include/configs/{dns325.h => dnskw.h} | 23 ++-
8 files changed, 285 insertions(+), 52 deletions(-)
delete mode 100644 board/d-link/dns325/dns325.h
rename board/d-link/{dns325 => dnskw}/Makefile (93%)
rename board/d-link/{dns325/dns325.c => dnskw/dnskw.c} (84%)
create mode 100644 board/d-link/dnskw/dnskw.h
create mode 100644 board/d-link/dnskw/kwbimage.dns320.cfg
rename board/d-link/{dns325/kwbimage.cfg => dnskw/kwbimage.dns325.cfg} (100%)
rename include/configs/{dns325.h => dnskw.h} (86%)Signature · 1 line
2.0.0.rc0
PATCH v2 1/4 kirkwood: Rename dns325 to dnskw
From: Jamie Lentin <[email protected]>
So we can re-use DNS-325 configuration for the DNS-320 without things getting confusing, rename all common parts from dns325 to dnskw, and use a config option to configure DNS-325 specifics.
---
board/d-link/{dns325 => dnskw}/Makefile | 2 +-
board/d-link/{dns325/dns325.c => dnskw/dnskw.c} | 10 ++++-----
board/d-link/{dns325/dns325.h => dnskw/dnskw.h} | 24 +++++++++++++---------
.../kwbimage.cfg => dnskw/kwbimage.dns325.cfg} | 0
boards.cfg | 2 +-
include/configs/{dns325.h => dnskw.h} | 11 +++++++---
6 files changed, 29 insertions(+), 20 deletions(-)
rename board/d-link/{dns325 => dnskw}/Makefile (93%)
rename board/d-link/{dns325/dns325.c => dnskw/dnskw.c} (93%)
rename board/d-link/{dns325/dns325.h => dnskw/dnskw.h} (52%)
rename board/d-link/{dns325/kwbimage.cfg => dnskw/kwbimage.dns325.cfg} (100%)
rename include/configs/{dns325.h => dnskw.h} (94%)board/d-link/dnskw/Makefile renamed from board/d-link/dns325/Makefile +1 -1
@@ -10,4 +10,4 @@ # SPDX-License-Identifier: GPL-2.0+ # -obj-y := dns325.o +obj-y := dnskw.o
board/d-link/dnskw/dnskw.c renamed from board/d-link/dns325/dns325.c +5 -5
@@ -17,15 +17,15 @@#include <asm/arch/kirkwood.h> #include <asm/arch/mpp.h> #include <asm/arch/gpio.h> -#include "dns325.h" +#include "dnskw.h" DECLARE_GLOBAL_DATA_PTR ;int board_early_init_f (void ) {/* Gpio configuration */ -kw_config_gpio (DNS325_OE_VAL_LOW ,DNS325_OE_VAL_HIGH , -DNS325_OE_LOW ,DNS325_OE_HIGH ); +kw_config_gpio (DNSKW_OE_VAL_LOW ,DNSKW_OE_VAL_HIGH , +DNSKW_OE_LOW ,DNSKW_OE_HIGH );/* Multi-Purpose Pins Functionality configuration */ static const u32 kwmpp_config[] = {
@@ -83,9 +83,9 @@ int board_early_init_f(void) };kirkwood_mpp_conf (kwmpp_config,NULL ); -kw_gpio_set_blink (DNS325_GPIO_LED_POWER ,1 ); +kw_gpio_set_blink (DNSKW_GPIO_LED_POWER ,1 ); -kw_gpio_set_value (DNS325_GPIO_SATA0_EN ,1 ); +kw_gpio_set_value (DNSKW_GPIO_SATA0_EN ,1 );return 0 ; }
board/d-link/dnskw/dnskw.h renamed from board/d-link/dns325/dns325.h +14 -10
@@ -10,18 +10,22 @@* SPDX-License-Identifier: GPL-2.0+ */ -#ifndef __DNS325_H -#define __DNS325_H +#ifndef __DNSKW_H +#define __DNSKW_H/* GPIO configuration */ -#define DNS325_OE_LOW 0x00000000 -#define DNS325_OE_HIGH 0x00039604 -#define DNS325_OE_VAL_LOW 0x38000000/* disable leds */ -#define DNS325_OE_VAL_HIGH 0x00000800/* disable leds */ +#define DNSKW_OE_LOW 0x00000000 +#define DNSKW_OE_HIGH 0x00039604 -#define DNS325_GPIO_LED_POWER 26 -#define DNS325_GPIO_SATA0_EN 39 -#define DNS325_GPIO_SATA1_EN 40 +#define DNSKW_GPIO_LED_POWER 26 +#define DNSKW_GPIO_SATA0_EN 39 +#define DNSKW_GPIO_SATA1_EN 40 + +/* DNS-325 specific configuration */ +#ifdef CONFIG_BOARD_IS_DNS325 +#define DNSKW_OE_VAL_LOW 0x38000000/* disable leds */ +#define DNSKW_OE_VAL_HIGH 0x00000800/* disable leds */ +#endif /* CONFIG_BOARD_IS_DNS325 */ /* PHY related */ #define MV88E1116_MAC_CTRL_REG 21
@@ -29,4 +33,4 @@#define MV88E1116_RGMII_TXTM_CTRL (1 << 4)#define MV88E1116_RGMII_RXTM_CTRL (1 << 5) -#endif /* __DNS325_H */ +#endif /* __DNSKW_H */
board/d-link/dnskw/kwbimage.dns325.cfg renamed from board/d-link/dns325/kwbimage.cfg +0 -0
boards.cfg +1 -1
@@ -168,7 +168,7 @@ Active arm arm926ejs davinci omicron calimain Active arm arm926ejs kirkwood buffalo lsxl lschlv2 lsxl:LSCHLV2 Michael Walle <[email protected]> Active arm arm926ejs kirkwood buffalo lsxl lsxhl lsxl:LSXHL Michael Walle <[email protected]> Active arm arm926ejs kirkwood cloudengines - pogo_e02 - Dave Purdy <[email protected]> -Active arm arm926ejs kirkwood d-link - dns325 - Stefan Herbrechtsmeier <[email protected]> +Active arm arm926ejs kirkwood d-link dnskw dns325 dnskw:BOARD_IS_DNS325 Stefan Herbrechtsmeier <[email protected]> Active arm arm926ejs kirkwood iomega - iconnect - Luka Perkov <[email protected]> Active arm arm926ejs kirkwood karo tk71 tk71 - - Active arm arm926ejs kirkwood keymile km_arm km_kirkwood km_kirkwood:KM_KIRKWOOD Valentin Longchamp <[email protected]>
include/configs/dnskw.h renamed from include/configs/dns325.h +8 -3
@@ -10,16 +10,21 @@* SPDX-License-Identifier: GPL-2.0+ */ -#ifndef _CONFIG_DNS325_H -#define _CONFIG_DNS325_H +#ifndef _CONFIG_DNSKW_H +#define _CONFIG_DNSKW_H/* * Machine number definition */ +#ifdef CONFIG_BOARD_IS_DNS325 #define MACH_TYPE_DNS325 3800#define CONFIG_MACH_TYPE MACH_TYPE_DNS325#define CONFIG_IDENT_STRING "\nD-Link DNS-325" +#define CONFIG_SYS_KWD_CONFIG $(SRCTREE)/$(CONFIG_BOARDDIR)/kwbimage.dns325.cfg + +#endif /* CONFIG_BOARD_IS_DNS325 */ +/* * High Level Configuration Options (easy to change) */
@@ -167,4 +172,4 @@"fi;" \ "run setnandbootenv subbootcmd;" -#endif /* _CONFIG_DNS325_H */ +#endif /* _CONFIG_DNSKW_H */
Signature · 1 line
2.0.0.rc0
PATCH v2 2/4 kirkwood: Add support for the D-Link DNS-320
In reply to Bastien ROUCARIÈSFrom: Jamie Lentin <[email protected]>
Extend dnskw to support the D-Link DNS-320 ShareCenter NAS also. For more information on this NAS, see:-
http://jamie.lentin.co.uk/devices/dlink-dns320
http://dns323.kood.org/dns-320
http://sharecenter.dlink.com/products/DNS-320
Changes since last submission (V1):-
* Shorten CONFIG_IDENT_STRING [Prafulla Wadaskar]
--- board/d-link/dnskw/dnskw.c | 8 +- board/d-link/dnskw/dnskw.h | 6 + board/d-link/dnskw/kwbimage.dns320.cfg | 207 +++++++++++++++++++++++++++++++++ boards.cfg | 3 +- include/configs/dnskw.h | 10 ++ 5 files changed, 229 insertions(+), 5 deletions(-) create mode 100644 board/d-link/dnskw/kwbimage.dns320.cfg
board/d-link/dnskw/dnskw.c +4 -4
@@ -42,8 +42,8 @@ int board_early_init_f(void)MPP10_UART0_TXD ,MPP11_UART0_RXD ,MPP12_SD_CLK , -MPP13_SD_CMD , -MPP14_SD_D0 , +MPP13_UART1_TXD ,/* Custom ...*/ +MPP14_UART1_RXD ,/* ... controller */ MPP15_SD_D1 ,MPP16_SD_D2 , MPP17_SD_D3,
@@ -58,13 +58,13 @@ int board_early_init_f(void)MPP26_GPIO ,/* power led */ MPP27_GPIO ,/* sata0(right) error led */ MPP28_GPIO ,/* sata1(left) error led */ -MPP29_GPIO ,/* usb error led */ +MPP29_GPIO ,/* usb error led (dns-325) */ MPP30_GPIO ,MPP31_GPIO ,MPP32_GPIO ,MPP33_GPIO ,MPP34_GPIO ,/* power key */ -MPP35_GPIO , +MPP35_GPIO ,/* usb error led (dns-320) */ MPP36_GPIO ,MPP37_GPIO , MPP38_GPIO,
board/d-link/dnskw/dnskw.h +6 -0
@@ -27,6 +27,12 @@#define DNSKW_OE_VAL_HIGH 0x00000800/* disable leds */ #endif /* CONFIG_BOARD_IS_DNS325 */ +/* DNS-320 specific configuration */ +#ifdef CONFIG_BOARD_IS_DNS320 +#define DNSKW_OE_VAL_LOW 0x38000000/* disable leds */ +#define DNSKW_OE_VAL_HIGH 0x00000808/* disable leds */ +#endif /* CONFIG_BOARD_IS_DNS320 */ +/* PHY related */ #define MV88E1116_MAC_CTRL_REG 21#define MV88E1116_PGADR_REG 22
board/d-link/dnskw/kwbimage.dns320.cfg new file +207 -0
207 lines not on this page · raw message
boards.cfg +2 -1
@@ -168,7 +168,8 @@ Active arm arm926ejs davinci omicron calimain Active arm arm926ejs kirkwood buffalo lsxl lschlv2 lsxl:LSCHLV2 Michael Walle <[email protected]> Active arm arm926ejs kirkwood buffalo lsxl lsxhl lsxl:LSXHL Michael Walle <[email protected]> Active arm arm926ejs kirkwood cloudengines - pogo_e02 - Dave Purdy <[email protected]> -Active arm arm926ejs kirkwood d-link dnskw dns325 dnskw:BOARD_IS_DNS325 Stefan Herbrechtsmeier <[email protected]> +Active arm arm926ejs kirkwood d-link - dns320 - Jamie Lentin <[email protected]> +Active arm arm926ejs kirkwood d-link - dns325 - Stefan Herbrechtsmeier <[email protected]> Active arm arm926ejs kirkwood iomega - iconnect - Luka Perkov <[email protected]> Active arm arm926ejs kirkwood karo tk71 tk71 - - Active arm arm926ejs kirkwood keymile km_arm km_kirkwood km_kirkwood:KM_KIRKWOOD Valentin Longchamp <[email protected]>
include/configs/dnskw.h +10 -0
@@ -25,6 +25,16 @@#endif /* CONFIG_BOARD_IS_DNS325 */ +#ifdef CONFIG_BOARD_IS_DNS320 +#define MACH_TYPE_DNS320 3985 +#define CONFIG_MACH_TYPE MACH_TYPE_DNS320 +#define CONFIG_IDENT_STRING "\nDNS-320" + +#define CONFIG_SYS_KWD_CONFIG $(SRCTREE)/$(CONFIG_BOARDDIR)/kwbimage.dns320.cfg +#define CONFIG_SYS_TCLK 166666667/* 800Mhz */ + +#endif /* CONFIG_BOARD_IS_DNS320 */ +/* * High Level Configuration Options (easy to change) */
Signature · 1 line
2.0.0.rc0
PATCH 2/4 kirkwood: Add support for the D-Link DNS-320
Am 18.05.2014 18:21, schrieb Bastien ROUCARI?S:
boards.cfg Active arm arm926ejs davinci omicron calimain · line 172
Quoted 11 lines
boards.cfg +2
-1@@ -168,7 +168,8 @@ Active arm arm926ejs davinci omicron calimain Active arm arm926ejs kirkwood buffalo lsxl lschlv2 lsxl:LSCHLV2 Michael Walle <[email protected]> Active arm arm926ejs kirkwood buffalo lsxl lsxhl lsxl:LSXHL Michael Walle <[email protected]> Active arm arm926ejs kirkwood cloudengines - pogo_e02 - Dave Purdy <[email protected]> -Active arm arm926ejs kirkwood d-link dnskw dns325 dnskw:BOARD_IS_DNS325 Stefan Herbrechtsmeier <[email protected]> +Active arm arm926ejs kirkwood d-link - dns320 - Jamie Lentin <[email protected]> +Active arm arm926ejs kirkwood d-link - dns325 -
The "board name" (dnskw) and "options" (dnskw:BOARD_IS_DNS325 and dnskw:BOARD_IS_DNS320) is missing.
PATCH v2 3/4 kirkwood: Set unused SD pins back to GPIO for DNS-320 & DNS-325
In reply to Bastien ROUCARIÈSFrom: Jamie Lentin <[email protected]>
Neither device makes any use of the SD reader functionalty, so as suggested by Stefan Herbrechtsmeier, set the pins to GPIO instead to make this more obvious. Label MPP10 & MPP11's use whilst here.
--- board/d-link/dnskw/dnskw.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
board/d-link/dnskw/dnskw.c +6 -6
@@ -39,14 +39,14 @@ int board_early_init_f(void)MPP7_GPO ,MPP8_TW_SDA ,MPP9_TW_SCK , -MPP10_UART0_TXD , -MPP11_UART0_RXD , -MPP12_SD_CLK , +MPP10_UART0_TXD ,/* 5 pin ...*/ +MPP11_UART0_RXD ,/* ... console header */ +MPP12_GPO ,MPP13_UART1_TXD ,/* Custom ...*/ MPP14_UART1_RXD ,/* ... controller */ -MPP15_SD_D1 , -MPP16_SD_D2 , -MPP17_SD_D3 , +MPP15_GPIO , +MPP16_GPIO , +MPP17_GPIO ,MPP18_NF_IO0 ,MPP19_NF_IO1 , MPP20_SATA1_ACTn, /* sata1(left) status led */
Signature · 1 line
2.0.0.rc0
PATCH v2 4/4 kirkwood: Shorten DNS-325 IDENT_STRING to match DNS-320
In reply to Bastien ROUCARIÈSFrom: Jamie Lentin <[email protected]>
You should already know you're using a D-link device.
--- include/configs/dnskw.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/dnskw.h +1 -1
@@ -19,7 +19,7 @@#ifdef CONFIG_BOARD_IS_DNS325 #define MACH_TYPE_DNS325 3800#define CONFIG_MACH_TYPE MACH_TYPE_DNS325 -#define CONFIG_IDENT_STRING "\nD-Link DNS-325" +#define CONFIG_IDENT_STRING "\nDNS-325"#define CONFIG_SYS_KWD_CONFIG $(SRCTREE)/$(CONFIG_BOARDDIR)/kwbimage.dns325.cfg
Signature · 1 line
2.0.0.rc0
PATCH 4/4 kirkwood: Shorten DNS-325 IDENT_STRING to match DNS-320
Quoted 33 lines
-----Original Message-----
From: Bastien ROUCARI?S [mailto:roucaries.bastien at gmail.com]
Sent: 18 May 2014 21:51
To: u-boot at lists.denx.de
Cc: Jamie Lentin; Prafulla Wadaskar; Albert ARIBAUD; Stefan Herbrechtsmeier
Subject: [PATCH 4/4] kirkwood: Shorten DNS-325IDENT_STRINGto match DNS-320From: Jamie Lentin <[email protected]>
You should already know you're using a D-link device.
Signed-off-by Jamie Lentin <[email protected]>Cc: Prafulla Wadaskar <[email protected]>
Cc: Jamie Lentin <[email protected]>
Cc: Albert ARIBAUD <[email protected]>
Cc: Stefan Herbrechtsmeier <[email protected]>--- include/configs/dnskw.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/configs/dnskw.h +0
-0
include/configs/dnskw.h line 22
Quoted 5 lines
include/configs/dnskw.h +1
-1@@ -19,7 +19,7 @@#ifdef CONFIG_BOARD_IS_DNS325 #define MACH_TYPE_DNS325 3800#define CONFIG_MACH_TYPE MACH_TYPE_DNS325 -#define CONFIG_IDENT_STRING "\nD-Link DNS-325" +#define CONFIG_IDENT_STRING "\nDNS-325"
First of all thanks for preferring short names.
Since the file is renamed to dnskw, and there are two or more boards supported like 320 and 325,
Does above string makes sense? Or you should better name to some common name? like "DNSKW"?
I have ack for rest other patches in this series.
Regards...
Prafulla . . .
Quoted 6 lines
include/configs/dnskw.h +0
-1#define CONFIG_SYS_KWD_CONFIG $ (SRCTREE )/$ (CONFIG_BOARDDIR )/kwbimage.dns325.cfg --2.0.0.rc0
PATCH 4/4 kirkwood: Shorten DNS-325 IDENT_STRING to match DNS-320
Am 19.05.2014 11:21, schrieb Prafulla Wadaskar:
Quoted 38 lines
Quoted 31 lines
-----Original Message-----
From: Bastien ROUCARI?S [mailto:roucaries.bastien at gmail.com]
Sent: 18 May 2014 21:51
To: u-boot at lists.denx.de
Cc: Jamie Lentin; Prafulla Wadaskar; Albert ARIBAUD; Stefan Herbrechtsmeier
Subject: [PATCH 4/4] kirkwood: Shorten DNS-325IDENT_STRINGto match DNS-320From: Jamie Lentin <[email protected]>
You should already know you're using a D-link device.
Signed-off-by Jamie Lentin <[email protected]>Cc: Prafulla Wadaskar <[email protected]>
Cc: Jamie Lentin <[email protected]>
Cc: Albert ARIBAUD <[email protected]>
Cc: Stefan Herbrechtsmeier <[email protected]>--- include/configs/dnskw.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/configs/dnskw.h +0
-0include/configs/dnskw.h line 22
Quoted 5 lines
include/configs/dnskw.h +1
-1@@ -19,7 +19,7 @@#ifdef CONFIG_BOARD_IS_DNS325 #define MACH_TYPE_DNS325 3800#define CONFIG_MACH_TYPE MACH_TYPE_DNS325 -#define CONFIG_IDENT_STRING "\nD-Link DNS-325" +#define CONFIG_IDENT_STRING "\nDNS-325"First of all thanks for preferring short names.
Quoted 3 lines
Since the file is renamed to dnskw, and there are two or more boards supported like 320 and 325,
Does above string makes sense? Or you should better name to some common name? like "DNSKW"?
Because the u-boot.kwb is different for the boards I would prefer different names.