fix format mismatch in drivers/net/ethernet/intel/i40e/i40e_debugfs.c
Ursuly,
related to the usage of u8 versus int/unsigned I forward here an comment from Jeffrey:
-------- Original Message --------
Subject: RE: [E1000-devel] [PATCH] fix format mismatch in drivers/net/ethernet/intel/i40e/i40e_debugfs.c
Date: Tue, 20 May 2014 00:17:07 +0000
From: Nelson, Shannon <[email protected]>
To: Kirsher, Jeffrey T <[email protected]>, Toralf F�rster <[email protected]>
CC: Brandeburg, Jesse <[email protected]>, [email protected] <[email protected]>, [email protected] <[email protected]>
Quoted 22 lines
From: Kirsher, Jeffrey T
Quoted 6 lines · Toralf F�rster
spotted by cppcheck
Signed-off-by Toralf F�rster <[email protected]>--- drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)I will add your patch to my queue and will hold off on making my suggested change below until Shannon and Jesse have had time to review your patch.
Review
Quoted 2 lines
(quoted diff) +0
-0
b/drivers/net/ethernet/intel/i40e/i40e_debugfs.cdrivers/net/ethernet/intel/i40e/i40e_debugfs.c static ssize_t i40e_dbg_command_write(struct
Quoted 4 lines
index 3c37386..1bc35a2 100644
drivers/net/ethernet/intel/i40e/i40e_debugfs.c +0
-0@@ -1239,7 +1239,7 @@ static ssize_t i40e_dbg_command_write(structfile *filp,
Quoted 7 lines
drivers/net/ethernet/intel/i40e/i40e_debugfs.c static ssize_t i40e_dbg_command_write(struct · line 1242
Quoted 5 lines
drivers/net/ethernet/intel/i40e/i40e_debugfs.c +1
-1}else if (strncmp (cmd_buf,"add pvid" ,8 ) ==0 ) {i40e_status ret;u16 vid; -int v; +unsigned int v;Maybe u16 instead...
sscanf() can be a tricksie little beastie, and I'm more comfortable with giving it an int of some sort rather than a u16, otherwise this would have just used vid from the start. I can live with Toralf's suggestion.
sln
Quoted 15 lines
drivers/net/ethernet/intel/i40e/i40e_debugfs.c static ssize_t i40e_dbg_command_write(struct
Quoted 5 lines
drivers/net/ethernet/intel/i40e/i40e_debugfs.c +0
-0cnt =sscanf (&cmd_buf[8 ],"%i %u" , &vsi_seid, &v);if (cnt !=2 ) {@@ -1255,7 +1255,7 @@ static ssize_t i40e_dbg_command_write(structfile *filp,
Quoted 8 lines
drivers/net/ethernet/intel/i40e/i40e_debugfs.c +1
-1goto command_write_done; } - vid = (unsigned )v; + vid = v; ret =i40e_vsi_add_pvid (vsi, vid);if (!ret) dev_info(&pf->pdev->dev,