Skip to contentSkip to conversation

mpc85xx: configs: remove c=ffe from default environment

PATCH New Kim Phillips 3 participants 4 messages May 15, 2014 – May 20, 2014

lore
Share & tools
lore

Kim Phillips

author
#0 lore raw

PATCH 1/1 mpc85xx: configs: remove c=ffe from default environment

AFAICT, c=ffe does nothing and was a typo from the original commit d17123696c6180ac8b74fbd318bf14652623e982 "powerpc/p4080: Add support for the P4080DS board" and just kept on getting duplicated in subsequently added board config files.

Signed-off-by Kim Phillips <[email protected]>
---
 include/configs/B4860QDS.h   | 3 +--
 include/configs/P2041RDB.h   | 3 +--
 include/configs/T1040QDS.h   | 3 +--
 include/configs/T104xRDB.h   | 3 +--
 include/configs/T208xQDS.h   | 3 +--
 include/configs/T208xRDB.h   | 3 +--
 include/configs/T4240EMU.h   | 3 +--
 include/configs/T4240QDS.h   | 3 +--
 include/configs/corenet_ds.h | 3 +--
 9 files changed, 9 insertions(+), 18 deletions(-)
include/configs/B4860QDS.h +1 -2
index df371b7..70cda74 100644
@@ -824,8 +824,7 @@ unsigned long get_board_ddr_clk(void);
 	"ramdiskfile=b4860qds/ramdisk.uboot\0"			\
 	"fdtaddr=c00000\0"					\
 	"fdtfile=b4860qds/b4860qds.dtb\0"				\
-	"bdev=sda3\0"						\
-	"c=ffe\0"
+	"bdev=sda3\0"
 
 /* For emulation this causes u-boot to jump to the start of the proof point
    app code automatically */
include/configs/P2041RDB.h +1 -2
index 54e6493..e662322 100644
@@ -713,8 +713,7 @@ unsigned long get_board_sys_clk(unsigned long dummy);
 	"ramdiskfile=p2041rdb/ramdisk.uboot\0"			\
 	"fdtaddr=c00000\0"					\
 	"fdtfile=p2041rdb/p2041rdb.dtb\0"			\
-	"bdev=sda3\0"						\
-	"c=ffe\0"
+	"bdev=sda3\0"
 
 #define CONFIG_HDBOOT					\
 	"setenv bootargs root=/dev/$bdev rw "		\
include/configs/T1040QDS.h +1 -2
index 522653b..2215ac8 100644
@@ -767,8 +767,7 @@ unsigned long get_board_ddr_clk(void);
 	"ramdiskfile=t1040qds/ramdisk.uboot\0"			\
 	"fdtaddr=c00000\0"					\
 	"fdtfile=t1040qds/t1040qds.dtb\0"			\
-	"bdev=sda3\0"						\
-	"c=ffe\0"
+	"bdev=sda3\0"
 
 #define CONFIG_LINUX                       \
 	"setenv bootargs root=/dev/ram rw "            \
include/configs/T104xRDB.h +1 -2
index 81b4f31..e564cb7 100644
@@ -779,8 +779,7 @@
 	"ramdiskfile=" __stringify(RAMDISKFILE) "\0"		\
 	"fdtaddr=c00000\0"					\
 	"fdtfile=" __stringify(FDTFILE) "\0"			\
-	"bdev=sda3\0"						\
-	"c=ffe\0"
+	"bdev=sda3\0"
 
 #define CONFIG_LINUX                       \
 	"setenv bootargs root=/dev/ram rw "            \
include/configs/T208xQDS.h +1 -2
index 8bf0843..d2a9c6d 100644
@@ -837,8 +837,7 @@ unsigned long get_board_ddr_clk(void);
 	"ramdiskfile=t2080qds/ramdisk.uboot\0"			\
 	"fdtaddr=c00000\0"					\
 	"fdtfile=t2080qds/t2080qds.dtb\0"			\
-	"bdev=sda3\0"						\
-	"c=ffe\0"
+	"bdev=sda3\0"
 
 /*
  * For emulation this causes u-boot to jump to the start of the
include/configs/T208xRDB.h +1 -2
index 0be0a0f..081e391 100644
@@ -796,8 +796,7 @@ unsigned long get_board_ddr_clk(void);
 	"ramdiskfile=t2080rdb/ramdisk.uboot\0"			\
 	"fdtaddr=c00000\0"					\
 	"fdtfile=t2080rdb/t2080rdb.dtb\0"			\
-	"bdev=sda3\0"						\
-	"c=ffe\0"
+	"bdev=sda3\0"
 
 /*
  * For emulation this causes u-boot to jump to the start of the
include/configs/T4240EMU.h +1 -2
index ad5a9a6..53c69b0 100644
@@ -128,8 +128,7 @@
 	"ramdiskfile=t4240emu/ramdisk.uboot\0"			\
 	"fdtaddr=c00000\0"					\
 	"fdtfile=t4240emu/t4240emu.dtb\0"				\
-	"bdev=sda3\0"						\
-	"c=ffe\0"
+	"bdev=sda3\0"
 
 /*
  * For emulation this causes u-boot to jump to the start of the proof point
include/configs/T4240QDS.h +1 -2
index e4eb30f..5e4065a 100644
@@ -572,8 +572,7 @@ unsigned long get_board_ddr_clk(void);
 	"ramdiskfile=t4240qds/ramdisk.uboot\0"			\
 	"fdtaddr=c00000\0"					\
 	"fdtfile=t4240qds/t4240qds.dtb\0"				\
-	"bdev=sda3\0"						\
-	"c=ffe\0"
+	"bdev=sda3\0"
 
 #define CONFIG_HVBOOT				\
 	"setenv bootargs config-addr=0x60000000; "	\
include/configs/corenet_ds.h +1 -2
index db6b9be..e288755 100644
@@ -712,8 +712,7 @@
 	"ramdiskfile=p4080ds/ramdisk.uboot\0"			\
 	"fdtaddr=c00000\0"					\
 	"fdtfile=p4080ds/p4080ds.dtb\0"				\
-	"bdev=sda3\0"						\
-	"c=ffe\0"
+	"bdev=sda3\0"
 
 #define CONFIG_HDBOOT					\
 	"setenv bootargs root=/dev/$bdev rw "		\
Signature · 1 line
1.9.3
#1 lore raw

PATCH 1/1 mpc85xx: configs: remove c=ffe from default environment

Quoted 7 lines · Kim Phillips

AFAICT, c=ffe does nothing and was a typo from the original commit d17123696c6180ac8b74fbd318bf14652623e982 "powerpc/p4080: Add support for the P4080DS board" and just kept on getting duplicated in subsequently added board config files.

Signed-off-by Kim Phillips <[email protected]>

---

Thanks. I have been trying to get Kumar to respond but haven't heard from him. It does look odd. I think we can delete them.

York

#2 lore raw

PATCH 1/1 mpc85xx: configs: remove c=ffe from default environment

From: York Sun <[email protected]>

Quoted 8 lines · Kim Phillips
Quoted 4 lines

AFAICT, c=ffe does nothing and was a typo from the original commit d17123696c6180ac8b74fbd318bf14652623e982 "powerpc/p4080: Add support for the P4080DS board" and just kept on getting duplicated in subsequently added board config files.

Thanks. I have been trying to get Kumar to respond but haven't heard from him. It does look odd. I think we can delete them.

ACK. It was a convenience variable to access ccsrbar space from scripts, but should have been changed to "c=fe" on p4080 and subsequent soc's.

Ed

#3 lore raw

PATCH 1/1 mpc85xx: configs: remove c=ffe from default environment

In reply to Kim Phillips
Quoted 7 lines · Kim Phillips

AFAICT, c=ffe does nothing and was a typo from the original commit d17123696c6180ac8b74fbd318bf14652623e982 "powerpc/p4080: Add support for the P4080DS board" and just kept on getting duplicated in subsequently added board config files.

Signed-off-by Kim Phillips <[email protected]>

---

Applied to u-boot-mpc85xx/master.

York