Skip to contentSkip to conversation

cpufreq: intel_pstate: Remove unused member name of cpudata

PATCH In review Stratos Karafotis 3 participants 3 messages May 20, 2014 – May 21, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cpufreq: intel_pstate: Remove unused member name of cpudata

Although, a value is assigned to member name of struct cpudata, it is never used.

We can safely remove it.

---
 drivers/cpufreq/intel_pstate.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/cpufreq/intel_pstate.c +0 -4
index 24a534a..a6d5afa 100644
@@ -88,8 +88,6 @@ struct _pid {
 struct cpudata {
 	int cpu;
 
-	char name[64];
-
 	struct timer_list timer;
 
 	struct pstate_data pstate;
@@ -544,8 +542,6 @@ static inline void intel_pstate_pstate_decrease(struct cpudata *cpu, int steps)
 
 static void intel_pstate_get_cpu_pstates(struct cpudata *cpu)
 {
-	sprintf(cpu->name, "Intel 2nd generation core");
-
 	cpu->pstate.min_pstate = pstate_funcs.get_min();
 	cpu->pstate.max_pstate = pstate_funcs.get_max();
 	cpu->pstate.turbo_pstate = pstate_funcs.get_turbo();
Signature · 1 line
1.9.0
Acked-by on v1 1/1
#2 lore raw
In reply to Stratos Karafotis
Quoted 6 lines · Stratos Karafotis

Although, a value is assigned to member name of struct cpudata, it is never used.

We can safely remove it.

Quoted 27 lines
---
  drivers/cpufreq/intel_pstate.c | 4 ----
  1 file changed, 4 deletions(-)
drivers/cpufreq/intel_pstate.c +0 -4
index 24a534a..a6d5afa 100644
@@ -88,8 +88,6 @@ struct _pid {
  struct cpudata {
  	int cpu;
 
-	char name[64];
-
  	struct timer_list timer;
 
  	struct pstate_data pstate;
@@ -544,8 +542,6 @@ static inline void intel_pstate_pstate_decrease(struct cpudata *cpu, int steps)
 
  static void intel_pstate_get_cpu_pstates(struct cpudata *cpu)
  {
-	sprintf(cpu->name, "Intel 2nd generation core");
-
  	cpu->pstate.min_pstate = pstate_funcs.get_min();
  	cpu->pstate.max_pstate = pstate_funcs.get_max();
  	cpu->pstate.turbo_pstate = pstate_funcs.get_turbo();