Skip to contentSkip to conversation

arch: unicore32: kernel: ksyms: remove 'bswapsi2' and 'muldi3' to avoid compiling failure

PATCH In review Chen Gang 2 participants 2 messages May 21, 2014

lore
Share & tools
lore

Chen Gang

author
#0 lore raw

PATCH 1/1 arch: unicore32: kernel: ksyms: remove 'bswapsi2' and 'muldi3' to avoid compiling failure

After check the code, 'bswapsi2' and 'muldi3' are useless for unicore32, so can remove them to avoid compiling failure.

The related error (with allmodconfig under unicore32):

LD init/built-in.o
arch/unicore32/kernel/built-in.o:(___ksymtab+__muldi3+0x0): undefined reference to __muldi3' arch/unicore32/kernel/built-in.o:(___ksymtab+__bswapsi2+0x0): undefined reference to __bswapsi2'

---
 arch/unicore32/kernel/ksyms.c | 2 --
 arch/unicore32/kernel/ksyms.h | 2 --
 2 files changed, 4 deletions(-)
arch/unicore32/kernel/ksyms.c +0 -2
index bc06140..e78911a 100644
@@ -53,9 +53,7 @@ EXPORT_SYMBOL(__ashrdi3);
 EXPORT_SYMBOL(__divsi3);
 EXPORT_SYMBOL(__lshrdi3);
 EXPORT_SYMBOL(__modsi3);
-EXPORT_SYMBOL(__muldi3);
 EXPORT_SYMBOL(__ucmpdi2);
 EXPORT_SYMBOL(__udivsi3);
 EXPORT_SYMBOL(__umodsi3);
-EXPORT_SYMBOL(__bswapsi2);
 
arch/unicore32/kernel/ksyms.h +0 -2
index 185cdc7..31472ad 100644
@@ -8,8 +8,6 @@ extern void __ashrdi3(void);
 extern void __divsi3(void);
 extern void __lshrdi3(void);
 extern void __modsi3(void);
-extern void __muldi3(void);
 extern void __ucmpdi2(void);
 extern void __udivsi3(void);
 extern void __umodsi3(void);
-extern void __bswapsi2(void);
Signature · 1 line
1.9.2.459.g68773ac
Acked-by Xuetao Guan on v1 1/1
#1 lore raw

Thanks.

For __muldi3, it is no longer used by gcc, so I think that's ok. For __bswapsi2, maybe it's because I copied it from arm.

Quoted 45 lines · ----- Chen Gang

After check the code, 'bswapsi2' and 'muldi3' are useless for unicore32, so can remove them to avoid compiling failure.

The related error (with allmodconfig under unicore32):

LD init/built-in.o
arch/unicore32/kernel/built-in.o:(___ksymtab+__muldi3+0x0): undefined reference to __muldi3' arch/unicore32/kernel/built-in.o:(___ksymtab+__bswapsi2+0x0): undefined reference to __bswapsi2'

---
 arch/unicore32/kernel/ksyms.c | 2 --
 arch/unicore32/kernel/ksyms.h | 2 --
 2 files changed, 4 deletions(-)
arch/unicore32/kernel/ksyms.c +0 -2
index bc06140..e78911a 100644
@@ -53,9 +53,7 @@ EXPORT_SYMBOL(__ashrdi3);
 EXPORT_SYMBOL(__divsi3);
 EXPORT_SYMBOL(__lshrdi3);
 EXPORT_SYMBOL(__modsi3);
-EXPORT_SYMBOL(__muldi3);
 EXPORT_SYMBOL(__ucmpdi2);
 EXPORT_SYMBOL(__udivsi3);
 EXPORT_SYMBOL(__umodsi3);
-EXPORT_SYMBOL(__bswapsi2);
 
arch/unicore32/kernel/ksyms.h +0 -2
index 185cdc7..31472ad 100644
@@ -8,8 +8,6 @@ extern void __ashrdi3(void);
 extern void __divsi3(void);
 extern void __lshrdi3(void);
 extern void __modsi3(void);
-extern void __muldi3(void);
 extern void __ucmpdi2(void);
 extern void __udivsi3(void);
 extern void __umodsi3(void);
-extern void __bswapsi2(void);
Signature · 1 line
1.9.2.459.g68773ac