I found an errataum at drivers/base/dma-contiguous.c:294

RFC In review Gioh Kim 2 participants 3 messages May 22, 2014 Driver core

lore

Share & tools

lore

Gioh Kim

author

2014-05-22 01:37 UTC #0 lore raw

RFC 1/1 I found an errataum at drivers/base/dma-contiguous.c:294

This is not a big deal but I think get_dev_cma_area is errataum of dev_get_cma_area.

drivers/base/dma-contiguous.c +1 -1

index b056661..6343f25 100644
@@ -291,7 +291,7 @@ err:
  *
  * This function allocates memory buffer for specified device. It uses
  * device specific contiguous memory area if available or the default
- * global one. Requires architecture specific get_dev_cma_area() helper
+ * global one. Requires architecture specific dev_get_cma_area() helper
  * function.
  */
 struct page *dma_alloc_from_contiguous(struct device *dev, int count,

David Rientjes

2014-05-22 02:54 UTC #1 lore raw

Quoted 2 lines · Gioh Kim

This is not a big deal but I think get_dev_cma_area is errataum of dev_get_cma_area.

Looks good, but you may want to read Documentation/SubmittingPatches when proposing patches.

Gioh Kim

author

2014-05-22 04:40 UTC #2 lore raw

Thanks your advice.
I'll send a patch soon.

2014-05-22 오전 11:54, David Rientjes 쓴 글:

Quoted 8 lines · Gioh Kim

Quoted 3 lines
This is not a big deal but I think get_dev_cma_area is errataum of dev_get_cma_area.
Looks good, but you may want to read Documentation/SubmittingPatches when proposing patches.