fat: Define MAX_CLUSTSIZE only if not defined in config

PATCH New Siva Durga Prasad Paladugu 2 participants 2 messages May 26, 2014

Share & tools

Siva Durga Prasad Paladugu

author

2014-05-26 10:29 UTC #0 lore raw

PATCH v2 1/1 fat: Define MAX_CLUSTSIZE only if not defined in config

Define the MAX_CLUSTSIZE to default of 65536 only if CONFIG_FS_FAT_MAX_CLUSTSIZE is not defined in board specific config file.
Also please define your own MAX_CLUSTSIZE value if CONFIG_FS_FAT_MAX_CLUSTSIZE is defined.
This option has been provided to save memory in some memory constrained cases.

Signed-off-by Siva Durga Prasad Paladugu <[email protected]>

---

Changes in v2:
-Defined CONFIG_FS_FAT_MAX_CLUSTSIZE and documented as per review comment.

 README        |    7 +++++++
 include/fat.h |    2 ++
 2 files changed, 9 insertions(+), 0 deletions(-)

README +7 -0

index 5f89552..0d947cb 100644
@@ -1613,6 +1613,13 @@ CBFS (Coreboot Filesystem) support
 		filesystem. Available commands are cbfsinit, cbfsinfo, cbfsls
 		and cbfsload.
 
+- FAT(File Allocation Table) filesystem write/read buffer size:
+		CONFIG_FS_FAT_MAX_CLUSTSIZE
+
+		If this macro is not defined then the default MAX_CLUSTSIZE
+		is defined with 65536 else specify your own MAX_CLUSTSSIZE
+		value.
+
 - Keyboard Support:
 		CONFIG_ISA_KEYBOARD

include/fat.h +2 -0

index 81d9790..8b67851 100644
@@ -18,7 +18,9 @@
 #define VFAT_MAXSEQ		9   /* Up to 9 of 13 2-byte UTF-16 entries */
 #define PREFETCH_BLOCKS		2
 
+#ifndef CONFIG_FS_FAT_MAX_CLUSTSIZE
 #define MAX_CLUSTSIZE	65536
+#endif
 #define DIRENTSPERBLOCK	(mydata->sect_size / sizeof(dir_entry))
 #define DIRENTSPERCLUST	((mydata->clust_size * mydata->sect_size) / \
 			 sizeof(dir_entry))

Signature · 1 line

1.7.4

Michal Simek

2014-05-26 11:48 UTC #1 lore raw

PATCH v2 1/1 fat: Define MAX_CLUSTSIZE only if not defined in config

Quoted 43 lines · Siva Durga Prasad Paladugu

Define the MAX_CLUSTSIZE to default of 65536 only if CONFIG_FS_FAT_MAX_CLUSTSIZE is not defined in board specific config file.
Also please define your own MAX_CLUSTSIZE value if CONFIG_FS_FAT_MAX_CLUSTSIZE is defined.
This option has been provided to save memory in some memory constrained cases.
Signed-off-by Siva Durga Prasad Paladugu <[email protected]>
---
Changes in v2:
-Defined CONFIG_FS_FAT_MAX_CLUSTSIZE and documented as per review comment.
 README        |    7 +++++++
 include/fat.h |    2 ++
 2 files changed, 9 insertions(+), 0 deletions(-)
README +7 -0
index 5f89552..0d947cb 100644
@@ -1613,6 +1613,13 @@ CBFS (Coreboot Filesystem) support
 		filesystem. Available commands are cbfsinit, cbfsinfo, cbfsls
 		and cbfsload.
 
+- FAT(File Allocation Table) filesystem write/read buffer size:
+		CONFIG_FS_FAT_MAX_CLUSTSIZE
+
+		If this macro is not defined then the default MAX_CLUSTSIZE
+		is defined with 65536 else specify your own MAX_CLUSTSSIZE
+		value.
+
 - Keyboard Support:
 		CONFIG_ISA_KEYBOARD
 
include/fat.h +0 -0
index 81d9790..8b67851 100644

include/fat.h line 26

Quoted 9 lines

include/fat.h +2 -0

@@ -18,7 +18,9 @@
 #define VFAT_MAXSEQ		9   /* Up to 9 of 13 2-byte UTF-16 entries */
 #define PREFETCH_BLOCKS		2
 
+#ifndef CONFIG_FS_FAT_MAX_CLUSTSIZE
 #define MAX_CLUSTSIZE	65536
+#endif
 #define DIRENTSPERBLOCK	(mydata->sect_size / sizeof(dir_entry))
 #define DIRENTSPERCLUST	((mydata->clust_size * mydata->sect_size) / \
 			 sizeof(dir_entry))

CONFIG_FS_FAT_MAX_CLUSTSIZE is not used anywhere.

This should be the solution.

#ifndef CONFIG_FS_FAT_MAX_CLUSTSIZE
#define CONFIG_FS_FAT_MAX_CLUSTSIZE 65536
#endif

#define MAX_CLUSTSIZE CONFIG_FS_FAT_MAX_CLUSTSIZE

Please send v3.

Thanks,
Michal

Signature · 14 lines

Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140526/ef11a568/attachment.pgp>