Skip to contentSkip to conversation

ARM: mvebu: mark armada_370_xp_pmsu_idle_prepare() as static

PATCH New Thomas Petazzoni 3 participants 3 messages May 26, 2014 – Jun 20, 2014

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm/Marvell Kirkwood and Armada 370, 375, 38x, 39x, XP, 3700, 7K/8K, CN9130 SoC support
lore
Share & tools
lore

Thomas Petazzoni

author
#0 lore raw

PATCH 1/1 ARM: mvebu: mark armada_370_xp_pmsu_idle_prepare() as static

The armada_370_xp_pmsu_idle_prepare() function is only used internally to pmsu.c, so there's no reason to not use the static qualifier.

Signed-off-by Thomas Petazzoni <[email protected]>
---
 arch/arm/mach-mvebu/pmsu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-mvebu/pmsu.c +1 -1
index 53a55c8..6e83d32 100644
@@ -148,7 +148,7 @@ static void armada_370_xp_cpu_resume(void)
 }
 
 /* No locking is needed because we only access per-CPU registers */
-void armada_370_xp_pmsu_idle_prepare(bool deepidle)
+static void armada_370_xp_pmsu_idle_prepare(bool deepidle)
 {
 	unsigned int hw_cpu = cpu_logical_map(smp_processor_id());
 	u32 reg;
Signature · 1 line
1.9.3
#1 lore raw

PATCH 1/1 ARM: mvebu: mark armada_370_xp_pmsu_idle_prepare() as static

Quoted 2 lines · Thomas Petazzoni

The armada_370_xp_pmsu_idle_prepare() function is only used internally to pmsu.c, so there's no reason to not use the static qualifier.

Indeed, it was exported in the 1st version of the series, and then I forgot to make it static later.

Acked-by Gregory CLEMENT <[email protected]>

Thanks,

Gregory

Quoted 20 lines
Signed-off-by Thomas Petazzoni <[email protected]>
---
 arch/arm/mach-mvebu/pmsu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-mvebu/pmsu.c +1 -1
index 53a55c8..6e83d32 100644
@@ -148,7 +148,7 @@ static void armada_370_xp_cpu_resume(void)
 }
 
 /* No locking is needed because we only access per-CPU registers */
-void armada_370_xp_pmsu_idle_prepare(bool deepidle)
+static void armada_370_xp_pmsu_idle_prepare(bool deepidle)
 {
 	unsigned int hw_cpu = cpu_logical_map(smp_processor_id());
 	u32 reg;
Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
Applied
#2 lore raw

PATCH 1/1 ARM: mvebu: mark armada_370_xp_pmsu_idle_prepare() as static

In reply to Thomas Petazzoni
Quoted 7 lines · Thomas Petazzoni

The armada_370_xp_pmsu_idle_prepare() function is only used internally to pmsu.c, so there's no reason to not use the static qualifier.

Signed-off-by Thomas Petazzoni <[email protected]>
---
 arch/arm/mach-mvebu/pmsu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to mvebu/soc with Gregory's Ack.

thx,

Jason.