Skip to contentSkip to conversation

ARM64: Update support for FSL's LS2085A SoC

PATCH Superseded Bhupesh Sharma 7 participants 32 messages Sep 4, 2015 – Sep 10, 2015

Subsystems (6)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v2 cover ARM64: Update support for FSL's LS2085A SoC

This is the v2 of the patchset which updates the support for FSL's LS2085A SoC which is now being renamed to LS2080A (and is based on ARMv8 architecture).

Here is a description of what this patchset tries to achieve:

- Patch 1:
Freescale will be a churning out a host of ARMv8 based SoCs which will be based on a similar overall SoC architecture. So, this patch converts the existing infrastructure to use the generic convention ARCH_LAYERSCAPE. Also since Freescale is renaming LS2085A to LS2080A this patch fixes the same as well.

Further details of the LS2080a based platforms can be seen here:
http://www.freescale.com/products/arm-processors/qoriq-arm-processors/qoriq-ls2080a-40a-multicore-communications-processors:LS2080A?fsrch=1&sr=1&pageNum=1

- Patch 2:
Adds DTS binding documentation for Freescale's LS2080A QDS and RDB boards

- Patch 3:
This patch adds bindings for QIXIS FPGA controller found on FSL boards.

- Patch 4:
Updates PCIe devicetree binding documentation for LS2080A.

- Patch 5:
Updates clk-qoriq bindings for FSL's chassis-3.0 SoCs

- Patch 6:
Addresses changes required in clk-qoriq driver to handle little-endian clockgen SoCs like LS2080A.

- Patch 7:
Updates the support of various peripherals (PMU, Watchdog, SMMU, SATA, PCI, SPI, etc.) present on FSL LS2080a SoC in the SoC DTSI.

- Patch 8:
Updates the DTS LS2085a simulator platform to reflect the new peripherals added in the DTSI.

- Patch 9:
Adds new DTS files for LS2085a based QDS and RDB boards.

- Patch 10:
Adds build support for LS2085a QDS and RDB board DTS files.

Rebasing details:
-----------------
- Rebased against arm-soc git tree, branch: next/dt

- Rebased against Scott's latest v2 of QorIQ clk fixes, which can be viewed here:
https://patchwork.kernel.org/patch/7020471/
https://patchwork.kernel.org/patch/7020541/
https://patchwork.kernel.org/patch/7020491/
https://patchwork.kernel.org/patch/7020481/
https://patchwork.kernel.org/patch/7020501/

Changes since v1:
----------------
(v1 can be viewed here: http://lists.infradead.org/pipermail/linux-arm-kernel/2015-April/334990.html)

- Addressed Mark's comments regarding the FTM alarm timer node. Removed the node for now as the FTM binding change related discussion is underway with the maintainers.
- Added support for Layerscape family of SoCs and changed name of LS2085a chip to LS2080a chip.
- Updated QorIQ clk driver to support LS2080a like SoCs.
- Added support for SATA nodes in the DTSI.
- Added binding document for on-board QIXIS FPGA controllers.

Note:
-----
I get a checkpatch warning for the amba-bus compatible string being missing from Documentation/devicetree/bindings/ . I am not aware if some patch is already being worked on, to solve the same:

	compatible = "arm,amba-bus";

If not, I can try to send a patch, with the re-spin of this patchset.

Bhupesh Sharma (9):
arm64: Use generic Layerscape SoC family naming & rename LS2085A to

    LS2080A
  Documentation: DT: Add entry for FSL LS2080A QDS and RDB boards
  Documentation/dts: Add bindings for QIXIS FPGA controller found on
    FSL boards
  doc/bindings: Update PCIe devicetree binding documentation for
    LS2080A

doc/bindings: Update clk-qoriq bindings for FSL's chassis-3.0 SoCs dts/ls2085a: Update DTSI to add support of various peripherals dts/ls2085a: Update Simulator DTS to add support of various
peripherals
dts/ls2080a: Add DTS support for LS2080a QDS & RDB boards dts/Makefile: Add build support for LS2080a QDS & RDB board DTS

Scott Wood (1):
clk: qoriq: Add ls2080a support.

 .../devicetree/bindings/arm/fsl,board.txt          |   31 +
 Documentation/devicetree/bindings/arm/fsl.txt      |   16 +-
 .../devicetree/bindings/clock/qoriq-clock.txt      |   16 +-
 .../devicetree/bindings/pci/layerscape-pci.txt     |    3 +-
 arch/arm64/Kconfig                                 |    6 +-
 arch/arm64/boot/dts/freescale/Makefile             |    2 +-
 arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts  |  198 +++++++
 .../{fsl-ls2085a-simu.dts => fsl-ls2080a-rdb.dts}  |  126 +++-
 .../{fsl-ls2085a-simu.dts => fsl-ls2080a-simu.dts} |   64 +-
 arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi     |  612 ++++++++++++++++++++
 arch/arm64/boot/dts/freescale/fsl-ls2085a.dtsi     |  163 ------
 arch/arm64/configs/defconfig                       |    2 +-
 drivers/clk/Kconfig                                |    2 +-
 drivers/clk/clk-qoriq.c                            |   78 ++-
 14 files changed, 1107 insertions(+), 212 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/arm/fsl,board.txt
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts
 copy arch/arm64/boot/dts/freescale/{fsl-ls2085a-simu.dts => fsl-ls2080a-rdb.dts} (52%)
 rename arch/arm64/boot/dts/freescale/{fsl-ls2085a-simu.dts => fsl-ls2080a-simu.dts} (76%)
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
 delete mode 100644 arch/arm64/boot/dts/freescale/fsl-ls2085a.dtsi
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v2 1/10 arm64: Use generic Layerscape SoC family naming & rename LS2085A to LS2080A

Freescale will be a churning out a host of ARMv8 based SoCs which will be based on a similar overall SoC architecture. So, this patch converts the existing infrastructure in the arm64/dts, arm64/Kconfig and arm64/configs to use the generic convention ARCH_LAYERSCAPE in place of the more specific FSL_LS2085A, to save code duplication later-on.

Also Freescale is renaming LS2085A to LS2080A.

This patch addresses the above two points.

---
 Documentation/devicetree/bindings/arm/fsl.txt      |    8 ++++----
 arch/arm64/Kconfig                                 |    6 +++---
 arch/arm64/boot/dts/freescale/Makefile             |    2 +-
 .../{fsl-ls2085a-simu.dts => fsl-ls2080a-simu.dts} |   10 +++++-----
 .../{fsl-ls2085a.dtsi => fsl-ls2080a.dtsi}         |    6 +++---
 arch/arm64/configs/defconfig                       |    2 +-
 6 files changed, 17 insertions(+), 17 deletions(-)
 rename arch/arm64/boot/dts/freescale/{fsl-ls2085a-simu.dts => fsl-ls2080a-simu.dts} (90%)
 rename arch/arm64/boot/dts/freescale/{fsl-ls2085a.dtsi => fsl-ls2080a.dtsi} (97%)
Documentation/devicetree/bindings/arm/fsl.txt +4 -4
index 2a3ba73..53f229a 100644
@@ -128,10 +128,10 @@ Example:
 		reg = <0x0 0x1ee0000 0x0 0x10000>;
 	};
 
-Freescale LS2085A SoC Device Tree Bindings
-------------------------------------------
+Freescale ARMv8 based Layerscape SoC family Device Tree Bindings
+----------------------------------------------------------------
 
-LS2085A ARMv8 based Simulator model
+LS2080A ARMv8 based Simulator model
 Required root node properties:
-    - compatible = "fsl,ls2085a-simu", "fsl,ls2085a";
+    - compatible = "fsl,ls2080a-simu", "fsl,ls2080a";
 
arch/arm64/Kconfig +3 -3
index 318175f..65b335b 100644
@@ -179,10 +179,10 @@ config ARCH_EXYNOS7
 	help
 	  This enables support for Samsung Exynos7 SoC family
 
-config ARCH_FSL_LS2085A
-	bool "Freescale LS2085A SOC"
+config ARCH_LAYERSCAPE
+	bool "ARMv8 based Freescale Layerscape SoC family"
 	help
-	  This enables support for Freescale LS2085A SOC.
+	  This enables support for Freescale Layerscape SoC family.
 
 config ARCH_HISI
 	bool "Hisilicon SoC Family"
arch/arm64/boot/dts/freescale/Makefile +1 -1
index 4f2de3e7..932001a 100644
@@ -1,4 +1,4 @@
-dtb-$(CONFIG_ARCH_FSL_LS2085A) += fsl-ls2085a-simu.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-simu.dtb
  
 always		:= $(dtb-y)
 subdir-y	:= $(dts-dirs)
arch/arm64/boot/dts/freescale/fsl-ls2080a-simu.dts renamed from arch/arm64/boot/dts/freescale/fsl-ls2085a-simu.dts +5 -5
similarity index 90%
rename from arch/arm64/boot/dts/freescale/fsl-ls2085a-simu.dts
rename to arch/arm64/boot/dts/freescale/fsl-ls2080a-simu.dts
index 82e2a6f..cf45d38 100644
@@ -1,7 +1,7 @@
 /*
- * Device Tree file for Freescale LS2085a software Simulator model
+ * Device Tree file for Freescale LS2080a software Simulator model
  *
- * Copyright (C) 2014, Freescale Semiconductor
+ * Copyright (C) 2014-15, Freescale Semiconductor
  *
  * Bhupesh Sharma <[email protected]>
  *
@@ -51,11 +51,11 @@
 
 /dts-v1/;
 
-/include/ "fsl-ls2085a.dtsi"
+/include/ "fsl-ls2080a.dtsi"
 
 / {
-	model = "Freescale Layerscape 2085a software Simulator model";
-	compatible = "fsl,ls2085a-simu", "fsl,ls2085a";
+	model = "Freescale Layerscape 2080a software Simulator model";
+	compatible = "fsl,ls2080a-simu", "fsl,ls2080a";
 
 	ethernet at 2210000 {
 		compatible = "smsc,lan91c111";
arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi renamed from arch/arm64/boot/dts/freescale/fsl-ls2085a.dtsi +3 -3
similarity index 97%
rename from arch/arm64/boot/dts/freescale/fsl-ls2085a.dtsi
rename to arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
index e281ceb..333d942 100644
@@ -1,7 +1,7 @@
 /*
- * Device Tree Include file for Freescale Layerscape-2085A family SoC.
+ * Device Tree Include file for Freescale Layerscape-2080A family SoC.
  *
- * Copyright (C) 2014, Freescale Semiconductor
+ * Copyright (C) 2014-15, Freescale Semiconductor
  *
  * Bhupesh Sharma <[email protected]>
  *
@@ -50,7 +50,7 @@
  */
 
 / {
-	compatible = "fsl,ls2085a";
+	compatible = "fsl,ls2080a";
 	interrupt-parent = <&gic>;
 	#address-cells = <2>;
 	#size-cells = <2>;
arch/arm64/configs/defconfig +1 -1
index 4e17e7e..fa6aa9f 100644
@@ -32,7 +32,7 @@ CONFIG_MODULE_UNLOAD=y
 # CONFIG_BLK_DEV_BSG is not set
 # CONFIG_IOSCHED_DEADLINE is not set
 CONFIG_ARCH_EXYNOS7=y
-CONFIG_ARCH_FSL_LS2085A=y
+CONFIG_ARCH_LAYERSCAPE=y
 CONFIG_ARCH_HISI=y
 CONFIG_ARCH_MEDIATEK=y
 CONFIG_ARCH_SEATTLE=y
Signature · 1 line
1.7.9.5
#2 lore raw

PATCH v2 1/10 arm64: Use generic Layerscape SoC family naming & rename LS2085A to LS2080A

Quoted 7 lines · Bhupesh Sharma

Freescale will be a churning out a host of ARMv8 based SoCs which will be based on a similar overall SoC architecture. So, this patch converts the existing infrastructure in the arm64/dts, arm64/Kconfig and arm64/configs to use the generic convention ARCH_LAYERSCAPE in place of the more specific FSL_LS2085A, to save code duplication later-on.

Quoted 6 lines

Also Freescale is renaming LS2085A to LS2080A.

This patch addresses the above two points.

---

{snip}

arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi line 4

Quoted 9 lines
arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi renamed from arch/arm64/boot/dts/freescale/fsl-ls2085a.dtsi +2 -2
@@ -1,7 +1,7 @@
 /*
- * Device Tree Include file for Freescale Layerscape-2085A family SoC.
+ * Device Tree Include file for Freescale Layerscape-2080A family SoC.
  *
- * Copyright (C) 2014, Freescale Semiconductor
+ * Copyright (C) 2014-15, Freescale Semiconductor

Normally we spell out the whole 2015. The preferred copyright template is:

Copyright 2014-2015 Freescale Semiconductor, Inc.

- Leo

#3 lore raw

PATCH v2 1/10 arm64: Use generic Layerscape SoC family naming & rename LS2085A to LS2080A

Quoted 31 lines

From: pku.leo at gmail.com [mailto:pku.leo at gmail.com]
Sent: Friday, September 04, 2015 10:01 PM

Quoted 7 lines · Bhupesh Sharma

Freescale will be a churning out a host of ARMv8 based SoCs which will be based on a similar overall SoC architecture. So, this patch converts the existing infrastructure in the arm64/dts, arm64/Kconfig and arm64/configs to use the generic convention ARCH_LAYERSCAPE in place of the more specific FSL_LS2085A, to save code duplication later-on.

Quoted 6 lines

Also Freescale is renaming LS2085A to LS2080A.

This patch addresses the above two points.

---

{snip}

arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi line 4

Quoted 9 lines
arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi renamed from arch/arm64/boot/dts/freescale/fsl-ls2085a.dtsi +2 -2
@@ -1,7 +1,7 @@
 /*
- * Device Tree Include file for Freescale Layerscape-2085A family SoC.
+ * Device Tree Include file for Freescale Layerscape-2080A family SoC.
  *
- * Copyright (C) 2014, Freescale Semiconductor
+ * Copyright (C) 2014-15, Freescale Semiconductor

Normally we spell out the whole 2015. The preferred copyright template is:

Quoted 2 lines

Copyright 2014-2015 Freescale Semiconductor, Inc.

Ok.

Regards,
Bhupesh

#4 lore raw

PATCH v2 1/10 arm64: Use generic Layerscape SoC family naming & rename LS2085A to LS2080A

In reply to Bhupesh Sharma
Quoted 10 lines · Bhupesh Sharma

Freescale will be a churning out a host of ARMv8 based SoCs which will be based on a similar overall SoC architecture. So, this patch converts the existing infrastructure in the arm64/dts, arm64/Kconfig and arm64/configs to use the generic convention ARCH_LAYERSCAPE in place of the more specific FSL_LS2085A, to save code duplication later-on.

Also Freescale is renaming LS2085A to LS2080A.

This patch addresses the above two points.

Suggest splitting this into 2 patches because these 2 changes are really orthogonal-- one patch for the ARCH config name change, one for the rename ls2085a to ls2080a rename.

Not sure why you're describing it as "churning out a host of ARMv8 based SoCs". Just get to the point-- Layerscape is an SoC family so we're changing from the SoC specific ARCH kconfig option to a more general SoC family option.

Thanks,
Stuart

#5 lore raw

PATCH v2 1/10 arm64: Use generic Layerscape SoC family naming & rename LS2085A to LS2080A

Quoted 11 lines

From: Stuart Yoder [mailto:b08248 at gmail.com]
Sent: Wednesday, September 09, 2015 1:55 AM

Quoted 7 lines · Bhupesh Sharma

Freescale will be a churning out a host of ARMv8 based SoCs which will be based on a similar overall SoC architecture. So, this patch converts the existing infrastructure in the arm64/dts, arm64/Kconfig and arm64/configs to use the generic convention ARCH_LAYERSCAPE in place of the more specific FSL_LS2085A, to save code duplication later-on.

Quoted 7 lines
Quoted 3 lines

Also Freescale is renaming LS2085A to LS2080A.

This patch addresses the above two points.

Suggest splitting this into 2 patches because these 2 changes are really orthogonal-- one patch for the ARCH config name change, one for the rename ls2085a to ls2080a rename.

I was seeing the compilation breaking up at patch level if I did so. Will try to see if this can be achieved without breaking up the compilation for individual patches in v3.

Quoted 5 lines

Not sure why you're describing it as "churning out a host of ARMv8 based SoCs".
Just get to the point-- Layerscape is an SoC family so we're changing from the SoC specific ARCH kconfig option to a more general SoC family option.

The prologue is to describe that other ARMv8 SoCs with similar architecture will be put-out, which will be part of the overall Layerscape family.

Regards,
Bhupesh

#6 lore raw

PATCH v2 2/10 Documentation: DT: Add entry for FSL LS2080A QDS and RDB boards

In reply to Bhupesh Sharma

This patch adds a devicetree binding documentation for Freescale's LS2080A QDS and RDB boards.

---
 Documentation/devicetree/bindings/arm/fsl.txt |    8 ++++++++
 1 file changed, 8 insertions(+)
Documentation/devicetree/bindings/arm/fsl.txt +8 -0
index 53f229a..34c88b0 100644
@@ -135,3 +135,11 @@ LS2080A ARMv8 based Simulator model
 Required root node properties:
     - compatible = "fsl,ls2080a-simu", "fsl,ls2080a";
 
+LS2080A ARMv8 based QDS Board
+Required root node properties:
+    - compatible = "fsl,ls2080a-qds", "fsl,ls2080a";
+
+LS2080A ARMv8 based RDB Board
+Required root node properties:
+    - compatible = "fsl,ls2080a-rdb", "fsl,ls2080a";
+
Signature · 1 line
1.7.9.5
#7 lore raw

PATCH v2 3/10 Documentation/dts: Add bindings for QIXIS FPGA controller found on FSL boards

In reply to Bhupesh Sharma

This patch adds bindings for QIXIS FPGA controller found on FSL boards.

Some Freescale boards like LS2080AQDS/LS2080ARDB have an on-board FPGA/CPLD connected to the IFC controller. The bindings specified in this patch cater to those on-board FPGA/CPLD controllers.

---
 .../devicetree/bindings/arm/fsl,board.txt          |   31 ++++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/fsl,board.txt
Documentation/devicetree/bindings/arm/fsl,board.txt new file +31 -0
new file mode 100644
index 0000000..756b730
@@ -0,0 +1,31 @@
+Freescale Reference Board Bindings
+----------------------------------
+
+This document describes device tree bindings for various devices that
+exist on some Freescale reference boards.
+
+* Freescale on-board FPGA connected to IFC controller
+
+Some Freescale boards like LS2080AQDS/LS2080ARDB have an on-board FPGA/CPLD
+connected to the IFC controller.
+
+Required properties:
+- compatible: Should be a board-specific string followed by a string
+  indicating the type of FPGA.  Example:
+       "fsl,ls2080a-qds-qixis", "fsl,fpga-qixis"
+       "fsl,ls2080a-rdb-qixis", "fsl,fpga-qixis"
+- reg: The register set for the device
+
+Example:
+       &ifc {
+               status = "okay";
+               #address-cells = <2>;
+               #size-cells <1>;
+               ranges = <0x3 0x0 0x5 0x20000000 0x00010000>;
+
+               cpld at 3,0 {
+                       compatible = "fsl,ls2080a-qds-qixis", "fsl,fpga-qixis";
+                       reg = <0x3 0 0x10000>;
+               };
+       };
+
Signature · 1 line
1.7.9.5
#8 lore raw

PATCH v2 3/10 Documentation/dts: Add bindings for QIXIS FPGA controller found on FSL boards

Quoted 1 line · Bhupesh Sharma

This patch adds bindings for QIXIS FPGA controller found on FSL boards.

A general comment: when you are updating the device tree bindings. You should cc the devicetree at vger.kernel.org mailing list.

Quoted 4 lines

Some Freescale boards like LS2080AQDS/LS2080ARDB have an on-board FPGA/CPLD connected to the IFC controller. The bindings specified in this patch cater to those on-board FPGA/CPLD controllers.

We already have the binding defined in Documentation/devicetree/bindings/powerpc/fsl/board.txt. We probably should just move it to a more generic location.

Regards,
Leo

#9 lore raw

PATCH v2 3/10 Documentation/dts: Add bindings for QIXIS FPGA controller found on FSL boards

Quoted 10 lines

From: pku.leo at gmail.com [mailto:pku.leo at gmail.com]
Sent: Friday, September 04, 2015 10:27 PM

Quoted 1 line · Bhupesh Sharma

This patch adds bindings for QIXIS FPGA controller found on FSL boards.

A general comment: when you are updating the device tree bindings. You should cc the devicetree at vger.kernel.org mailing list.

Quoted 1 line
Quoted 7 lines
Quoted 3 lines

Some Freescale boards like LS2080AQDS/LS2080ARDB have an on-board FPGA/CPLD connected to the IFC controller. The bindings specified in this patch cater to those on-board FPGA/CPLD controllers.

We already have the binding defined in Documentation/devicetree/bindings/powerpc/fsl/board.txt. We probably should just move it to a more generic location.

Consolidation of powerpc and ARM bindings is something that needs to be targeted by a separate patch-series, perhaps in future.

There are a number of duplications that can be looked into, but I don't think this patchset should depend on that.

Regards,
Bhupesh

#10 lore raw

PATCH v2 3/10 Documentation/dts: Add bindings for QIXIS FPGA controller found on FSL boards

Quoted 18 lines · Sharma Bhupesh
Quoted 10 lines

From: pku.leo at gmail.com [mailto:pku.leo at gmail.com]
Sent: Friday, September 04, 2015 10:27 PM

Quoted 1 line · Bhupesh Sharma

This patch adds bindings for QIXIS FPGA controller found on FSL boards.

A general comment: when you are updating the device tree bindings. You should cc the devicetree at vger.kernel.org mailing list.

Quoted 1 line
Quoted 7 lines
Quoted 3 lines

Some Freescale boards like LS2080AQDS/LS2080ARDB have an on-board FPGA/CPLD connected to the IFC controller. The bindings specified in this patch cater to those on-board FPGA/CPLD controllers.

We already have the binding defined in Documentation/devicetree/bindings/powerpc/fsl/board.txt. We probably should just move it to a more generic location.

Quoted 5 lines

Consolidation of powerpc and ARM bindings is something that needs to be targeted by a separate patch-series, perhaps in future.

There are a number of duplications that can be looked into, but I don't think this patchset should depend on that.

There might be some duplication, but we shouldn't be adding more. :) I would rather you directly updating that file than creating a new file even though the original one was in a wrong directory.

Regards,
Leo

#11 lore raw

PATCH v2 3/10 Documentation/dts: Add bindings for QIXIS FPGA controller found on FSL boards

Quoted 25 lines

From: pku.leo at gmail.com [mailto:pku.leo at gmail.com]
Sent: Saturday, September 05, 2015 2:43 AM

Quoted 4 lines · Sharma Bhupesh
Quoted 4 lines

From: pku.leo at gmail.com [mailto:pku.leo at gmail.com]
Sent: Friday, September 04, 2015 10:27 PM On Fri, Sep 4, 2015 at 1:57

Quoted 1 line · Bhupesh Sharma

This patch adds bindings for QIXIS FPGA controller found on FSL

boards.

Quoted 16 lines
Quoted 5 lines

A general comment: when you are updating the device tree bindings. You should cc the devicetree at vger.kernel.org mailing list.

Quoted 1 line
Quoted 7 lines
Quoted 3 lines

Some Freescale boards like LS2080AQDS/LS2080ARDB have an on-board FPGA/CPLD connected to the IFC controller. The bindings specified in this patch cater to those on-board FPGA/CPLD controllers.

We already have the binding defined in Documentation/devicetree/bindings/powerpc/fsl/board.txt. We probably should just move it to a more generic location.

Consolidation of powerpc and ARM bindings is something that needs to be targeted by a separate patch-series, perhaps in future.

Quoted 7 lines
Quoted 2 lines

There are a number of duplications that can be looked into, but I don't think this patchset should depend on that.

There might be some duplication, but we shouldn't be adding more. :) I would rather you directly updating that file than creating a new file even though the original one was in a wrong directory.

IMO a PowerPC binding update makes no sense in a ARM machine patchset sent on a arm specific mailing list.

I would like to wait to hear what maintainers have to say on the same.

Regards,
Bhupesh

#12 lore raw

PATCH v2 3/10 Documentation/dts: Add bindings for QIXIS FPGA controller found on FSL boards

Quoted 28 lines · Sharma Bhupesh
Quoted 28 lines

From: pku.leo at gmail.com [mailto:pku.leo at gmail.com]
Sent: Saturday, September 05, 2015 2:43 AM

Quoted 4 lines · Sharma Bhupesh
Quoted 4 lines

From: pku.leo at gmail.com [mailto:pku.leo at gmail.com]
Sent: Friday, September 04, 2015 10:27 PM On Fri, Sep 4, 2015 at 1:57

Quoted 1 line · Bhupesh Sharma

This patch adds bindings for QIXIS FPGA controller found on FSL

boards.

Quoted 18 lines
Quoted 5 lines

A general comment: when you are updating the device tree bindings. You should cc the devicetree at vger.kernel.org mailing list.

Quoted 1 line
Quoted 7 lines
Quoted 3 lines

Some Freescale boards like LS2080AQDS/LS2080ARDB have an on-board FPGA/CPLD connected to the IFC controller. The bindings specified in this patch cater to those on-board FPGA/CPLD controllers.

We already have the binding defined in Documentation/devicetree/bindings/powerpc/fsl/board.txt. We probably should just move it to a more generic location.

Consolidation of powerpc and ARM bindings is something that needs to be targeted by a separate patch-series, perhaps in future.

There are a number of duplications that can be looked into, but I don't think this patchset should depend on that.

Quoted 7 lines
Quoted 4 lines

There might be some duplication, but we shouldn't be adding more. :) I would rather you directly updating that file than creating a new file even though the original one was in a wrong directory.

IMO a PowerPC binding update makes no sense in a ARM machine patchset sent on a arm specific mailing list.

So the best approach is to merge the change with the original binding and put it into a common place. Although there were a lot of non-arch specific bindings placed into the arch folder, we should stop adding more now.

Regards,
Leo

#13 lore raw

PATCH v2 4/10 doc/bindings: Update PCIe devicetree binding documentation for LS2080A

In reply to Bhupesh Sharma

Add the documentation for compatible string "fsl,ls2080a-pcie" for Freescale's LS2080A platform.

---
 .../devicetree/bindings/pci/layerscape-pci.txt     |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/pci/layerscape-pci.txt +2 -1
index 6286f04..e72e68f 100644
@@ -4,7 +4,8 @@ This PCIe host controller is based on the Synopsis Designware PCIe IP
 and thus inherits all the common properties defined in designware-pcie.txt.
 
 Required properties:
-- compatible: should contain the platform identifier such as "fsl,ls1021a-pcie"
+- compatible: should contain the platform identifier such as "fsl,ls1021a-pcie",
+  "fsl,ls2080a-pcie".
 - reg: base addresses and lengths of the PCIe controller
 - interrupts: A list of interrupt outputs of the controller. Must contain an
   entry for each entry in the interrupt-names property.
Signature · 1 line
1.7.9.5
#14 lore raw

PATCH v2 4/10 doc/bindings: Update PCIe devicetree binding documentation for LS2080A

Quoted 14 lines · Bhupesh Sharma

Add the documentation for compatible string "fsl,ls2080a-pcie" for Freescale's LS2080A platform.

---
 .../devicetree/bindings/pci/layerscape-pci.txt     |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/pci/layerscape-pci.txt +0 -0
index 6286f04..e72e68f 100644

Documentation/devicetree/bindings/pci/layerscape-pci.txt This PCIe host controller is based on the Synopsis Designware PCIe IP · line 8

Quoted 6 lines
Documentation/devicetree/bindings/pci/layerscape-pci.txt +2 -1
@@ -4,7 +4,8 @@ This PCIe host controller is based on the Synopsis Designware PCIe IP
 and thus inherits all the common properties defined in designware-pcie.txt.
 
 Required properties:
-- compatible: should contain the platform identifier such as "fsl,ls1021a-pcie"
+- compatible: should contain the platform identifier such as "fsl,ls1021a-pcie",
+  "fsl,ls2080a-pcie".

Make it generic like "fsl,<chip>-pcie"

- Leo

#15 lore raw

PATCH v2 4/10 doc/bindings: Update PCIe devicetree binding documentation for LS2080A

Quoted 22 lines

From: Leo Li [mailto:pku.leo at gmail.com]
Sent: Friday, September 04, 2015 11:27 PM

Quoted 15 lines · Bhupesh Sharma

Add the documentation for compatible string "fsl,ls2080a-pcie" for Freescale's LS2080A platform.

---
 .../devicetree/bindings/pci/layerscape-pci.txt     |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/pci/layerscape-pci.txt +0 -0
index 6286f04..e72e68f 100644
@@ -4,7 +4,8 @@ This PCIe host controller is based on the Synopsis
Quoted 1 line

Designware PCIe IP and thus inherits all the common properties defined

in designware-pcie.txt.

Quoted 1 line
Quoted 8 lines
Quoted 2 lines

Required properties:
-- compatible: should contain the platform identifier such as

"fsl,ls1021a-pcie"

Quoted 3 lines

+- compatible: should contain the platform identifier such as +"fsl,ls1021a-pcie",
+ "fsl,ls2080a-pcie".

Make it generic like "fsl,<chip>-pcie"

Minghuan, if you don't have an objection, I would like to address Leo's suggestion in v3 of this series as I think it is a valid one.

Please share your views.

Regards,
Bhupesh

#16 lore raw

PATCH v2 4/10 doc/bindings: Update PCIe devicetree binding documentation for LS2080A

Hi Bhupesh

I agree with Leo whose suggestion is a better.

Thanks,
Minghuan

Quoted 52 lines

-----Original Message-----
From: Sharma Bhupesh-B45370
Sent: Saturday, September 05, 2015 4:20 AM
To: Leo Li <[email protected]>; Lian Minghuan-B31939 <[email protected]>
Cc: Arnd Bergmann <[email protected]>; Mark Rutland <[email protected]>; linux-arm-kernel at lists.infradead.org; marc.zyngier at arm.com; linux-clk at vger.kernel.org; Catalin.Marinas at arm.com; will.deacon at arm.com; olof at lixom.net; Bhupesh SHARMA <[email protected]>; devicetree at vger.kernel.org
Subject: RE: [PATCH v2 04/10] doc/bindings: Update PCIe devicetree binding documentation for LS2080A

Quoted 23 lines

From: Leo Li [mailto:pku.leo at gmail.com]
Sent: Friday, September 04, 2015 11:27 PM On Fri, Sep 4, 2015 at 1:57

Quoted 16 lines · Bhupesh Sharma

Add the documentation for compatible string "fsl,ls2080a-pcie" for Freescale's LS2080A platform.

---
 .../devicetree/bindings/pci/layerscape-pci.txt     |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt b/Documentation/devicetree/bindings/pci/layerscape-pci.txt index 6286f04..e72e68f 100644

Documentation/devicetree/bindings/pci/layerscape-pci.txt +0 -0
@@ -4,7 +4,8 @@ This PCIe host controller is based on the Synopsis
Quoted 2 lines

Designware PCIe IP and thus inherits all the common properties defined

in designware-pcie.txt.

Quoted 1 line
Quoted 8 lines
Quoted 2 lines

Required properties:
-- compatible: should contain the platform identifier such as

"fsl,ls1021a-pcie"

Quoted 3 lines

+- compatible: should contain the platform identifier such as +"fsl,ls1021a-pcie",
+ "fsl,ls2080a-pcie".

Make it generic like "fsl,<chip>-pcie"

Minghuan, if you don't have an objection, I would like to address Leo's suggestion in v3 of this series as I think it is a valid one.

Please share your views.

Regards,
Bhupesh

#17 lore raw

PATCH v2 4/10 doc/bindings: Update PCIe devicetree binding documentation for LS2080A

Quoted 5 lines

From: Lian Minghuan-B31939
Sent: Sunday, September 06, 2015 7:56 AM
Hi Bhupesh

I agree with Leo whose suggestion is a better.

Ok, thanks.

I will make this change in v3 patchset then.

Regards,
Bhupesh

Quoted 41 lines
Quoted 41 lines

From: Sharma Bhupesh-B45370
Sent: Saturday, September 05, 2015 4:20 AM

Quoted 23 lines

From: Leo Li [mailto:pku.leo at gmail.com]
Sent: Friday, September 04, 2015 11:27 PM On Fri, Sep 4, 2015 at

Quoted 16 lines · Bhupesh Sharma

Add the documentation for compatible string "fsl,ls2080a-pcie" for Freescale's LS2080A platform.

---
 .../devicetree/bindings/pci/layerscape-pci.txt     |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt b/Documentation/devicetree/bindings/pci/layerscape-pci.txt index 6286f04..e72e68f 100644

Documentation/devicetree/bindings/pci/layerscape-pci.txt +0 -0
@@ -4,7 +4,8 @@ This PCIe host controller is based on the Synopsis
Quoted 2 lines

Designware PCIe IP and thus inherits all the common properties defined

in designware-pcie.txt.

Quoted 1 line
Quoted 8 lines
Quoted 2 lines

Required properties:
-- compatible: should contain the platform identifier such as

"fsl,ls1021a-pcie"

Quoted 3 lines

+- compatible: should contain the platform identifier such as +"fsl,ls1021a-pcie",
+ "fsl,ls2080a-pcie".

Make it generic like "fsl,<chip>-pcie"

Minghuan, if you don't have an objection, I would like to address Leo's suggestion in v3 of this series as I think it is a valid one.

Please share your views.

Regards,
Bhupesh

#18 lore raw

PATCH v2 4/10 doc/bindings: Update PCIe devicetree binding documentation for LS2080A

In reply to Bhupesh Sharma

Documentation/devicetree/bindings/pci/layerscape-pci.txt This PCIe host controller is based on the Synopsis Designware PCIe IP · line 11

Quoted 11 lines · On Friday 04 September 2015 12:27:46 Bhupesh Sharma wrote:
Documentation/devicetree/bindings/pci/layerscape-pci.txt +2 -1
@@ -4,7 +4,8 @@ This PCIe host controller is based on the Synopsis Designware PCIe IP
 and thus inherits all the common properties defined in designware-pcie.txt.
 
 Required properties:
-- compatible: should contain the platform identifier such as "fsl,ls1021a-pcie"
+- compatible: should contain the platform identifier such as "fsl,ls1021a-pcie",
+  "fsl,ls2080a-pcie".
 - reg: base addresses and lengths of the PCIe controller
 - interrupts: A list of interrupt outputs of the controller. Must contain an
   entry for each entry in the interrupt-names property.

Are the two PCIe hosts mutually compatible? If they are, you should mandate one of the strings as the base model for identification, with the additional model being optional for identification of the specific SoC.

It would also be good to add a string with the specific version number of the designware PCIe block that is being used there.

Arnd

#19 lore raw

PATCH v2 4/10 doc/bindings: Update PCIe devicetree binding documentation for LS2080A

Quoted 4 lines · Arnd Bergmann
Quoted 3 lines · On Friday 04 September 2015 12:27:46 Bhupesh Sharma wrote:
Documentation/devicetree/bindings/pci/layerscape-pci.txt +0 -0
@@ -4,7 +4,8 @@ This PCIe host controller is based on the Synopsis Designware PCIe IP
 and thus inherits all the common properties defined in designware-pcie.txt.
 
Quoted 12 lines

Documentation/devicetree/bindings/pci/layerscape-pci.txt This PCIe host controller is based on the Synopsis Designware PCIe IP · line 11

Quoted 8 lines
Documentation/devicetree/bindings/pci/layerscape-pci.txt +2 -1
 Required properties:
-- compatible: should contain the platform identifier such as "fsl,ls1021a-pcie"
+- compatible: should contain the platform identifier such as "fsl,ls1021a-pcie",
+  "fsl,ls2080a-pcie".
 - reg: base addresses and lengths of the PCIe controller
 - interrupts: A list of interrupt outputs of the controller. Must contain an
   entry for each entry in the interrupt-names property.

Are the two PCIe hosts mutually compatible? If they are, you should mandate one of the strings as the base model for identification, with the additional model being optional for identification of the specific SoC.

It seems that controllers on these chips are not exactly the same. They will get different driver data by matching the compatible strings. Probably we could define a more generic compatible string, such as "fsl,layerscape-pcie" or "fsl,ls-pcie".

Quoted 3 lines

It would also be good to add a string with the specific version number of the designware PCIe block that is being used there.

The binding has mentioned to reference the designware-pcie.txt. But it might be more clear to mention the designware compatible string "snps,dw-pcie" again in the compatible part. Currently there is no version number defined in the designware-pcie binding. It might be hard to get this information for some SoCs.

Regards,
Leo

#20 lore raw

PATCH v2 4/10 doc/bindings: Update PCIe devicetree binding documentation for LS2080A

Quoted 23 lines

From: pku.leo at gmail.com [mailto:pku.leo at gmail.com]
Sent: Wednesday, September 09, 2015 1:36 AM

Quoted 3 lines · Arnd Bergmann
Quoted 2 lines · On Friday 04 September 2015 12:27:46 Bhupesh Sharma wrote:
(quoted diff) +0 -0
@@ -4,7 +4,8 @@ This PCIe host controller is based on the Synopsis

Designware PCIe IP and thus inherits all the common properties

defined in designware-pcie.txt.

Quoted 3 lines
Quoted 3 lines

Required properties:
-- compatible: should contain the platform identifier such as

"fsl,ls1021a-pcie"

Quoted 5 lines
Quoted 5 lines

+- compatible: should contain the platform identifier such as +"fsl,ls1021a-pcie",
+ "fsl,ls2080a-pcie".
- reg: base addresses and lengths of the PCIe controller
- interrupts: A list of interrupt outputs of the controller. Must

contain an

Quoted 6 lines
Quoted 2 lines

entry for each entry in the interrupt-names property.

Are the two PCIe hosts mutually compatible? If they are, you should mandate one of the strings as the base model for identification, with the additional model being optional for identification of the specific

Quoted 6 lines

SoC.

It seems that controllers on these chips are not exactly the same. They will get different driver data by matching the compatible strings. Probably we could define a more generic compatible string, such as "fsl,layerscape-pcie" or "fsl,ls-pcie".

Yes, Minghaun captured the differences in the two versions in the v1 review discussion for the DTS here:
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-April/338343.html

Regards,
Bhupesh

#21 lore raw

PATCH v2 4/10 doc/bindings: Update PCIe devicetree binding documentation for LS2080A

In reply to Li Yang
Quoted 24 lines · On Tuesday 08 September 2015 15:06:16 Li Yang wrote:
Quoted 4 lines · Arnd Bergmann
Quoted 3 lines · On Friday 04 September 2015 12:27:46 Bhupesh Sharma wrote:
Documentation/devicetree/bindings/pci/layerscape-pci.txt +0 -0
@@ -4,7 +4,8 @@ This PCIe host controller is based on the Synopsis Designware PCIe IP
 and thus inherits all the common properties defined in designware-pcie.txt.
 
Quoted 12 lines

Documentation/devicetree/bindings/pci/layerscape-pci.txt This PCIe host controller is based on the Synopsis Designware PCIe IP · line 11

Quoted 8 lines
Documentation/devicetree/bindings/pci/layerscape-pci.txt +2 -1
 Required properties:
-- compatible: should contain the platform identifier such as "fsl,ls1021a-pcie"
+- compatible: should contain the platform identifier such as "fsl,ls1021a-pcie",
+  "fsl,ls2080a-pcie".
 - reg: base addresses and lengths of the PCIe controller
 - interrupts: A list of interrupt outputs of the controller. Must contain an
   entry for each entry in the interrupt-names property.

Are the two PCIe hosts mutually compatible? If they are, you should mandate one of the strings as the base model for identification, with the additional model being optional for identification of the specific SoC.

It seems that controllers on these chips are not exactly the same. They will get different driver data by matching the compatible strings. Probably we could define a more generic compatible string, such as "fsl,layerscape-pcie" or "fsl,ls-pcie".

Quoted 1 line
Quoted 8 lines
Quoted 2 lines

It would also be good to add a string with the specific version number of the designware PCIe block that is being used there.

The binding has mentioned to reference the designware-pcie.txt. But it might be more clear to mention the designware compatible string "snps,dw-pcie" again in the compatible part. Currently there is no version number defined in the designware-pcie binding. It might be hard to get this information for some SoCs.

For most of them, the information is available and then it should be added. Obviously if you can't find it out, it's hard to guess and you have to leave it out for that particular chip.

A lot of devices also have some internal version register that you can read out.

Arnd

#22 lore raw

PATCH v2 4/10 doc/bindings: Update PCIe devicetree binding documentation for LS2080A

Quoted 34 lines · Arnd Bergmann
Quoted 24 lines · On Tuesday 08 September 2015 15:06:16 Li Yang wrote:
Quoted 4 lines · Arnd Bergmann
Quoted 3 lines · On Friday 04 September 2015 12:27:46 Bhupesh Sharma wrote:
Documentation/devicetree/bindings/pci/layerscape-pci.txt +0 -0
@@ -4,7 +4,8 @@ This PCIe host controller is based on the Synopsis Designware PCIe IP
 and thus inherits all the common properties defined in designware-pcie.txt.
 
Quoted 12 lines

Documentation/devicetree/bindings/pci/layerscape-pci.txt This PCIe host controller is based on the Synopsis Designware PCIe IP · line 11

Quoted 8 lines
Documentation/devicetree/bindings/pci/layerscape-pci.txt +2 -1
 Required properties:
-- compatible: should contain the platform identifier such as "fsl,ls1021a-pcie"
+- compatible: should contain the platform identifier such as "fsl,ls1021a-pcie",
+  "fsl,ls2080a-pcie".
 - reg: base addresses and lengths of the PCIe controller
 - interrupts: A list of interrupt outputs of the controller. Must contain an
   entry for each entry in the interrupt-names property.

Are the two PCIe hosts mutually compatible? If they are, you should mandate one of the strings as the base model for identification, with the additional model being optional for identification of the specific SoC.

It seems that controllers on these chips are not exactly the same. They will get different driver data by matching the compatible strings. Probably we could define a more generic compatible string, such as "fsl,layerscape-pcie" or "fsl,ls-pcie".

Quoted 1 line
Quoted 8 lines
Quoted 2 lines

It would also be good to add a string with the specific version number of the designware PCIe block that is being used there.

The binding has mentioned to reference the designware-pcie.txt. But it might be more clear to mention the designware compatible string "snps,dw-pcie" again in the compatible part. Currently there is no version number defined in the designware-pcie binding. It might be hard to get this information for some SoCs.

Quoted 3 lines

For most of them, the information is available and then it should be added. Obviously if you can't find it out, it's hard to guess and you have to leave it out for that particular chip.

Actually I don't know any approach to get the version number of the designware block used. Maybe they are actually using the same version of the IP block, and the differences in the driver are actually caused by the differences in SoC integration.

Quoted 3 lines

A lot of devices also have some internal version register that you can read out.

There doesn't seem to be this kind of register for the PCIe block.

Minghuan,

Please correct me if you know more. :)

Regards,
Leo

#23 lore raw

PATCH v2 4/10 doc/bindings: Update PCIe devicetree binding documentation for LS2080A

Hi Leo and Bergmann,

Please see my comments inline.

Quoted 63 lines

-----Original Message-----
From: pku.leo at gmail.com [mailto:pku.leo at gmail.com] On Behalf Of Li Yang
Sent: Thursday, September 10, 2015 7:50 AM
To: Arnd Bergmann <[email protected]>
Cc: linux-arm-kernel at lists.infradead.org; devicetree at vger.kernel.org; Mark Rutland <[email protected]>; Sharma Bhupesh-B45370 <[email protected]>; Catalin.Marinas at arm.com;
olof at lixom.net; will.deacon at arm.com; Lian Minghuan-B31939 <[email protected]>; marc.zyngier at arm.com; Bhupesh SHARMA <[email protected]>; linux-clk at vger.kernel.org
Subject: Re: [PATCH v2 04/10] doc/bindings: Update PCIe devicetree binding documentation for LS2080A

Quoted 5 lines · Arnd Bergmann
Quoted 4 lines · On Tuesday 08 September 2015 15:06:16 Li Yang wrote:
Quoted 3 lines · Arnd Bergmann
Quoted 2 lines · On Friday 04 September 2015 12:27:46 Bhupesh Sharma wrote:
(quoted diff) +0 -0
@@ -4,7 +4,8 @@ This PCIe host controller is based on the Synopsis

Designware PCIe IP and thus inherits all the common properties

defined in designware-pcie.txt.

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

Required properties:
-- compatible: should contain the platform identifier such as

"fsl,ls1021a-pcie"

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

+- compatible: should contain the platform identifier such as +"fsl,ls1021a-pcie",
+ "fsl,ls2080a-pcie".
- reg: base addresses and lengths of the PCIe controller
- interrupts: A list of interrupt outputs of the controller. Must contain

an

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines

entry for each entry in the interrupt-names property.

Are the two PCIe hosts mutually compatible? If they are, you should mandate one of the strings as the base model for identification, with the additional model being optional for identification of the specific

SoC.

Quoted 16 lines
Quoted 7 lines

It seems that controllers on these chips are not exactly the same. They will get different driver data by matching the compatible strings. Probably we could define a more generic compatible string, such as "fsl,layerscape-pcie" or "fsl,ls-pcie".

Quoted 1 line
Quoted 8 lines
Quoted 2 lines

It would also be good to add a string with the specific version number of the designware PCIe block that is being used there.

The binding has mentioned to reference the designware-pcie.txt. But it might be more clear to mention the designware compatible string "snps,dw-pcie" again in the compatible part. Currently there is no version number defined in the designware-pcie binding. It might be hard to get this information for some SoCs.

Quoted 3 lines

For most of them, the information is available and then it should be added. Obviously if you can't find it out, it's hard to guess and you have to leave it out for that particular chip.

Actually I don't know any approach to get the version number of the designware block used. Maybe they are actually using the same version of the IP block, and the differences in the driver are actually caused by the differences in SoC integration.

Quoted 1 line
Quoted 5 lines
Quoted 2 lines

A lot of devices also have some internal version register that you can read out.

There doesn't seem to be this kind of register for the PCIe block.

[Lian Minghuan-B31939] Yes. There is no register to show PCIe block version according to reference manual. I agree that differences in the driver are caused by the differences in SoC integration.

Quoted 6 lines

Minghuan,

Please correct me if you know more. :)

Regards,
Leo

#24 lore raw

PATCH v2 5/10 doc/bindings: Update clk-qoriq bindings for FSL's chassis-3.0 SoCs

In reply to Bhupesh Sharma

This patch updates the 'clk-qoriq' device-tree bindings for chassis-3.0 compliant SoCs from FSL, for e.g. LS2080A

---
 .../devicetree/bindings/clock/qoriq-clock.txt      |   16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/clock/qoriq-clock.txt +12 -4
index 16a3ec4..f0a4b1c 100644
@@ -14,6 +14,7 @@ Chassis Version		Example Chips
 ---------------		-------------
 1.0			p4080, p5020, p5040
 2.0			t4240, b4860
+3.0			ls2080a
 
 1. Clock Block Binding
 
@@ -32,9 +33,11 @@ Required properties:
 	* "fsl,b4420-clockgen"
 	* "fsl,b4860-clockgen"
 	* "fsl,ls1021a-clockgen"
-	Chassis-version clock strings include:
+	* "fsl,ls2080a-clockgen"
+	Chassis clock strings include:
 	* "fsl,qoriq-clockgen-1.0": for chassis 1.0 clocks
 	* "fsl,qoriq-clockgen-2.0": for chassis 2.0 clocks
+	* "fsl,qoriq-clockgen-3.0": for chassis 3.0 clocks
 - reg: Describes the address of the device's resources within the
 	address space defined by its parent bus, and resource zero
 	represents the clock register set
@@ -96,18 +99,23 @@ Required properties:
 - compatible : Should include one of the following:
 	* "fsl,qoriq-core-pll-1.0" for core PLL clocks (v1.0)
 	* "fsl,qoriq-core-pll-2.0" for core PLL clocks (v2.0)
+	* "fsl,qoriq-core-pll-3.0" for core PLL clocks (v3.0)
 	* "fsl,qoriq-core-mux-1.0" for core mux clocks (v1.0)
 	* "fsl,qoriq-core-mux-2.0" for core mux clocks (v2.0)
+	* "fsl,qoriq-core-mux-3.0" for core mux clocks (v3.0)
 	* "fsl,qoriq-sysclk-1.0": for input system clock (v1.0).
 		It takes parent's clock-frequency as its clock.
 	* "fsl,qoriq-sysclk-2.0": for input system clock (v2.0).
 		It takes parent's clock-frequency as its clock.
+	* "fsl,qoriq-sysclk-3.0": for input system clock (v3.0).
+		It takes parent's clock-frequency as its clock.
 	* "fsl,qoriq-platform-pll-1.0" for the platform PLL clock (v1.0)
 	* "fsl,qoriq-platform-pll-2.0" for the platform PLL clock (v2.0)
+	* "fsl,qoriq-platform-pll-3.0" for the platform PLL clock (v3.0)
 - #clock-cells: From common clock binding. The number of cells in a
-	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0"
-	clocks, or <1> for "fsl,qoriq-core-pll-[1,2].0" clocks.
-	For "fsl,qoriq-core-pll-[1,2].0" clocks, the single
+	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2,3].0"
+	clocks, or <1> for "fsl,qoriq-core-pll-[1,2,3].0" clocks.
+	For "fsl,qoriq-core-pll-[1,2,3].0" clocks, the single
 	clock-specifier cell may take the following values:
 	* 0 - equal to the PLL frequency
 	* 1 - equal to the PLL frequency divided by 2
Signature · 1 line
1.7.9.5
#25 lore raw

PATCH v2 5/10 doc/bindings: Update clk-qoriq bindings for FSL's chassis-3.0 SoCs

Quoted 7 lines · Bhupesh Sharma

This patch updates the 'clk-qoriq' device-tree bindings for chassis-3.0 compliant SoCs from FSL, for e.g. LS2080A

---
 .../devicetree/bindings/clock/qoriq-clock.txt      |   16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

Why didn't you CC me on this?

Quoted 14 lines
Documentation/devicetree/bindings/clock/qoriq-clock.txt +1 -0
index 16a3ec4..f0a4b1c 100644
@@ -14,6 +14,7 @@ Chassis Version             Example Chips
 ---------------              -------------
 1.0                  p4080, p5020, p5040
 2.0                  t4240, b4860
+3.0                  ls2080a
 
 1. Clock Block Binding
 

Documentation/devicetree/bindings/clock/qoriq-clock.txt Required properties: · line 36

Quoted 5 lines
Documentation/devicetree/bindings/clock/qoriq-clock.txt +1 -1
@@ -32,9 +33,11 @@ Required properties:
      * "fsl,b4420-clockgen"
      * "fsl,b4860-clockgen"
      * "fsl,ls1021a-clockgen"
-     Chassis-version clock strings include:
+     * "fsl,ls2080a-clockgen"

We don't need to update this for every new chip. It says "such as".

Documentation/devicetree/bindings/clock/qoriq-clock.txt Required properties: · line 40

Quoted 4 lines
Documentation/devicetree/bindings/clock/qoriq-clock.txt +2 -0
+     Chassis clock strings include:
      * "fsl,qoriq-clockgen-1.0": for chassis 1.0 clocks
      * "fsl,qoriq-clockgen-2.0": for chassis 2.0 clocks
+     * "fsl,qoriq-clockgen-3.0": for chassis 3.0 clocks

With the new binding I don't see value in the generic version compatible.

Quoted 10 lines
Documentation/devicetree/bindings/clock/qoriq-clock.txt +1 -0
 - reg: Describes the address of the device's resources within the
      address space defined by its parent bus, and resource zero
      represents the clock register set
@@ -96,18 +99,23 @@ Required properties:
 - compatible : Should include one of the following:
      * "fsl,qoriq-core-pll-1.0" for core PLL clocks (v1.0)
      * "fsl,qoriq-core-pll-2.0" for core PLL clocks (v2.0)
+     * "fsl,qoriq-core-pll-3.0" for core PLL clocks (v3.0)
      * "fsl,qoriq-core-mux-1.0" for core mux clocks (v1.0)
      * "fsl,qoriq-core-mux-2.0" for core mux clocks (v2.0)

Documentation/devicetree/bindings/clock/qoriq-clock.txt Required properties: · line 114

Quoted 10 lines
Documentation/devicetree/bindings/clock/qoriq-clock.txt +4 -0
+     * "fsl,qoriq-core-mux-3.0" for core mux clocks (v3.0)
      * "fsl,qoriq-sysclk-1.0": for input system clock (v1.0).
              It takes parent's clock-frequency as its clock.
      * "fsl,qoriq-sysclk-2.0": for input system clock (v2.0).
              It takes parent's clock-frequency as its clock.
+     * "fsl,qoriq-sysclk-3.0": for input system clock (v3.0).
+             It takes parent's clock-frequency as its clock.
      * "fsl,qoriq-platform-pll-1.0" for the platform PLL clock (v1.0)
      * "fsl,qoriq-platform-pll-2.0" for the platform PLL clock (v2.0)
+     * "fsl,qoriq-platform-pll-3.0" for the platform PLL clock (v3.0)

No new legacy compatibles please.

-Scott

#26 lore raw

PATCH v2 6/10 clk: qoriq: Add ls2080a support.

In reply to Bhupesh Sharma

From: Scott Wood <[email protected]>

LS2080A is the first implementation of the chassis 3 clockgen, which has a different register layout than previous chips. It is also little endian, unlike previous chips.

---
 drivers/clk/Kconfig     |    2 +-
 drivers/clk/clk-qoriq.c |   78 +++++++++++++++++++++++++++++++++++++++++------
 2 files changed, 70 insertions(+), 10 deletions(-)
drivers/clk/Kconfig +1 -1
index 42f7120..9f1970c 100644
@@ -121,7 +121,7 @@ config COMMON_CLK_AXI_CLKGEN
 
 config CLK_QORIQ
 	bool "Clock driver for Freescale QorIQ platforms"
-	depends on (PPC_E500MC || ARM) && OF
+	depends on (PPC_E500MC || ARM || ARM64) && OF
 	---help---
 	  This adds the clock driver support for Freescale QorIQ platforms
 	  using common clock framework.
drivers/clk/clk-qoriq.c +69 -9

141 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#27 lore raw

PATCH v2 6/10 clk: qoriq: Add ls2080a support.

Quoted 8 lines · Bhupesh Sharma

From: Scott Wood <[email protected]>

LS2080A is the first implementation of the chassis 3 clockgen, which has a different register layout than previous chips. It is also little endian, unlike previous chips.

---

You should probably mention here that the patch is depending on another pending patch to apply. And this patch should be going through the same sub-system tree as the dependency patch. Otherwise, there is no way it can be applied.

Regards,
Leo

#28 lore raw

PATCH v2 6/10 clk: qoriq: Add ls2080a support.

Quoted 10 lines

From: pku.leo at gmail.com [mailto:pku.leo at gmail.com]
Sent: Saturday, September 05, 2015 1:32 AM

Quoted 6 lines · Bhupesh Sharma

From: Scott Wood <[email protected]>

LS2080A is the first implementation of the chassis 3 clockgen, which has a different register layout than previous chips. It is also little endian, unlike previous chips.

Quoted 8 lines
Quoted 2 lines

---

You should probably mention here that the patch is depending on another pending patch to apply. And this patch should be going through the same sub-system tree as the dependency patch. Otherwise, there is no way it can be applied.

Cover-letter already captures this:
http://www.spinics.net/lists/arm-kernel/msg442910.html

See the section 'Rebasing details'. linux-clk is already copied.

Regards,
Bhupesh

#29 lore raw

PATCH v2 6/10 clk: qoriq: Add ls2080a support.

Quoted 19 lines · Sharma Bhupesh
Quoted 10 lines

From: pku.leo at gmail.com [mailto:pku.leo at gmail.com]
Sent: Saturday, September 05, 2015 1:32 AM

Quoted 6 lines · Bhupesh Sharma

From: Scott Wood <[email protected]>

LS2080A is the first implementation of the chassis 3 clockgen, which has a different register layout than previous chips. It is also little endian, unlike previous chips.

Quoted 8 lines
Quoted 2 lines

---

You should probably mention here that the patch is depending on another pending patch to apply. And this patch should be going through the same sub-system tree as the dependency patch. Otherwise, there is no way it can be applied.

Quoted 4 lines

Cover-letter already captures this:
http://www.spinics.net/lists/arm-kernel/msg442910.html

See the section 'Rebasing details'. linux-clk is already copied.

But not all the patches are depending on the clk patches. You should probably break up the series to patches that can be applied cleanly and patches that are depending on the clock patches and should go through the clk tree.

Regards,
Leo

#30 lore raw

PATCH v2 6/10 clk: qoriq: Add ls2080a support.

Quoted 24 lines · Li Yang
Quoted 22 lines · Sharma Bhupesh
Quoted 10 lines

From: pku.leo at gmail.com[mailto:pku.leo at gmail.com]
Sent: Saturday, September 05, 2015 1:32 AM

Quoted 6 lines · Bhupesh Sharma

From: Scott Wood <[email protected]>

LS2080A is the first implementation of the chassis 3 clockgen, which has a different register layout than previous chips. It is also little endian, unlike previous chips.

Quoted 8 lines
Quoted 2 lines

---

You should probably mention here that the patch is depending on another pending patch to apply. And this patch should be going through the same sub-system tree as the dependency patch. Otherwise, there is no way it can be applied.

Cover-letter already captures this:
http://www.spinics.net/lists/arm-kernel/msg442910.html

Quoted 6 lines
Quoted 1 line

See the section 'Rebasing details'. linux-clk is already copied.

But not all the patches are depending on the clk patches. You should probably break up the series to patches that can be applied cleanly and patches that are depending on the clock patches and should go through the clk tree.

The clock patches have already been acked, so they don't necessarily need to go via the clock tree. However, there are both ARM and PPC patches that depend on them, so maybe we should create a topic branch?

-Scott

#31 lore raw

PATCH v2 6/10 clk: qoriq: Add ls2080a support.

In reply to Bhupesh Sharma
Quoted 8 lines · Bhupesh Sharma

From: Scott Wood <[email protected]>

LS2080A is the first implementation of the chassis 3 clockgen, which has a different register layout than previous chips. It is also little endian, unlike previous chips.

---

You should add your own signoff when passing on someone else's patch.

FWIW, I'm likely to squash this with my previous clk-qoriq patches when I resubmit.

-Scott