Skip to contentSkip to conversation

MSI Digivox Trio, should I try to hire someone to patch for this device?

PATCH In review P. van Gaans 2 participants 3 messages May 27, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

http://linuxtv.org/wiki/index.php/MSI_DigiVox_Trio

If you're having a deja-vu, yeah, it's still me. I'm still using this device using my butt-ugly patch by adding:

{ USB_DEVICE(0xeb1a, 0x2885), /* MSI Digivox Trio */

            .driver_info = EM2884_BOARD_TERRATEC_H5 },

to linux/drivers/media/usb/em28xx/em28xx-cards.c.

It's starting to bug me more and more that I can never update my kernel (well not without hassle anyway). I've written this to the mailinglist before, but with no response.

I just don't have the skill to write this in the neat way it needs to be to be able to go upstream. Should I try to hire someone to do that? If so, any suggestions? Just put an ad up on craigslist or something? Does such a patch have a chance of going upstream? (as that's the whole point - I want to update my kernel again)

It should be really straightforward given that no reverse engineering or anything is needed. It's just what it states above - pretend the Digivox is an H5 and it's done.

Anyone who can tune in on this, please share your thoughts.

Best regards,

P. van Gaans

#1 lore raw

PATCH 1/1 em28xx: add MSI Digivox Trio support

Quoted 20 lines · P. van Gaans

http://linuxtv.org/wiki/index.php/MSI_DigiVox_Trio

If you're having a deja-vu, yeah, it's still me. I'm still using this device using my butt-ugly patch by adding:

{ USB_DEVICE(0xeb1a, 0x2885), /* MSI Digivox Trio */

             .driver_info = EM2884_BOARD_TERRATEC_H5 },

to linux/drivers/media/usb/em28xx/em28xx-cards.c.

It's starting to bug me more and more that I can never update my kernel (well not without hassle anyway). I've written this to the mailinglist before, but with no response.

I just don't have the skill to write this in the neat way it needs to be to be able to go upstream. Should I try to hire someone to do that? If so, any suggestions? Just put an ad up on craigslist or something? Does such a patch have a chance of going upstream? (as that's the whole point
- I want to update my kernel again)

Quoted 5 lines

It should be really straightforward given that no reverse engineering or anything is needed. It's just what it states above - pretend the Digivox is an H5 and it's done.

Anyone who can tune in on this, please share your thoughts.

I've made it into a proper patch, see below.

Can you reply with your 'Signed-off-by' line?

i.e.: Signed-off-by: John Doe <[email protected]>

Since you're the author of the patch (I just formatted it), I need that to get it upstream.

Regards,

Hans

drivers/media/usb/em28xx/em28xx-cards.c +2 -0
index 15ad470..9da812b 100644
@@ -2280,6 +2280,8 @@ struct usb_device_id em28xx_id_table[] = {
 			.driver_info = EM2820_BOARD_UNKNOWN },
 	{ USB_DEVICE(0xeb1a, 0x2875),
 			.driver_info = EM2820_BOARD_UNKNOWN },
+	{ USB_DEVICE(0xeb1a, 0x2885), /* MSI Digivox Trio */
+			.driver_info = EM2884_BOARD_TERRATEC_H5 },
 	{ USB_DEVICE(0xeb1a, 0xe300),
 			.driver_info = EM2861_BOARD_KWORLD_PVRTV_300U },
 	{ USB_DEVICE(0xeb1a, 0xe303),
#2 lore raw

Re: [PATCH] em28xx: add MSI Digivox Trio support

Quoted 55 lines · Hans Verkuil
Quoted 20 lines · P. van Gaans

http://linuxtv.org/wiki/index.php/MSI_DigiVox_Trio

If you're having a deja-vu, yeah, it's still me. I'm still using this device using my butt-ugly patch by adding:

{ USB_DEVICE(0xeb1a, 0x2885), /* MSI Digivox Trio */

              .driver_info = EM2884_BOARD_TERRATEC_H5 },

to linux/drivers/media/usb/em28xx/em28xx-cards.c.

It's starting to bug me more and more that I can never update my kernel (well not without hassle anyway). I've written this to the mailinglist before, but with no response.

I just don't have the skill to write this in the neat way it needs to be to be able to go upstream. Should I try to hire someone to do that? If so, any suggestions? Just put an ad up on craigslist or something? Does such a patch have a chance of going upstream? (as that's the whole point
- I want to update my kernel again)

Quoted 5 lines

It should be really straightforward given that no reverse engineering or anything is needed. It's just what it states above - pretend the Digivox is an H5 and it's done.

Anyone who can tune in on this, please share your thoughts.

I've made it into a proper patch, see below.

Can you reply with your 'Signed-off-by' line?

i.e.: Signed-off-by: John Doe <[email protected]>

Since you're the author of the patch (I just formatted it), I need that to get it upstream.

Regards,

Hans

drivers/media/usb/em28xx/em28xx-cards.c +2 -1
index 15ad470..9da812b 100644
@@ -2280,6 +2280,8 @@ struct usb_device_id em28xx_id_table[] = {
  			.driver_info = EM2820_BOARD_UNKNOWN },
  	{ USB_DEVICE(0xeb1a, 0x2875),
  			.driver_info = EM2820_BOARD_UNKNOWN },
+	{ USB_DEVICE(0xeb1a, 0x2885), /* MSI Digivox Trio */
+			.driver_info = EM2884_BOARD_TERRATEC_H5 },
  	{ USB_DEVICE(0xeb1a, 0xe300),
  			.driver_info = EM2861_BOARD_KWORLD_PVRTV_300U },
  	{ USB_DEVICE(0xeb1a, 0xe303),
 
--
Quoted 4 lines

To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Thank you!