Skip to contentSkip to conversation

ARM: keystone: Staticize keystone_restart

PATCH New Sachin Kamat 2 participants 3 messages May 27, 2014 – May 28, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: keystone: Staticize keystone_restart

'keystone_restart' is used only in this file.

---
 arch/arm/mach-keystone/keystone.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-keystone/keystone.c +1 -1
index 59b8383cbdb0..4ac124b7e4e8 100644
@@ -123,7 +123,7 @@ static const char *keystone_match[] __initconst = {
 	NULL,
 };
 
-void keystone_restart(enum reboot_mode mode, const char *cmd)
+static void keystone_restart(enum reboot_mode mode, const char *cmd)
 {
 	u32 val;
 
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 ARM: keystone: Staticize keystone_restart

Quoted 12 lines · Sachin Kamat

'keystone_restart' is used only in this file.

---
  arch/arm/mach-keystone/keystone.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-keystone/keystone.c +0 -0
index 59b8383cbdb0..4ac124b7e4e8 100644

arch/arm/mach-keystone/keystone.c static const char *keystone_match[] __initconst = { · line 129

Quoted 8 lines
arch/arm/mach-keystone/keystone.c +1 -1
@@ -123,7 +123,7 @@ static const char *keystone_match[] __initconst = {
  	NULL,
  };
 
-void keystone_restart(enum reboot_mode mode, const char *cmd)
+static void keystone_restart(enum reboot_mode mode, const char *cmd)
  {
  	u32 val;
 

Hi Sachin,

The function keystone_restart() has been deleted in the following series:
[Patch v7 0/7] Introduce keystone reset driver
https://lkml.org/lkml/2014/5/23/588

So, there is no reason to correct it.

Signature · 2 lines
Regards,
Ivan Khoronzhuk
#2 lore raw

PATCH 1/1 ARM: keystone: Staticize keystone_restart

Hi Ivan,

Quoted 27 lines · Ivan Khoronzhuk
Quoted 14 lines · Sachin Kamat

'keystone_restart' is used only in this file.

---
  arch/arm/mach-keystone/keystone.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-keystone/keystone.c +0 -0
index 59b8383cbdb0..4ac124b7e4e8 100644

arch/arm/mach-keystone/keystone.c static const char *keystone_match[] __initconst = { · line 129

Quoted 7 lines
arch/arm/mach-keystone/keystone.c +1 -0
@@ -123,7 +123,7 @@ static const char *keystone_match[] __initconst = {
        NULL,
  };
  -void keystone_restart(enum reboot_mode mode, const char *cmd)
+static void keystone_restart(enum reboot_mode mode, const char *cmd)
  {
        u32 val;
 

Hi Sachin,

Quoted 3 lines

The function keystone_restart() has been deleted in the following series:
[Patch v7 0/7] Introduce keystone reset driver
https://lkml.org/lkml/2014/5/23/588

Ah.. missed it.

Quoted 2 lines

So, there is no reason to correct it.

Please ignore this patch.

Signature · 2 lines
With warm regards,
Sachin