Adding support for Ariag25 and Terra board from Acmesystems
PATCH v2 1/1 Adding support for Ariag25 and Terra board from Acmesystems
This patch adds support for Acmesystems' AriaG25 SOM and the corresponding Terra demo board.
The AriaG25 config is fairly basic, it provides only the minimal configuration to get the module booting.
The Terra config instead provides many userspace tools.
--- board/acmesystems/ariag25/at91-ariag25.config | 211 +++++++++++++++++++++ board/acmesystems/ariag25/at91-ariag25.dts | 191 +++++++++++++++++++ .../fs-overlay/etc/network/interfaces | 5 + configs/ariag25_defconfig | 12 ++ configs/ariag25_demo_terra_defconfig | 21 ++ 5 files changed, 440 insertions(+) create mode 100644 board/acmesystems/ariag25/at91-ariag25.config create mode 100644 board/acmesystems/ariag25/at91-ariag25.dts create mode 100644 board/acmesystems/ariag25_terra/fs-overlay/etc/network/interfaces create mode 100644 configs/ariag25_defconfig create mode 100644 configs/ariag25_demo_terra_defconfig
board/acmesystems/ariag25/at91-ariag25.config new file +211 -0
@@ -0,0 +1,211 @@ +# CONFIG_LOCALVERSION_AUTO is not set +CONFIG_KERNEL_LZO=y +CONFIG_SYSVIPC=y +CONFIG_LOG_BUF_SHIFT=16 +CONFIG_BLK_DEV_INITRD=y +CONFIG_RD_BZIP2=y +CONFIG_RD_LZMA=y +CONFIG_RD_XZ=y +CONFIG_RD_LZO=y +CONFIG_CC_OPTIMIZE_FOR_SIZE=y +CONFIG_SYSCTL_SYSCALL=y +CONFIG_KALLSYMS_ALL=y +CONFIG_EMBEDDED=y +CONFIG_SLAB=y +CONFIG_JUMP_LABEL=y +CONFIG_MODULES=y +CONFIG_MODULE_FORCE_LOAD=y +CONFIG_MODULE_UNLOAD=y +CONFIG_MODULE_FORCE_UNLOAD=y +CONFIG_MODVERSIONS=y +CONFIG_MODULE_SRCVERSION_ALL=y +CONFIG_BLK_DEV_BSGLIB=y +CONFIG_DEFAULT_NOOP=y +CONFIG_ARCH_AT91=y +CONFIG_SOC_AT91SAM9260=y +CONFIG_SOC_AT91SAM9261=y +CONFIG_SOC_AT91SAM9263=y +CONFIG_SOC_AT91SAM9RL=y +CONFIG_SOC_AT91SAM9G45=y +CONFIG_SOC_AT91SAM9X5=y +CONFIG_SOC_AT91SAM9N12=y +CONFIG_MACH_AT91SAM9_DT=y +CONFIG_AT91_TIMER_HZ=128 +CONFIG_AEABI=y +CONFIG_UACCESS_WITH_MEMCPY=y +# CONFIG_ATAGS is not set +CONFIG_ZBOOT_ROM_TEXT=0x0 +CONFIG_ZBOOT_ROM_BSS=0x0 +CONFIG_KEXEC=y +CONFIG_AUTO_ZRELADDR=y +# CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS is not set +CONFIG_NET=y +CONFIG_PACKET=y +CONFIG_UNIX=y +CONFIG_INET=y +CONFIG_IP_MULTICAST=y +CONFIG_IP_PNP=y +# CONFIG_INET_XFRM_MODE_TRANSPORT is not set +# CONFIG_INET_XFRM_MODE_TUNNEL is not set +# CONFIG_INET_XFRM_MODE_BEET is not set +# CONFIG_INET_DIAG is not set +CONFIG_IPV6=y +# CONFIG_INET6_XFRM_MODE_TRANSPORT is not set +# CONFIG_INET6_XFRM_MODE_TUNNEL is not set +# CONFIG_INET6_XFRM_MODE_BEET is not set +CONFIG_IPV6_SIT_6RD=y +CONFIG_DNS_RESOLVER=y +CONFIG_CFG80211=y +CONFIG_CFG80211_WEXT=y +CONFIG_MAC80211=y +CONFIG_UEVENT_HELPER_PATH="/sbin/mdev" +CONFIG_DEVTMPFS=y +CONFIG_DEVTMPFS_MOUNT=y +# CONFIG_STANDALONE is not set +# CONFIG_PREVENT_FIRMWARE_BUILD is not set +CONFIG_MTD=y +CONFIG_MTD_CMDLINE_PARTS=y +CONFIG_MTD_BLOCK=y +CONFIG_MTD_NAND=y +CONFIG_MTD_NAND_ATMEL=y +CONFIG_MTD_UBI=y +CONFIG_MTD_UBI_GLUEBI=y +CONFIG_PROC_DEVICETREE=y +CONFIG_BLK_DEV_LOOP=y +CONFIG_BLK_DEV_RAM=y +CONFIG_BLK_DEV_RAM_COUNT=4 +CONFIG_BLK_DEV_RAM_SIZE=8192 +CONFIG_ATMEL_PWM=y +CONFIG_ATMEL_TCLIB=y +CONFIG_ATMEL_SSC=y +CONFIG_EEPROM_93CX6=m +CONFIG_SCSI=y +CONFIG_BLK_DEV_SD=y +CONFIG_CHR_DEV_SG=y +CONFIG_SCSI_MULTI_LUN=y +CONFIG_NETDEVICES=y +CONFIG_MACB=y +# CONFIG_NET_VENDOR_BROADCOM is not set +# CONFIG_NET_VENDOR_CIRRUS is not set +# CONFIG_NET_VENDOR_FARADAY is not set +# CONFIG_NET_VENDOR_INTEL is not set +# CONFIG_NET_VENDOR_MARVELL is not set +# CONFIG_NET_VENDOR_MICREL is not set +# CONFIG_NET_VENDOR_MICROCHIP is not set +# CONFIG_NET_VENDOR_NATSEMI is not set +# CONFIG_NET_VENDOR_SEEQ is not set +# CONFIG_NET_VENDOR_SMSC is not set +# CONFIG_NET_VENDOR_STMICRO is not set +# CONFIG_NET_VENDOR_WIZNET is not set +CONFIG_SMSC_PHY=y +CONFIG_ATH_CARDS=m +CONFIG_ATH9K_HTC=m +CONFIG_RT2X00=y +CONFIG_RT73USB=m +CONFIG_RT2800USB=m +# CONFIG_RT2800USB_RT33XX is not set +# CONFIG_RT2800USB_RT35XX is not set +CONFIG_RT2800USB_RT53XX=y +CONFIG_INPUT_POLLDEV=y +# CONFIG_INPUT_MOUSEDEV_PSAUX is not set +CONFIG_INPUT_MOUSEDEV_SCREEN_X=480 +CONFIG_INPUT_MOUSEDEV_SCREEN_Y=272 +CONFIG_INPUT_JOYDEV=y +CONFIG_INPUT_EVDEV=y +# CONFIG_KEYBOARD_ATKBD is not set +CONFIG_KEYBOARD_GPIO=y +# CONFIG_INPUT_MOUSE is not set +CONFIG_INPUT_TOUCHSCREEN=y +# CONFIG_SERIO is not set +CONFIG_LEGACY_PTY_COUNT=4 +CONFIG_SERIAL_ATMEL=y +CONFIG_SERIAL_ATMEL_CONSOLE=y +CONFIG_HW_RANDOM=y +CONFIG_I2C_CHARDEV=y +CONFIG_I2C_AT91=m +CONFIG_SPI=y +CONFIG_SPI_ATMEL=y +CONFIG_SPI_SPIDEV=y +CONFIG_GPIO_SYSFS=y +CONFIG_W1=y +CONFIG_W1_MASTER_GPIO=y +CONFIG_W1_SLAVE_THERM=y +# CONFIG_HWMON is not set +CONFIG_WATCHDOG=y +CONFIG_AT91SAM9X_WATCHDOG=y +CONFIG_SSB=m +CONFIG_MEDIA_SUPPORT=y +CONFIG_MEDIA_CAMERA_SUPPORT=y +CONFIG_MEDIA_USB_SUPPORT=y +CONFIG_USB_VIDEO_CLASS=y +CONFIG_V4L_PLATFORM_DRIVERS=y +CONFIG_HID_PID=y +CONFIG_USB_HIDDEV=y +CONFIG_USB=y +CONFIG_USB_ANNOUNCE_NEW_DEVICES=y +CONFIG_USB_EHCI_HCD=y +CONFIG_USB_OHCI_HCD=m +CONFIG_USB_WDM=m +CONFIG_USB_STORAGE=m +CONFIG_USB_SERIAL=y +CONFIG_USB_SERIAL_GENERIC=y +CONFIG_USB_SERIAL_FTDI_SIO=y +CONFIG_USB_SERIAL_PL2303=y +CONFIG_USB_GADGET=y +CONFIG_USB_AT91=m +CONFIG_USB_ETH=m +CONFIG_USB_GADGETFS=m +CONFIG_USB_CDC_COMPOSITE=m +CONFIG_USB_G_ACM_MS=m +CONFIG_USB_G_MULTI=m +CONFIG_USB_G_MULTI_CDC=y +CONFIG_MMC=y +CONFIG_MMC_UNSAFE_RESUME=y +CONFIG_MMC_ATMELMCI=y +CONFIG_LEDS_CLASS=y +CONFIG_LEDS_ATMEL_PWM=m +CONFIG_LEDS_GPIO=y +CONFIG_LEDS_TRIGGER_TIMER=y +CONFIG_LEDS_TRIGGER_ONESHOT=y +CONFIG_LEDS_TRIGGER_HEARTBEAT=y +CONFIG_LEDS_TRIGGER_CPU=y +CONFIG_LEDS_TRIGGER_GPIO=y +CONFIG_RTC_CLASS=y +CONFIG_RTC_DRV_AT91RM9200=y +CONFIG_RTC_DRV_AT91SAM9=y +CONFIG_DMADEVICES=y +CONFIG_AT_HDMAC=y +# CONFIG_IOMMU_SUPPORT is not set +CONFIG_PWM=y +CONFIG_PWM_ATMEL_TCB=y +CONFIG_EXT4_FS=y +CONFIG_EXT4_FS_POSIX_ACL=y +CONFIG_FANOTIFY=y +CONFIG_VFAT_FS=y +CONFIG_TMPFS=y +CONFIG_TMPFS_POSIX_ACL=y +# CONFIG_MISC_FILESYSTEMS is not set +# CONFIG_NETWORK_FILESYSTEMS is not set +CONFIG_NLS_CODEPAGE_437=y +CONFIG_NLS_CODEPAGE_850=y +CONFIG_NLS_ISO8859_1=y +CONFIG_PRINTK_TIME=y +CONFIG_STRIP_ASM_SYMS=y +CONFIG_UNUSED_SYMBOLS=y +CONFIG_MAGIC_SYSRQ=y +# CONFIG_SCHED_DEBUG is not set +# CONFIG_DEBUG_BUGVERBOSE is not set +# CONFIG_FTRACE is not set +CONFIG_STRICT_DEVMEM=y +CONFIG_DEBUG_USER=y +CONFIG_KEYS=y +CONFIG_CRYPTO_ECB=y +CONFIG_CRYPTO_SHA1=y +# CONFIG_CRYPTO_ANSI_CPRNG is not set +CONFIG_CRYPTO_USER_API_HASH=m +CONFIG_CRYPTO_USER_API_SKCIPHER=m +# CONFIG_CRYPTO_HW is not set +CONFIG_CRC_CCITT=y +CONFIG_CRC_T10DIF=m +CONFIG_CRC_ITU_T=y +CONFIG_CRC7=y
board/acmesystems/ariag25/at91-ariag25.dts new file +191 -0
191 lines not on this page · raw message
board/acmesystems/ariag25_terra/fs-overlay/etc/network/interfaces new file +5 -0
@@ -0,0 +1,5 @@ +auto lo +iface lo inet loopback + +auto eth0 +iface eth0 inet dhcp
configs/ariag25_defconfig new file +12 -0
@@ -0,0 +1,12 @@ +BR2_arm=y +BR2_DEFCONFIG="$(CONFIG_DIR)/defconfig" +BR2_TOOLCHAIN_BUILDROOT_LARGEFILE=y +BR2_TARGET_GENERIC_HOSTNAME="ariag25" +BR2_TARGET_GENERIC_ISSUE="Welcome to AriaG25 by www.acmesystems.it!" +BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y +BR2_LINUX_KERNEL=y +BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y +BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/acmesystems/ariag25/at91-ariag25.config" +BR2_LINUX_KERNEL_DTS_SUPPORT=y +BR2_LINUX_KERNEL_USE_CUSTOM_DTS=y +BR2_LINUX_KERNEL_CUSTOM_DTS_PATH="board/acmesystems/ariag25/at91-ariag25.dts"
configs/ariag25_demo_terra_defconfig new file +21 -0
@@ -0,0 +1,21 @@ +BR2_arm=y +BR2_DEFCONFIG="$(CONFIG_DIR)/defconfig" +BR2_TOOLCHAIN_BUILDROOT_LARGEFILE=y +BR2_TOOLCHAIN_BUILDROOT_WCHAR=y +BR2_TARGET_GENERIC_HOSTNAME="ariag25" +BR2_TARGET_GENERIC_ISSUE="Welcome to AriaG25 by www.acmesystems.it!" +BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y +BR2_LINUX_KERNEL=y +BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y +BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/acmesystems/ariag25/at91-ariag25.config" +BR2_LINUX_KERNEL_DTS_SUPPORT=y +BR2_LINUX_KERNEL_USE_CUSTOM_DTS=y +BR2_LINUX_KERNEL_CUSTOM_DTS_PATH="board/acmesystems/ariag25/at91-ariag25.dts" +BR2_PACKAGE_PYTHON=y +BR2_PACKAGE_PYTHON_SQLITE=y +BR2_PACKAGE_PYTHON_ZLIB=y +BR2_PACKAGE_PYTHON_SERIAL=y +BR2_PACKAGE_DROPBEAR=y +BR2_PACKAGE_IPUTILS=y +BR2_PACKAGE_NTP=y +BR2_PACKAGE_OPKG=y
Signature · 1 line
1.9.1
PATCH v2 1/1 Adding support for Ariag25 and Terra board from Acmesystems
Quoted 47 lines · Angelo Compagnucci
This patch adds support for Acmesystems' AriaG25 SOM and the corresponding Terra demo board.
The AriaG25 config is fairly basic, it provides only the minimal configuration to get the module booting.
The Terra config instead provides many userspace tools.Signed-off-by Angelo Compagnucci <[email protected]>--- board/acmesystems/ariag25/at91-ariag25.config | 211 +++++++++++++++++++++ board/acmesystems/ariag25/at91-ariag25.dts | 191 +++++++++++++++++++ .../fs-overlay/etc/network/interfaces | 5 + configs/ariag25_defconfig | 12 ++ configs/ariag25_demo_terra_defconfig | 21 ++ 5 files changed, 440 insertions(+) create mode 100644 board/acmesystems/ariag25/at91-ariag25.config create mode 100644 board/acmesystems/ariag25/at91-ariag25.dts create mode 100644 board/acmesystems/ariag25_terra/fs-overlay/etc/network/interfaces create mode 100644 configs/ariag25_defconfig create mode 100644 configs/ariag25_demo_terra_defconfigboard/acmesystems/ariag25/at91-ariag25.config new file +21
-0@@ -0,0 +1,211 @@ +# CONFIG_LOCALVERSION_AUTO is not set +CONFIG_KERNEL_LZO=y +CONFIG_SYSVIPC=y +CONFIG_LOG_BUF_SHIFT=16 +CONFIG_BLK_DEV_INITRD=y +CONFIG_RD_BZIP2=y +CONFIG_RD_LZMA=y +CONFIG_RD_XZ=y +CONFIG_RD_LZO=y +CONFIG_CC_OPTIMIZE_FOR_SIZE=y +CONFIG_SYSCTL_SYSCALL=y +CONFIG_KALLSYMS_ALL=y +CONFIG_EMBEDDED=y +CONFIG_SLAB=y +CONFIG_JUMP_LABEL=y +CONFIG_MODULES=y +CONFIG_MODULE_FORCE_LOAD=y +CONFIG_MODULE_UNLOAD=y +CONFIG_MODULE_FORCE_UNLOAD=y +CONFIG_MODVERSIONS=y +CONFIG_MODULE_SRCVERSION_ALL=y
board/acmesystems/ariag25/at91-ariag25.config line 31
Quoted 10 lines
board/acmesystems/ariag25/at91-ariag25.config new file +10
-0+CONFIG_BLK_DEV_BSGLIB=y +CONFIG_DEFAULT_NOOP=y +CONFIG_ARCH_AT91=y +CONFIG_SOC_AT91SAM9260=y +CONFIG_SOC_AT91SAM9261=y +CONFIG_SOC_AT91SAM9263=y +CONFIG_SOC_AT91SAM9RL=y +CONFIG_SOC_AT91SAM9G45=y +CONFIG_SOC_AT91SAM9X5=y +CONFIG_SOC_AT91SAM9N12=y
Any reason to support all these different chips?
Quoted 3 lines
board/acmesystems/ariag25/at91-ariag25.config new file +3
-0+CONFIG_MACH_AT91SAM9_DT=y +CONFIG_AT91_TIMER_HZ=128 +CONFIG_AEABI=y
[snip]
board/acmesystems/ariag25/at91-ariag25.config line 182
Quoted 2 lines
board/acmesystems/ariag25/at91-ariag25.config new file +2
-0+CONFIG_EXT4_FS=y +CONFIG_EXT4_FS_POSIX_ACL=y
Why do you need ext4 support?
Quoted 9 lines
board/acmesystems/ariag25/at91-ariag25.config new file +9
-0+CONFIG_FANOTIFY=y +CONFIG_VFAT_FS=y +CONFIG_TMPFS=y +CONFIG_TMPFS_POSIX_ACL=y +# CONFIG_MISC_FILESYSTEMS is not set +# CONFIG_NETWORK_FILESYSTEMS is not set +CONFIG_NLS_CODEPAGE_437=y +CONFIG_NLS_CODEPAGE_850=y +CONFIG_NLS_ISO8859_1=y
[snip]
board/acmesystems/ariag25_terra/fs-overlay/etc/network/interfaces
Quoted 5 lines
board/acmesystems/ariag25_terra/fs-overlay/etc/network/interfaces new file +0
-0
You're not actually using this in your defconfigs...
Quoted 12 lines
board/acmesystems/ariag25_terra/fs-overlay/etc/network/interfaces new file +5
-0@@ -0,0 +1,5 @@ +auto lo +iface lo inet loopback + +auto eth0 +iface eth0 inet dhcpconfigs/ariag25_defconfig new file +0
-0
configs/ariag25_defconfig line 3
Quoted 3 lines
configs/ariag25_defconfig new file +3
-0@@ -0,0 +1,12 @@ +BR2_arm=y +BR2_DEFCONFIG="$(CONFIG_DIR)/defconfig" +BR2_TOOLCHAIN_BUILDROOT_LARGEFILE=y
There's no reason to have this in the minimal defconfig.
configs/ariag25_defconfig line 12
Quoted 9 lines
configs/ariag25_defconfig new file +9
-0+BR2_TARGET_GENERIC_HOSTNAME="ariag25" +BR2_TARGET_GENERIC_ISSUE="Welcome to AriaG25 by www.acmesystems.it!" +BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y +BR2_LINUX_KERNEL=y +BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y +BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/acmesystems/ariag25/at91-ariag25.config" +BR2_LINUX_KERNEL_DTS_SUPPORT=y +BR2_LINUX_KERNEL_USE_CUSTOM_DTS=y +BR2_LINUX_KERNEL_CUSTOM_DTS_PATH="board/acmesystems/ariag25/at91-ariag25.dts"
Since you create just a root filesystem and a kernel, not even a bootloader,
I'd expect a README file with an explanation how you get this stuff on your device.
Quoted 17 lines
configs/ariag25_demo_terra_defconfig new file +11
-0@@ -0,0 +1,21 @@ +BR2_arm=y +BR2_DEFCONFIG="$(CONFIG_DIR)/defconfig" +BR2_TOOLCHAIN_BUILDROOT_LARGEFILE=y +BR2_TOOLCHAIN_BUILDROOT_WCHAR=y +BR2_TARGET_GENERIC_HOSTNAME="ariag25" +BR2_TARGET_GENERIC_ISSUE="Welcome to AriaG25 by www.acmesystems.it!" +BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y +BR2_LINUX_KERNEL=y +BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y +BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/acmesystems/ariag25/at91-ariag25.config" +BR2_LINUX_KERNEL_DTS_SUPPORT=y
configs/ariag25_demo_terra_defconfig line 21
Quoted 10 lines
configs/ariag25_demo_terra_defconfig new file +10
-0+BR2_LINUX_KERNEL_USE_CUSTOM_DTS=y +BR2_LINUX_KERNEL_CUSTOM_DTS_PATH="board/acmesystems/ariag25/at91-ariag25.dts" +BR2_PACKAGE_PYTHON=y +BR2_PACKAGE_PYTHON_SQLITE=y +BR2_PACKAGE_PYTHON_ZLIB=y +BR2_PACKAGE_PYTHON_SERIAL=y +BR2_PACKAGE_DROPBEAR=y +BR2_PACKAGE_IPUTILS=y +BR2_PACKAGE_NTP=y +BR2_PACKAGE_OPKG=y
I like the fact that we get our first demo config. However, I don't understand
the choice of packages here. dropbear makes a lot of sense of course, but the others just seem a bit random. In this case, I don't think the demo config makes a lot of sense.
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH v2 1/1 Adding support for Ariag25 and Terra board from Acmesystems
Quoted 9 lines
board/acmesystems/ariag25/at91-ariag25.config line 31
Quoted 7 lines
board/acmesystems/ariag25/at91-ariag25.config new file +7
-0+CONFIG_SOC_AT91SAM9260=y +CONFIG_SOC_AT91SAM9261=y +CONFIG_SOC_AT91SAM9263=y +CONFIG_SOC_AT91SAM9RL=y +CONFIG_SOC_AT91SAM9G45=y +CONFIG_SOC_AT91SAM9X5=y +CONFIG_SOC_AT91SAM9N12=yAny reason to support all these different chips?
I used the kernel config provided by Acmesystems, do you think it should be reviewed?
Quoted 8 lines
Quoted 3 lines
board/acmesystems/ariag25/at91-ariag25.config new file +3
-0+CONFIG_MACH_AT91SAM9_DT=y +CONFIG_AT91_TIMER_HZ=128 +CONFIG_AEABI=y[snip]
board/acmesystems/ariag25/at91-ariag25.config line 182
Quoted 2 lines
board/acmesystems/ariag25/at91-ariag25.config new file +2
-0+CONFIG_EXT4_FS=y +CONFIG_EXT4_FS_POSIX_ACL=yWhy do you need ext4 support?
Why not? EXT4 is ubiquitous and used extensively on AriaG25 / Terra board.
Quoted 7 lines
board/acmesystems/ariag25_terra/fs-overlay/etc/network/interfaces
Quoted 5 lines
board/acmesystems/ariag25_terra/fs-overlay/etc/network/interfaces new file +0
-0You're not actually using this in your defconfigs...
Ouch, big mistake, sorry.
Quoted 3 lines
Quoted 1 line
+BR2_TOOLCHAIN_BUILDROOT_LARGEFILE=y
There's no reason to have this in the minimal defconfig.
Ok, I'll remove it
Quoted 4 lines
Quoted 4 lines
board/acmesystems/ariag25_terra/fs-overlay/etc/network/interfaces new file +4
-0+BR2_TARGET_GENERIC_HOSTNAME="ariag25" +BR2_TARGET_GENERIC_ISSUE="Welcome to AriaG25 by www.acmesystems.it!" +BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y +BR2_LINUX_KERNEL=y
Quoted 8 lines
board/acmesystems/ariag25_terra/fs-overlay/etc/network/interfaces
Quoted 5 lines
board/acmesystems/ariag25_terra/fs-overlay/etc/network/interfaces new file +5
-0+BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y +BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/acmesystems/ariag25/at91-ariag25.config" +BR2_LINUX_KERNEL_DTS_SUPPORT=y +BR2_LINUX_KERNEL_USE_CUSTOM_DTS=y +BR2_LINUX_KERNEL_CUSTOM_DTS_PATH="board/acmesystems/ariag25/at91-ariag25.dts"Since you create just a root filesystem and a kernel, not even a bootloader,
I'd expect a README file with an explanation how you get this stuff on your device.
Ok, I will add the at91 bootloader.
Quoted 5 lines
Quoted 5 lines
board/acmesystems/ariag25_terra/fs-overlay/etc/network/interfaces new file +5
-0+BR2_PACKAGE_PYTHON=y +BR2_PACKAGE_PYTHON_SQLITE=y +BR2_PACKAGE_PYTHON_ZLIB=y +BR2_PACKAGE_PYTHON_SERIAL=y +BR2_PACKAGE_DROPBEAR=y
Quoted 8 lines
board/acmesystems/ariag25_terra/fs-overlay/etc/network/interfaces
Quoted 3 lines
board/acmesystems/ariag25_terra/fs-overlay/etc/network/interfaces new file +3
-0+BR2_PACKAGE_IPUTILS=y +BR2_PACKAGE_NTP=y +BR2_PACKAGE_OPKG=yI like the fact that we get our first demo config. However, I don't understand
the choice of packages here. dropbear makes a lot of sense of course, but the others just seem a bit random. In this case, I don't think the demo config makes a lot of sense.
It should be a rationale for a demo board? I choose that packages because the provides a minimal support to run the examples provided on the manufacturer's website.
Why do you think they are randomly chosen?
Python packages are useful for running website examples, iputils contains basic useful commands as ping, ntp is ntp, and OPKG makes possible to add other pre-compiled software from
http://feeds.angstrom-distribution.org/
I don't think it' so random :) !
Sincerly,
Angelo
PATCH v2 1/1 Adding support for Ariag25 and Terra board from Acmesystems
Quoted 10 lines · Angelo Compagnucci
Quoted 9 lines
board/acmesystems/ariag25/at91-ariag25.config line 31
Quoted 7 lines
board/acmesystems/ariag25/at91-ariag25.config new file +7
-0+CONFIG_SOC_AT91SAM9260=y +CONFIG_SOC_AT91SAM9261=y +CONFIG_SOC_AT91SAM9263=y +CONFIG_SOC_AT91SAM9RL=y +CONFIG_SOC_AT91SAM9G45=y +CONFIG_SOC_AT91SAM9X5=y +CONFIG_SOC_AT91SAM9N12=yAny reason to support all these different chips?
Quoted 2 lines
I used the kernel config provided by Acmesystems, do you think it should be reviewed?
No, just mention in the README or in the commit message where it comes from then.
Quoted 11 lines
Quoted 9 lines
Quoted 4 lines
board/acmesystems/ariag25/at91-ariag25.config new file +3
-0+CONFIG_MACH_AT91SAM9_DT=y +CONFIG_AT91_TIMER_HZ=128 +CONFIG_AEABI=y[snip]
board/acmesystems/ariag25/at91-ariag25.config line 182
Quoted 2 lines
board/acmesystems/ariag25/at91-ariag25.config new file +2
-0+CONFIG_EXT4_FS=y +CONFIG_EXT4_FS_POSIX_ACL=yWhy do you need ext4 support?
Why not? EXT4 is ubiquitous and used extensively on AriaG25 / Terra board.
The config you provide doesn't show that because it doesn't have an ext4 rootfs.
Quoted 30 lines
Quoted 8 lines
board/acmesystems/ariag25_terra/fs-overlay/etc/network/interfaces
Quoted 6 lines
board/acmesystems/ariag25_terra/fs-overlay/etc/network/interfaces new file +0
-0You're not actually using this in your defconfigs...
Ouch, big mistake, sorry.
Quoted 3 lines
Quoted 1 line
+BR2_TOOLCHAIN_BUILDROOT_LARGEFILE=y
There's no reason to have this in the minimal defconfig.
Ok, I'll remove it
Quoted 4 lines
Quoted 4 lines
board/acmesystems/ariag25_terra/fs-overlay/etc/network/interfaces new file +4
-0+BR2_TARGET_GENERIC_HOSTNAME="ariag25" +BR2_TARGET_GENERIC_ISSUE="Welcome to AriaG25 by www.acmesystems.it!" +BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y +BR2_LINUX_KERNEL=yQuoted 8 lines
board/acmesystems/ariag25_terra/fs-overlay/etc/network/interfaces
Quoted 5 lines
board/acmesystems/ariag25_terra/fs-overlay/etc/network/interfaces new file +5
-0+BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y +BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/acmesystems/ariag25/at91-ariag25.config" +BR2_LINUX_KERNEL_DTS_SUPPORT=y +BR2_LINUX_KERNEL_USE_CUSTOM_DTS=y +BR2_LINUX_KERNEL_CUSTOM_DTS_PATH="board/acmesystems/ariag25/at91-ariag25.dts"Since you create just a root filesystem and a kernel, not even a bootloader,
I'd expect a README file with an explanation how you get this stuff on your device.
Quoted 1 line
Ok, I will add the at91 bootloader.
And a readme about how to put it on the board. You can make it very short and
just refer to a website - on condition that the instructions on that website are correct for the images generated by buildroot.
We want a user to be able to boot a board with buildroot by doing:
- make ariag25_defconfig
- follow the instructions in board/acmesystems/ariag25/readme.txt
Quoted 15 lines
Quoted 14 lines
board/acmesystems/ariag25_terra/fs-overlay/etc/network/interfaces
Quoted 9 lines
board/acmesystems/ariag25_terra/fs-overlay/etc/network/interfaces new file +8
-0+BR2_PACKAGE_PYTHON=y +BR2_PACKAGE_PYTHON_SQLITE=y +BR2_PACKAGE_PYTHON_ZLIB=y +BR2_PACKAGE_PYTHON_SERIAL=y +BR2_PACKAGE_DROPBEAR=y +BR2_PACKAGE_IPUTILS=y +BR2_PACKAGE_NTP=y +BR2_PACKAGE_OPKG=yI like the fact that we get our first demo config. However, I don't understand
the choice of packages here. dropbear makes a lot of sense of course, but the others just seem a bit random. In this case, I don't think the demo config makes a lot of sense.
Quoted 3 lines
It should be a rationale for a demo board? I choose that packages because the provides a minimal support to run the examples provided on the manufacturer's website.
That's perfect - but then you should refer to the examples on the website, and
how to install them on the system. Perhaps even create a package for them (though that's probably not very useful).
Quoted 2 lines
Why do you think they are randomly chosen? Python packages are useful for running website examples,
OK
Quoted 2 lines
iputils
contains basic useful commands as ping, ntp is ntp,
Those are also in busybox.
Quoted 3 lines
and OPKG makes
possible to add other pre-compiled software from
http://feeds.angstrom-distribution.org/
Have you tried that? I doubt that angstrom uses uClibc toolchains...
Regards,
Arnout
Quoted 7 lines
I don't think it' so random :) !
Sincerly,
Angelo
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH v2 1/1 Adding support for Ariag25 and Terra board from Acmesystems
Hi Arnout,
2014-05-28 12:30 GMT+02:00 Arnout Vandecappelle <[email protected]>:
Quoted 3 lines · Angelo Compagnucci
No, just mention in the README or in the commit message where it comes from then.
Ok. I'll add a README.
Quoted 1 line
The config you provide doesn't show that because it doesn't have an ext4 rootfs.
Yes, but I can simply untar the rootfs in a EXT4 root partition, removing EXT4 will make the system unbootable without a plausible reason. Moreover this setting is inside the producer provided config, so I think it should stay.
A user that wants a really tailored rootfs for is own needs should tweak the kernel configuration anyway. I think it's better to have a sensible default, and ext4 seems sensible to me! Anyway, I'll remove it if this prevents the patch been accepted.
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
Since you create just a root filesystem and a kernel, not even a bootloader,
I'd expect a README file with an explanation how you get this stuff on your device.Ok, I will add the at91 bootloader.
And a readme about how to put it on the board. You can make it very short and
just refer to a website - on condition that the instructions on that website are correct for the images generated by buildroot.
Ok. Producer website has very detailed explanations that work for sure with buildroot.
Quoted 4 lines
We want a user to be able to boot a board with buildroot by doing:
- make
ariag25_defconfig
- follow the instructions inboard/acmesystems/ariag25/readme.txt
Ok, will be done!
Quoted 3 lines
That's perfect - but then you should refer to the examples on the website, and
how to install them on the system. Perhaps even create a package for them (though that's probably not very useful).
I think a package it's not that much useful, they are simply examples (like how to blink an led). So I will mention them in the README.
Quoted 4 lines
Quoted 2 lines
iputils
contains basic useful commands as ping, ntp is ntp,Those are also in busybox.
Ok, catched. I'll replace packages with busybox ones.
Quoted 5 lines
Quoted 3 lines
and OPKG makes
possible to add other pre-compiled software from
http://feeds.angstrom-distribution.org/Have you tried that? I doubt that angstrom uses uClibc toolchains...
Yeah, you are right ... I've tried in the past, but used eGlibc, with default toolchain setting it will not work. I'll remove it.
Thank you for your great support!
Angelo