Skip to contentSkip to conversation

fat: Define MAX_CLUSTSIZE using CONFIG_FS_FAT_MAX_CLUSTSIZE

PATCH New Siva Durga Prasad Paladugu 3 participants 3 messages May 26, 2014 – Jun 5, 2014

lore
Share & tools
lore

Siva Durga Prasad Paladugu

author
#0 lore raw

PATCH v3 1/1 fat: Define MAX_CLUSTSIZE using CONFIG_FS_FAT_MAX_CLUSTSIZE

Define the MAX_CLUSTSIZE to default of 65536 only if CONFIG_FS_FAT_MAX_CLUSTSIZE is not defined. This option has been provided to save memory in some memory constrained cases.

Signed-off-by Siva Durga Prasad Paladugu <[email protected]>

---

Changes in v3:
-Used CONFIG_FS_FAT_MAX_CLUSTSIZE to define MAX_CLUSTSIZE as per review comment.

Changes in v2:
-Defined CONFIG_FS_FAT_MAX_CLUSTSIZE and documented as per review comment.

 README        |    6 ++++++
 include/fat.h |    6 +++++-
 2 files changed, 11 insertions(+), 1 deletions(-)
README +6 -0
index 5f89552..2f2aba3 100644
@@ -1613,6 +1613,12 @@ CBFS (Coreboot Filesystem) support
 		filesystem. Available commands are cbfsinit, cbfsinfo, cbfsls
 		and cbfsload.
 
+- FAT(File Allocation Table) filesystem cluster size:
+		CONFIG_FS_FAT_MAX_CLUSTSIZE
+
+		Define the max cluster size for fat operations else
+		a default value of 65536 will be defined.
+
 - Keyboard Support:
 		CONFIG_ISA_KEYBOARD
include/fat.h +5 -1
index 81d9790..63cf787 100644
@@ -18,7 +18,11 @@
 #define VFAT_MAXSEQ		9   /* Up to 9 of 13 2-byte UTF-16 entries */
 #define PREFETCH_BLOCKS		2
 
-#define MAX_CLUSTSIZE	65536
+#ifndef CONFIG_FS_FAT_MAX_CLUSTSIZE
+#define CONFIG_FS_FAT_MAX_CLUSTSIZE 65536
+#endif
+#define MAX_CLUSTSIZE	CONFIG_FS_FAT_MAX_CLUSTSIZE
+
 #define DIRENTSPERBLOCK	(mydata->sect_size / sizeof(dir_entry))
 #define DIRENTSPERCLUST	((mydata->clust_size * mydata->sect_size) / \
 			 sizeof(dir_entry))
Signature · 1 line
1.7.4
#1 lore raw

PATCH v3 1/1 fat: Define MAX_CLUSTSIZE using CONFIG_FS_FAT_MAX_CLUSTSIZE

Quoted 45 lines · Siva Durga Prasad Paladugu

Define the MAX_CLUSTSIZE to default of 65536 only if CONFIG_FS_FAT_MAX_CLUSTSIZE is not defined. This option has been provided to save memory in some memory constrained cases.

Signed-off-by Siva Durga Prasad Paladugu <[email protected]>

---

Changes in v3:
-Used CONFIG_FS_FAT_MAX_CLUSTSIZE to define MAX_CLUSTSIZE as per review comment.

Changes in v2:
-Defined CONFIG_FS_FAT_MAX_CLUSTSIZE and documented as per review comment.

 README        |    6 ++++++
 include/fat.h |    6 +++++-
 2 files changed, 11 insertions(+), 1 deletions(-)
README +6 -0
index 5f89552..2f2aba3 100644
@@ -1613,6 +1613,12 @@ CBFS (Coreboot Filesystem) support
 		filesystem. Available commands are cbfsinit, cbfsinfo, cbfsls
 		and cbfsload.
 
+- FAT(File Allocation Table) filesystem cluster size:
+		CONFIG_FS_FAT_MAX_CLUSTSIZE
+
+		Define the max cluster size for fat operations else
+		a default value of 65536 will be defined.
+
 - Keyboard Support:
 		CONFIG_ISA_KEYBOARD
include/fat.h +0 -0
index 81d9790..63cf787 100644
@@ -18,7 +18,11 @@
 #define VFAT_MAXSEQ		9   /* Up to 9 of 13 2-byte UTF-16 entries */
 #define PREFETCH_BLOCKS		2

include/fat.h line 28

Quoted 10 lines
include/fat.h +5 -1
 
-#define MAX_CLUSTSIZE	65536
+#ifndef CONFIG_FS_FAT_MAX_CLUSTSIZE
+#define CONFIG_FS_FAT_MAX_CLUSTSIZE 65536
+#endif
+#define MAX_CLUSTSIZE	CONFIG_FS_FAT_MAX_CLUSTSIZE
+
 #define DIRENTSPERBLOCK	(mydata->sect_size / sizeof(dir_entry))
 #define DIRENTSPERCLUST	((mydata->clust_size * mydata->sect_size) / \
 			 sizeof(dir_entry))
Acked-by Michal Simek <[email protected]>

Thanks,
Michal

Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140528/39abbcfe/attachment.pgp>
#2 lore raw

PATCH v3 1/1 fat: Define MAX_CLUSTSIZE using CONFIG_FS_FAT_MAX_CLUSTSIZE

In reply to Siva Durga Prasad Paladugu
Quoted 7 lines · Siva Durga Prasad Paladugu

Define the MAX_CLUSTSIZE to default of 65536 only if CONFIG_FS_FAT_MAX_CLUSTSIZE is not defined. This option has been provided to save memory in some memory constrained cases.

Signed-off-by Siva Durga Prasad Paladugu <[email protected]>
Acked-by Michal Simek <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140605/68ede2d2/attachment.pgp>