Skip to contentSkip to conversation

mx28evk: Remove extra CONFIG_ENV_SIZE

PATCH New Fabio Estevam 2 participants 6 messages May 8, 2014 – May 28, 2014 Arm i.MX and Layerscape

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH v2 1/3 mx28evk: Remove extra CONFIG_ENV_SIZE

From: Fabio Estevam <[email protected]>

When building a target with CONFIG_ENV_IS_IN_SPI_FLASH the following build warning is seen:

include/configs/mx28evk.h:73:0: warning: "CONFIG_ENV_SIZE" redefined [enabled by default]

Each target has its own CONFIG_ENV_SIZE definition, so remove the one that does not belong to any target.

While at it, fix a typo.

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- None

 include/configs/mx28evk.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
include/configs/mx28evk.h +1 -2
index 9b9124a..e5370f3 100644
@@ -48,7 +48,6 @@
 #define CONFIG_SYS_SDRAM_BASE		PHYS_SDRAM_1
 
 /* Environment */
-#define CONFIG_ENV_SIZE			(16 * 1024)
 #define CONFIG_ENV_OVERWRITE
 
 /* Environment is in MMC */

@@ -67,7 +66,7 @@
 		(CONFIG_ENV_OFFSET + CONFIG_ENV_RANGE)
 #endif
 
-/* Environemnt is in SPI flash */
+/* Environment is in SPI flash */
 #if defined(CONFIG_CMD_SF) && defined(CONFIG_ENV_IS_IN_SPI_FLASH)
 #define CONFIG_SYS_REDUNDAND_ENVIRONMENT
 #define CONFIG_ENV_SIZE			0x1000		/* 4KB */
Signature · 1 line
1.8.3.2
author reviewer
#1 lore raw

PATCH v2 2/3 mx28evk: Add a target for SPI NOR boot

From: Fabio Estevam <[email protected]>

Introduce 'mx28evk_spi' target which will store the environment variables into SPI NOR, which is useful when booting from SPI NOR.

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- None

 boards.cfg | 1 +
 1 file changed, 1 insertion(+)
boards.cfg +1 -0
index 89ed095..7e24ab8 100644
@@ -214,6 +214,7 @@ Active  arm         arm926ejs      mxs         freescale       mx23evk
 Active  arm         arm926ejs      mxs         freescale       mx28evk             mx28evk                              mx28evk:ENV_IS_IN_MMC                                                                                                             Fabio Estevam <[email protected]>
 Active  arm         arm926ejs      mxs         freescale       mx28evk             mx28evk_auart_console                mx28evk:MXS_AUART,MXS_AUART_BASE=MXS_UARTAPP3_BASE,ENV_IS_IN_MMC                                                                  Fabio Estevam <[email protected]>
 Active  arm         arm926ejs      mxs         freescale       mx28evk             mx28evk_nand                         mx28evk:ENV_IS_IN_NAND                                                                                                            Fabio Estevam <[email protected]>
+Active  arm         arm926ejs      mxs         freescale       mx28evk             mx28evk_spi                          mx28evk:ENV_IS_IN_SPI_FLASH                                                                                                            Fabio Estevam <[email protected]>
 Active  arm         arm926ejs      mxs         olimex          mx23_olinuxino      mx23_olinuxino                       -                                                                                                                                 Marek Vasut <[email protected]>
 Active  arm         arm926ejs      mxs         ppcag           bg0900              bg0900                               -                                                                                                                                 Marek Vasut <[email protected]>
 Active  arm         arm926ejs      mxs         sandisk         sansa_fuze_plus     sansa_fuze_plus                      -                                                                                                                                 Marek Vasut <[email protected]>
Signature · 1 line
1.8.3.2
author reviewer
#2 lore raw

PATCH v2 3/3 mx28evk: Add documentation on how to boot from SPI NOR

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

Explain the necessary steps in order to boot from SPI NOR.

Based on a earlier submission from M?rten Wikman.

Signed-off-by M?rten Wikman <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- Remove accidental hunk:
"-
+n"

 board/freescale/mx28evk/README | 22 +++++++++++++++++++---
 doc/README.mxs                 | 26 ++++++++++++++++++++++++++
 2 files changed, 45 insertions(+), 3 deletions(-)
board/freescale/mx28evk/README +19 -3
index 0389a1d..958ebc6 100644
@@ -23,11 +23,19 @@ To boot MX28EVK from an SD card, set the boot mode DIP switches as:
    * VDD 5V: To the left (off)
    * Hold Button: Down (off)
 
+To boot MX28EVK from SPI NOR flash, set the boot mode DIP switches as:
+
+   * Boot Mode Select: 0 0 1 0 (Boot from SSP2)
+   * JTAG PSWITCH RESET: To the right (reset disabled)
+   * Battery Source: Down
+   * Wall 5V: Up
+   * VDD 5V: To the left (off)
+   * Hold Button: Down (off)
 
 Environment Storage
 -------------------
 
-There are two targets for mx28evk:
+There are three targets for mx28evk:
 
 "make mx28evk_config"		- store environment variables into MMC
 

@@ -35,12 +43,20 @@ or
 
 "make mx28evk_nand_config"	- store environment variables into NAND flash
 
+or
+
+"make mx28evk_spi_config"       - store enviroment variables into SPI NOR flash
+
 Choose the target accordingly.
 
 Note: The mx28evk board does not come with a NAND flash populated from the
 factory. It comes with an empty slot (U23), which allows the insertion of a
 48-pin TSOP flash device.
 
-Follow the instructions from doc/README.mxs to generate a bootable SD card.
+mx28evk does not come with SPI NOR flash populated from the factory either.
+It is possible to solder a SOIC memory on U49 or use a DIP8 on J89.
+To get SPI communication to work R320, R321,R322 and C178 need to be populated.
+Look in the schematics for the proper component values.
 
-Insert the SD card in slot 0, power up the board and U-boot will boot.
+Follow the instructions from doc/README.mxs to generate a bootable SD card or
+to generate a binary to be flashed into SPI NOR.
doc/README.mxs +26 -0
index 0235a5a..ed2e568 100644
@@ -23,6 +23,7 @@ Contents
 2) Compiling U-Boot for a MXS based board
 3) Installation of U-Boot for a MXS based board to SD card
 4) Installation of U-Boot into NAND flash on a MX28 based board
+5) Installation of U-boot into SPI NOR flash on a MX28 based board
 
 1) Prerequisites
 ----------------

@@ -262,3 +263,28 @@ There are two possibilities when preparing an image writable to NAND flash.
 	   In case the user needs to boot a firmware image bigger than 1Mb, the
 	   user has to adjust the "update_nand_firmware_maxsz" variable for the
 	   update scripts to work properly.
+
+5) Installation of U-Boot into SPI NOR flash on a MX28 based board
+------------------------------------------------------------------
+
+The u-boot.sb file can be directly written to SPI NOR from U-boot prompt.
+
+Load u-boot.sb into RAM, this can be done in several ways and one way is to use
+tftp:
+       => tftp u-boot.sb 0x42000000
+
+Probe the SPI NOR flash:
+       => sf probe
+
+(SPI NOR should be succesfully detected in this step)
+
+Erase the blocks where U-boot binary will be written to:
+       => sf erase 0x0 0x80000
+
+Write u-boot.sb to SPI NOR:
+       => sf write 0x42000000 0 0x80000
+
+Power off the board and set the boot mode DIP switches to boot from the SPI NOR
+according to MX28 manual section 12.2.1 (Table 12-2)
+
+Last step is to power up the board and U-boot should start from SPI NOR.
Signature · 1 line
1.8.3.2
author reviewer
#3 lore raw

PATCH v2 3/3 mx28evk: Add documentation on how to boot from SPI NOR

Hi Stefano,

Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Explain the necessary steps in order to boot from SPI NOR.

Based on a earlier submission from M?rten Wikman.

Quoted 7 lines
Signed-off-by M?rten Wikman <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- Remove accidental hunk:
"-
+n"

Any comments about this one?

#4 lore raw

PATCH v2 1/3 mx28evk: Remove extra CONFIG_ENV_SIZE

In reply to Fabio Estevam
Quoted 7 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

When building a target with CONFIG_ENV_IS_IN_SPI_FLASH the following build warning is seen:

include/configs/mx28evk.h:73:0: warning: "CONFIG_ENV_SIZE" redefined [enabled by default]

Quoted 7 lines

Each target has its own CONFIG_ENV_SIZE definition, so remove the one that does not belong to any target.

While at it, fix a typo.

Signed-off-by Fabio Estevam <[email protected]>

---

Applied all patchset to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#5 lore raw

PATCH v2 1/3 mx28evk: Remove extra CONFIG_ENV_SIZE

In reply to Fabio Estevam

Hi Fabio,

Quoted 7 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

When building a target with CONFIG_ENV_IS_IN_SPI_FLASH the following build warning is seen:

include/configs/mx28evk.h:73:0: warning: "CONFIG_ENV_SIZE" redefined [enabled by default]

Quoted 7 lines

Each target has its own CONFIG_ENV_SIZE definition, so remove the one that does not belong to any target.

While at it, fix a typo.

Signed-off-by Fabio Estevam <[email protected]>

---

Sorry for the noise. I have not applied it. In fact, this breaks the other mx28evk setup.

./MAKEALL mx28evk_nand
Configuring for mx28evk_nand - Board: mx28evk, Options: ENV_IS_IN_NAND include/environment.h:85:4: error: #error "Need to define CONFIG_ENV_SIZE when using CONFIG_ENV_IS_IN_NAND" include/environment.h:85:4: error: #error "Need to define CONFIG_ENV_SIZE when using CONFIG_ENV_IS_IN_NAND" include/environment.h:85:4: error: #error "Need to define CONFIG_ENV_SIZE when using CONFIG_ENV_IS_IN_NAND"

The only one without errors is the SPI version.

Can you take a look at it ?

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================