SUNRPC/NFSD: Remove using of dprintk with KERN_WARNING
Subsystems (3)
PATCH 1/1 SUNRPC/NFSD: Remove using of dprintk with KERN_WARNING
When debugging, rpc prints messages from dprintk(KERN_WARNING ...) with "^A4" prefixed,
[ 2780.339988] ^A4nfsd: connect from unprivileged port: 127.0.0.1, port=35316
Trond tells,
Quoted 1 line
dprintk != printk. We have NEVER supported
dprintk(KERN_WARNING...)
This patch removes using of dprintk with KERN_WARNING.
Signed-off-by Kinglong Mee <[email protected]>
--- fs/nfsd/nfsfh.c | 5 ++--- net/sunrpc/svcsock.c | 3 +-- 2 files changed, 3 insertions(+), 5 deletions(-)
fs/nfsd/nfsfh.c +2 -3
@@ -88,9 +88,8 @@ static __be32 nfsd_setuser_and_check_port(struct svc_rqst *rqstp,/* Check if the request originated from a secure port. */ if (!rqstp->rq_secure && !(flags &NFSEXP_INSECURE_PORT )) { RPC_IFDEBUG(char buf[RPC_MAX_ADDRBUFLEN]); -dprintk (KERN_WARNING -"nfsd: request from insecure port %s!\n" , -svc_print_addr (rqstp, buf,sizeof (buf))); +dprintk ("nfsd: request from insecure port %s!\n" , +svc_print_addr (rqstp, buf,sizeof (buf)));return nfserr_perm; }
net/sunrpc/svcsock.c +1 -2
@@ -849,8 +849,7 @@ static struct svc_xprt *svc_tcp_accept(struct svc_xprt *xprt)* tell us anything. For now just warn about unpriv connections. */ if (!svc_port_is_privileged (sin)) { -dprintk (KERN_WARNING -"%s: connect from unprivileged port: %s\n" , +dprintk ("%s: connect from unprivileged port: %s\n" , serv->sv_name,__svc_print_addr (sin, buf,sizeof (buf))); }
Signature · 1 line
1.9.3
Thanks, applying.--b
Quoted 49 lines · Kinglong Mee
When debugging, rpc prints messages from
dprintk(KERN_WARNING ...)with "^A4" prefixed,[ 2780.339988] ^A4nfsd: connect from unprivileged port: 127.0.0.1, port=35316Trond tells,
Quoted 1 line
dprintk != printk. We have NEVER supported
dprintk(KERN_WARNING...)This patch removes using of dprintk with
KERN_WARNING.Signed-off-by Kinglong Mee <[email protected]>--- fs/nfsd/nfsfh.c | 5 ++--- net/sunrpc/svcsock.c | 3 +-- 2 files changed, 3 insertions(+), 5 deletions(-)fs/nfsd/nfsfh.c +2
-3@@ -88,9 +88,8 @@ static __be32 nfsd_setuser_and_check_port(struct svc_rqst *rqstp,/* Check if the request originated from a secure port. */ if (!rqstp->rq_secure && !(flags &NFSEXP_INSECURE_PORT )) { RPC_IFDEBUG(char buf[RPC_MAX_ADDRBUFLEN]); -dprintk (KERN_WARNING -"nfsd: request from insecure port %s!\n" , -svc_print_addr (rqstp, buf,sizeof (buf))); +dprintk ("nfsd: request from insecure port %s!\n" , +svc_print_addr (rqstp, buf,sizeof (buf)));return nfserr_perm; }net/sunrpc/svcsock.c +1
-2@@ -849,8 +849,7 @@ static struct svc_xprt *svc_tcp_accept(struct svc_xprt *xprt)* tell us anything. For now just warn about unpriv connections. */ if (!svc_port_is_privileged (sin)) { -dprintk (KERN_WARNING -"%s: connect from unprivileged port: %s\n" , +dprintk ("%s: connect from unprivileged port: %s\n" , serv->sv_name,__svc_print_addr (sin, buf,sizeof (buf))); }Signature · 1 line
1.9.3