Skip to contentSkip to conversation

ARM: shmobile: r8a7791 SYSC setup code

PATCH Superseded keita kobayashi 4 participants 4 messages May 29, 2014 – May 30, 2014

Subsystems (4)
Arm (32-bit) Arm sub-architectures SuperH Arm/RISC-V/Renesas architecture

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

keita kobayashi

author
#0 lore raw

PATCH 1/1 ARM: shmobile: r8a7791 SYSC setup code

Add r8a7791 SYSC power management support.

Signed-off-by Keita Kobayashi <[email protected]>
---
 arch/arm/mach-shmobile/Makefile               |    1 +
 arch/arm/mach-shmobile/include/mach/r8a7791.h |    1 +
 arch/arm/mach-shmobile/pm-r8a7791.c           |   47 +++++++++++++++++++++++++
 arch/arm/mach-shmobile/smp-r8a7791.c          |    2 ++
 4 files changed, 51 insertions(+)
 create mode 100644 arch/arm/mach-shmobile/pm-r8a7791.c
arch/arm/mach-shmobile/Makefile +1 -0
index 0d6a04c..29034aa 100644
@@ -53,6 +53,7 @@ obj-$(CONFIG_ARCH_SH73A0)	+= pm-sh73a0.o
 obj-$(CONFIG_ARCH_R8A7740)	+= pm-r8a7740.o pm-rmobile.o
 obj-$(CONFIG_ARCH_R8A7779)	+= pm-r8a7779.o pm-rcar.o
 obj-$(CONFIG_ARCH_R8A7790)	+= pm-r8a7790.o pm-rcar.o
+obj-$(CONFIG_ARCH_R8A7791)	+= pm-r8a7791.o pm-rcar.o
 
 # Board objects
 ifdef CONFIG_ARCH_SHMOBILE_MULTI
arch/arm/mach-shmobile/include/mach/r8a7791.h +1 -0
index 664274c..86eae7b 100644
@@ -5,6 +5,7 @@ void r8a7791_add_standard_devices(void);
 void r8a7791_add_dt_devices(void);
 void r8a7791_clock_init(void);
 void r8a7791_pinmux_init(void);
+void r8a7791_pm_init(void);
 extern struct smp_operations r8a7791_smp_ops;
 
 #endif /* __ASM_R8A7791_H__ */
arch/arm/mach-shmobile/pm-r8a7791.c new file +47 -0

47 lines not on this page · raw message

arch/arm/mach-shmobile/smp-r8a7791.c +2 -0
index ec97952..ddccef6 100644
@@ -50,6 +50,8 @@ static void __init r8a7791_smp_prepare_cpus(unsigned int max_cpus)
 	writel_relaxed((readl_relaxed(p + CA15RESCNT) & ~0x0f) | 0xa5a50000,
 		       p + CA15RESCNT);
 	iounmap(p);
+
+	r8a7791_pm_init();
 }
 
 static int r8a7791_smp_boot_secondary(unsigned int cpu,
Signature · 1 line
1.7.9.5
#1 lore raw

Hi

Quoted 4 lines

Add r8a7791 SYSC power management support.

Signed-off-by Keita Kobayashi <[email protected]>

---

(snip)

Quoted 6 lines

+/*
+ * r8a7791 Power management support
+ *

+ * Copyright (C) 2013  Renesas Electronics Corporation
+ * Copyright (C) 2011  Renesas Solutions Corp.
+ * Copyright (C) 2011  Magnus Damm

2014 ?

arch/arm/mach-shmobile/pm-r8a7791.c line 16

Quoted 4 lines
arch/arm/mach-shmobile/pm-r8a7791.c new file +4 -0
+#include <linux/kernel.h>
+#include <asm/io.h>
+#include <mach/pm-rcar.h>
+#include <mach/r8a7791.h>

alphabetical order if possible

Best regards
---
Kuninori Morimoto

#2 lore raw
In reply to keita kobayashi

Hi Morimoto-san,

Quoted 6 lines · Kuninori Morimoto

arch/arm/mach-shmobile/pm-r8a7791.c line 16

Quoted 4 lines
arch/arm/mach-shmobile/pm-r8a7791.c new file +4 -0
+#include <linux/kernel.h>
+#include <asm/io.h>
+#include <mach/pm-rcar.h>
+#include <mach/r8a7791.h>

alphabetical order if possible

To me the order looks OK:
- Linux-specific first (in alphabetical order),
- ARM-specific second (in alphabetical order),
- Machine-specific third (in alphabetical order),

I would separate the sections by a blank line, though, but for sections with a single item that's not really needed.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#3 lore raw
In reply to keita kobayashi

Hi Geert

Thank you for your feedback

Quoted 7 lines
Quoted 6 lines

arch/arm/mach-shmobile/pm-r8a7791.c line 16

Quoted 4 lines
arch/arm/mach-shmobile/pm-r8a7791.c new file +4 -0
+#include <linux/kernel.h>
+#include <asm/io.h>
+#include <mach/pm-rcar.h>
+#include <mach/r8a7791.h>

alphabetical order if possible

Quoted 7 lines

To me the order looks OK:
- Linux-specific first (in alphabetical order),
- ARM-specific second (in alphabetical order),
- Machine-specific third (in alphabetical order),

I would separate the sections by a blank line, though, but for sections with a single item that's not really needed.

I see.
This is not a big deal.