Skip to contentSkip to conversation

WARNING: CPU: 0 PID: 2623 at drivers/pnp/pnpacpi/core.c:96 pnpacpi_set_resource

DISCUSSION Zdenek Kabelac 4 participants 12 messages May 29, 2014 – Jul 30, 2014

Subsystems (2)
ACPI Pnp support
lore
Share & tools
lore

Zdenek Kabelac

author
#0 lore raw

Hi

I've noticed this message in my dmesg:
(Possibly related to this commit?:
a8d22396302b7e4e5f0a594c1c1594388c29edaf)

(My vanilla git commit number for my kernel:
cd79bde29f00a346eec3fe17c1c5073c37ed95e7)

Zdenek

[ 2174.058615] ata5: port disabled--ignoring
[ 2174.059460] sd 0:0:0:0: [sda] Starting disk
[ 2174.076342] ------------[ cut here ]------------
[ 2174.076350] WARNING: CPU: 0 PID: 2623 at drivers/pnp/pnpacpi/core.c:96 pnpacpi_set_resources+0x14f/0x160()
[ 2174.076412] Modules linked in: dm_raid raid456 async_raid6_recov async_memcpy async_pq async_xor async_tx raid1 raid10 dm_mod md_mod xor raid6_pq i915 i2c_algo_bit drm_kms_helper drm xt_CHECKSUM iptable_mangle ipt_MASQUERADE iptable_nat nf_nat_ipv4 nf_nat nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack ipt_REJECT xt_tcpudp iptable_filter ip_tables x_tables tun bridge stp llc ipv6 hid_generic usbhid hid snd_hda_codec_analog snd_hda_codec_generic iTCO_wdt iTCO_vendor_support coretemp kvm_intel kvm microcode psmouse serio_raw i2c_i801 i2c_core arc4 lpc_ich mfd_core r852 iwl3945 sm_common nand r592 nand_ecc nand_ids iwlegacy mtd memstick mac80211 sdhci_pci pcmcia sdhci snd_hda_intel mmc_core snd_hda_controller snd_hda_codec snd_hwdep snd_seq snd_seq_device snd_pcm cfg80211 e1000e ptp snd_timer
[ 2174.076433]  pps_core wmi thinkpad_acpi nvram snd soundcore evdev nfsd auth_rpcgss oid_registry nfs_acl lockd binfmt_misc loop sunrpc uhci_hcd sr_mod cdrom yenta_socket ehci_pci ehci_hcd usbcore usb_common video backlight autofs4
[ 2174.076436] CPU: 0 PID: 2623 Comm: systemd-sleep Not tainted 3.15.0-rc7-00044-g887210a #209
[ 2174.076437] Hardware name: LENOVO 6464CTO/6464CTO, BIOS 7LETC9WW (2.29 ) 03/18/2011
[ 2174.076440]  0000000000000009 ffff880095d55c40 ffffffff815db694 0000000000000000
[ 2174.076444]  ffff880095d55c78 ffffffff8104e78d 0000000000000000 ffff880136c3cd98
[ 2174.076447]  ffff8800bac2b000 ffffffff8180cb5a 0000000000000000 ffff880095d55c88
[ 2174.076448] Call Trace:
[ 2174.076453]  [<ffffffff815db694>] dump_stack+0x4e/0x7a
[ 2174.076643]  [<ffffffff8104e78d>] warn_slowpath_common+0x7d/0xa0
[ 2174.076646]  [<ffffffff8104e86a>] warn_slowpath_null+0x1a/0x20
[ 2174.076648]  [<ffffffff814046cf>] pnpacpi_set_resources+0x14f/0x160
[ 2174.076651]  [<ffffffff81401db2>] pnp_start_dev+0x42/0x80
[ 2174.076655]  [<ffffffff81400858>] pnp_bus_resume+0x88/0xa0
[ 2174.076658]  [<ffffffff814007d0>] ? pnp_bus_suspend+0x20/0x20
[ 2174.076662]  [<ffffffff8145e919>] dpm_run_callback+0x49/0xa0
[ 2174.076664]  [<ffffffff8145ec18>] device_resume+0xc8/0x1f0
[ 2174.076667]  [<ffffffff81460639>] dpm_resume+0x119/0x250
[ 2174.076670]  [<ffffffff814609b1>] dpm_resume_end+0x11/0x20
[ 2174.076673]  [<ffffffff810b4b0f>] suspend_devices_and_enter+0xff/0x680
[ 2174.076676]  [<ffffffff810b5277>] pm_suspend+0x1e7/0x2a0
[ 2174.076678]  [<ffffffff810b3c2c>] state_store+0x7c/0xf0
[ 2174.076683]  [<ffffffff81359f2f>] kobj_attr_store+0xf/0x20
[ 2174.076686]  [<ffffffff8124b1b5>] sysfs_kf_write+0x45/0x60
[ 2174.076690]  [<ffffffff8124a4d9>] kernfs_fop_write+0xf9/0x180
[ 2174.076694]  [<ffffffff811c66bd>] vfs_write+0xbd/0x1e0
[ 2174.076696]  [<ffffffff811c7249>] SyS_write+0x49/0xb0
[ 2174.076700]  [<ffffffff815ecbd6>] system_call_fastpath+0x1a/0x1f
[ 2174.081587] ---[ end trace 32ffe1e61f685f01 ]---
[ 2174.082221] serial 00:09: activated
[ 2174.233290] thinkpad_acpi: ACPI backlight control delay disabled
[ 2174.323685] ata4.00: ACPI cmd ef/03:42:00:00:00:a0 (SET FEATURES) filtered out
[ 2174.323688] ata4.00: ACPI cmd ef/03:0c:00:00:00:a0 (SET FEATURES) filtered out
[ 2174.324671] ata4.00: ACPI cmd e3/00:79:00:00:00:a0 (IDLE) succeeded
[ 2174.325651] ata4.00: ACPI cmd e3/00:01:00:00:00:a0 (IDLE) succeeded
[ 2174.345266] ata4.00: configured for UDMA/33
#1 lore raw
Quoted 6 lines · Zdenek Kabelac

Hi

I've noticed this message in my dmesg:
(Possibly related to this commit?:
a8d22396302b7e4e5f0a594c1c1594388c29edaf)

Well, does reverting that commit make the warning go away?

Rafael

Quoted 69 lines

(My vanilla git commit number for my kernel:
cd79bde29f00a346eec3fe17c1c5073c37ed95e7)

Zdenek

[ 2174.058615] ata5: port disabled--ignoring
[ 2174.059460] sd 0:0:0:0: [sda] Starting disk
[ 2174.076342] ------------[ cut here ]------------
[ 2174.076350] WARNING: CPU: 0 PID: 2623 at drivers/pnp/pnpacpi/core.c:96 
pnpacpi_set_resources+0x14f/0x160()
[ 2174.076412] Modules linked in: dm_raid raid456 async_raid6_recov

async_memcpy async_pq async_xor async_tx raid1 raid10 dm_mod md_mod xor raid6_pq i915 i2c_algo_bit drm_kms_helper drm xt_CHECKSUM iptable_mangle ipt_MASQUERADE iptable_nat nf_nat_ipv4 nf_nat nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack ipt_REJECT xt_tcpudp iptable_filter ip_tables x_tables tun bridge stp llc ipv6 hid_generic usbhid hid snd_hda_codec_analog snd_hda_codec_generic iTCO_wdt iTCO_vendor_support coretemp kvm_intel kvm microcode psmouse serio_raw i2c_i801 i2c_core arc4 lpc_ich mfd_core r852 iwl3945 sm_common nand r592 nand_ecc nand_ids iwlegacy mtd memstick mac80211 sdhci_pci pcmcia sdhci snd_hda_intel mmc_core snd_hda_controller snd_hda_codec snd_hwdep snd_seq snd_seq_device snd_pcm cfg80211 e1000e ptp snd_timer

[ 2174.076433]  pps_core wmi thinkpad_acpi nvram snd soundcore evdev nfsd 
auth_rpcgss oid_registry nfs_acl lockd binfmt_misc loop sunrpc uhci_hcd sr_mod 
cdrom yenta_socket ehci_pci ehci_hcd usbcore usb_common video backlight autofs4
[ 2174.076436] CPU: 0 PID: 2623 Comm: systemd-sleep Not tainted 
3.15.0-rc7-00044-g887210a #209
[ 2174.076437] Hardware name: LENOVO 6464CTO/6464CTO, BIOS 7LETC9WW (2.29 ) 
03/18/2011
[ 2174.076440]  0000000000000009 ffff880095d55c40 ffffffff815db694 
0000000000000000
[ 2174.076444]  ffff880095d55c78 ffffffff8104e78d 0000000000000000 
ffff880136c3cd98
[ 2174.076447]  ffff8800bac2b000 ffffffff8180cb5a 0000000000000000 
ffff880095d55c88
[ 2174.076448] Call Trace:
[ 2174.076453]  [<ffffffff815db694>] dump_stack+0x4e/0x7a
[ 2174.076643]  [<ffffffff8104e78d>] warn_slowpath_common+0x7d/0xa0
[ 2174.076646]  [<ffffffff8104e86a>] warn_slowpath_null+0x1a/0x20
[ 2174.076648]  [<ffffffff814046cf>] pnpacpi_set_resources+0x14f/0x160
[ 2174.076651]  [<ffffffff81401db2>] pnp_start_dev+0x42/0x80
[ 2174.076655]  [<ffffffff81400858>] pnp_bus_resume+0x88/0xa0
[ 2174.076658]  [<ffffffff814007d0>] ? pnp_bus_suspend+0x20/0x20
[ 2174.076662]  [<ffffffff8145e919>] dpm_run_callback+0x49/0xa0
[ 2174.076664]  [<ffffffff8145ec18>] device_resume+0xc8/0x1f0
[ 2174.076667]  [<ffffffff81460639>] dpm_resume+0x119/0x250
[ 2174.076670]  [<ffffffff814609b1>] dpm_resume_end+0x11/0x20
[ 2174.076673]  [<ffffffff810b4b0f>] suspend_devices_and_enter+0xff/0x680
[ 2174.076676]  [<ffffffff810b5277>] pm_suspend+0x1e7/0x2a0
[ 2174.076678]  [<ffffffff810b3c2c>] state_store+0x7c/0xf0
[ 2174.076683]  [<ffffffff81359f2f>] kobj_attr_store+0xf/0x20
[ 2174.076686]  [<ffffffff8124b1b5>] sysfs_kf_write+0x45/0x60
[ 2174.076690]  [<ffffffff8124a4d9>] kernfs_fop_write+0xf9/0x180
[ 2174.076694]  [<ffffffff811c66bd>] vfs_write+0xbd/0x1e0
[ 2174.076696]  [<ffffffff811c7249>] SyS_write+0x49/0xb0
[ 2174.076700]  [<ffffffff815ecbd6>] system_call_fastpath+0x1a/0x1f
[ 2174.081587] ---[ end trace 32ffe1e61f685f01 ]---
[ 2174.082221] serial 00:09: activated
[ 2174.233290] thinkpad_acpi: ACPI backlight control delay disabled
[ 2174.323685] ata4.00: ACPI cmd ef/03:42:00:00:00:a0 (SET FEATURES) filtered out
[ 2174.323688] ata4.00: ACPI cmd ef/03:0c:00:00:00:a0 (SET FEATURES) filtered out
[ 2174.324671] ata4.00: ACPI cmd e3/00:79:00:00:00:a0 (IDLE) succeeded
[ 2174.325651] ata4.00: ACPI cmd e3/00:01:00:00:00:a0 (IDLE) succeeded
[ 2174.345266] ata4.00: configured for UDMA/33

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 2 lines
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
#2 lore raw
Quoted 83 lines · Rafael J. Wysocki
Quoted 6 lines · Zdenek Kabelac

Hi

I've noticed this message in my dmesg:
(Possibly related to this commit?:
a8d22396302b7e4e5f0a594c1c1594388c29edaf)

Well, does reverting that commit make the warning go away?

Rafael

Quoted 64 lines

(My vanilla git commit number for my kernel:
cd79bde29f00a346eec3fe17c1c5073c37ed95e7)

Zdenek

[ 2174.058615] ata5: port disabled--ignoring
[ 2174.059460] sd 0:0:0:0: [sda] Starting disk
[ 2174.076342] ------------[ cut here ]------------
[ 2174.076350] WARNING: CPU: 0 PID: 2623 at drivers/pnp/pnpacpi/core.c:96
pnpacpi_set_resources+0x14f/0x160()
[ 2174.076412] Modules linked in: dm_raid raid456 async_raid6_recov

async_memcpy async_pq async_xor async_tx raid1 raid10 dm_mod md_mod xor raid6_pq i915 i2c_algo_bit drm_kms_helper drm xt_CHECKSUM iptable_mangle ipt_MASQUERADE iptable_nat nf_nat_ipv4 nf_nat nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack ipt_REJECT xt_tcpudp iptable_filter ip_tables x_tables tun bridge stp llc ipv6 hid_generic usbhid hid snd_hda_codec_analog snd_hda_codec_generic iTCO_wdt iTCO_vendor_support coretemp kvm_intel kvm microcode psmouse serio_raw i2c_i801 i2c_core arc4 lpc_ich mfd_core r852 iwl3945 sm_common nand r592 nand_ecc nand_ids iwlegacy mtd memstick mac80211 sdhci_pci pcmcia sdhci snd_hda_intel mmc_core snd_hda_controller snd_hda_codec snd_hwdep snd_seq snd_seq_device snd_pcm cfg80211 e1000e ptp snd_timer

[ 2174.076433]  pps_core wmi thinkpad_acpi nvram snd soundcore evdev nfsd
auth_rpcgss oid_registry nfs_acl lockd binfmt_misc loop sunrpc uhci_hcd sr_mod
cdrom yenta_socket ehci_pci ehci_hcd usbcore usb_common video backlight autofs4
[ 2174.076436] CPU: 0 PID: 2623 Comm: systemd-sleep Not tainted
3.15.0-rc7-00044-g887210a #209
[ 2174.076437] Hardware name: LENOVO 6464CTO/6464CTO, BIOS 7LETC9WW (2.29 )
03/18/2011
[ 2174.076440]  0000000000000009 ffff880095d55c40 ffffffff815db694
0000000000000000
[ 2174.076444]  ffff880095d55c78 ffffffff8104e78d 0000000000000000
ffff880136c3cd98
[ 2174.076447]  ffff8800bac2b000 ffffffff8180cb5a 0000000000000000
ffff880095d55c88
[ 2174.076448] Call Trace:
[ 2174.076453]  [<ffffffff815db694>] dump_stack+0x4e/0x7a
[ 2174.076643]  [<ffffffff8104e78d>] warn_slowpath_common+0x7d/0xa0
[ 2174.076646]  [<ffffffff8104e86a>] warn_slowpath_null+0x1a/0x20
[ 2174.076648]  [<ffffffff814046cf>] pnpacpi_set_resources+0x14f/0x160
[ 2174.076651]  [<ffffffff81401db2>] pnp_start_dev+0x42/0x80
[ 2174.076655]  [<ffffffff81400858>] pnp_bus_resume+0x88/0xa0
[ 2174.076658]  [<ffffffff814007d0>] ? pnp_bus_suspend+0x20/0x20
[ 2174.076662]  [<ffffffff8145e919>] dpm_run_callback+0x49/0xa0
[ 2174.076664]  [<ffffffff8145ec18>] device_resume+0xc8/0x1f0
[ 2174.076667]  [<ffffffff81460639>] dpm_resume+0x119/0x250
[ 2174.076670]  [<ffffffff814609b1>] dpm_resume_end+0x11/0x20
[ 2174.076673]  [<ffffffff810b4b0f>] suspend_devices_and_enter+0xff/0x680
[ 2174.076676]  [<ffffffff810b5277>] pm_suspend+0x1e7/0x2a0
[ 2174.076678]  [<ffffffff810b3c2c>] state_store+0x7c/0xf0
[ 2174.076683]  [<ffffffff81359f2f>] kobj_attr_store+0xf/0x20
[ 2174.076686]  [<ffffffff8124b1b5>] sysfs_kf_write+0x45/0x60
[ 2174.076690]  [<ffffffff8124a4d9>] kernfs_fop_write+0xf9/0x180
[ 2174.076694]  [<ffffffff811c66bd>] vfs_write+0xbd/0x1e0
[ 2174.076696]  [<ffffffff811c7249>] SyS_write+0x49/0xb0
[ 2174.076700]  [<ffffffff815ecbd6>] system_call_fastpath+0x1a/0x1f
[ 2174.081587] ---[ end trace 32ffe1e61f685f01 ]---
[ 2174.082221] serial 00:09: activated
[ 2174.233290] thinkpad_acpi: ACPI backlight control delay disabled
[ 2174.323685] ata4.00: ACPI cmd ef/03:42:00:00:00:a0 (SET FEATURES) filtered out
[ 2174.323688] ata4.00: ACPI cmd ef/03:0c:00:00:00:a0 (SET FEATURES) filtered out
[ 2174.324671] ata4.00: ACPI cmd e3/00:79:00:00:00:a0 (IDLE) succeeded
[ 2174.325651] ata4.00: ACPI cmd e3/00:01:00:00:00:a0 (IDLE) succeeded
[ 2174.345266] ata4.00: configured for UDMA/33
Quoted 5 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Quoted 8 lines

--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Hi.

I hit a similar stack trace with 3.14.8.

------------[ cut here ]------------
 WARNING: CPU: 23 PID: 1 at drivers/pnp/pnpacpi/core.c:96
pnpacpi_set_resources+0x9a/0x134()
 Modules linked in:
 CPU: 23 PID: 1 Comm: swapper/0 Not tainted 3.14.8 #1
  0000000000000000 ffff881fd29f5c78 ffffffff814e27e5 0000000000000000
  ffff881fd29f5cb0 ffffffff8105c4b1 ffffffff812f32f3 0000000000000000
  ffff883fd1f0a800 ffff881fff047348 0000000000000000 ffff881fd29f5cc0
 Call Trace:
  [<ffffffff814e27e5>] dump_stack+0x45/0x56
  [<ffffffff8105c4b1>] warn_slowpath_common+0x7f/0x98
  [<ffffffff812f32f3>] ? pnpacpi_set_resources+0x9a/0x134
  [<ffffffff8105c578>] warn_slowpath_null+0x1a/0x1c
  [<ffffffff812f32f3>] pnpacpi_set_resources+0x9a/0x134
  [<ffffffff812f1264>] pnp_start_dev+0x3d/0x76
  [<ffffffff812f189d>] pnp_activate_dev+0x29/0x44
  [<ffffffff812f0406>] pnp_device_probe+0x47/0xa6
  [<ffffffff81333e20>] driver_probe_device+0x120/0x2f2
  [<ffffffff8133408c>] __driver_attach+0x5d/0x7f
  [<ffffffff8133402f>] ? __device_attach+0x3d/0x3d
  [<ffffffff81332248>] bus_for_each_dev+0x7b/0x85
  [<ffffffff81333852>] driver_attach+0x1e/0x20
  [<ffffffff813334a6>] bus_add_driver+0x12f/0x1f9
  [<ffffffff81334614>] driver_register+0x8e/0xca
  [<ffffffff812f0299>] pnp_register_driver+0x21/0x23
  [<ffffffff813169b6>] serial8250_pnp_init+0x15/0x17
  [<ffffffff81b39d3c>] serial8250_init+0x60/0x143
  [<ffffffff81b39cdc>] ? serial8250_console_init+0x19/0x19
  [<ffffffff810002d2>] do_one_initcall+0xa4/0x12a
  [<ffffffff810758b1>] ? parse_args+0x258/0x331
  [<ffffffff81afcea2>] kernel_init_freeable+0x16f/0x1f4
  [<ffffffff81afc719>] ? do_early_param+0x88/0x88
  [<ffffffff814d47b5>] ? rest_init+0x79/0x79
  [<ffffffff814d47c3>] kernel_init+0xe/0xdf
  [<ffffffff814ee0ec>] ret_from_fork+0x7c/0xb0
  [<ffffffff814d47b5>] ? rest_init+0x79/0x79
 ---[ end trace 9cf08771a70bd5a1 ]—

Cheers,
Vinson

#3 lore raw
Quoted 137 lines · Vinson Lee
Quoted 83 lines · Rafael J. Wysocki
Quoted 6 lines · Zdenek Kabelac

Hi

I've noticed this message in my dmesg:
(Possibly related to this commit?:
a8d22396302b7e4e5f0a594c1c1594388c29edaf)

Well, does reverting that commit make the warning go away?

Rafael

Quoted 64 lines

(My vanilla git commit number for my kernel:
cd79bde29f00a346eec3fe17c1c5073c37ed95e7)

Zdenek

[ 2174.058615] ata5: port disabled--ignoring
[ 2174.059460] sd 0:0:0:0: [sda] Starting disk
[ 2174.076342] ------------[ cut here ]------------
[ 2174.076350] WARNING: CPU: 0 PID: 2623 at drivers/pnp/pnpacpi/core.c:96
pnpacpi_set_resources+0x14f/0x160()
[ 2174.076412] Modules linked in: dm_raid raid456 async_raid6_recov

async_memcpy async_pq async_xor async_tx raid1 raid10 dm_mod md_mod xor raid6_pq i915 i2c_algo_bit drm_kms_helper drm xt_CHECKSUM iptable_mangle ipt_MASQUERADE iptable_nat nf_nat_ipv4 nf_nat nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack ipt_REJECT xt_tcpudp iptable_filter ip_tables x_tables tun bridge stp llc ipv6 hid_generic usbhid hid snd_hda_codec_analog snd_hda_codec_generic iTCO_wdt iTCO_vendor_support coretemp kvm_intel kvm microcode psmouse serio_raw i2c_i801 i2c_core arc4 lpc_ich mfd_core r852 iwl3945 sm_common nand r592 nand_ecc nand_ids iwlegacy mtd memstick mac80211 sdhci_pci pcmcia sdhci snd_hda_intel mmc_core snd_hda_controller snd_hda_codec snd_hwdep snd_seq snd_seq_device snd_pcm cfg80211 e1000e ptp snd_timer

[ 2174.076433]  pps_core wmi thinkpad_acpi nvram snd soundcore evdev nfsd
auth_rpcgss oid_registry nfs_acl lockd binfmt_misc loop sunrpc uhci_hcd sr_mod
cdrom yenta_socket ehci_pci ehci_hcd usbcore usb_common video backlight autofs4
[ 2174.076436] CPU: 0 PID: 2623 Comm: systemd-sleep Not tainted
3.15.0-rc7-00044-g887210a #209
[ 2174.076437] Hardware name: LENOVO 6464CTO/6464CTO, BIOS 7LETC9WW (2.29 )
03/18/2011
[ 2174.076440]  0000000000000009 ffff880095d55c40 ffffffff815db694
0000000000000000
[ 2174.076444]  ffff880095d55c78 ffffffff8104e78d 0000000000000000
ffff880136c3cd98
[ 2174.076447]  ffff8800bac2b000 ffffffff8180cb5a 0000000000000000
ffff880095d55c88
[ 2174.076448] Call Trace:
[ 2174.076453]  [<ffffffff815db694>] dump_stack+0x4e/0x7a
[ 2174.076643]  [<ffffffff8104e78d>] warn_slowpath_common+0x7d/0xa0
[ 2174.076646]  [<ffffffff8104e86a>] warn_slowpath_null+0x1a/0x20
[ 2174.076648]  [<ffffffff814046cf>] pnpacpi_set_resources+0x14f/0x160
[ 2174.076651]  [<ffffffff81401db2>] pnp_start_dev+0x42/0x80
[ 2174.076655]  [<ffffffff81400858>] pnp_bus_resume+0x88/0xa0
[ 2174.076658]  [<ffffffff814007d0>] ? pnp_bus_suspend+0x20/0x20
[ 2174.076662]  [<ffffffff8145e919>] dpm_run_callback+0x49/0xa0
[ 2174.076664]  [<ffffffff8145ec18>] device_resume+0xc8/0x1f0
[ 2174.076667]  [<ffffffff81460639>] dpm_resume+0x119/0x250
[ 2174.076670]  [<ffffffff814609b1>] dpm_resume_end+0x11/0x20
[ 2174.076673]  [<ffffffff810b4b0f>] suspend_devices_and_enter+0xff/0x680
[ 2174.076676]  [<ffffffff810b5277>] pm_suspend+0x1e7/0x2a0
[ 2174.076678]  [<ffffffff810b3c2c>] state_store+0x7c/0xf0
[ 2174.076683]  [<ffffffff81359f2f>] kobj_attr_store+0xf/0x20
[ 2174.076686]  [<ffffffff8124b1b5>] sysfs_kf_write+0x45/0x60
[ 2174.076690]  [<ffffffff8124a4d9>] kernfs_fop_write+0xf9/0x180
[ 2174.076694]  [<ffffffff811c66bd>] vfs_write+0xbd/0x1e0
[ 2174.076696]  [<ffffffff811c7249>] SyS_write+0x49/0xb0
[ 2174.076700]  [<ffffffff815ecbd6>] system_call_fastpath+0x1a/0x1f
[ 2174.081587] ---[ end trace 32ffe1e61f685f01 ]---
[ 2174.082221] serial 00:09: activated
[ 2174.233290] thinkpad_acpi: ACPI backlight control delay disabled
[ 2174.323685] ata4.00: ACPI cmd ef/03:42:00:00:00:a0 (SET FEATURES) filtered out
[ 2174.323688] ata4.00: ACPI cmd ef/03:0c:00:00:00:a0 (SET FEATURES) filtered out
[ 2174.324671] ata4.00: ACPI cmd e3/00:79:00:00:00:a0 (IDLE) succeeded
[ 2174.325651] ata4.00: ACPI cmd e3/00:01:00:00:00:a0 (IDLE) succeeded
[ 2174.345266] ata4.00: configured for UDMA/33
Quoted 5 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Quoted 8 lines

--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Hi.

I hit a similar stack trace with 3.14.8.

------------[ cut here ]------------
 WARNING: CPU: 23 PID: 1 at drivers/pnp/pnpacpi/core.c:96
pnpacpi_set_resources+0x9a/0x134()
 Modules linked in:
 CPU: 23 PID: 1 Comm: swapper/0 Not tainted 3.14.8 #1
  0000000000000000 ffff881fd29f5c78 ffffffff814e27e5 0000000000000000
  ffff881fd29f5cb0 ffffffff8105c4b1 ffffffff812f32f3 0000000000000000
  ffff883fd1f0a800 ffff881fff047348 0000000000000000 ffff881fd29f5cc0
 Call Trace:
  [<ffffffff814e27e5>] dump_stack+0x45/0x56
  [<ffffffff8105c4b1>] warn_slowpath_common+0x7f/0x98
  [<ffffffff812f32f3>] ? pnpacpi_set_resources+0x9a/0x134
  [<ffffffff8105c578>] warn_slowpath_null+0x1a/0x1c
  [<ffffffff812f32f3>] pnpacpi_set_resources+0x9a/0x134
  [<ffffffff812f1264>] pnp_start_dev+0x3d/0x76
  [<ffffffff812f189d>] pnp_activate_dev+0x29/0x44
  [<ffffffff812f0406>] pnp_device_probe+0x47/0xa6
  [<ffffffff81333e20>] driver_probe_device+0x120/0x2f2
  [<ffffffff8133408c>] __driver_attach+0x5d/0x7f
  [<ffffffff8133402f>] ? __device_attach+0x3d/0x3d
  [<ffffffff81332248>] bus_for_each_dev+0x7b/0x85
  [<ffffffff81333852>] driver_attach+0x1e/0x20
  [<ffffffff813334a6>] bus_add_driver+0x12f/0x1f9
  [<ffffffff81334614>] driver_register+0x8e/0xca
  [<ffffffff812f0299>] pnp_register_driver+0x21/0x23
  [<ffffffff813169b6>] serial8250_pnp_init+0x15/0x17
  [<ffffffff81b39d3c>] serial8250_init+0x60/0x143
  [<ffffffff81b39cdc>] ? serial8250_console_init+0x19/0x19
  [<ffffffff810002d2>] do_one_initcall+0xa4/0x12a
  [<ffffffff810758b1>] ? parse_args+0x258/0x331
  [<ffffffff81afcea2>] kernel_init_freeable+0x16f/0x1f4
  [<ffffffff81afc719>] ? do_early_param+0x88/0x88
  [<ffffffff814d47b5>] ? rest_init+0x79/0x79
  [<ffffffff814d47c3>] kernel_init+0xe/0xdf
  [<ffffffff814ee0ec>] ret_from_fork+0x7c/0xb0
  [<ffffffff814d47b5>] ? rest_init+0x79/0x79
 ---[ end trace 9cf08771a70bd5a1 ]—
Quoted 2 lines

Cheers,
Vinson

Hi.

Reverting "PNP / ACPI: Do not return errors if _DIS or _SRS are not present" does not make the warning go away.

The warning also occurs with kernel 3.16-rc6.

------------[ cut here ]------------
 WARNING: CPU: 23 PID: 1 at drivers/pnp/pnpacpi/core.c:76
pnpacpi_set_resources+0x9a/0x134()
 Modules linked in:
 CPU: 23 PID: 1 Comm: swapper/0 Not tainted 3.16.0-rc6 #1
  0000000000000000 ffff8808541efc78 ffffffff814facfd 0000000000000000
  ffff8808541efcb0 ffffffff8105f229 ffffffff81302487 0000000000000000
  ffff8810530e8000 ffff88085f450e60 0000000000000000 ffff8808541efcc0
 Call Trace:
  [<ffffffff814facfd>] dump_stack+0x45/0x56
  [<ffffffff8105f229>] warn_slowpath_common+0x7f/0x98
  [<ffffffff81302487>] ? pnpacpi_set_resources+0x9a/0x134
  [<ffffffff8105f2f0>] warn_slowpath_null+0x1a/0x1c
  [<ffffffff81302487>] pnpacpi_set_resources+0x9a/0x134
  [<ffffffff8130029c>] pnp_start_dev+0x3d/0x76
  [<ffffffff813008d5>] pnp_activate_dev+0x29/0x44
  [<ffffffff812ff43e>] pnp_device_probe+0x47/0xa6
  [<ffffffff81342e1f>] driver_probe_device+0x120/0x2f3
  [<ffffffff8134308c>] __driver_attach+0x5d/0x7f
  [<ffffffff8134302f>] ? __device_attach+0x3d/0x3d
  [<ffffffff813412a0>] bus_for_each_dev+0x7b/0x85
  [<ffffffff81342886>] driver_attach+0x1e/0x20
  [<ffffffff813424fe>] bus_add_driver+0x12f/0x1f9
  [<ffffffff81343694>] driver_register+0x8e/0xca
  [<ffffffff812ff2d1>] pnp_register_driver+0x21/0x23
  [<ffffffff81325c2d>] serial8250_pnp_init+0x15/0x17
  [<ffffffff81b456a1>] serial8250_init+0x60/0x143
  [<ffffffff81b45641>] ? serial8250_console_init+0x19/0x19
  [<ffffffff8100032d>] do_one_initcall+0xff/0x186
  [<ffffffff81077ee1>] ? parse_args+0x280/0x373
  [<ffffffff81b07fb0>] kernel_init_freeable+0x16f/0x1f4
  [<ffffffff81b07719>] ? do_early_param+0x88/0x88
  [<ffffffff814efa15>] ? rest_init+0x79/0x79
  [<ffffffff814efa23>] kernel_init+0xe/0xdf
  [<ffffffff815002ec>] ret_from_fork+0x7c/0xb0
  [<ffffffff814efa15>] ? rest_init+0x79/0x79
 ---[ end trace 68542c0606786a42 ]---

Vinson

#4 lore raw
Quoted 186 lines · Vinson Lee
Quoted 137 lines · Vinson Lee
Quoted 83 lines · Rafael J. Wysocki
Quoted 6 lines · Zdenek Kabelac

Hi

I've noticed this message in my dmesg:
(Possibly related to this commit?:
a8d22396302b7e4e5f0a594c1c1594388c29edaf)

Well, does reverting that commit make the warning go away?

Rafael

Quoted 64 lines

(My vanilla git commit number for my kernel:
cd79bde29f00a346eec3fe17c1c5073c37ed95e7)

Zdenek

[ 2174.058615] ata5: port disabled--ignoring
[ 2174.059460] sd 0:0:0:0: [sda] Starting disk
[ 2174.076342] ------------[ cut here ]------------
[ 2174.076350] WARNING: CPU: 0 PID: 2623 at drivers/pnp/pnpacpi/core.c:96
pnpacpi_set_resources+0x14f/0x160()
[ 2174.076412] Modules linked in: dm_raid raid456 async_raid6_recov

async_memcpy async_pq async_xor async_tx raid1 raid10 dm_mod md_mod xor raid6_pq i915 i2c_algo_bit drm_kms_helper drm xt_CHECKSUM iptable_mangle ipt_MASQUERADE iptable_nat nf_nat_ipv4 nf_nat nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack ipt_REJECT xt_tcpudp iptable_filter ip_tables x_tables tun bridge stp llc ipv6 hid_generic usbhid hid snd_hda_codec_analog snd_hda_codec_generic iTCO_wdt iTCO_vendor_support coretemp kvm_intel kvm microcode psmouse serio_raw i2c_i801 i2c_core arc4 lpc_ich mfd_core r852 iwl3945 sm_common nand r592 nand_ecc nand_ids iwlegacy mtd memstick mac80211 sdhci_pci pcmcia sdhci snd_hda_intel mmc_core snd_hda_controller snd_hda_codec snd_hwdep snd_seq snd_seq_device snd_pcm cfg80211 e1000e ptp snd_timer

[ 2174.076433]  pps_core wmi thinkpad_acpi nvram snd soundcore evdev nfsd
auth_rpcgss oid_registry nfs_acl lockd binfmt_misc loop sunrpc uhci_hcd sr_mod
cdrom yenta_socket ehci_pci ehci_hcd usbcore usb_common video backlight autofs4
[ 2174.076436] CPU: 0 PID: 2623 Comm: systemd-sleep Not tainted
3.15.0-rc7-00044-g887210a #209
[ 2174.076437] Hardware name: LENOVO 6464CTO/6464CTO, BIOS 7LETC9WW (2.29 )
03/18/2011
[ 2174.076440]  0000000000000009 ffff880095d55c40 ffffffff815db694
0000000000000000
[ 2174.076444]  ffff880095d55c78 ffffffff8104e78d 0000000000000000
ffff880136c3cd98
[ 2174.076447]  ffff8800bac2b000 ffffffff8180cb5a 0000000000000000
ffff880095d55c88
[ 2174.076448] Call Trace:
[ 2174.076453]  [<ffffffff815db694>] dump_stack+0x4e/0x7a
[ 2174.076643]  [<ffffffff8104e78d>] warn_slowpath_common+0x7d/0xa0
[ 2174.076646]  [<ffffffff8104e86a>] warn_slowpath_null+0x1a/0x20
[ 2174.076648]  [<ffffffff814046cf>] pnpacpi_set_resources+0x14f/0x160
[ 2174.076651]  [<ffffffff81401db2>] pnp_start_dev+0x42/0x80
[ 2174.076655]  [<ffffffff81400858>] pnp_bus_resume+0x88/0xa0
[ 2174.076658]  [<ffffffff814007d0>] ? pnp_bus_suspend+0x20/0x20
[ 2174.076662]  [<ffffffff8145e919>] dpm_run_callback+0x49/0xa0
[ 2174.076664]  [<ffffffff8145ec18>] device_resume+0xc8/0x1f0
[ 2174.076667]  [<ffffffff81460639>] dpm_resume+0x119/0x250
[ 2174.076670]  [<ffffffff814609b1>] dpm_resume_end+0x11/0x20
[ 2174.076673]  [<ffffffff810b4b0f>] suspend_devices_and_enter+0xff/0x680
[ 2174.076676]  [<ffffffff810b5277>] pm_suspend+0x1e7/0x2a0
[ 2174.076678]  [<ffffffff810b3c2c>] state_store+0x7c/0xf0
[ 2174.076683]  [<ffffffff81359f2f>] kobj_attr_store+0xf/0x20
[ 2174.076686]  [<ffffffff8124b1b5>] sysfs_kf_write+0x45/0x60
[ 2174.076690]  [<ffffffff8124a4d9>] kernfs_fop_write+0xf9/0x180
[ 2174.076694]  [<ffffffff811c66bd>] vfs_write+0xbd/0x1e0
[ 2174.076696]  [<ffffffff811c7249>] SyS_write+0x49/0xb0
[ 2174.076700]  [<ffffffff815ecbd6>] system_call_fastpath+0x1a/0x1f
[ 2174.081587] ---[ end trace 32ffe1e61f685f01 ]---
[ 2174.082221] serial 00:09: activated
[ 2174.233290] thinkpad_acpi: ACPI backlight control delay disabled
[ 2174.323685] ata4.00: ACPI cmd ef/03:42:00:00:00:a0 (SET FEATURES) filtered out
[ 2174.323688] ata4.00: ACPI cmd ef/03:0c:00:00:00:a0 (SET FEATURES) filtered out
[ 2174.324671] ata4.00: ACPI cmd e3/00:79:00:00:00:a0 (IDLE) succeeded
[ 2174.325651] ata4.00: ACPI cmd e3/00:01:00:00:00:a0 (IDLE) succeeded
[ 2174.345266] ata4.00: configured for UDMA/33
Quoted 5 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Quoted 8 lines

--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Hi.

I hit a similar stack trace with 3.14.8.

------------[ cut here ]------------
 WARNING: CPU: 23 PID: 1 at drivers/pnp/pnpacpi/core.c:96
pnpacpi_set_resources+0x9a/0x134()
 Modules linked in:
 CPU: 23 PID: 1 Comm: swapper/0 Not tainted 3.14.8 #1
  0000000000000000 ffff881fd29f5c78 ffffffff814e27e5 0000000000000000
  ffff881fd29f5cb0 ffffffff8105c4b1 ffffffff812f32f3 0000000000000000
  ffff883fd1f0a800 ffff881fff047348 0000000000000000 ffff881fd29f5cc0
 Call Trace:
  [<ffffffff814e27e5>] dump_stack+0x45/0x56
  [<ffffffff8105c4b1>] warn_slowpath_common+0x7f/0x98
  [<ffffffff812f32f3>] ? pnpacpi_set_resources+0x9a/0x134
  [<ffffffff8105c578>] warn_slowpath_null+0x1a/0x1c
  [<ffffffff812f32f3>] pnpacpi_set_resources+0x9a/0x134
  [<ffffffff812f1264>] pnp_start_dev+0x3d/0x76
  [<ffffffff812f189d>] pnp_activate_dev+0x29/0x44
  [<ffffffff812f0406>] pnp_device_probe+0x47/0xa6
  [<ffffffff81333e20>] driver_probe_device+0x120/0x2f2
  [<ffffffff8133408c>] __driver_attach+0x5d/0x7f
  [<ffffffff8133402f>] ? __device_attach+0x3d/0x3d
  [<ffffffff81332248>] bus_for_each_dev+0x7b/0x85
  [<ffffffff81333852>] driver_attach+0x1e/0x20
  [<ffffffff813334a6>] bus_add_driver+0x12f/0x1f9
  [<ffffffff81334614>] driver_register+0x8e/0xca
  [<ffffffff812f0299>] pnp_register_driver+0x21/0x23
  [<ffffffff813169b6>] serial8250_pnp_init+0x15/0x17
  [<ffffffff81b39d3c>] serial8250_init+0x60/0x143
  [<ffffffff81b39cdc>] ? serial8250_console_init+0x19/0x19
  [<ffffffff810002d2>] do_one_initcall+0xa4/0x12a
  [<ffffffff810758b1>] ? parse_args+0x258/0x331
  [<ffffffff81afcea2>] kernel_init_freeable+0x16f/0x1f4
  [<ffffffff81afc719>] ? do_early_param+0x88/0x88
  [<ffffffff814d47b5>] ? rest_init+0x79/0x79
  [<ffffffff814d47c3>] kernel_init+0xe/0xdf
  [<ffffffff814ee0ec>] ret_from_fork+0x7c/0xb0
  [<ffffffff814d47b5>] ? rest_init+0x79/0x79
 ---[ end trace 9cf08771a70bd5a1 ]—
Quoted 2 lines

Cheers,
Vinson

Hi.

Reverting "PNP / ACPI: Do not return errors if _DIS or _SRS are not present" does not make the warning go away.

The warning also occurs with kernel 3.16-rc6.

------------[ cut here ]------------
 WARNING: CPU: 23 PID: 1 at drivers/pnp/pnpacpi/core.c:76
pnpacpi_set_resources+0x9a/0x134()
 Modules linked in:
 CPU: 23 PID: 1 Comm: swapper/0 Not tainted 3.16.0-rc6 #1
  0000000000000000 ffff8808541efc78 ffffffff814facfd 0000000000000000
  ffff8808541efcb0 ffffffff8105f229 ffffffff81302487 0000000000000000
  ffff8810530e8000 ffff88085f450e60 0000000000000000 ffff8808541efcc0
 Call Trace:
  [<ffffffff814facfd>] dump_stack+0x45/0x56
  [<ffffffff8105f229>] warn_slowpath_common+0x7f/0x98
  [<ffffffff81302487>] ? pnpacpi_set_resources+0x9a/0x134
  [<ffffffff8105f2f0>] warn_slowpath_null+0x1a/0x1c
  [<ffffffff81302487>] pnpacpi_set_resources+0x9a/0x134
  [<ffffffff8130029c>] pnp_start_dev+0x3d/0x76
  [<ffffffff813008d5>] pnp_activate_dev+0x29/0x44
  [<ffffffff812ff43e>] pnp_device_probe+0x47/0xa6
  [<ffffffff81342e1f>] driver_probe_device+0x120/0x2f3
  [<ffffffff8134308c>] __driver_attach+0x5d/0x7f
  [<ffffffff8134302f>] ? __device_attach+0x3d/0x3d
  [<ffffffff813412a0>] bus_for_each_dev+0x7b/0x85
  [<ffffffff81342886>] driver_attach+0x1e/0x20
  [<ffffffff813424fe>] bus_add_driver+0x12f/0x1f9
  [<ffffffff81343694>] driver_register+0x8e/0xca
  [<ffffffff812ff2d1>] pnp_register_driver+0x21/0x23
  [<ffffffff81325c2d>] serial8250_pnp_init+0x15/0x17
  [<ffffffff81b456a1>] serial8250_init+0x60/0x143
  [<ffffffff81b45641>] ? serial8250_console_init+0x19/0x19
  [<ffffffff8100032d>] do_one_initcall+0xff/0x186
  [<ffffffff81077ee1>] ? parse_args+0x280/0x373
  [<ffffffff81b07fb0>] kernel_init_freeable+0x16f/0x1f4
  [<ffffffff81b07719>] ? do_early_param+0x88/0x88
  [<ffffffff814efa15>] ? rest_init+0x79/0x79
  [<ffffffff814efa23>] kernel_init+0xe/0xdf
  [<ffffffff815002ec>] ret_from_fork+0x7c/0xb0
  [<ffffffff814efa15>] ? rest_init+0x79/0x79
 ---[ end trace 68542c0606786a42 ]---
Quoted 1 line

Vinson

The warning first happens with 3.14-rc1. The warning does not occur with 3.13.0.

#5 lore raw

Hi Vinson,

Quoted 1 line · Vinson Lee

The warning first happens with 3.14-rc1. The warning does not occur with 3.13.0.

Hitting the same issue here with a similar trace on 3.14.x. Did you start bisecting?

Regards,

Signature · 1 line
William
Tested-by Mika Westerberg
#6 lore raw
Quoted 11 lines · William Dauchy

Hi Vinson,

Quoted 1 line · Vinson Lee

The warning first happens with 3.14-rc1. The warning does not occur with 3.13.0.

Hitting the same issue here with a similar trace on 3.14.x. Did you start bisecting?

Regards,
--
William

I bisected the warning that I'm seeing to this commit.

commit 202317a573b20d77a9abb7c16a3fd5b40cef3d9d

Author: Rafael J. Wysocki <[email protected]>
Date:   Fri Nov 22 21:54:37 2013 +0100

ACPI / scan: Add acpi_device objects for all device nodes in the namespace

Modify the ACPI namespace scanning code to register a struct acpi_device object for every namespace node representing a device, processor and so on, even if the device represented by that namespace node is reported to be not present and not functional by _STA.

There are multiple reasons to do that. First of all, it avoids quite a lot of overhead when struct acpi_device objects are deleted every time acpi_bus_trim() is run and then added again by a subsequent acpi_bus_scan() for the same scope, although the namespace objects they correspond to stay in memory all the time (which always is the case on a vast majority of systems).

Second, it will allow user space to see that there are namespace nodes representing devices that are not present at the moment and may be added to the system. It will also allow user space to evaluate _SUN for those nodes to check what physical slots the "missing" devices may be put into and it will make sense to add a sysfs attribute for _STA evaluation after this change (that will be useful for thermal management on some systems).

Next, it will help to consolidate the ACPI hotplug handling among subsystems by making it possible to store hotplug-related information in struct acpi_device objects in a standard common way.

Finally, it will help to avoid a race condition related to the deletion of ACPI namespace nodes. Namely, namespace nodes may be deleted as a result of a table unload triggered by _EJ0 or _DCK. If a hotplug notification for one of those nodes is triggered right before the deletion and it executes a hotplug callback via acpi_hotplug_execute(), the ACPI handle passed to that callback may be stale when the callback actually runs. One way to work around that is to always pass struct acpi_device pointers to hotplug callbacks after doing a get_device() on the objects in question which eliminates the use-after-free possibility (the ACPI handles in those objects are invalidated by acpi_scan_drop_device(), so they will trigger ACPICA errors on attempts to use them).

Signed-off-by Rafael J. Wysocki <[email protected]>
Tested-by Mika Westerberg <[email protected]>
#7 lore raw
Quoted 14 lines · Vinson Lee
Quoted 11 lines · William Dauchy

Hi Vinson,

Quoted 1 line · Vinson Lee

The warning first happens with 3.14-rc1. The warning does not occur with 3.13.0.

Hitting the same issue here with a similar trace on 3.14.x. Did you start bisecting?

Regards,
--
William

Quoted 7 lines

I bisected the warning that I'm seeing to this commit.

commit 202317a573b20d77a9abb7c16a3fd5b40cef3d9d

Author: Rafael J. Wysocki <[email protected]>
Date:   Fri Nov 22 21:54:37 2013 +0100

ACPI / scan: Add acpi_device objects for all device nodes in the namespace

Interesting.

Does the appended patch make any difference?

Rafael

---
 drivers/pnp/pnpacpi/core.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/pnp/pnpacpi/core.c +1 -2
Index: linux-pm/drivers/pnp/pnpacpi/core.c
===================================================================
@@ -319,8 +319,7 @@ static int __init acpi_pnp_match(struct
 	struct pnp_dev *pnp = _pnp;
 
 	/* true means it matched */
-	return !acpi->physical_node_count
-	    && compare_pnp_id(pnp->id, acpi_device_hid(acpi));
+	return pnp->data == acpi;
 }
 
 static struct acpi_device * __init acpi_pnp_find_companion(struct device *dev)
#8 lore raw
Quoted 49 lines · Rafael J. Wysocki
Quoted 14 lines · Vinson Lee
Quoted 11 lines · William Dauchy

Hi Vinson,

Quoted 1 line · Vinson Lee

The warning first happens with 3.14-rc1. The warning does not occur with 3.13.0.

Hitting the same issue here with a similar trace on 3.14.x. Did you start bisecting?

Regards,
--
William

Quoted 7 lines

I bisected the warning that I'm seeing to this commit.

commit 202317a573b20d77a9abb7c16a3fd5b40cef3d9d

Author: Rafael J. Wysocki <[email protected]>
Date:   Fri Nov 22 21:54:37 2013 +0100

ACPI / scan: Add acpi_device objects for all device nodes in the namespace

Interesting.

Does the appended patch make any difference?

Rafael

---
 drivers/pnp/pnpacpi/core.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Index: linux-pm/drivers/pnp/pnpacpi/core.c
===================================================================

drivers/pnp/pnpacpi/core.c +1 -3
@@ -319,8 +319,7 @@ static int __init acpi_pnp_match(struct
        struct pnp_dev *pnp = _pnp;
 
        /* true means it matched */
-       return !acpi->physical_node_count
-           && compare_pnp_id(pnp->id, acpi_device_hid(acpi));
+       return pnp->data == acpi;
 }
 
 static struct acpi_device * __init acpi_pnp_find_companion(struct device *dev)
 
--
Quoted 3 lines

To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Yes, with the patch on top of 3.16-rc7 I do not see the warning.

#9 lore raw
Quoted 30 lines · Vinson Lee
Quoted 29 lines · Rafael J. Wysocki
Quoted 14 lines · Vinson Lee
Quoted 11 lines · William Dauchy

Hi Vinson,

Quoted 1 line · Vinson Lee

The warning first happens with 3.14-rc1. The warning does not occur with 3.13.0.

Hitting the same issue here with a similar trace on 3.14.x. Did you start bisecting?

Regards,
--
William

Quoted 7 lines

I bisected the warning that I'm seeing to this commit.

commit 202317a573b20d77a9abb7c16a3fd5b40cef3d9d

Author: Rafael J. Wysocki <[email protected]>
Date:   Fri Nov 22 21:54:37 2013 +0100

ACPI / scan: Add acpi_device objects for all device nodes in the namespace

Interesting.

Does the appended patch make any difference?

Rafael

[cut]

Quoted 3 lines

Yes, with the patch on top of 3.16-rc7 I do not see the warning.

Great, thanks for testing!

The patch goes again below with a proper changelog.

William, it would be good if you could test it too as I'd like to push it for 3.16.

Rafael

---
From: Rafael J. Wysocki <[email protected]>
Subject: ACPI / PNP: Fix acpi_pnp_match()

The acpi_pnp_match() function is used for finding the ACPI device object that should be associated with the given PNP device. Unfortunately, the check used by that function is not strict enough and may cause success to be returned for a wrong ACPI device object.

To fix that, use the observation that the pointer to the ACPI device object in question is already stored in the data field in struct pnp_dev, so acpi_pnp_match() can simply use that field to do its job.

This problem was uncovered in 3.14 by commit 202317a573b2 (ACPI / scan:
Add acpi_device objects for all device nodes in the namespace).

Fixes 202317a573b2 (ACPI / scan: Add acpi_device objects for all device nodes in the namespace)
Reported-and-tested-by Vinson Lee <[email protected]>
Cc 3.14+ <[email protected]> # 3.14+
Signed-off-by Rafael J. Wysocki <[email protected]>
---
 drivers/pnp/pnpacpi/core.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/pnp/pnpacpi/core.c +1 -2
Index: linux-pm/drivers/pnp/pnpacpi/core.c
===================================================================
@@ -319,8 +319,7 @@ static int __init acpi_pnp_match(struct
 	struct pnp_dev *pnp = _pnp;
 
 	/* true means it matched */
-	return !acpi->physical_node_count
-	    && compare_pnp_id(pnp->id, acpi_device_hid(acpi));
+	return pnp->data == acpi;
 }
 
 static struct acpi_device * __init acpi_pnp_find_companion(struct device *dev)
Tested-by
#10 lore raw

Hi Rafael,

Quoted 2 lines · Rafael J. Wysocki

William, it would be good if you could test it too as I'd like to push it for 3.16.

It also fixes the issue in 3.14.x

Tested-by William Dauchy <[email protected]>

Thanks,

Signature · 1 line
William
#11 lore raw
Quoted 9 lines · William Dauchy

Hi Rafael,

Quoted 2 lines · Rafael J. Wysocki

William, it would be good if you could test it too as I'd like to push it for 3.16.

It also fixes the issue in 3.14.x

Tested-by William Dauchy <[email protected]>

Great, thanks for testing!

Signature · 2 lines
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.