arm: shmobile: r8a7790: add USB3.0 node to r8a7790.dtsi
Subsystems (2)
PATCH 2/2 arm: shmobile: r8a7790: add USB3.0 node to r8a7790.dtsi
--- arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)
arch/arm/boot/dts/r8a7790.dtsi +10 -0
@@ -902,4 +902,14 @@ #size-cells = <0>; status = "disabled"; }; + + xhci: xhci at ee000000 { + compatible = "renesas,xhci-r8a7790"; + reg = <0 0xee000000 0 0xc00>; + interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&mstp3_clks R8A7790_CLK_SSUSB>; + phys = <&usbphy 1 1>; + phy-names = "usb"; + status = "disabled"; + }; };
Signature · 1 line
1.7.9.5
PATCH 2/2 arm: shmobile: r8a7790: add USB3.0 node to r8a7790.dtsi
Hello.
Quoted 10 lines · Yoshihiro Shimoda
Signed-off-by Yoshihiro Shimoda <[email protected]>--- arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)arch/arm/boot/dts/r8a7790.dtsi +0
-0
arch/arm/boot/dts/r8a7790.dtsi line 906
Quoted 5 lines
arch/arm/boot/dts/r8a7790.dtsi +2
-0@@ -902,4 +902,14 @@ #size-cells = <0>; status = "disabled"; }; + + xhci: xhci at ee000000 {
The node name should be "usb at ee000000", according to section 2.2.2 of the
ePAPR standard [1]:
arch/arm/boot/dts/r8a7790.dtsi line 911
Quoted 5 lines
arch/arm/boot/dts/r8a7790.dtsi +5
-0+ compatible = "renesas,xhci-r8a7790"; + reg = <0 0xee000000 0 0xc00>; + interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&mstp3_clks R8A7790_CLK_SSUSB>; + phys = <&usbphy 1 1>;
This part is dependent on the generic PHY support in the USB HCD in order
to work.
arch/arm/boot/dts/r8a7790.dtsi line 915
Quoted 4 lines
arch/arm/boot/dts/r8a7790.dtsi +3
-0+ phy-names = "usb"; + status = "disabled"; + }; };
[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
WBR, Sergei
PATCH 2/2 arm: shmobile: r8a7790: add USB3.0 node to r8a7790.dtsi
Hello.
Quoted 9 lines · Sergei Shtylyov
Hello.
Quoted 4 lines · Yoshihiro Shimoda
Signed-off-by Yoshihiro Shimoda <[email protected]>--- arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)
Quoted 13 lines
arch/arm/boot/dts/r8a7790.dtsi line 906
Quoted 10 lines
arch/arm/boot/dts/r8a7790.dtsi +2
-0@@ -902,4 +902,14 @@ #size-cells = <0>; status = "disabled"; }; + + xhci: xhci at ee000000 {The node name should be "usb at
ee000000", according to section 2.2.2 of the
ePAPR standard [1]:
Thank you for the point! I will fix this and r8a7791's one.
Quoted 8 lines
arch/arm/boot/dts/r8a7790.dtsi line 911
Quoted 5 lines
arch/arm/boot/dts/r8a7790.dtsi +5
-0+ compatible = "renesas,xhci-r8a7790"; + reg = <0 0xee000000 0 0xc00>; + interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&mstp3_clks R8A7790_CLK_SSUSB>; + phys = <&usbphy 1 1>;This part is dependent on the generic PHY support in the USB HCD in order
to work.
This means that I should wait to add this parameter until the generic USB PHY Gen2 driver is supported in upstream?
Best regards,
Yoshihiro Shimoda
Quoted 9 lines
arch/arm/boot/dts/r8a7790.dtsi line 915
Quoted 4 lines
arch/arm/boot/dts/r8a7790.dtsi +3
-0+ phy-names = "usb"; + status = "disabled"; + }; };[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
WBR, Sergei
Signature · 1 line
Yoshihiro Shimoda
PATCH 2/2 arm: shmobile: r8a7790: add USB3.0 node to r8a7790.dtsi
Hello.
Quoted 19 lines · Yoshihiro Shimoda
Quoted 5 lines
Quoted 4 lines
Signed-off-by Yoshihiro Shimoda <[email protected]>--- arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)Quoted 13 lines
arch/arm/boot/dts/r8a7790.dtsi line 906
Quoted 10 lines
arch/arm/boot/dts/r8a7790.dtsi +2
-0@@ -902,4 +902,14 @@ #size-cells = <0>; status = "disabled"; }; + + xhci: xhci at ee000000 {The node name should be "usb at
ee000000", according to section 2.2.2 of the
ePAPR standard [1]:
Quoted 10 lines
Thank you for the point! I will fix this and r8a7791's one.
Quoted 8 lines
arch/arm/boot/dts/r8a7790.dtsi line 911
Quoted 5 lines
arch/arm/boot/dts/r8a7790.dtsi +5
-0+ compatible = "renesas,xhci-r8a7790"; + reg = <0 0xee000000 0 0xc00>; + interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&mstp3_clks R8A7790_CLK_SSUSB>; + phys = <&usbphy 1 1>;This part is dependent on the generic PHY support in the USB HCD in order
to work.
Oops, I hadn't seen that you added generic PHY support to the xHCI driver
when writing this. I'm however for adding the generic PHY support to the generic USB HCD code, so that we can use it for the PCI controllers.
Quoted 2 lines
This means that I should wait to add this parameter until the generic USB PHY Gen2 driver is supported in upstream?
At least describe that dependency.
Quoted 2 lines
Best regards,
Yoshihiro Shimoda
WBR, Sergei
PATCH 2/2 arm: shmobile: r8a7790: add USB3.0 node to r8a7790.dtsi
Hello.
Quoted 34 lines · Sergei Shtylyov
Hello.
Quoted 19 lines · Yoshihiro Shimoda
Quoted 5 lines
Quoted 4 lines
Signed-off-by Yoshihiro Shimoda <[email protected]>--- arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)Quoted 13 lines
arch/arm/boot/dts/r8a7790.dtsi line 906
Quoted 10 lines
arch/arm/boot/dts/r8a7790.dtsi +2
-0@@ -902,4 +902,14 @@ #size-cells = <0>; status = "disabled"; }; + + xhci: xhci at ee000000 {The node name should be "usb at
ee000000", according to section 2.2.2 of the
ePAPR standard [1]:Quoted 10 lines
Thank you for the point! I will fix this and r8a7791's one.
Quoted 8 lines
arch/arm/boot/dts/r8a7790.dtsi line 911
Quoted 5 lines
arch/arm/boot/dts/r8a7790.dtsi +5
-0+ compatible = "renesas,xhci-r8a7790"; + reg = <0 0xee000000 0 0xc00>; + interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&mstp3_clks R8A7790_CLK_SSUSB>; + phys = <&usbphy 1 1>;This part is dependent on the generic PHY support in the USB HCD in order
to work.
Quoted 6 lines
Oops, I hadn't seen that you added generic PHY support to the xHCI driver when writing this. I'm however for adding the generic PHY support to the generic USB HCD code, so that we can use it for the PCI controllers.
Quoted 2 lines
This means that I should wait to add this parameter until the generic USB PHY Gen2 driver is supported in upstream?
At least describe that dependency.
Thank you for the reply! I will add such a describption in change log.
Best regards,
Yoshihiro Shimoda
Quoted 5 lines
Quoted 2 lines
Best regards,
Yoshihiro ShimodaWBR, Sergei
Signature · 1 line
Yoshihiro Shimoda