Skip to contentSkip to conversation

ARM: dts: exynos4: Fix reg sizes of GIC

PATCH New Tomasz Figa 3 participants 5 messages May 23, 2014 – Jun 11, 2014

Subsystems (2)
Device tree bindings Arm Samsung Exynos
lore
Share & tools
lore

Tomasz Figa

author
#0 lore raw

PATCH 1/1 ARM: dts: exynos4: Fix reg sizes of GIC

This patch fixes reg entry sizes in GIC node that were not large enough to cover whole regions.

Signed-off-by Tomasz Figa <[email protected]>
---
 arch/arm/boot/dts/exynos4.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos4.dtsi +1 -1
index b8ece4b..fbaf426 100644
@@ -113,7 +113,7 @@
 		compatible = "arm,cortex-a9-gic";
 		#interrupt-cells = <3>;
 		interrupt-controller;
-		reg = <0x10490000 0x1000>, <0x10480000 0x100>;
+		reg = <0x10490000 0x10000>, <0x10480000 0x10000>;
 	};
 
 	combiner: interrupt-controller at 10440000 {
Signature · 1 line
1.9.3
#1 lore raw

PATCH 1/1 ARM: dts: exynos4: Fix reg sizes of GIC

Hi,

Quoted 14 lines · Tomasz Figa

This patch fixes reg entry sizes in GIC node that were not large enough to cover whole regions.

Signed-off-by Tomasz Figa <[email protected]>
---
 arch/arm/boot/dts/exynos4.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos4.dtsi +0 -0
index b8ece4b..fbaf426 100644

arch/arm/boot/dts/exynos4.dtsi line 119

Quoted 8 lines
arch/arm/boot/dts/exynos4.dtsi +1 -1
@@ -113,7 +113,7 @@
 		compatible = "arm,cortex-a9-gic";
 		#interrupt-cells = <3>;
 		interrupt-controller;
-		reg = <0x10490000 0x1000>, <0x10480000 0x100>;
+		reg = <0x10490000 0x10000>, <0x10480000 0x10000>;
 	};
 
 	combiner: interrupt-controller at 10440000 {

Ping.

Best regards,
Tomasz

#2 lore raw

PATCH 1/1 ARM: dts: exynos4: Fix reg sizes of GIC

Quoted 23 lines · Tomasz Figa

Hi,

Quoted 20 lines · Tomasz Figa

This patch fixes reg entry sizes in GIC node that were not large enough to cover whole regions.

Signed-off-by Tomasz Figa<[email protected]>
---
  arch/arm/boot/dts/exynos4.dtsi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos4.dtsi +1 -1
index b8ece4b..fbaf426 100644
@@ -113,7 +113,7 @@
  		compatible = "arm,cortex-a9-gic";
  		#interrupt-cells =<3>;
  		interrupt-controller;
-		reg =<0x10490000 0x1000>,<0x10480000 0x100>;
+		reg =<0x10490000 0x10000>,<0x10480000 0x10000>;
  	};
Quoted 5 lines

arch/arm/boot/dts/exynos4.dtsi line 119

Quoted 2 lines
arch/arm/boot/dts/exynos4.dtsi +0 -0
  	combiner: interrupt-controller at 10440000 {

Ping.

Yeah, SZ_64K is used for GIC_CPU and GIC_DIST before moving on DT support. Applied, but I need to check this is required for stable tree...

Thanks,
Kukjin

author
#3 lore raw

PATCH 1/1 ARM: dts: exynos4: Fix reg sizes of GIC

Hi Kukjin,

Quoted 24 lines · Kukjin Kim
Quoted 23 lines · Tomasz Figa

Hi,

Quoted 20 lines · Tomasz Figa

This patch fixes reg entry sizes in GIC node that were not large enough to cover whole regions.

Signed-off-by Tomasz Figa<[email protected]>
---
  arch/arm/boot/dts/exynos4.dtsi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos4.dtsi +1 -1
index b8ece4b..fbaf426 100644
@@ -113,7 +113,7 @@
  		compatible = "arm,cortex-a9-gic";
  		#interrupt-cells =<3>;
  		interrupt-controller;
-		reg =<0x10490000 0x1000>,<0x10480000 0x100>;
+		reg =<0x10490000 0x10000>,<0x10480000 0x10000>;
  	};
Quoted 7 lines
Quoted 5 lines

arch/arm/boot/dts/exynos4.dtsi line 119

Quoted 2 lines
arch/arm/boot/dts/exynos4.dtsi +0 -0
  	combiner: interrupt-controller at 10440000 {

Ping.

Yeah, SZ_64K is used for GIC_CPU and GIC_DIST before moving on DT support. Applied, but I need to check this is required for stable tree...

Not sure if you already managed, but I think it might not be necessary in stable trees, as the (correct) static mapping is still there and it causes ioremap() to return correctly mapped area, ignoring the length specified in device tree.

Best regards,
Tomasz

#4 lore raw

PATCH 1/1 ARM: dts: exynos4: Fix reg sizes of GIC

Quoted 2 lines · Tomasz Figa

Hi Kukjin,

Hi Tomasz,

Quoted 30 lines · Kukjin Kim
Quoted 29 lines · Tomasz Figa
Quoted 28 lines

Hi,

Quoted 14 lines · Tomasz Figa

This patch fixes reg entry sizes in GIC node that were not large enough to cover whole regions.

Signed-off-by Tomasz Figa<[email protected]>
---
   arch/arm/boot/dts/exynos4.dtsi | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos4.dtsi +0 -0
index b8ece4b..fbaf426 100644

arch/arm/boot/dts/exynos4.dtsi line 119

Quoted 8 lines
arch/arm/boot/dts/exynos4.dtsi +1 -1
@@ -113,7 +113,7 @@
   		compatible = "arm,cortex-a9-gic";
   		#interrupt-cells =<3>;
   		interrupt-controller;
-		reg =<0x10490000 0x1000>,<0x10480000 0x100>;
+		reg =<0x10490000 0x10000>,<0x10480000 0x10000>;
   	};
 
   	combiner: interrupt-controller at 10440000 {

Ping.

Quoted 8 lines
Quoted 2 lines

Yeah, SZ_64K is used for GIC_CPU and GIC_DIST before moving on DT support. Applied, but I need to check this is required for stable tree...

Not sure if you already managed, but I think it might not be necessary in stable trees, as the (correct) static mapping is still there and it causes ioremap() to return correctly mapped area, ignoring the length specified in device tree.

Yes, agreed. this is not required for stable tree...

Thanks,
Kukjin