ARM: EXYNOS: Update secondary boot addr for secure mode

PATCH RESEND New Sachin Kamat 7 participants 12 messages May 28, 2014 – Jul 5, 2014

Subsystems (4)

Device tree bindings Arm (32-bit) Arm sub-architectures Arm Samsung Exynos

lore

Share & tools

lore

Sachin Kamat

author

2014-05-28 04:13 UTC #0 lore raw

PATCH RESEND v2 1/2 ARM: EXYNOS: Update secondary boot addr for secure mode

Almost all Exynos-series of SoCs that run in secure mode don't need additional offset for every CPU, with Exynos4412 being the only exception.

Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).

While at it, fix the coding style (space around *).

Signed-off-by Sachin Kamat <[email protected]>

Signed-off-by Tushar Behera <[email protected]>

---
 arch/arm/mach-exynos/firmware.c |    9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

arch/arm/mach-exynos/firmware.c +7 -2

index eb91d2350f8c..e8797bb78871 100644
@@ -57,8 +57,13 @@ static int exynos_set_cpu_boot_addr(int cpu, unsigned long boot_addr)
 
 	boot_reg = sysram_ns_base_addr + 0x1c;
 
-	if (!soc_is_exynos4212() && !soc_is_exynos3250())
-		boot_reg += 4*cpu;
+	/*
+	 * Almost all Exynos-series of SoCs that run in secure mode don't need
+	 * additional offset for every CPU, with Exynos4412 being the only
+	 * exception.
+	 */
+	if (soc_is_exynos4412())
+		boot_reg += 4 * cpu;
 
 	__raw_writel(boot_addr, boot_reg);
 	return 0;

Signature · 1 line

1.7.9.5

Sachin Kamat

author

2014-05-28 04:13 UTC #1 lore raw

PATCH RESEND v2 2/2 ARM: dts: Add secure firmware support for Arndale-octa

From: Tushar Behera <[email protected]>

Arndale-Octa board is always configured to work with trustzone firmware binary. Added DTS node entry to enable this support.

Signed-off-by Tushar Behera <[email protected]>

Signed-off-by Sachin Kamat <[email protected]>

---
 arch/arm/boot/dts/exynos5420-arndale-octa.dts |    5 +++++
 1 file changed, 5 insertions(+)

arch/arm/boot/dts/exynos5420-arndale-octa.dts +5 -0

index 6ee8149fd5c4..434fd9d3e09d 100644
@@ -26,6 +26,11 @@
 		bootargs = "console=ttySAC3,115200";
 	};
 
+	firmware at 02073000 {
+		compatible = "samsung,secure-firmware";
+		reg = <0x02073000 0x1000>;
+	};
+
 	fixed-rate-clocks {
 		oscclk {
 			compatible = "samsung,exynos5420-oscclk";

Signature · 1 line

1.7.9.5

Andreas Färber

2014-05-30 18:19 UTC #3 lore raw

PATCH RESEND v2 1/2 ARM: EXYNOS: Update secondary boot addr for secure mode

In reply to Sachin Kamat

Am 28.05.2014 06:13, schrieb Sachin Kamat:

Quoted 6 lines

Almost all Exynos-series of SoCs that run in secure mode don't need additional offset for every CPU, with Exynos4412 being the only exception.
Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).

Quoted 7 lines

While at it, fix the coding style (space around *).
Signed-off-by Sachin Kamat <[email protected]>
Signed-off-by Tushar Behera <[email protected]>
---
 arch/arm/mach-exynos/firmware.c |    9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

Fixes ODROID-XU (Exynos5410) as well - thought it had been a prereq to applying the 5410 patches...

Tested-by Andreas F?rber <[email protected]>

Regards,
Andreas

Signature · 2 lines

SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg

Kukjin Kim

2014-05-30 18:42 UTC #4 lore raw

PATCH RESEND v2 1/2 ARM: EXYNOS: Update secondary boot addr for secure mode

Quoted 15 lines · Andreas F?rber

Am 28.05.2014 06:13, schrieb Sachin Kamat:
Quoted 6 lines
Almost all Exynos-series of SoCs that run in secure mode don't need additional offset for every CPU, with Exynos4412 being the only exception.
Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).
Quoted 7 lines
While at it, fix the coding style (space around *).
Signed-off-by Sachin Kamat<[email protected]>
Signed-off-by Tushar Behera<[email protected]>
---
  arch/arm/mach-exynos/firmware.c |    9 +++++++--
  1 file changed, 7 insertions(+), 2 deletions(-)

Quoted 5 lines

Fixes ODROID-XU (Exynos5410) as well - thought it had been a prereq to applying the 5410 patches...
Tested-by Andreas F?rber<[email protected]>

Andreas, thanks for your test :-)

Sachin, How about exynos4210, 5250, 5260 and 5440?...
I need to check again, honestly I don't remember all of Exynos SoCs' different things ;-) Then will apply into fixes for 3.16.

Thanks,
Kukjin

Tomasz Figa

2014-05-30 18:47 UTC #5 lore raw

PATCH RESEND v2 1/2 ARM: EXYNOS: Update secondary boot addr for secure mode

Quoted 19 lines · Kukjin Kim

Quoted 18 lines · Andreas F?rber
Am 28.05.2014 06:13, schrieb Sachin Kamat:
Quoted 6 lines
Almost all Exynos-series of SoCs that run in secure mode don't need additional offset for every CPU, with Exynos4412 being the only exception.
Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).
Quoted 7 lines
While at it, fix the coding style (space around *).
Signed-off-by Sachin Kamat<[email protected]>
Signed-off-by Tushar Behera<[email protected]>
---
  arch/arm/mach-exynos/firmware.c |    9 +++++++--
  1 file changed, 7 insertions(+), 2 deletions(-)
Fixes ODROID-XU (Exynos5410) as well - thought it had been a prereq to applying the 5410 patches...

Quoted 7 lines

Quoted 2 lines
Tested-by Andreas F?rber<[email protected]>
Andreas, thanks for your test :-)
Sachin, How about exynos4210, 5250, 5260 and 5440?...
I need to check again, honestly I don't remember all of Exynos SoCs' different things ;-) Then will apply into fixes for 3.16.

Exynos4210 doesn't use secure firmware, at least on any board supported in mainline. Not sure about those Exynos5 models, but the only boards supported in mainline with firmware node in DT are based on Exynos4412 or Exynos5410.

Best regards,
Tomasz

Tushar Behera

2014-06-25 10:47 UTC #6 lore raw

PATCH RESEND v2 1/2 ARM: EXYNOS: Update secondary boot addr for secure mode

Quoted 28 lines · Tomasz Figa

Quoted 19 lines · Kukjin Kim
Quoted 18 lines · Andreas F?rber
Am 28.05.2014 06:13, schrieb Sachin Kamat:
Quoted 6 lines
Almost all Exynos-series of SoCs that run in secure mode don't need additional offset for every CPU, with Exynos4412 being the only exception.
Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).
Quoted 7 lines
While at it, fix the coding style (space around *).
Signed-off-by Sachin Kamat<[email protected]>
Signed-off-by Tushar Behera<[email protected]>
---
  arch/arm/mach-exynos/firmware.c |    9 +++++++--
  1 file changed, 7 insertions(+), 2 deletions(-)
Fixes ODROID-XU (Exynos5410) as well - thought it had been a prereq to applying the 5410 patches...
Quoted 7 lines
Quoted 2 lines
Tested-by Andreas F?rber<[email protected]>
Andreas, thanks for your test :-)
Sachin, How about exynos4210, 5250, 5260 and 5440?...
I need to check again, honestly I don't remember all of Exynos SoCs' different things ;-) Then will apply into fixes for 3.16.

Quoted 8 lines

Exynos4210 doesn't use secure firmware, at least on any board supported in mainline. Not sure about those Exynos5 models, but the only boards supported in mainline with firmware node in DT are based on Exynos4412 or Exynos5410.
Best regards,
Tomasz

Kukjin,

Would you please pick this patch as a fix for 3.16?

Signature · 1 line

Tushar Behera

Sachin Kamat

2014-06-13 16:25 UTC #7 lore raw

PATCH RESEND v2 1/2 ARM: EXYNOS: Update secondary boot addr for secure mode

In reply to Kukjin Kim

Kukjin,

Quoted 22 lines · Kukjin Kim

Quoted 21 lines · Andreas F?rber
Am 28.05.2014 06:13, schrieb Sachin Kamat:
Quoted 7 lines
Almost all Exynos-series of SoCs that run in secure mode don't need additional offset for every CPU, with Exynos4412 being the only exception.
Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).
Quoted 7 lines
While at it, fix the coding style (space around *).
Signed-off-by Sachin Kamat<[email protected]>
Signed-off-by Tushar Behera<[email protected]>
---
  arch/arm/mach-exynos/firmware.c |    9 +++++++--
  1 file changed, 7 insertions(+), 2 deletions(-)
Fixes ODROID-XU (Exynos5410) as well - thought it had been a prereq to applying the 5410 patches...

Quoted 7 lines

Quoted 2 lines
Tested-by Andreas F?rber<[email protected]>
Andreas, thanks for your test :-)
Sachin, How about exynos4210, 5250, 5260 and 5440?...
I need to check again, honestly I don't remember all of Exynos SoCs' different things ;-) Then will apply into fixes for 3.16.

ping..

--
Regards,
Sachin.

Sachin Kamat

2014-06-23 04:33 UTC #8 lore raw

PATCH RESEND v2 1/2 ARM: EXYNOS: Update secondary boot addr for secure mode

In reply to Andreas Färber

Quoted 15 lines · Andreas F?rber

Am 28.05.2014 06:13, schrieb Sachin Kamat:
Quoted 6 lines
Almost all Exynos-series of SoCs that run in secure mode don't need additional offset for every CPU, with Exynos4412 being the only exception.
Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).
Quoted 7 lines
While at it, fix the coding style (space around *).
Signed-off-by Sachin Kamat <[email protected]>
Signed-off-by Tushar Behera <[email protected]>
---
 arch/arm/mach-exynos/firmware.c |    9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

Quoted 5 lines

Fixes ODROID-XU (Exynos5410) as well - thought it had been a prereq to applying the 5410 patches...
Tested-by Andreas F?rber <[email protected]>

Kukjin, this patch is required to bring up 4 A15 cores on some 5410 and 5420 based
boards. Can you please queue this up for the upcoming rc as fixes?

Kukjin Kim

2014-06-25 11:43 UTC #9 lore raw

PATCH RESEND v2 1/2 ARM: EXYNOS: Update secondary boot addr for secure mode

Quoted 20 lines · Sachin Kamat

Quoted 18 lines · Andreas F?rber
Am 28.05.2014 06:13, schrieb Sachin Kamat:
Quoted 6 lines
Almost all Exynos-series of SoCs that run in secure mode don't need additional offset for every CPU, with Exynos4412 being the only exception.
Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).
Quoted 7 lines
While at it, fix the coding style (space around *).
Signed-off-by Sachin Kamat <[email protected]>
Signed-off-by Tushar Behera <[email protected]>
---
 arch/arm/mach-exynos/firmware.c |    9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
Fixes ODROID-XU (Exynos5410) as well - thought it had been a prereq to applying the 5410 patches...

Quoted 6 lines

Quoted 2 lines
Tested-by Andreas F?rber <[email protected]>
Kukjin, this patch is required to bring up 4 A15 cores on some 5410 and 5420 based
boards. Can you please queue this up for the upcoming rc as fixes?

Sure, I will take this into fixes.

Thanks,
Kukjin

Andreas Färber

2014-06-25 11:54 UTC #10 lore raw

PATCH RESEND v2 1/2 ARM: EXYNOS: Update secondary boot addr for secure mode

Am 25.06.2014 13:43, schrieb Kukjin Kim:

Quoted 18 lines

Quoted 17 lines · Sachin Kamat
Quoted 15 lines · Andreas F?rber
Am 28.05.2014 06:13, schrieb Sachin Kamat:
Quoted 13 lines
Almost all Exynos-series of SoCs that run in secure mode don't need additional offset for every CPU, with Exynos4412 being the only exception.
Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).
While at it, fix the coding style (space around *).
Signed-off-by Sachin Kamat <[email protected]>
Signed-off-by Tushar Behera <[email protected]>
---
 arch/arm/mach-exynos/firmware.c |    9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

Quoted 4 lines

Quoted 4 lines
Quoted 4 lines
Fixes ODROID-XU (Exynos5410) as well - thought it had been a prereq to applying the 5410 patches...
Tested-by Andreas F?rber <[email protected]>

FWIW meanwhile I also successfully tested it on 5420 based Arndale Octa.

I can also check on 5250 based Spring, now that it's working, if that helps build confidence in the patch.

Cheers,
Andreas

Quoted 8 lines

Quoted 3 lines
Kukjin, this patch is required to bring up 4 A15 cores on some 5410 and 5420 based
boards. Can you please queue this up for the upcoming rc as fixes?
Sure, I will take this into fixes.
Thanks,
Kukjin

Signature · 2 lines

SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg

Sachin Kamat

2014-07-05 14:53 UTC #11 lore raw

PATCH RESEND v2 1/2 ARM: EXYNOS: Update secondary boot addr for secure mode

In reply to Kukjin Kim

Quoted 21 lines · Kukjin Kim

Quoted 20 lines · Sachin Kamat
Quoted 18 lines · Andreas F?rber
Am 28.05.2014 06:13, schrieb Sachin Kamat:
Quoted 6 lines
Almost all Exynos-series of SoCs that run in secure mode don't need additional offset for every CPU, with Exynos4412 being the only exception.
Tested on Origen-Quad (Exynos4412) and Arndale-Octa (Exynos5420).
Quoted 7 lines
While at it, fix the coding style (space around *).
Signed-off-by Sachin Kamat <[email protected]>
Signed-off-by Tushar Behera <[email protected]>
---
 arch/arm/mach-exynos/firmware.c |    9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
Fixes ODROID-XU (Exynos5410) as well - thought it had been a prereq to applying the 5410 patches...

Quoted 8 lines

Quoted 6 lines
Quoted 2 lines
Tested-by Andreas F?rber <[email protected]>
Kukjin, this patch is required to bring up 4 A15 cores on some 5410 and 5420 based
boards. Can you please queue this up for the upcoming rc as fixes?
Sure, I will take this into fixes.

Kukjin,

I don't see this patch in your fixes-2 branch yet.

Quoted 4 lines

Thanks,
Kukjin

Regards,
Sachin.