Skip to contentSkip to conversation

tam3517: fix NAND detection

PATCH In review Jeroen Hofstee 4 participants 5 messages May 31, 2014 – Jun 6, 2014

lore
Share & tools
lore

Jeroen Hofstee

author
#0 lore raw

PATCH 1/1 tam3517: fix NAND detection

commit a0a37183bd7 "ARM: omap: merge GPMC initialization code for all platform" needs CONFIG_NOR, CONFIG_NAND or CONFIG_CMD_ONENAND to be set to access flash. Add CONFIG_NAND for tam3517 derived boards to prevent the following error: "nand: error: Unable to find NAND settings in GPMC Configuration - quitting"

cc Stefano Babic <[email protected]>
Signed-off-by Jeroen Hofstee <[email protected]>
---
 include/configs/tam3517-common.h | 1 +
 1 file changed, 1 insertion(+)
include/configs/tam3517-common.h +1 -0
index 3522c1a..bd117d5 100644
@@ -185,6 +185,7 @@
 /* Configure the PISMO */
 #define PISMO1_NAND_SIZE		GPMC_SIZE_128M
 
+#define CONFIG_NAND
 #define CONFIG_NAND_OMAP_GPMC
 #define CONFIG_ENV_IS_IN_NAND
 #define SMNAND_ENV_OFFSET		0x180000 /* environment starts here */
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 tam3517: fix NAND detection

Quoted 19 lines

From: Jeroen Hofstee

commit a0a37183bd7 "ARM: omap: merge GPMC initialization code for all platform" needs CONFIG_NOR, CONFIG_NAND or CONFIG_CMD_ONENAND to be set to access flash. Add CONFIG_NAND for tam3517 derived boards to prevent the following error: "nand: error: Unable to find NAND settings in GPMC Configuration - quitting"

cc Stefano Babic <[email protected]>
Signed-off-by Jeroen Hofstee <[email protected]>

---
include/configs/tam3517-common.h | 1 +

1 file changed, 1 insertion(+)
include/configs/tam3517-common.h +0 -0
index 3522c1a..bd117d5 100644

include/configs/tam3517-common.h line 188

Quoted 4 lines
include/configs/tam3517-common.h +1 -0
@@ -185,6 +185,7 @@
 /* Configure the PISMO */
 #define PISMO1_NAND_SIZE		GPMC_SIZE_128M
 
+#define CONFIG_NAND

You should not add CONFIG_NAND directly to include/configs/... instead this should come from board profiles defined in boards.cfg refer am335x_evm or description given in header of boards.cfg

with regards, pekon

#2 lore raw

PATCH 1/1 tam3517: fix NAND detection

Hi Gupta,

Quoted 22 lines · Pekon
Quoted 22 lines

From: Jeroen Hofstee

commit a0a37183bd7 "ARM: omap: merge GPMC initialization code for all platform" needs CONFIG_NOR, CONFIG_NAND or CONFIG_CMD_ONENAND to be set to access flash. Add CONFIG_NAND for tam3517 derived boards to prevent the following error: "nand: error: Unable to find NAND settings in GPMC Configuration - quitting"

cc Stefano Babic <[email protected]>
Signed-off-by Jeroen Hofstee <[email protected]>

---
include/configs/tam3517-common.h | 1 +

1 file changed, 1 insertion(+)
include/configs/tam3517-common.h +0 -0
index 3522c1a..bd117d5 100644
@@ -185,6 +185,7 @@
 /* Configure the PISMO */
 #define PISMO1_NAND_SIZE		GPMC_SIZE_128M
Quoted 6 lines

include/configs/tam3517-common.h line 188

Quoted 1 line
include/configs/tam3517-common.h +1 -0
+#define CONFIG_NAND

You should not add CONFIG_NAND directly to include/configs/... instead this should come from board profiles defined in boards.cfg refer am335x_evm or description given in header of boards.cfg

But TAM3517 is a SOM and it has always NAND. It is slightly different as the am335x_evm. All boards using this SOM are then affected by this problem, and fixing it in the SOM configuration file let us to make a global fix for all boards, instead of adding CONFIG_NAND for each single profile in boards.cfg.

Best regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#3 lore raw

PATCH 1/1 tam3517: fix NAND detection

Quoted 1 line

From: Stefano Babic [mailto:sbabic at denx.de]

[...]

Quoted 15 lines
Quoted 8 lines
Quoted 8 lines
include/configs/tam3517-common.h +0 -0
index 3522c1a..bd117d5 100644
@@ -185,6 +185,7 @@
 /* Configure the PISMO */
 #define PISMO1_NAND_SIZE		GPMC_SIZE_128M
Quoted 6 lines

include/configs/tam3517-common.h line 188

Quoted 1 line
include/configs/tam3517-common.h +1 -0
+#define CONFIG_NAND

You should not add CONFIG_NAND directly to include/configs/... instead this should come from board profiles defined in boards.cfg refer am335x_evm or description given in header of boards.cfg

Quoted 6 lines

But TAM3517 is a SOM and it has always NAND. It is slightly different as the am335x_evm. All boards using this SOM are then affected by this problem, and fixing it in the SOM configuration file let us to make a global fix for all boards, instead of adding CONFIG_NAND for each single profile in boards.cfg.

Oh sorry, yes I forgot it?s a OMAP3 variant (same family).
So this can also be added to include/configs/ti_omap3_common.h
But as you are not re-using that config file, please proceed with above change.

with regards, pekon

#4 lore raw
In reply to Jeroen Hofstee
Quoted 8 lines · Jeroen Hofstee

commit a0a37183bd7 "ARM: omap: merge GPMC initialization code for all platform" needs CONFIG_NOR, CONFIG_NAND or CONFIG_CMD_ONENAND to be set to access flash. Add CONFIG_NAND for tam3517 derived boards to prevent the following error: "nand: error: Unable to find NAND settings in GPMC Configuration - quitting"

cc Stefano Babic <[email protected]>
Signed-off-by Jeroen Hofstee <[email protected]>

Applied to u-boot-ti/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140606/08e6fe72/attachment.pgp>