Skip to contentSkip to conversation

extcon next-v2 for v3.16

GIT PULL Chanwoo Choi 2 participants 5 messages Jun 2, 2014 – Jun 3, 2014

lore
Share & tools
lore
#0 lore raw

Dear Greg,

This is extcon-next-v2 full request for v3.16. This pull request includes additional patchset after merged previous extcon-next pull request(tags/extcon-next-for-v3.16). I add detailed description of this pull request on below. Please pull extcon with following update.

Best Regards,
Chanwoo Choi

The following changes since commit 3f79a3fb5f41e8f2229e5bf8aa725eaa79686f14:

extcon: palmas: Use devm_extcon_dev_allocate for extcon_dev (2014-04-29 09:52:12 +0900)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git tags/extcon-next-v2-for-3.16

for you to fetch changes up to 19c27d2fe7773f07ed53126f04ff9d7d62f64672:

extcon: sm5502: Change internal hardware switch according to cable type (2014-06-02 09:28:34 +0900)

----------------------------------------------------------------
Update extcon for v3.16

This patchset add new extcon provider driver and fix minor issue of extcon driver.

Detailed description for patchset:
1. Add new Silicon-Mitus SM5502 MUIC (Micro-USB Interface Controller) device
- extcon-sm5502 driver is capable of identifying the type of the external power source and attached accessory. And external power sources, such as Dedicated charger or a standard USB port, are able to charge the battery in the smart phone via the connector.

2. Fix minor issue of extcon driver
- extcon-arizona driver
- extcon-palmas driver

3. Fix minor issue of extcon core
- Re-order the sequence of extcon device driver in Kconfig/Makefile alphabitically
- Set parent device of extcon device automatically using devm_extcon_dev_allocate()

----------------------------------------------------------------
Chanwoo Choi (5):
extcon: Reorder the sequence of extcon device driver alphabetically
extcon: Set parent device of extcon device using prameter of devm_extcon_dev_allocate
extcon: sm5502: Add support new SM5502 extcon device driver
extcon: sm5502: Detect cable state after completing platform booting
extcon: sm5502: Change internal hardware switch according to cable type

Charles Keepax (3):
extcon: arizona: Remove duplicate set of input parent device
extcon: arizona: Correct typo to disable regulation for button detection
extcon: arizona: Update manual headphone detection calculation

Krzysztof Kozlowski (1):
extcon: palmas: Make of_device_id array const

Nikesh Oswal (1):
extcon: arizona: Use extcon cable API with index of extcon cable instead of string

Richard Fitzgerald (1):
extcon: arizona: support inverted jack detect switch

 drivers/extcon/Kconfig            |  35 +-
 drivers/extcon/Makefile           |   7 +-
 drivers/extcon/extcon-adc-jack.c  |   1 -
 drivers/extcon/extcon-arizona.c   |  68 ++--
 drivers/extcon/extcon-class.c     |   2 +
 drivers/extcon/extcon-gpio.c      |   1 -
 drivers/extcon/extcon-max77693.c  |   1 -
 drivers/extcon/extcon-max8997.c   |   1 -
 drivers/extcon/extcon-palmas.c    |   3 +-
 drivers/extcon/extcon-sm5502.c    | 726 ++++++++++++++++++++++++++++++++++++++
 include/linux/extcon/sm5502.h     | 287 +++++++++++++++
 include/linux/mfd/arizona/pdata.h |   3 +
 12 files changed, 1087 insertions(+), 48 deletions(-)
 create mode 100644 drivers/extcon/extcon-sm5502.c
 create mode 100644 include/linux/extcon/sm5502.h
#1 lore raw
Quoted 9 lines · Chanwoo Choi

Dear Greg,

This is extcon-next-v2 full request for v3.16. This pull request includes additional patchset after merged previous extcon-next pull request(tags/extcon-next-for-v3.16). I add detailed description of this pull request on below. Please pull extcon with following update.

Best Regards,
Chanwoo Choi

Quoted 7 lines

The following changes since commit 3f79a3fb5f41e8f2229e5bf8aa725eaa79686f14:

extcon: palmas: Use devm_extcon_dev_allocate for extcon_dev (2014-04-29 09:52:12 +0900)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git tags/extcon-next-v2-for-3.16

I was thinking it was too late for 3.16-rc1, as the merge window is now open and I like to have things in my tree a week or so before that happens, but I figured this was nice and self-contained so I would take it.

So I pulled, and built, and then got this:

ERROR: "regmap_irq_get_virq" [drivers/extcon/extcon-sm5502.ko] undefined!
ERROR: "regmap_add_irq_chip" [drivers/extcon/extcon-sm5502.ko] undefined!
ERROR: "regmap_del_irq_chip" [drivers/extcon/extcon-sm5502.ko] undefined!

which makes me know that you haven't done much build testing of the code :(

So I can't take this now, sorry, please fix it up and make it ready for 3.17. If you have bugfixes for 3.16, feel free to send them in a separate pull request...

thanks,

greg k-h

#2 lore raw

Dear Greg,

Quoted 14 lines · Greg KH
Quoted 13 lines · Chanwoo Choi

Dear Greg,

This is extcon-next-v2 full request for v3.16. This pull request includes additional patchset after merged previous extcon-next pull request(tags/extcon-next-for-v3.16). I add detailed description of this pull request on below. Please pull extcon with following update.

Best Regards,
Chanwoo Choi

The following changes since commit 3f79a3fb5f41e8f2229e5bf8aa725eaa79686f14:

extcon: palmas: Use devm_extcon_dev_allocate for extcon_dev (2014-04-29 09:52:12 +0900)

Quoted 8 lines
Quoted 3 lines

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git tags/extcon-next-v2-for-3.16

I was thinking it was too late for 3.16-rc1, as the merge window is now open and I like to have things in my tree a week or so before that happens, but I figured this was nice and self-contained so I would take it.

Sorry late pull-request. I'll send next pull-request before -rc7 release certainly.

Quoted 9 lines

So I pulled, and built, and then got this:

ERROR: "regmap_irq_get_virq" [drivers/extcon/extcon-sm5502.ko] undefined!
ERROR: "regmap_add_irq_chip" [drivers/extcon/extcon-sm5502.ko] undefined!
ERROR: "regmap_del_irq_chip" [drivers/extcon/extcon-sm5502.ko] undefined!

which makes me know that you haven't done much build testing of the code :(

Sorry about this mistake. As you comment, I'll check much build testing.

Quoted 4 lines

So I can't take this now, sorry, please fix it up and make it ready for 3.17. If you have bugfixes for 3.16, feel free to send them in a separate pull request...

OK, I'll fix it and send pull-requesst for 3.17.
Thanks for your comment.

Best Regards,
Chanwoo Choi

#3 lore raw
Quoted 31 lines · Chanwoo Choi

Dear Greg,

Quoted 14 lines · Greg KH
Quoted 13 lines · Chanwoo Choi

Dear Greg,

This is extcon-next-v2 full request for v3.16. This pull request includes additional patchset after merged previous extcon-next pull request(tags/extcon-next-for-v3.16). I add detailed description of this pull request on below. Please pull extcon with following update.

Best Regards,
Chanwoo Choi

The following changes since commit 3f79a3fb5f41e8f2229e5bf8aa725eaa79686f14:

extcon: palmas: Use devm_extcon_dev_allocate for extcon_dev (2014-04-29 09:52:12 +0900)

Quoted 8 lines
Quoted 3 lines

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git tags/extcon-next-v2-for-3.16

I was thinking it was too late for 3.16-rc1, as the merge window is now open and I like to have things in my tree a week or so before that happens, but I figured this was nice and self-contained so I would take it.

Sorry late pull-request. I'll send next pull-request before -rc7 release certainly.

Quoted 3 lines

So I pulled, and built, and then got this:

Quoted 8 lines
Quoted 6 lines

ERROR: "regmap_irq_get_virq" [drivers/extcon/extcon-sm5502.ko] undefined!
ERROR: "regmap_add_irq_chip" [drivers/extcon/extcon-sm5502.ko] undefined!
ERROR: "regmap_del_irq_chip" [drivers/extcon/extcon-sm5502.ko] undefined!

which makes me know that you haven't done much build testing of the code :(

Sorry about this mistake. As you comment, I'll check much build testing.

Any reason your trees are not in linux-next? I'd recommend them to be there, so you can get that build testing ahead-of-time.

thanks,

greg k-h

#4 lore raw
Quoted 36 lines · Greg KH
Quoted 35 lines · Chanwoo Choi

Dear Greg,

Quoted 14 lines · Greg KH
Quoted 13 lines · Chanwoo Choi

Dear Greg,

This is extcon-next-v2 full request for v3.16. This pull request includes additional patchset after merged previous extcon-next pull request(tags/extcon-next-for-v3.16). I add detailed description of this pull request on below. Please pull extcon with following update.

Best Regards,
Chanwoo Choi

The following changes since commit 3f79a3fb5f41e8f2229e5bf8aa725eaa79686f14:

extcon: palmas: Use devm_extcon_dev_allocate for extcon_dev (2014-04-29 09:52:12 +0900)

Quoted 8 lines
Quoted 3 lines

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git tags/extcon-next-v2-for-3.16

I was thinking it was too late for 3.16-rc1, as the merge window is now open and I like to have things in my tree a week or so before that happens, but I figured this was nice and self-contained so I would take it.

Sorry late pull-request. I'll send next pull-request before -rc7 release certainly.

Quoted 7 lines

So I pulled, and built, and then got this:

ERROR: "regmap_irq_get_virq" [drivers/extcon/extcon-sm5502.ko] undefined!
ERROR: "regmap_add_irq_chip" [drivers/extcon/extcon-sm5502.ko] undefined!
ERROR: "regmap_del_irq_chip" [drivers/extcon/extcon-sm5502.ko] undefined!

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

which makes me know that you haven't done much build testing of the code :(

Sorry about this mistake. As you comment, I'll check much build testing.

Any reason your trees are not in linux-next? I'd recommend them to be there, so you can get that build testing ahead-of-time.

As you comment, I'm going to find the way to include extcon patchset for build test in linux-next.

Best Regards,
Chanwoo Choi