Skip to contentSkip to conversation

net: driver: smsc: set NOCARRIER flag in dev at driver initialization

PATCH Applied Balakumaran Kannan 2 participants 2 messages Jun 3, 2014 – Jun 4, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 net: driver: smsc: set NOCARRIER flag in dev at driver initialization

As smsc driver supports carrier detection, it should unset NOCARRIER flag only after carrier state determination. By default that flag is off so driver should set it before starting auto-negotiation

---
 drivers/net/ethernet/smsc/smsc911x.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/ethernet/smsc/smsc911x.c +2 -0
index a0fc151..5e13fa5 100644
@@ -2477,6 +2477,8 @@ static int smsc911x_drv_probe(struct platform_device *pdev)
 		goto out_disable_resources;
 	}
 
+	netif_carrier_off(dev);
+
 	retval = register_netdev(dev);
 	if (retval) {
 		SMSC_WARN(pdata, probe, "Error %i registering device", retval);
Signature · 1 line
1.8.2.1
maintainer Applied
#1 lore raw

From: Balakumaran Kannan <[email protected]>
Date: Tue, 03 Jun 2014 22:13:48 +0530

Quoted 5 lines

As smsc driver supports carrier detection, it should unset NOCARRIER flag only after carrier state determination. By default that flag is off so driver should set it before starting auto-negotiation

Applied, thanks.