t9001: avoid not portable '\n' with sed

t9001 used a '\n' in a sed expression to split one line into two lines. Some versions of sed simply ignore the '\' before the 'n', treating '\n' as 'n'.

As the test already requires perl as a prerequisite, use perl instead of sed.

Signed-off-by Torsten Bögershausen <[email protected]>

---

Quoted 8 lines · Torsten Bögershausen

t9001 used a '\n' in a sed expression to split one line into two lines. Some versions of sed simply ignore the '\' before the 'n', treating '\n' as 'n'.

As the test already requires perl as a prerequisite, use perl instead of sed.

Signed-off-by Torsten Bögershausen <[email protected]>

---

Hmph. I read this in pubs.opengroup.org/onlinepubs/9699919799/utilities/sed.html

The escape sequence '\n' shall match a <newline> embedded in the pattern space.

so it may be better to be a bit more explicit in the log message to say whose implementation has this issue to warn people.

t/t9001-send-email.sh test_cover_addresses () { · line 1345

Quoted 2 lines

t/t9001-send-email.sh +1 -1

-	sed "s/^From:/$header: [email protected]\nFrom:/" cover-to-edit.patch >"$cover" &&
+	"$PERL_PATH" -pe "s/^From:/$header: extra\@address.com\nFrom:/" cover-to-edit.patch | tr Q "$LF" >"$cover" &&

So the portable way to do it is:

	sed "s/^From:/$header: [email protected]\

From:/" cover-to-edit.patch >"$cover" &&

Note that quoted section of POSIX says "embedded in the pattern space"; under the description of the "s" command, it says:

The replacement string shall be scanned from beginning to end. [...]
The meaning of a <backslash> immediately followed by any character other than '&', <backslash>, a digit, or the delimiter character used for this command, is unspecified.

Quoted 8 lines · Torsten Bögershausen

t9001 used a '\n' in a sed expression to split one line into two lines. Some versions of sed simply ignore the '\' before the 'n', treating '\n' as 'n'.

As the test already requires perl as a prerequisite, use perl instead of sed.

Signed-off-by Torsten Bögershausen <[email protected]>

---

Hmph. I read this in pubs.opengroup.org/onlinepubs/9699919799/utilities/sed.html

The escape sequence '\n' shall match a <newline> embedded in the pattern space.

so it may be better to be a bit more explicit in the log message to say whose implementation has this issue to warn people.

Quoted 8 lines · Torsten Bögershausen

t9001 used a '\n' in a sed expression to split one line into two lines. Some versions of sed simply ignore the '\' before the 'n', treating '\n' as 'n'.

As the test already requires perl as a prerequisite, use perl instead of sed.

Signed-off-by Torsten Bögershausen <[email protected]>

---

Hmph. I read this in pubs.opengroup.org/onlinepubs/9699919799/utilities/sed.html

The escape sequence '\n' shall match a <newline> embedded in the pattern space.

so it may be better to be a bit more explicit in the log message to say whose implementation has this issue to warn people.

Quoted 3 lines

 t/t9001-send-email.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

t/t9001-send-email.sh test_cover_addresses () { · line 1345

Quoted 10 lines

t/t9001-send-email.sh +1 -1

index 64d9434..2bf48d1 100755
@@ -1342,7 +1342,7 @@ test_cover_addresses () {
 	git format-patch --cover-letter -2 -o outdir &&
 	cover=`echo outdir/0000-*.patch` &&
 	mv $cover cover-to-edit.patch &&
-	sed "s/^From:/$header: [email protected]\nFrom:/" cover-to-edit.patch >"$cover" &&
+	"$PERL_PATH" -pe "s/^From:/$header: extra\@address.com\nFrom:/" cover-to-edit.patch | tr Q "$LF" >"$cover" &&

We have a shell function "perl" in test-lib-function.sh these days so that you do not have to write "$PERL_PATH" yourself in tests ;-)

Quoted 22 lines · Junio C Hamano

Quoted 8 lines · Torsten Bögershausen

t9001 used a '\n' in a sed expression to split one line into two lines. Some versions of sed simply ignore the '\' before the 'n', treating '\n' as 'n'.

As the test already requires perl as a prerequisite, use perl instead of sed.

Signed-off-by Torsten Bögershausen <[email protected]>

---

Hmph. I read this in pubs.opengroup.org/onlinepubs/9699919799/utilities/sed.html

The escape sequence '\n' shall match a <newline> embedded in the pattern space.

so it may be better to be a bit more explicit in the log message to say whose implementation has this issue to warn people.

Quoted 3 lines

 t/t9001-send-email.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Quoted 13 lines

t/t9001-send-email.sh test_cover_addresses () { · line 1345

Quoted 10 lines

t/t9001-send-email.sh +1 -1

index 64d9434..2bf48d1 100755
@@ -1342,7 +1342,7 @@ test_cover_addresses () {
 	git format-patch --cover-letter -2 -o outdir &&
 	cover=`echo outdir/0000-*.patch` &&
 	mv $cover cover-to-edit.patch &&
-	sed "s/^From:/$header: [email protected]\nFrom:/" cover-to-edit.patch >"$cover" &&
+	"$PERL_PATH" -pe "s/^From:/$header: extra\@address.com\nFrom:/" cover-to-edit.patch | tr Q "$LF" >"$cover" &&

We have a shell function "perl" in test-lib-function.sh these days so that you do not have to write "$PERL_PATH" yourself in tests ;-)

Also, piping output from perl to tr feels somewhat suboptimal. I do not see where in the test material we use "Q to LF", and we may want to remove that altogether, but without that removal, an updated patch may look like this.

 t/t9001-send-email.sh | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

t/t9001-send-email.sh +0 -0

index 64d9434..9f06b8c 100755
@@ -1342,7 +1342,10 @@ test_cover_addresses () {
 	git format-patch --cover-letter -2 -o outdir &&

In default operation, sed cyclically shall append a line of input, less its terminating <newline> >character, into the pattern space....