Skip to contentSkip to conversation

be2iscsi: add an missing goto in error path

PATCH In review Tomas Henzl 3 participants 3 messages Jun 6, 2014

Subsystems (2)
SCSI Emulex 10Gbps iSCSI - OneConnect driver
lore
Share & tools
lore

Tomas Henzl

author
#0 lore raw

PATCH 1/1 be2iscsi: add an missing goto in error path

a jump to 'free_memory' is apparently missing

Signed-off-by Tomas Henzl <[email protected]>

---

drivers/scsi/be2iscsi/be_main.c +2 -0
index ac54cf5..442982d 100644
@@ -4209,6 +4209,8 @@ static int hba_setup_cid_tbls(struct beiscsi_hba *phba)
 		kfree(phba->ep_array);
 		phba->ep_array = NULL;
 		ret = -ENOMEM;
+
+		goto free_memory;
 	}
 
 	for (i = 0; i < phba->params.cxns_per_ctrl; i++) {
Signature · 1 line
1.8.3.1
Reviewed-by on v1 1/1
#2 lore raw
In reply to Tomas Henzl
Quoted 17 lines · Tomas Henzl

a jump to 'free_memory' is apparently missing

Signed-off-by Tomas Henzl <[email protected]>

---

drivers/scsi/be2iscsi/be_main.c +2 -0
index ac54cf5..442982d 100644
@@ -4209,6 +4209,8 @@ static int hba_setup_cid_tbls(struct beiscsi_hba *phba)
 		kfree(phba->ep_array);
 		phba->ep_array = NULL;
 		ret = -ENOMEM;
+
+		goto free_memory;
 	}
 
 	for (i = 0; i < phba->params.cxns_per_ctrl; i++) {
Quoted 1 line

—

Thanks.

Reviewed-by Mike Christie <[email protected]>

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html