Skip to contentSkip to conversation

drivers: Kconfig: Add HAS_IOMEM dependency for allmodconfig under score architecture

PATCH In review Chen Gang 2 participants 3 messages Jun 10, 2014 – Jun 11, 2014

Subsystems (3)
Linux-next tree HID Generic PHY framework
lore
Share & tools
lore

Chen Gang

author
#0 lore raw

PATCH 1/1 drivers: Kconfig: Add HAS_IOMEM dependency for allmodconfig under score architecture

When NO_IOMEM is enabled (e.g. score architecture), some drivers which need HAS_IOMEM need notice about it, or it will report related warning:

  scripts/kconfig/conf --allmodconfig Kconfig
  kernel/time/Kconfig:162:warning: range is invalid
  warning: (PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE && S3C2410_WATCHDOG && VIDEO_S5P_FIMC && PHY_SAMSUNG_USB2) selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)
  warning: (GPIO_SCH && GPIO_ICH && GPIO_VX855 && GPIO_RDC321X && IE6XX_WDT && RADIO_WL1273 && HID_SENSOR_HUB && MFD_NVEC) selects MFD_CORE which has unmet direct dependencies (HAS_IOMEM)
Signed-off-by Chen Gang <[email protected]>
---
 drivers/hid/Kconfig | 2 +-
 drivers/phy/Kconfig | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
drivers/hid/Kconfig +1 -1
index 800c8b6..5e79c6a 100644
@@ -810,7 +810,7 @@ config HID_ZYDACRON
 
 config HID_SENSOR_HUB
 	tristate "HID Sensors framework support"
-	depends on HID
+	depends on HID && HAS_IOMEM
 	select MFD_CORE
 	default n
 	---help---
drivers/phy/Kconfig +1 -0
index 16a2f06..fcdfe7c 100644
@@ -122,6 +122,7 @@ config PHY_SUN4I_USB
 
 config PHY_SAMSUNG_USB2
 	tristate "Samsung USB 2.0 PHY driver"
+	depends on HAS_IOMEM
 	select GENERIC_PHY
 	select MFD_SYSCON
 	help
Signature · 1 line
1.9.2.459.g68773ac
author
#1 lore raw
Quoted 5 lines · Chen Gang

When NO_IOMEM is enabled (e.g. score architecture), some drivers which need HAS_IOMEM need notice about it, or it will report related warning:

  scripts/kconfig/conf --allmodconfig Kconfig
  kernel/time/Kconfig:162:warning: range is invalid
    ^

Oh, sorry, this line above need be removed, it is not for this patch, if still necessary to send patch v2 for it, please let me know, thanks.

Quoted 36 lines
  warning: (PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE && S3C2410_WATCHDOG && VIDEO_S5P_FIMC && PHY_SAMSUNG_USB2) selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)
  warning: (GPIO_SCH && GPIO_ICH && GPIO_VX855 && GPIO_RDC321X && IE6XX_WDT && RADIO_WL1273 && HID_SENSOR_HUB && MFD_NVEC) selects MFD_CORE which has unmet direct dependencies (HAS_IOMEM)
Signed-off-by Chen Gang <[email protected]>
---
 drivers/hid/Kconfig | 2 +-
 drivers/phy/Kconfig | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
drivers/hid/Kconfig +1 -1
index 800c8b6..5e79c6a 100644
@@ -810,7 +810,7 @@ config HID_ZYDACRON
 
 config HID_SENSOR_HUB
 	tristate "HID Sensors framework support"
-	depends on HID
+	depends on HID && HAS_IOMEM
 	select MFD_CORE
 	default n
 	---help---
drivers/phy/Kconfig +1 -0
index 16a2f06..fcdfe7c 100644
@@ -122,6 +122,7 @@ config PHY_SUN4I_USB
 
 config PHY_SAMSUNG_USB2
 	tristate "Samsung USB 2.0 PHY driver"
+	depends on HAS_IOMEM
 	select GENERIC_PHY
 	select MFD_SYSCON
 	help
Signature · 3 lines
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
#2 lore raw
Quoted 8 lines · Chen Gang
Quoted 5 lines

When NO_IOMEM is enabled (e.g. score architecture), some drivers which need HAS_IOMEM need notice about it, or it will report related warning:

  scripts/kconfig/conf --allmodconfig Kconfig
  kernel/time/Kconfig:162:warning: range is invalid
    ^

Oh, sorry, this line above need be removed, it is not for this patch, if still necessary to send patch v2 for it, please let me know, thanks.

I have fixed it up (together with adding a proper subject) and applied.

Signature · 2 lines
Jiri Kosina
SUSE Labs