Skip to contentSkip to conversation

ARM: exynos: mark machine descriptor functions static

PATCH New Olof Johansson 2 participants 2 messages Jun 3, 2014 – Jun 10, 2014

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Samsung Exynos
lore
Share & tools
lore

Olof Johansson

author
#0 lore raw

PATCH 1/1 ARM: exynos: mark machine descriptor functions static

There's no reason to export these functions, and I have no idea why they have over time ended up in the header file. As a result, none of the checker tools caught it (i.e. sparse was silent on it).

Signed-off-by Olof Johansson <[email protected]>

---

I'm guessing with all the churn right now this might not apply, so it might need manual application around -rc1.

There's definitely room for more cleanup in common.h.

 arch/arm/mach-exynos/common.h |    6 ------
 arch/arm/mach-exynos/exynos.c |   10 +++++-----
 2 files changed, 5 insertions(+), 11 deletions(-)
arch/arm/mach-exynos/common.h +0 -6
index 5a3a1ec..0b0b6d5 100644
@@ -116,13 +116,7 @@ void mct_init(void __iomem *base, int irq_g0, int irq_l0, int irq_l1);
 struct map_desc;
 extern void __iomem *sysram_ns_base_addr;
 extern void __iomem *sysram_base_addr;
-void exynos_init_io(void);
-void exynos_restart(enum reboot_mode mode, const char *cmd);
 void exynos_sysram_init(void);
-void exynos_cpuidle_init(void);
-void exynos_cpufreq_init(void);
-void exynos_init_late(void);
-
 void exynos_firmware_init(void);
 
 #ifdef CONFIG_PINCTRL_EXYNOS
arch/arm/mach-exynos/exynos.c +5 -5
index 9183675..c4f9c3d 100644
@@ -146,7 +146,7 @@ static struct map_desc exynos5_iodesc[] __initdata = {
 	},
 };
 
-void exynos_restart(enum reboot_mode mode, const char *cmd)
+static void exynos_restart(enum reboot_mode mode, const char *cmd)
 {
 	struct device_node *np;
 	u32 val = 0x1;

@@ -174,7 +174,7 @@ static struct platform_device exynos_cpuidle = {
 	.id                = -1,
 };
 
-void __init exynos_cpuidle_init(void)
+static void __init exynos_cpuidle_init(void)
 {
 	if (soc_is_exynos5440())
 		return;

@@ -182,7 +182,7 @@ void __init exynos_cpuidle_init(void)
 	platform_device_register(&exynos_cpuidle);
 }
 
-void __init exynos_cpufreq_init(void)
+static void __init exynos_cpufreq_init(void)
 {
 	platform_device_register_simple("exynos-cpufreq", -1, NULL, 0);
 }

@@ -209,7 +209,7 @@ void __init exynos_sysram_init(void)
 	}
 }
 
-void __init exynos_init_late(void)
+static void __init exynos_init_late(void)
 {
 	if (of_machine_is_compatible("samsung,exynos5440"))
 		/* to be supported later */

@@ -256,7 +256,7 @@ static void __init exynos_map_io(void)
 		iotable_init(exynos5_iodesc, ARRAY_SIZE(exynos5_iodesc));
 }
 
-void __init exynos_init_io(void)
+static void __init exynos_init_io(void)
 {
 	debug_ll_io_init();
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 ARM: exynos: mark machine descriptor functions static

Hi Olof,

Quoted 7 lines · Olof Johansson

There's no reason to export these functions, and I have no idea why they have over time ended up in the header file. As a result, none of the checker tools caught it (i.e. sparse was silent on it).

Signed-off-by Olof Johansson <[email protected]>

---

Quoted 9 lines

I'm guessing with all the churn right now this might not apply, so it might need manual application around -rc1.

There's definitely room for more cleanup in common.h.

 arch/arm/mach-exynos/common.h |    6 ------
 arch/arm/mach-exynos/exynos.c |   10 +++++-----
 2 files changed, 5 insertions(+), 11 deletions(-)

Similar patch and few other clean-up patches were posted some time ago on the list as a part of PMU rework series, but somehow got missed. They can be applied independently from rest of the series which is still under discussion.

Best regards,
Tomasz