Skip to contentSkip to conversation

hw: vmware_vga: don't return cursorx when the driver asks for cursory register

PATCH In review mischief 2 participants 2 messages Jun 9, 2014 – Jun 10, 2014

lore
Share & tools
lore

mischief

author
#0 lore raw

PATCH 1/1 hw: vmware_vga: don't return cursorx when the driver asks for cursory register

hello qemu-*@nongnu.org, this is my first contribution. apologies if something is incorrect.

this patch fixes vmware_vga.c so that it actually returns the cursory register when asked for, instead of cursorx.

---
 hw/display/vmware_vga.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/display/vmware_vga.c +1 -1
index 9ba47e6..ab54b6f 100644
@@ -863,7 +863,7 @@ static uint32_t vmsvga_value_read(void *opaque, uint32_t address)
         break;
 
     case SVGA_REG_CURSOR_Y:
-        ret = s->cursor.x;
+        ret = s->cursor.y;
         break;
 
     case SVGA_REG_CURSOR_ON:
Signature · 1 line
2.0.0
#1 lore raw
Quoted 5 lines · mischief

hello qemu-*@nongnu.org, this is my first contribution. apologies if something is incorrect.

this patch fixes vmware_vga.c so that it actually returns the cursory register when asked for, instead of cursorx.

That's a good one. Thank you, applied to -trivial.

/mjt