mmc: sdhci-msm: Fix fallout from sdhci refactoring
Subsystems (3)
PATCH 1/1 mmc: sdhci-msm: Fix fallout from sdhci refactoring
The sdhci core was refactored recently and some of those refactorings required changes in every sdhci platform driver. Those updates happened around the same time as when the msm driver was merged so the refactorings missed the msm driver. Hook in the basic library functions so that we can boot apq8074 dragonboards again instead of crashing when we try to jump to NULL function pointers.
---
Patch based on next-20140610
drivers/mmc/host/sdhci-msm.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/mmc/host/sdhci-msm.c +4 -0
@@ -468,6 +468,10 @@ MODULE_DEVICE_TABLE(of, sdhci_msm_dt_match);static struct sdhci_ops sdhci_msm_ops = { .platform_execute_tuning = sdhci_msm_execute_tuning, + .reset = sdhci_reset, + .set_clock = sdhci_set_clock, + .set_bus_width = sdhci_set_bus_width, + .set_uhs_signaling = sdhci_set_uhs_signaling, };static int sdhci_msm_probe (struct platform_device *pdev)
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
Quoted 12 lines · Stephen Boyd
The sdhci core was refactored recently and some of those refactorings required changes in every sdhci platform driver. Those updates happened around the same time as when the msm driver was merged so the refactorings missed the msm driver. Hook in the basic library functions so that we can boot apq8074 dragonboards again instead of crashing when we try to jump to NULL function pointers.
Reported-by Kevin Hilman <[email protected]>Cc Georgi Djakov <[email protected]>Cc Russell King <[email protected]>Signed-off-by Stephen Boyd <[email protected]>
Quoted 6 lines
---
Patch based on next-20140610
drivers/mmc/host/sdhci-msm.c| 4 ++++1 file changed, 4 insertions(+)
Feel free to pick up this version of the patch and ignore mine.
- k
Signature · 2 lines
Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Quoted 8 lines · Stephen Boyd
The sdhci core was refactored recently and some of those refactorings required changes in every sdhci platform driver. Those updates happened around the same time as when the msm driver was merged so the refactorings missed the msm driver. Hook in the basic library functions so that we can boot apq8074 dragonboards again instead of crashing when we try to jump to NULL function pointers.
Quoted 4 lines
Reported-by Kevin Hilman <[email protected]>Cc Georgi Djakov <[email protected]>Cc Russell King <[email protected]>Signed-off-by Stephen Boyd <[email protected]>
Quoted 8 lines · Stephen Boyd
The sdhci core was refactored recently and some of those refactorings required changes in every sdhci platform driver. Those updates happened around the same time as when the msm driver was merged so the refactorings missed the msm driver. Hook in the basic library functions so that we can boot apq8074 dragonboards again instead of crashing when we try to jump to NULL function pointers.
Quoted 4 lines
Reported-by Kevin Hilman <[email protected]>Cc Georgi Djakov <[email protected]>Cc Russell King <[email protected]>Signed-off-by Stephen Boyd <[email protected]>
I verifed that this patch on top of next-20140610 gets the qcom dragonboard booting again.
Kevin
Quoted 8 lines · Stephen Boyd
The sdhci core was refactored recently and some of those refactorings required changes in every sdhci platform driver. Those updates happened around the same time as when the msm driver was merged so the refactorings missed the msm driver. Hook in the basic library functions so that we can boot apq8074 dragonboards again instead of crashing when we try to jump to NULL function pointers.
Quoted 4 lines
Reported-by Kevin Hilman <[email protected]>Cc Georgi Djakov <[email protected]>Cc Russell King <[email protected]>Signed-off-by Stephen Boyd <[email protected]>
Thanks!
Applied for fixes.
Kind regards
Uffe
Quoted 26 lines
---
Patch based on next-20140610
drivers/mmc/host/sdhci-msm.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/mmc/host/sdhci-msm.c +4
-1@@ -468,6 +468,10 @@ MODULE_DEVICE_TABLE(of, sdhci_msm_dt_match);static struct sdhci_ops sdhci_msm_ops = { .platform_execute_tuning = sdhci_msm_execute_tuning, + .reset = sdhci_reset, + .set_clock = sdhci_set_clock, + .set_bus_width = sdhci_set_bus_width, + .set_uhs_signaling = sdhci_set_uhs_signaling, };static int sdhci_msm_probe (struct platform_device *pdev) --The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation