gstreamer1.0-omx: Target Raspberry Pi instead of Bellagio.
cover gstreamer1.0-omx: Target Raspberry Pi instead of Bellagio.
Please see following patch for details
Alex J Lennon (1):
gstreamer1.0-omx: Target Raspberry Pi instead of Bellagio.
recipes-multimedia/gstreamer/gstreamer1.0-omx.inc | 2 ++ recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend | 1 + 2 files changed, 3 insertions(+) create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-omx.inc create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend
Signature · 1 line
2.0.0
PATCH 1/1 gstreamer1.0-omx: Target Raspberry Pi instead of Bellagio.
This changes the build slightly as there are some #ifdefs in there for Raspberry Pi.
Also the codec configuration file used by gstreamer1.0-omx codecs, /etc/xdg/gstomx.conf, is set correctly to core-name=/usr/lib/libopenmaxil.so
--- recipes-multimedia/gstreamer/gstreamer1.0-omx.inc | 2 ++ recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend | 1 + 2 files changed, 3 insertions(+) create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-omx.inc create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend
recipes-multimedia/gstreamer/gstreamer1.0-omx.inc new file +2 -0
@@ -0,0 +1,2 @@ +GSTREAMER_1_0_OMX_TARGET="rpi" +GSTREAMER_1_0_OMX_CORE_NAME="/usr/lib/libopenmaxil.so"
recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend new file +1 -0
@@ -0,0 +1 @@ +require ${PN}.inc
Signature · 1 line
2.0.0
Hello Alex.
On Sun, Jun 8, 2014 at 1:50 PM, Alex J Lennon <[email protected]
Quoted 9 lines
wrote:
This changes the build slightly as there are some #ifdefs in there for Raspberry Pi.
Also the codec configuration file used by gstreamer1.0-omx codecs,
/etc/xdg/gstomx.conf, is set correctly to core-name=/usr/lib/libopenmaxil.so
Quoted 6 lines
Change-Id I2352ecabfd053717d9ccd2d22422e7d4b7588ce4Signed-off-by Alex J Lennon <[email protected]>--- recipes-multimedia/gstreamer/gstreamer1.0-omx.inc | 2 ++ recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend | 1 +
I was thinking we we really need two files for this... I know that yocto has an inc too. But i don't know if that really makes sense for one line. What do you think?
Quoted 13 lines
2 files changed, 3 insertions(+) create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-omx.inc create mode 100644recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend
recipes-multimedia/gstreamer/gstreamer1.0-omx.inc new file +0
-0
recipes-multimedia/gstreamer/gstreamer1.0-omx.inc line 2
Quoted 2 lines
recipes-multimedia/gstreamer/gstreamer1.0-omx.inc new file +2
-0@@ -0,0 +1,2 @@ +GSTREAMER_1_0_OMX_TARGET="rpi" +GSTREAMER_1_0_OMX_CORE_NAME="/usr/lib/libopenmaxil.so"
These changes should be machine specific.
Quoted 17 lines
recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend new file +1
-1@@ -0,0 +1 @@ +require ${PN}.inc --2.0.0
--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto
Signature · 2 lines
*Andrei Gherzan* m: +40.744.478.414 | f: +40.31.816.28.12
Quoted 21 lines · Andrei Gherzan
Hello Alex.
On Sun, Jun 8, 2014 at 1:50 PM, Alex J Lennon <[email protected] <mailto:[email protected]>> wrote:
This changes the build slightly as there are some #ifdefs in there for Raspberry Pi.
Also the codec configuration file used by gstreamer1.0-omx codecs,
/etc/xdg/gstomx.conf, is set correctly to core-name=/usr/lib/libopenmaxil.soChange-Id I2352ecabfd053717d9ccd2d22422e7d4b7588ce4Signed-off-by Alex J Lennon <[email protected]<mailto:[email protected]>>
---
recipes-multimedia/gstreamer/gstreamer1.0-omx.inc | 2 ++
recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend | 1 +
Quoted 4 lines
I was thinking we we really need two files for this... I know that yocto has an inc too. But i don't know if that really makes sense for one line. What do you think?
I came across Yocto best practice here. This is more or less why I provided a patch for consideration into Poky on this earlier today. It would help me, and I suspect other newbies, to have best practice expectations on how to put patches together somewhere up front, say in the README.
"Do not merge .inc / .bb files"
https://wiki.yoctoproject.org/wiki/Best_Known_Methods_(BKMs)_for_Package_Updating
Cheers,
Alex
Quoted 34 lines · Alex J Lennon
On 10/06/2014 19:59, Andrei Gherzan wrote:
Hello Alex.
Quoted 7 lines · Alex J Lennon
This changes the build slightly as there are some #ifdefs in there for Raspberry Pi.
Also the codec configuration file used by gstreamer1.0-omx codecs,
/etc/xdg/gstomx.conf, is set correctly to core-name=/usr/lib/libopenmaxil.soQuoted 6 lines
Change-Id I2352ecabfd053717d9ccd2d22422e7d4b7588ce4Signed-off-by Alex J Lennon <[email protected]>--- recipes-multimedia/gstreamer/gstreamer1.0-omx.inc | 2 ++ recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend | 1 +I was thinking we we really need two files for this... I know that yocto
has an inc too. But i don't know if that really makes sense for one line. What do you think?I came across Yocto best practice here. This is more or less why I provided a patch for consideration into Poky on this earlier today. It would help me, and I suspect other newbies, to have best practice expectations on how to put patches together somewhere up front, say in the README.
Quoted 5 lines
"Do not merge .inc / .bb files"
https://wiki.yoctoproject.org/wiki/Best_Known_Methods_(BKMs)_for_Package_Updating
I understand. But I think that this is the case only for bb files. We are talking here about a bbappend in which case this would be pretty useless. Nobody reuses an inc for a bbappend - never seen something like that.
Signature · 2 lines
*Andrei Gherzan* m: +40.744.478.414 | f: +40.31.816.28.12
Re: ***UNCHECKED*** Re: [meta-raspberrypi][PATCH 1/1] gstreamer1.0-omx: Target Raspberry Pi instead of Bellagio.
Quoted 45 lines · Andrei Gherzan
On Wed, Jun 11, 2014 at 2:27 AM, Alex J Lennon <[email protected] <mailto:[email protected]>> wrote:
On 10/06/2014 19:59, Andrei Gherzan wrote:Quoted 23 lines
Hello Alex.
On Sun, Jun 8, 2014 at 1:50 PM, Alex J Lennon <[email protected] <mailto:[email protected]>> wrote:
This changes the build slightly as there are some #ifdefs in there for Raspberry Pi.
Also the codec configuration file used by gstreamer1.0-omx codecs,
/etc/xdg/gstomx.conf, is set correctly to core-name=/usr/lib/libopenmaxil.soChange-Id I2352ecabfd053717d9ccd2d22422e7d4b7588ce4Signed-off-by Alex J Lennon <[email protected]<mailto:[email protected]>>
---
recipes-multimedia/gstreamer/gstreamer1.0-omx.inc | 2 ++ recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend
| 1 +Quoted 4 lines
I was thinking we we really need two files for this... I know that yocto has an inc too. But i don't know if that really makes sense for one line. What do you think?
I came across Yocto best practice here. This is more or less why I provided a patch for consideration into Poky on this earlier today. It would help me, and I suspect other newbies, to have best practice expectations on how to put patches together somewhere up front, say in the README.
"Do not merge .inc / .bb files"
Quoted 8 lines
https://wiki.yoctoproject.org/wiki/Best_Known_Methods_(BKMs)_for_Package_Updating
<https://wiki.yoctoproject.org/wiki/Best_Known_Methods_%28BKMs%29_for_Package_Updating>I understand. But I think that this is the case only for bb files. We are talking here about a bbappend in which case this would be pretty useless. Nobody reuses an inc for a bbappend - never seen something like that.
e.g. I have gstreamer1.0-omx_git.bbappend here which reuses the .inc file. I didn't contribute it as for some reason the git build breaks and I need to look at why this is
Quoted 55 lines · Alex J Lennon
On 11/06/2014 08:47, Andrei Gherzan wrote:
Quoted 34 lines · Alex J Lennon
On 10/06/2014 19:59, Andrei Gherzan wrote:
Hello Alex.
Quoted 7 lines · Alex J Lennon
This changes the build slightly as there are some #ifdefs in there for Raspberry Pi.
Also the codec configuration file used by gstreamer1.0-omx codecs,
/etc/xdg/gstomx.conf, is set correctly to core-name=/usr/lib/libopenmaxil.soQuoted 6 lines
Change-Id I2352ecabfd053717d9ccd2d22422e7d4b7588ce4Signed-off-by Alex J Lennon <[email protected]>--- recipes-multimedia/gstreamer/gstreamer1.0-omx.inc | 2 ++ recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend | 1 +I was thinking we we really need two files for this... I know that
yocto has an inc too. But i don't know if that really makes sense for one line. What do you think?I came across Yocto best practice here. This is more or less why I
provided a patch for consideration into Poky on this earlier today. It would help me, and I suspect other newbies, to have best practice expectations on how to put patches together somewhere up front, say in the README.Quoted 5 lines
"Do not merge .inc / .bb files"
https://wiki.yoctoproject.org/wiki/Best_Known_Methods_(BKMs)_for_Package_Updating
I understand. But I think that this is the case only for bb files. We
are talking here about a bbappend in which case this would be pretty useless. Nobody reuses an inc for a bbappend - never seen something like that.
Quoted 5 lines
e.g. I have gstreamer1.0-omx_git.bbappend here which reuses the .inc file. I didn't contribute it as for some reason the git build breaks and I need to look at why this is
So, you say that if you merge your inc file in the bbappend one, the build breaks? It shouldn't really. I just tested and for me it works.
By the way, I would use _append_raspberrypi for this one too.
Signature · 2 lines
*Andrei Gherzan* m: +40.744.478.414 | f: +40.31.816.28.12
Quoted 63 lines · Andrei Gherzan
On Wed, Jun 11, 2014 at 11:19 AM, Alex J Lennon <[email protected] <mailto:[email protected]>> wrote:
On 11/06/2014 08:47, Andrei Gherzan wrote:Quoted 46 lines
On Wed, Jun 11, 2014 at 2:27 AM, Alex J Lennon <[email protected] <mailto:[email protected]>> wrote: On 10/06/2014 19:59, Andrei Gherzan wrote:Quoted 24 lines
Hello Alex.
On Sun, Jun 8, 2014 at 1:50 PM, Alex J Lennon <[email protected] <mailto:[email protected]>> wrote:
This changes the build slightly as there are some #ifdefs in there for Raspberry Pi.
Also the codec configuration file used by gstreamer1.0-omx codecs,
/etc/xdg/gstomx.conf, is set correctly to core-name=/usr/lib/libopenmaxil.soChange-Id: I2352ecabfd053717d9ccd2d22422e7d4b7588ce4
Signed-off-by: Alex J Lennon <[email protected] <mailto:[email protected]>>
---
recipes-multimedia/gstreamer/gstreamer1.0-omx.inc
| 2 ++
recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend
| 1 +Quoted 4 lines
I was thinking we we really need two files for this... I know that yocto has an inc too. But i don't know if that really makes sense for one line. What do you think?
I came across Yocto best practice here. This is more or less why I provided a patch for consideration into Poky on this earlier today. It would help me, and I suspect other newbies, to have best practice expectations on how to put patches together somewhere up front, say in the README.
"Do not merge .inc / .bb files"
Quoted 8 lines
https://wiki.yoctoproject.org/wiki/Best_Known_Methods_(BKMs)_for_Package_Updating
<https://wiki.yoctoproject.org/wiki/Best_Known_Methods_%28BKMs%29_for_Package_Updating>I understand. But I think that this is the case only for bb files. We are talking here about a bbappend in which case this would be pretty useless. Nobody reuses an inc for a bbappend - never seen something like that.
Quoted 8 lines
e.g. I have gstreamer1.0-omx_git.bbappend here which reuses the .inc file. I didn't contribute it as for some reason the git build breaks and I need to look at why this is
So, you say that if you merge your inc file in the bbappend one, the build breaks? It shouldn't really. I just tested and for me it works.
Not quite. I mean that I am reusing the code in the .inc file in another .bbappend file, called gstreamer1.0-omx_git.bbappend
This is identical to gstreamer1.0-omx_1.0.0.bbappend in that it just requires the inc file, so I don't have duplication of code.
Targetting gstreamer-omx 1.0.0 at the RPi works fine, but when I tried targetting the git source at RPi the build broke, so I didn't provide that recipe to you.
e.g. with my local.conf set to PREFERRED_VERSION_gstreamer1.0-omx = "git" the git build gives this
cc1: error: .../tmp/sysroots/raspberrypi/usr/include/vc: No such file or directory [-Werror]
cc1: error: .../tmp/sysroots/raspberrypi/usr/include/interface: No such file or directory [-Werror]
cc1: error: .../tmp/sysroots/raspberrypi/usr/include/interface/vcos: No such file or directory [-Werror]
cc1: error:
.../tmp/sysroots/raspberrypi/usr/include/interface/vcos/pthreads: No such file or directory $
cc1: all warnings being treated as errors
make[2]: *** [libgstomx_la-gstomxvideoenc.lo] Error 1 make[2]: *** Waiting for unfinished jobs....
I think there's something missing or some path not set correctly for the more recent gstreamer-omx code, but I haven't had a chance to look into it.
Quoted 4 lines
By the way, I would use
_append_raspberrypifor this one too.
OK, I just tried this instead of the anonymous python method I created in the last patch-set.
Perhaps I'm misunderstanding but, for example, we need GSTREAMER_1_0_OMX_TARGET set to 'rpi" when machine is raspberrypi
When I try,
GSTREAMER_1_0_OMX_TARGET_append_raspberrypi = "rpi"
I end up with the original value 'bellagio' appended with 'rpi' to give 'bellagiorpi'
Maybe I need something more like this?
GSTREAMER_1_0_OMX_TARGET_override_raspberrypi = "rpi"
Does such a mechanism exist in bitbake?
Regards,
Alex
Quoted 68 lines · Alex J Lennon
On 11/06/2014 18:24, Andrei Gherzan wrote:
Quoted 55 lines · Alex J Lennon
On 11/06/2014 08:47, Andrei Gherzan wrote:
Quoted 34 lines · Alex J Lennon
On 10/06/2014 19:59, Andrei Gherzan wrote:
Hello Alex.
Quoted 7 lines · Alex J Lennon
This changes the build slightly as there are some #ifdefs in there for Raspberry Pi.
Also the codec configuration file used by gstreamer1.0-omx codecs,
/etc/xdg/gstomx.conf, is set correctly to core-name=/usr/lib/libopenmaxil.soQuoted 6 lines
Change-Id I2352ecabfd053717d9ccd2d22422e7d4b7588ce4Signed-off-by Alex J Lennon <[email protected]>--- recipes-multimedia/gstreamer/gstreamer1.0-omx.inc | 2 ++ recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend | 1 +I was thinking we we really need two files for this... I know that
yocto has an inc too. But i don't know if that really makes sense for one line. What do you think?I came across Yocto best practice here. This is more or less why I
provided a patch for consideration into Poky on this earlier today. It would help me, and I suspect other newbies, to have best practice expectations on how to put patches together somewhere up front, say in the README.Quoted 5 lines
"Do not merge .inc / .bb files"
https://wiki.yoctoproject.org/wiki/Best_Known_Methods_(BKMs)_for_Package_Updating
I understand. But I think that this is the case only for bb files. We
are talking here about a bbappend in which case this would be pretty useless. Nobody reuses an inc for a bbappend - never seen something like that.Quoted 5 lines
e.g. I have gstreamer1.0-omx_git.bbappend here which reuses the .inc file. I didn't contribute it as for some reason the git build breaks and I need to look at why this is
Quoted 8 lines
So, you say that if you merge your inc file in the bbappend one, the
build breaks? It shouldn't really. I just tested and for me it works.Not quite. I mean that I am reusing the code in the .inc file in another .bbappend file, called gstreamer1.0-omx_git.bbappend
Got it now. Makes sense in this case, agreed.
Quoted 44 lines
This is identical to gstreamer1.0-omx_1.0.0.bbappend in that it just requires the inc file, so I don't have duplication of code.
Targetting gstreamer-omx 1.0.0 at the RPi works fine, but when I tried targetting the git source at RPi the build broke, so I didn't provide that recipe to you.
e.g. with my local.conf set to PREFERRED_VERSION_gstreamer1.0-omx = "git" the git build gives this
cc1: error: .../tmp/sysroots/raspberrypi/usr/include/vc: No such file or directory [-Werror]
cc1: error: .../tmp/sysroots/raspberrypi/usr/include/interface: No such file or directory [-Werror]
cc1: error: .../tmp/sysroots/raspberrypi/usr/include/interface/vcos: No such file or directory [-Werror]
cc1: error:
.../tmp/sysroots/raspberrypi/usr/include/interface/vcos/pthreads: No such file or directory $
cc1: all warnings being treated as errors
make[2]: *** [libgstomx_la-gstomxvideoenc.lo] Error 1 make[2]: *** Waiting for unfinished jobs....I think there's something missing or some path not set correctly for the more recent gstreamer-omx code, but I haven't had a chance to look into it.
Most probably you mangle some paths there. Needs some investigation.
By the way, I would use
_append_raspberrypifor this one too.OK, I just tried this instead of the anonymous python method I created in the last patch-set.
Perhaps I'm misunderstanding but, for example, we need
GSTREAMER_1_0_OMX_TARGETset to 'rpi" when machine is raspberrypiWhen I try,
GSTREAMER_1_0_OMX_TARGET_append_raspberrypi= "rpi"
Quoted 10 lines
I end up with the original value 'bellagio' appended with 'rpi' to give 'bellagiorpi'
Maybe I need something more like this?
GSTREAMER_1_0_OMX_TARGET_override_raspberrypi= "rpi"Does such a mechanism exist in bitbake?
Yes. To override a variable you just don't use "append":VARIABLE_mymachine = "my value"
Signature · 2 lines
*Andrei Gherzan* m: +40.744.478.414 | f: +40.31.816.28.12