btrfs: free ulist in qgroup_shared_accounting() error path

PATCH New Eric Sandeen 1 participant 1 message Jun 12, 2014 Btrfs file system

Share & tools

Eric Sandeen

author

2014-06-12 05:14 UTC #0 lore raw

PATCH 1/1 btrfs: free ulist in qgroup_shared_accounting() error path

If tmp = ulist_alloc(GFP_NOFS) fails, we return without freeing the previously allocated qgroups = ulist_alloc(GFP_NOFS) and cause a memory leak.

Signed-off-by Eric Sandeen <[email protected]>

---

fs/btrfs/qgroup.c +3 -1

index cf5aead..98cb6b2 100644
@@ -1798,8 +1798,10 @@ static int qgroup_shared_accounting(struct btrfs_trans_handle *trans,
 		return -ENOMEM;
 
 	tmp = ulist_alloc(GFP_NOFS);
-	if (!tmp)
+	if (!tmp) {
+		ulist_free(qgroups);
 		return -ENOMEM;
+	}
 
 	btrfs_get_tree_mod_seq(fs_info, &elem);
 	ret = btrfs_find_all_roots(trans, fs_info, oper->bytenr, elem.seq,