Skip to contentSkip to conversation

phy: Fix typo in drivers/phy/phy-exynos5250-sata.c module which fixes the build

PATCH In review Guillaume Gardet 4 participants 7 messages Jun 12, 2014

Subsystems (2)
Arm Samsung Exynos Generic PHY framework
lore
Share & tools
lore

Guillaume Gardet

author
#0 lore raw

PATCH 1/1 phy: Fix typo in drivers/phy/phy-exynos5250-sata.c module which fixes the build

Hi,

please find in attachment a patch which fixes a typo in drivers/phy/phy-exynos5250-sata.c module license. It fixes the following build error:
FATAL: modpost: GPL-incompatible module phy-exynos5250-sata.ko uses GPL-only symbol 'platform_driver_unregister'

Please keep me in CC since I am not subscribed to the [email protected] ML.

Signed-off-by Guillaume GARDET <[email protected]>

Regards,

Guillaume

Quoted 1 line

From d46b09fbf39bb8820b65e064482b923252379b8a Mon Sep 17 00:00:00 2001

From: Guillaume GARDET <[email protected]>
Date: Thu, 12 Jun 2014 10:02:15 +0200
Subject: [PATCH] Fix typo in drivers/phy/phy-exynos5250-sata.c module
license. It fixes the following error: FATAL: modpost:
GPL-incompatible module phy-exynos5250-sata.ko uses GPL-only symbol 'platform_driver_unregister'

---
 drivers/phy/phy-exynos5250-sata.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/phy/phy-exynos5250-sata.c +1 -1
index c9361b7..0568945 100644
@@ -246,6 +246,6 @@ static struct platform_driver exynos_sata_phy_driver = {
 module_platform_driver(exynos_sata_phy_driver);
 
 MODULE_DESCRIPTION("Samsung SerDes PHY driver");
-MODULE_LICENSE("GPL V2");
+MODULE_LICENSE("GPL v2");
 MODULE_AUTHOR("Girish K S <[email protected]>");
 MODULE_AUTHOR("Yuvaraj C D <[email protected]>");
Signature · 1 line
1.7.10.4
#1 lore raw

Hi Guillaume,

Quoted 9 lines · Guillaume Gardet

Hi,

please find in attachment a patch which fixes a typo in drivers/phy/phy-exynos5250-sata.c module license. It fixes the following build error:
FATAL: modpost: GPL-incompatible module phy-exynos5250-sata.ko uses GPL-only symbol 'platform_driver_unregister'

Please keep me in CC since I am not subscribed to the [email protected] ML.

Signed-off-by Guillaume GARDET <[email protected]>

A similar patch has already been submitted by Arnd. Please see below:
https://lkml.org/lkml/2014/3/15/40

In general, sending an attachment is not the right way to submit a patch. Please refer Documentation/SubmittingPatches in the kernel source for the correct procedure.

Regards,
Sachin.

author
#2 lore raw
Quoted 11 lines · Sachin Kamat

Hi Guillaume,

Quoted 6 lines · Guillaume Gardet

Hi,

please find in attachment a patch which fixes a typo in drivers/phy/phy-exynos5250-sata.c module license. It fixes the following build error:
FATAL: modpost: GPL-incompatible module phy-exynos5250-sata.ko uses GPL-only symbol 'platform_driver_unregister'

Quoted 5 lines
Quoted 3 lines

Please keep me in CC since I am not subscribed to the [email protected] ML.

Signed-off-by Guillaume GARDET <[email protected]>

A similar patch has already been submitted by Arnd. Please see below:
https://lkml.org/lkml/2014/3/15/40

Was not aware of this one. Will it be merged? I can see that it was sent 3 months ago and got no answer apparently.

Quoted 4 lines

In general, sending an attachment is not the right way to submit a patch. Please refer Documentation/SubmittingPatches in the kernel source for the correct procedure.

Sorry, I forgot to send it inline.

Guillaume

#3 lore raw
Quoted 13 lines · Guillaume Gardet
Quoted 11 lines · Sachin Kamat

Hi Guillaume,

Quoted 6 lines · Guillaume Gardet

Hi,

please find in attachment a patch which fixes a typo in drivers/phy/phy-exynos5250-sata.c module license. It fixes the following build error:
FATAL: modpost: GPL-incompatible module phy-exynos5250-sata.ko uses GPL-only symbol 'platform_driver_unregister'

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Please keep me in CC since I am not subscribed to the [email protected] ML.

Signed-off-by Guillaume GARDET <[email protected]>

A similar patch has already been submitted by Arnd. Please see below:
https://lkml.org/lkml/2014/3/15/40

Was not aware of this one. Will it be merged? I can see that it was sent 3 months ago and got no answer apparently.

It's in mainline kernel already
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/phy/phy-exynos5250-sata.c?id=fe04e4297e6eab014a2cf152319b9f361df07faf

-Kishon

Quoted 11 lines
Quoted 5 lines

In general, sending an attachment is not the right way to submit a patch. Please refer Documentation/SubmittingPatches in the kernel source for the correct procedure.

Sorry, I forgot to send it inline.

Guillaume

author
#4 lore raw
Quoted 14 lines · Kishon Vijay Abraham I
Quoted 12 lines · Guillaume Gardet
Quoted 11 lines · Sachin Kamat

Hi Guillaume,

Quoted 6 lines · Guillaume Gardet

Hi,

please find in attachment a patch which fixes a typo in drivers/phy/phy-exynos5250-sata.c module license. It fixes the following build error:
FATAL: modpost: GPL-incompatible module phy-exynos5250-sata.ko uses GPL-only symbol 'platform_driver_unregister'

Quoted 8 lines
Quoted 6 lines
Quoted 5 lines
Quoted 3 lines

Please keep me in CC since I am not subscribed to the [email protected] ML.

Signed-off-by Guillaume GARDET <[email protected]>

A similar patch has already been submitted by Arnd. Please see below:
https://lkml.org/lkml/2014/3/15/40

Was not aware of this one. Will it be merged? I can see that it was sent 3 months ago and got no answer apparently.

It's in mainline kernel already
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/phy/phy-exynos5250-sata.c?id=fe04e4297e6eab014a2cf152319b9f361df07faf

Ok. It is in mainline but not in 3.15.

Guillaume

#5 lore raw
Quoted 18 lines · Guillaume Gardet
Quoted 16 lines · Kishon Vijay Abraham I
Quoted 14 lines · Guillaume Gardet
Quoted 13 lines · Sachin Kamat

Hi Guillaume,

Quoted 8 lines · Guillaume Gardet

Hi,

please find in attachment a patch which fixes a typo in drivers/phy/phy-exynos5250-sata.c module license. It fixes the following build error:
FATAL: modpost: GPL-incompatible module phy-exynos5250-sata.ko uses GPL-only symbol 'platform_driver_unregister'

Please keep me in CC since I am not subscribed to the [email protected] ML.

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Guillaume GARDET <[email protected]>

A similar patch has already been submitted by Arnd. Please see below:
https://lkml.org/lkml/2014/3/15/40

Was not aware of this one. Will it be merged? I can see that it was sent 3 months ago and got no answer apparently.

It's in mainline kernel already
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/phy/phy-exynos5250-sata.c?id=fe04e4297e6eab014a2cf152319b9f361df07faf

Ok. It is in mainline but not in 3.15.

hmm, yes. It went in this merge window.

-Kishon

Quoted 4 lines

Guillaume

#6 lore raw
In reply to Guillaume Gardet
Quoted 17 lines · Guillaume Gardet
Quoted 16 lines · Kishon Vijay Abraham I
Quoted 14 lines · Guillaume Gardet
Quoted 13 lines · Sachin Kamat

Hi Guillaume,

Quoted 8 lines · Guillaume Gardet

Hi,

please find in attachment a patch which fixes a typo in drivers/phy/phy-exynos5250-sata.c module license. It fixes the following build error:
FATAL: modpost: GPL-incompatible module phy-exynos5250-sata.ko uses GPL-only symbol 'platform_driver_unregister'

Please keep me in CC since I am not subscribed to the [email protected] ML.

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Guillaume GARDET <[email protected]>

A similar patch has already been submitted by Arnd. Please see below:
https://lkml.org/lkml/2014/3/15/40

Was not aware of this one. Will it be merged? I can see that it was sent 3 months ago and got no answer apparently.

It's in mainline kernel already
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/phy/phy-exynos5250-sata.c?id=fe04e4297e6eab014a2cf152319b9f361df07faf

Ok. It is in mainline but not in 3.15.

And as it stands, it won't be, because [email protected] was not Cc'd. "Typo" in the subject makes it sound like a trivial and minor change. "Fix module loading" would probably have made it clearer that it fixes a real issue.

Guillaume, if this bothers you, please write to [email protected] and kindly ask them to consider including this commit in future stable releases.

Signature · 2 lines
Jean Delvare
SUSE L3 Support