Skip to contentSkip to conversation

via-rhine: fix full-duplex with autoneg disable

PATCH Applied François Cachereul 2 participants 2 messages Jun 12, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 via-rhine: fix full-duplex with autoneg disable

With some specific configuration (VT6105M on Soekris 5510 and depending on the device at the other end), fragmented packets were not transmitted when forcing 100 full-duplex with autoneg disable.

This fix now write full-duplex chips register when forcing full or half-duplex not only when autoneg is enable.

---
 drivers/net/ethernet/via/via-rhine.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/net/ethernet/via/via-rhine.c +3 -2
index f61dc2b..25bb25b 100644
@@ -1278,8 +1278,9 @@ static void rhine_set_carrier(struct mii_if_info *mii)
 		/* autoneg is off: Link is always assumed to be up */
 		if (!netif_carrier_ok(dev))
 			netif_carrier_on(dev);
-	} else	/* Let MMI library update carrier status */
-		rhine_check_media(dev, 0);
+	}
+
+	rhine_check_media(dev, 0);
 
 	netif_info(rp, link, dev, "force_media %d, carrier %d\n",
 		   mii->force_media, netif_carrier_ok(dev));
Signature · 1 line
1.7.10.4
maintainer Applied
#1 lore raw

From: François Cachereul <[email protected]>
Date: Thu, 12 Jun 2014 12:11:25 +0200

Quoted 8 lines

With some specific configuration (VT6105M on Soekris 5510 and depending on the device at the other end), fragmented packets were not transmitted when forcing 100 full-duplex with autoneg disable.

This fix now write full-duplex chips register when forcing full or half-duplex not only when autoneg is enable.

Applied.