Skip to contentSkip to conversation

xf86-video-intel hits an assert when using dri and xorg is not suid root

DISCUSSION Hans de Goede 2 participants 5 messages Jun 13, 2014

lore
Share & tools
lore
#0 lore raw

Hi,

When trying to run the latest xorg + intel drv, with dri3, with Xorg not running as root, the followin assert in src/intel_device.c: authorise() :

assert(is_i915_gem(fd));

Triggers, this is caused by the DRM_IOCTL_I915_GETPARAM ioctl in is_i915_gem() failing with -EACCESS in this case.

I thought that the use of rendernodes should work as normal user ?

Regards,

Hans

#1 lore raw
Quoted 11 lines · Hans de Goede

Hi,

When trying to run the latest xorg + intel drv, with dri3, with Xorg not running as root, the followin assert in src/intel_device.c: authorise() :

assert(is_i915_gem(fd));

Triggers, this is caused by the DRM_IOCTL_I915_GETPARAM ioctl in is_i915_gem() failing with -EACCESS in this case.

I thought that the use of rendernodes should work as normal user ?

Hmm, I have

DRM_IOCTL_DEF_DRV(I915_GETPARAM, i915_getparam, DRM_AUTH|DRM_RENDER_ALLOW),

What path did find_render_node() choose? Was it right? -Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
#2 lore raw

Hi,

Quoted 11 lines · Chris Wilson
Quoted 10 lines · Hans de Goede

Hi,

When trying to run the latest xorg + intel drv, with dri3, with Xorg not running as root, the followin assert in src/intel_device.c: authorise() :

assert(is_i915_gem(fd));

Triggers, this is caused by the DRM_IOCTL_I915_GETPARAM ioctl in is_i915_gem() failing with -EACCESS in this case.

Quoted 7 lines
Quoted 1 line

I thought that the use of rendernodes should work as normal user ?

Hmm, I have

DRM_IOCTL_DEF_DRV(I915_GETPARAM, i915_getparam, DRM_AUTH|DRM_RENDER_ALLOW),

What path did find_render_node() choose? Was it right?

I don't have USE_RENDERNODE defined in config.h, so find_render_node() is returning NULL, which makes dev->render_node point to dev->master_node, and thus makes intel_get_client_fd open the /dev/dri/card0 node a second time (when using non suid-root xorg the first time it was opened by systemd-logind and the fd was passed from systemd-logind to xf86-video-intel by the server).

Do we really want a second open in this case, maybe intel_get_client_fd should detect that render_node == master_node and re-use the master fd in that case ?

Regards,

Hans

#3 lore raw
Quoted 29 lines · Hans de Goede

Hi,

Quoted 11 lines · Chris Wilson
Quoted 10 lines · Hans de Goede

Hi,

When trying to run the latest xorg + intel drv, with dri3, with Xorg not running as root, the followin assert in src/intel_device.c: authorise() :

assert(is_i915_gem(fd));

Triggers, this is caused by the DRM_IOCTL_I915_GETPARAM ioctl in is_i915_gem() failing with -EACCESS in this case.

Quoted 7 lines
Quoted 1 line

I thought that the use of rendernodes should work as normal user ?

Hmm, I have

DRM_IOCTL_DEF_DRV(I915_GETPARAM, i915_getparam, DRM_AUTH|DRM_RENDER_ALLOW),

What path did find_render_node() choose? Was it right?

I don't have USE_RENDERNODE defined in config.h, so find_render_node() is returning NULL, which makes dev->render_node point to dev->master_node, and thus makes intel_get_client_fd open the /dev/dri/card0 node a second time (when using non suid-root xorg the first time it was opened by systemd-logind and the fd was passed from systemd-logind to xf86-video-intel by the server).

Quoted 3 lines

Do we really want a second open in this case, maybe intel_get_client_fd should detect that render_node == master_node and re-use the master fd in that case ?

We can't just hand out the contents of X! So let's just move the assertion to after we have a suitable fd.

committ 8322e3e5c6ed19e029f365d869c80388863c424d

Author: Chris Wilson <[email protected]>
Date:   Fri Jun 13 13:50:34 2014 +0100

intel: Check that the fd points to i915 after authorising

The call to GETPARAM requires either a rendernode or authorisation. Therefore we can only assert that the fd is a valid i915 handle after authorise() and not before.

Thanks,
-Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
#4 lore raw

Hi,

Quoted 41 lines · Chris Wilson
Quoted 29 lines · Hans de Goede

Hi,

Quoted 11 lines · Chris Wilson
Quoted 10 lines · Hans de Goede

Hi,

When trying to run the latest xorg + intel drv, with dri3, with Xorg not running as root, the followin assert in src/intel_device.c: authorise() :

assert(is_i915_gem(fd));

Triggers, this is caused by the DRM_IOCTL_I915_GETPARAM ioctl in is_i915_gem() failing with -EACCESS in this case.

Quoted 7 lines
Quoted 1 line

I thought that the use of rendernodes should work as normal user ?

Hmm, I have

DRM_IOCTL_DEF_DRV(I915_GETPARAM, i915_getparam, DRM_AUTH|DRM_RENDER_ALLOW),

What path did find_render_node() choose? Was it right?

I don't have USE_RENDERNODE defined in config.h, so find_render_node() is returning NULL, which makes dev->render_node point to dev->master_node, and thus makes intel_get_client_fd open the /dev/dri/card0 node a second time (when using non suid-root xorg the first time it was opened by systemd-logind and the fd was passed from systemd-logind to xf86-video-intel by the server).

Quoted 3 lines

Do we really want a second open in this case, maybe intel_get_client_fd should detect that render_node == master_node and re-use the master fd in that case ?

We can't just hand out the contents of X! So let's just move the assertion to after we have a suitable fd.

committ 8322e3e5c6ed19e029f365d869c80388863c424d

Author: Chris Wilson <[email protected]>
Date:   Fri Jun 13 13:50:34 2014 +0100
Quoted 8 lines

intel: Check that the fd points to i915 after authorising

The call to GETPARAM requires either a rendernode or authorisation. Therefore we can only assert that the fd is a valid i915 handle after authorise() and not before.

Thanks, I can confirm that this fixes things when the server is not running as root (I now get the gnome-shell hang as I do when the server is running as root).

Regards,

Hans