Skip to contentSkip to conversation

Suppress -Wignored-qualifiers warnings

PATCH In review Bart Van Assche 3 participants 3 messages Jun 14, 2014 – Jun 16, 2014 Scheduler

lore
Share & tools
lore

Bart Van Assche

author
#0 lore raw

PATCH 1/1 Suppress -Wignored-qualifiers warnings

Avoid that gcc reports the following warning when building with W=1:

warning: type qualifiers ignored on function return type [-Wignored-qualifiers]

Signed-off-by Bart Van Assche <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Vincent Guittot <[email protected]>
---
 include/linux/sched.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
include/linux/sched.h +4 -4
index 306f4f0..0376b05 100644
@@ -872,21 +872,21 @@ enum cpu_idle_type {
 #define SD_NUMA			0x4000	/* cross-node balancing */
 
 #ifdef CONFIG_SCHED_SMT
-static inline const int cpu_smt_flags(void)
+static inline int cpu_smt_flags(void)
 {
 	return SD_SHARE_CPUCAPACITY | SD_SHARE_PKG_RESOURCES;
 }
 #endif
 
 #ifdef CONFIG_SCHED_MC
-static inline const int cpu_core_flags(void)
+static inline int cpu_core_flags(void)
 {
 	return SD_SHARE_PKG_RESOURCES;
 }
 #endif
 
 #ifdef CONFIG_NUMA
-static inline const int cpu_numa_flags(void)
+static inline int cpu_numa_flags(void)
 {
 	return SD_NUMA;
 }

@@ -999,7 +999,7 @@ void free_sched_domains(cpumask_var_t doms[], unsigned int ndoms);
 bool cpus_share_cache(int this_cpu, int that_cpu);
 
 typedef const struct cpumask *(*sched_domain_mask_f)(int cpu);
-typedef const int (*sched_domain_flags_f)(void);
+typedef int (*sched_domain_flags_f)(void);
 
 #define SDTL_OVERLAP	0x01
Signature · 1 line
1.8.4.5
maintainer
#1 lore raw

Hi Bart,

Guenter sent similar patch few days ago
https://lkml.org/lkml/2014/6/12/743
with additional patches for ARM and powerpc architecture
https://lkml.org/lkml/2014/6/13/399
https://lkml.org/lkml/2014/6/13/407

Vincent

Quoted 53 lines · Bart Van Assche

Avoid that gcc reports the following warning when building with W=1:

warning: type qualifiers ignored on function return type [-Wignored-qualifiers]

Signed-off-by Bart Van Assche <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Vincent Guittot <[email protected]>
---
 include/linux/sched.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
include/linux/sched.h +4 -5
index 306f4f0..0376b05 100644
@@ -872,21 +872,21 @@ enum cpu_idle_type {
 #define SD_NUMA                        0x4000  /* cross-node balancing */
 
 #ifdef CONFIG_SCHED_SMT
-static inline const int cpu_smt_flags(void)
+static inline int cpu_smt_flags(void)
 {
        return SD_SHARE_CPUCAPACITY | SD_SHARE_PKG_RESOURCES;
 }
 #endif
 
 #ifdef CONFIG_SCHED_MC
-static inline const int cpu_core_flags(void)
+static inline int cpu_core_flags(void)
 {
        return SD_SHARE_PKG_RESOURCES;
 }
 #endif
 
 #ifdef CONFIG_NUMA
-static inline const int cpu_numa_flags(void)
+static inline int cpu_numa_flags(void)
 {
        return SD_NUMA;
 }

@@ -999,7 +999,7 @@ void free_sched_domains(cpumask_var_t doms[], unsigned int ndoms);
 bool cpus_share_cache(int this_cpu, int that_cpu);
 
 typedef const struct cpumask *(*sched_domain_mask_f)(int cpu);
-typedef const int (*sched_domain_flags_f)(void);
+typedef int (*sched_domain_flags_f)(void);
 
 #define SDTL_OVERLAP   0x01
 
--

1.8.4.5

#2 lore raw
Quoted 8 lines · Vincent Guittot

Hi Bart,

Guenter sent similar patch few days ago
https://lkml.org/lkml/2014/6/12/743
with additional patches for ARM and powerpc architecture
https://lkml.org/lkml/2014/6/13/399
https://lkml.org/lkml/2014/6/13/407

Still not applied, though, so maybe a few more submissions until one of them is accepted won't hurt ;-).

Guenter

Quoted 59 lines

Vincent

Quoted 53 lines · Bart Van Assche

Avoid that gcc reports the following warning when building with W=1:

warning: type qualifiers ignored on function return type [-Wignored-qualifiers]

Signed-off-by Bart Van Assche <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Vincent Guittot <[email protected]>
---
  include/linux/sched.h | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)
include/linux/sched.h +4 -5
index 306f4f0..0376b05 100644
@@ -872,21 +872,21 @@ enum cpu_idle_type {
  #define SD_NUMA                        0x4000  /* cross-node balancing */
 
  #ifdef CONFIG_SCHED_SMT
-static inline const int cpu_smt_flags(void)
+static inline int cpu_smt_flags(void)
  {
         return SD_SHARE_CPUCAPACITY | SD_SHARE_PKG_RESOURCES;
  }
  #endif
 
  #ifdef CONFIG_SCHED_MC
-static inline const int cpu_core_flags(void)
+static inline int cpu_core_flags(void)
  {
         return SD_SHARE_PKG_RESOURCES;
  }
  #endif
 
  #ifdef CONFIG_NUMA
-static inline const int cpu_numa_flags(void)
+static inline int cpu_numa_flags(void)
  {
         return SD_NUMA;
  }

@@ -999,7 +999,7 @@ void free_sched_domains(cpumask_var_t doms[], unsigned int ndoms);
  bool cpus_share_cache(int this_cpu, int that_cpu);
 
  typedef const struct cpumask *(*sched_domain_mask_f)(int cpu);
-typedef const int (*sched_domain_flags_f)(void);
+typedef int (*sched_domain_flags_f)(void);
 
  #define SDTL_OVERLAP   0x01
 
--

1.8.4.5