Skip to contentSkip to conversation

support/script/scancpan: populates Config.in with homepage

PATCH Superseded Francois Perrad 2 participants 5 messages Jun 15, 2014 – Jun 16, 2014

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Francois Perrad

author
#0 lore raw

PATCH 1/2 support/script/scancpan: populates Config.in with homepage

Signed-off-by Francois Perrad <[email protected]>
---
 support/scripts/scancpan | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
support/scripts/scancpan +4 -1
index d8723f3..bf0aaa5 100755
@@ -577,6 +577,7 @@ while (my ($distname, $dist) = each %dist) {
     mkdir $dirname unless -d $dirname;
     if ($need_target{$distname} && ($force || !-f $cfgname)) {
         my $abstract = $dist->{abstract};
+        my $homepage = $dist->{resources}->{homepage} || qq{https://metacpan.org/release/${distname}};
         say qq{write ${cfgname}} unless $quiet;
         open my $fh, q{>}, $cfgname;
         say {$fh} qq{config BR2_PACKAGE_${brname}};

@@ -585,8 +586,10 @@ while (my ($distname, $dist) = each %dist) {
             my $brdep = brname( fsname( $dep ) );
             say {$fh} qq{\tselect BR2_PACKAGE_${brdep}};
         }
-        say {$fh} qq{\thelp} if $abstract;
+        say {$fh} qq{\thelp};
         say {$fh} qq{\t  ${abstract}} if $abstract;
+        say {$fh} qq{\t  } if $abstract;
+        say {$fh} qq{\t  ${homepage}};
         close $fh;
     }
     if ($force || !-f $mkname) {
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 2/2 perl-mojolicious: new package

Signed-off-by Francois Perrad <[email protected]>
---
 package/Config.in                            |  1 +
 package/perl-mojolicious/Config.in           |  6 ++++++
 package/perl-mojolicious/perl-mojolicious.mk | 13 +++++++++++++
 3 files changed, 20 insertions(+)
 create mode 100644 package/perl-mojolicious/Config.in
 create mode 100644 package/perl-mojolicious/perl-mojolicious.mk
package/Config.in +1 -0
index f43e985..5e16ffa 100644
@@ -423,6 +423,7 @@ endif
 	source "package/perl/Config.in"
 if BR2_PACKAGE_PERL
 menu "Perl libraries/modules"
+source "package/perl-mojolicious/Config.in"
 endmenu
 endif
 	source "package/php/Config.in"
package/perl-mojolicious/Config.in new file +6 -0
new file mode 100644
index 0000000..8c9c25a
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_PERL_MOJOLICIOUS
+	bool "perl-mojolicious"
+	help
+	  Real-time web framework
+	  
+	  http://mojolicio.us
package/perl-mojolicious/perl-mojolicious.mk new file +13 -0
new file mode 100644
index 0000000..e4ced7e
@@ -0,0 +1,13 @@
+################################################################################
+#
+# perl-mojolicious
+#
+################################################################################
+
+PERL_MOJOLICIOUS_VERSION = 5.07
+PERL_MOJOLICIOUS_SOURCE = Mojolicious-$(PERL_MOJOLICIOUS_VERSION).tar.gz
+PERL_MOJOLICIOUS_SITE = $(BR2_CPAN_MIRROR)/authors/id/S/SR/SRI/
+PERL_MOJOLICIOUS_DEPENDENCIES = perl 
+PERL_MOJOLICIOUS_LICENSE = artistic_2
+
+$(eval $(perl-package))
Signature · 1 line
1.9.1
#2 lore raw

PATCH 2/2 perl-mojolicious: new package

Quoted 1 line · Francois Perrad
Signed-off-by Francois Perrad <[email protected]>
Tested-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

(build-tested)

However:

Quoted 13 lines
---
 package/Config.in                            |  1 +
 package/perl-mojolicious/Config.in           |  6 ++++++
 package/perl-mojolicious/perl-mojolicious.mk | 13 +++++++++++++
 3 files changed, 20 insertions(+)
 create mode 100644 package/perl-mojolicious/Config.in
 create mode 100644 package/perl-mojolicious/perl-mojolicious.mk
package/Config.in +0 -0
index f43e985..5e16ffa 100644

package/Config.in endif · line 426

Quoted 4 lines
package/Config.in +1 -0
@@ -423,6 +423,7 @@ endif
 	source "package/perl/Config.in"
 if BR2_PACKAGE_PERL
 menu "Perl libraries/modules"
+source "package/perl-mojolicious/Config.in"

This should be indented with a tab.

Quoted 9 lines
package/Config.in +0 -0
 endmenu
 endif
 	source "package/php/Config.in"
package/perl-mojolicious/Config.in new file +0 -0
new file mode 100644
index 0000000..8c9c25a

package/perl-mojolicious/Config.in line 5

Quoted 5 lines
package/perl-mojolicious/Config.in new file +5 -0
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_PERL_MOJOLICIOUS
+	bool "perl-mojolicious"
+	help
+	  Real-time web framework
+

Trailing whitespace.

Quoted 7 lines
package/perl-mojolicious/Config.in new file +1 -0
+	  http://mojolicio.us
package/perl-mojolicious/perl-mojolicious.mk new file +0 -0
new file mode 100644
index 0000000..e4ced7e

package/perl-mojolicious/perl-mojolicious.mk line 10

Quoted 10 lines
package/perl-mojolicious/perl-mojolicious.mk new file +10 -0
@@ -0,0 +1,13 @@
+################################################################################
+#
+# perl-mojolicious
+#
+################################################################################
+
+PERL_MOJOLICIOUS_VERSION = 5.07
+PERL_MOJOLICIOUS_SOURCE = Mojolicious-$(PERL_MOJOLICIOUS_VERSION).tar.gz
+PERL_MOJOLICIOUS_SITE = $(BR2_CPAN_MIRROR)/authors/id/S/SR/SRI/
+PERL_MOJOLICIOUS_DEPENDENCIES = perl

Trailing whitespace - probably something to fix in the scancpan script.

Regards,
Arnout

Quoted 4 lines
package/perl-mojolicious/perl-mojolicious.mk new file +3 -0
+PERL_MOJOLICIOUS_LICENSE = artistic_2
+
+$(eval $(perl-package))
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#3 lore raw

PATCH 1/2 support/script/scancpan: populates Config.in with homepage

In reply to Francois Perrad
Quoted 1 line · Francois Perrad
Signed-off-by Francois Perrad <[email protected]>
Reviewed-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Regards,
Arnout

Quoted 29 lines
---
 support/scripts/scancpan | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
support/scripts/scancpan +4 -1
index d8723f3..bf0aaa5 100755
@@ -577,6 +577,7 @@ while (my ($distname, $dist) = each %dist) {
     mkdir $dirname unless -d $dirname;
     if ($need_target{$distname} && ($force || !-f $cfgname)) {
         my $abstract = $dist->{abstract};
+        my $homepage = $dist->{resources}->{homepage} || qq{https://metacpan.org/release/${distname}};
         say qq{write ${cfgname}} unless $quiet;
         open my $fh, q{>}, $cfgname;
         say {$fh} qq{config BR2_PACKAGE_${brname}};

@@ -585,8 +586,10 @@ while (my ($distname, $dist) = each %dist) {
             my $brdep = brname( fsname( $dep ) );
             say {$fh} qq{\tselect BR2_PACKAGE_${brdep}};
         }
-        say {$fh} qq{\thelp} if $abstract;
+        say {$fh} qq{\thelp};
         say {$fh} qq{\t  ${abstract}} if $abstract;
+        say {$fh} qq{\t  } if $abstract;
+        say {$fh} qq{\t  ${homepage}};
         close $fh;
     }
     if ($force || !-f $mkname) {
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#4 lore raw

PATCH 1/2 support/script/scancpan: populates Config.in with homepage

Quoted 4 lines · Arnout Vandecappelle
Quoted 1 line · Francois Perrad
Signed-off-by Francois Perrad <[email protected]>
Reviewed-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Scratch that, I have a comment:

Quoted 20 lines

Regards,
Arnout

Quoted 16 lines
---
 support/scripts/scancpan | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
support/scripts/scancpan +1 -0
index d8723f3..bf0aaa5 100755
@@ -577,6 +577,7 @@ while (my ($distname, $dist) = each %dist) {
     mkdir $dirname unless -d $dirname;
     if ($need_target{$distname} && ($force || !-f $cfgname)) {
         my $abstract = $dist->{abstract};
+        my $homepage = $dist->{resources}->{homepage} || qq{https://metacpan.org/release/${distname}};
         say qq{write ${cfgname}} unless $quiet;
         open my $fh, q{>}, $cfgname;
         say {$fh} qq{config BR2_PACKAGE_${brname}};
Quoted 8 lines

support/scripts/scancpan while (my ($distname, $dist) = each %dist) { · line 591

Quoted 8 lines
support/scripts/scancpan +2 -1
@@ -585,8 +586,10 @@ while (my ($distname, $dist) = each %dist) {
             my $brdep = brname( fsname( $dep ) );
             say {$fh} qq{\tselect BR2_PACKAGE_${brdep}};
         }
-        say {$fh} qq{\thelp} if $abstract;
+        say {$fh} qq{\thelp};
         say {$fh} qq{\t  ${abstract}} if $abstract;
+        say {$fh} qq{\t  } if $abstract;

There shouldn't be any leading whitespace here, so just make it:

         say {$fh} qq{\t  ${abstract}\n} if $abstract;

(if that is perlish enough).

Quoted 7 lines
Quoted 5 lines
support/scripts/scancpan +1 -0
+        say {$fh} qq{\t  ${homepage}};
         close $fh;
     }
     if ($force || !-f $mkname) {
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F