Skip to contentSkip to conversation

powerpc: check/return actual error on sysfs functions

PATCH Applied Jeff Liu 3 participants 3 messages Jun 17, 2014 – Jun 24, 2014 PowerPC

lore
Share & tools
lore

Jeff Liu

author
#0 lore raw

PATCH 4/24 powerpc: check/return actual error on sysfs functions

From: Jie Liu <[email protected]>

Cc Benjamin Herrenschmidt <[email protected]>
Cc Paul Mackerras <[email protected]>
Signed-off-by Jie Liu <[email protected]>
---
 arch/powerpc/platforms/powernv/opal-dump.c | 2 +-
 arch/powerpc/platforms/powernv/opal-elog.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
arch/powerpc/platforms/powernv/opal-dump.c +1 -1
index 788a197..e718baf 100644
@@ -424,7 +424,7 @@ void __init opal_platform_dump_init(void)
 	int rc;
 
 	dump_kset = kset_create_and_add("dump", NULL, opal_kobj);
-	if (!dump_kset) {
+	if (IS_ERR(dump_kset)) {
 		pr_warn("%s: Failed to create dump kset\n", __func__);
 		return;
 	}
arch/powerpc/platforms/powernv/opal-elog.c +2 -2
index 10268c4..09c1f6f 100644
@@ -296,9 +296,9 @@ int __init opal_elog_init(void)
 	int rc = 0;
 
 	elog_kset = kset_create_and_add("elog", NULL, opal_kobj);
-	if (!elog_kset) {
+	if (IS_ERR(elog_kset)) {
 		pr_warn("%s: failed to create elog kset\n", __func__);
-		return -1;
+		return PTR_ERR(elog_kset);
 	}
 
 	rc = opal_notifier_register(&elog_nb);
Signature · 1 line
1.8.3.2
#2 lore raw
Quoted 11 lines · Greg KH
Quoted 9 lines · Jeff Liu

From: Jie Liu <[email protected]>

Cc Benjamin Herrenschmidt <[email protected]>
Cc Paul Mackerras <[email protected]>
Signed-off-by Jie Liu <[email protected]>
---
 arch/powerpc/platforms/powernv/opal-dump.c | 2 +-
 arch/powerpc/platforms/powernv/opal-elog.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
Quoted 1 line

Ben and Paul, please do not take this patch, it is incorrect.

Thanks, ignored :-)

Cheers,
Ben.