Skip to contentSkip to conversation

dcmtk: new package

PATCH Superseded William Frost 3 participants 5 messages Jun 18, 2014 Arm MediaTek

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

William Frost

author
#0 lore raw

PATCH v3 1/1 dcmtk: new package

[PATCH] Changes v2 -> v3: (suggested by Thomas De Schampheleire):
- removed version selection option, only stable release is used
- added an empty new line between the comment header and the first variable definition
- fixed license file reference
- reduced and cleaning DCMTK_CFLAGS and DCMTK_CXXFLAGS declarations
- removed DCMTK_INSTALL_STAGING_OPT and DCMTK_INSTALL_TARGET_OPT
- unconditionally use --with-zlib
- removed duplicated build commands

Signed-off-by William Frost <[email protected]>
---
 package/Config.in       |  1 +
 package/dcmtk/Config.in | 12 ++++++++++++
 package/dcmtk/dcmtk.mk  | 23 +++++++++++++++++++++++
 3 files changed, 36 insertions(+)
 create mode 100644 package/dcmtk/Config.in
 create mode 100644 package/dcmtk/dcmtk.mk
package/Config.in +1 -0
index 07fd166..b88c0b0 100644
@@ -568,6 +568,7 @@ endmenu
 menu "Graphics"
 source "package/atk/Config.in"
 source "package/cairo/Config.in"
+source "package/dcmtk/Config.in"
 source "package/fltk/Config.in"
 source "package/fontconfig/Config.in"
 source "package/freetype/Config.in"
package/dcmtk/Config.in new file +12 -0
new file mode 100644
index 0000000..0800c72
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_DCMTK
+	bool "dcmtk"
+	help
+	  DCMTK is a collection of libraries and applications implementing 
+	  large parts the DICOM standard. It includes software for examining, 
+	  constructing and converting DICOM image files, handling offline 
+	  media, sending and receiving images over a network connection, as 
+	  well as demonstrative image storage and worklist servers. DCMTK is 
+	  is written in a mixture of ANSI C and C++. It comes in complete 
+	  source code and is made available as "open source" software.
+
+	  http://dicom.offis.de/dcmtk.php.en
\ No newline at end of file
package/dcmtk/dcmtk.mk new file +23 -0
new file mode 100644
index 0000000..ae2c265
@@ -0,0 +1,23 @@
+################################################################################
+#
+# dcmtk
+#
+################################################################################
+
+DCMTK_VERSION = $(call qstrip,"3.6.0")
+DCMTK_SITE = http://dicom.offis.de/download/dcmtk/dcmtk360
+
+DCMTK_LICENSE = BSD
+DCMTK_LICENSE_FILES = COPYRIGHT
+DCMTK_INSTALL_STAGING = YES
+
+DCMTK_CFLAGS = $(TARGET_CFLAGS) -O -Wall
+DCMTK_CXXFLAGS = $(TARGET_CXXFLAGS) -O  -Wall
+DCMTK_CONF_OPT = \
+	--disable-rpath --with-zlib \
+	ac_cv_my_c_rightshift_unsigned=no
+
+DCMTK_CONF_ENV = ARFLAGS=cru
+DCMTK_MAKE_OPT	= DESTDIR=$(STAGING_DIR) install-lib
+
+$(eval $(autotools-package))
Signature · 1 line
1.8.1.4
#1 lore raw

PATCH v3 1/1 dcmtk: new package

package/dcmtk/Config.in line 12

Quoted 12 lines · William Frost
package/dcmtk/Config.in new file +12 -0
+config BR2_PACKAGE_DCMTK
+	bool "dcmtk"
+	help
+	  DCMTK is a collection of libraries and applications implementing 
+	  large parts the DICOM standard. It includes software for examining, 
+	  constructing and converting DICOM image files, handling offline 
+	  media, sending and receiving images over a network connection, as 
+	  well as demonstrative image storage and worklist servers. DCMTK is 
+	  is written in a mixture of ANSI C and C++. It comes in complete 
+	  source code and is made available as "open source" software.
+
+	  http://dicom.offis.de/dcmtk.php.en

Hi.
It seems the c++ part is mandatory, so it should depend on BR2_INSTALL_LIBSTDCPP (and add a comment when it's not available, see package/msgpack/Config.in for an example).
Also there's trailing whitespace in the help text. Regards.

author
#2 lore raw

PATCH v3 1/1 dcmtk: new package

In reply to William Frost

Sorry for the delay but I'm still having problems with git send-email. This is quite new to me.
I test:
git send-email --to tsmrnd0 at gmail.com *.patch
and I'm able to receive the email. but when I
git send-email --to buildroot at busybox.net *.patch
I don't see my email on the mailling list, but it is on the sent email. I'm really sorry for using thunderbird again.
Best regard,
William

-------- Original Message --------
Subject: [Buildroot][Patch v3] dcmtk: new package
Date: Wed, 18 Jun 2014 09:05:19 +0900
From: William Frost <[email protected]>
To: buildroot at busybox.net
CC: William Frost <[email protected]>

[PATCH] Changes v2 -> v3: (suggested by Thomas De Schampheleire):
- removed version selection option, only stable release is used
- added an empty new line between the comment header and the first variable definition
- fixed license file reference
- reduced and cleaning DCMTK_CFLAGS and DCMTK_CXXFLAGS declarations
- removed DCMTK_INSTALL_STAGING_OPT and DCMTK_INSTALL_TARGET_OPT
- unconditionally use --with-zlib
- removed duplicated build commands

Signed-off-by William Frost <[email protected]>
---
  package/Config.in       |  1 +
  package/dcmtk/Config.in | 12 ++++++++++++
  package/dcmtk/dcmtk.mk  | 23 +++++++++++++++++++++++
  3 files changed, 36 insertions(+)

create mode 100644 package/dcmtk/Config.in
create mode 100644 package/dcmtk/dcmtk.mk

package/Config.in +1 -0
index 07fd166..b88c0b0 100644
@@ -568,6 +568,7 @@ endmenu
  menu "Graphics"
  source "package/atk/Config.in"
  source "package/cairo/Config.in"
+source "package/dcmtk/Config.in"
  source "package/fltk/Config.in"
  source "package/fontconfig/Config.in"
  source "package/freetype/Config.in"
package/dcmtk/Config.in new file +12 -0
new file mode 100644
index 0000000..0800c72
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_DCMTK
+	bool "dcmtk"
+	help
+	  DCMTK is a collection of libraries and applications implementing
+	  large parts the DICOM standard. It includes software for examining,
+	  constructing and converting DICOM image files, handling offline
+	  media, sending and receiving images over a network connection, as
+	  well as demonstrative image storage and worklist servers. DCMTK is
+	  is written in a mixture of ANSI C and C++. It comes in complete
+	  source code and is made available as "open source" software.
+
+	  http://dicom.offis.de/dcmtk.php.en
\ No newline at end of file
package/dcmtk/dcmtk.mk new file +23 -0
new file mode 100644
index 0000000..ae2c265
@@ -0,0 +1,23 @@
+################################################################################
+#
+# dcmtk
+#
+################################################################################
+
+DCMTK_VERSION = $(call qstrip,"3.6.0")
+DCMTK_SITE = http://dicom.offis.de/download/dcmtk/dcmtk360
+
+DCMTK_LICENSE = BSD
+DCMTK_LICENSE_FILES = COPYRIGHT
+DCMTK_INSTALL_STAGING = YES
+
+DCMTK_CFLAGS = $(TARGET_CFLAGS) -O -Wall
+DCMTK_CXXFLAGS = $(TARGET_CXXFLAGS) -O  -Wall
+DCMTK_CONF_OPT = \
+	--disable-rpath --with-zlib \
+	ac_cv_my_c_rightshift_unsigned=no
+
+DCMTK_CONF_ENV = ARFLAGS=cru
+DCMTK_MAKE_OPT	= DESTDIR=$(STAGING_DIR) install-lib
+
+$(eval $(autotools-package))
Signature · 8 lines
1.8.1.4




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140618/b79549c0/attachment.html>
#3 lore raw

PATCH v3 1/1 dcmtk: new package

Dear William Frost,

Quoted 8 lines · William Frost

Sorry for the delay but I'm still having problems with git send-email. This is quite new to me.
I test:
git send-email --to tsmrnd0 at gmail.com *.patch
and I'm able to receive the email. but when I
git send-email --to buildroot at busybox.net *.patch
I don't see my email on the mailling list, but it is on the sent email. I'm really sorry for using thunderbird again.

Your e-mail sent with git send-email was perfectly received on the mailing list:

From: William Frost <[email protected]>
To: buildroot at busybox.net
Subject: [Buildroot] [Patch v3] dcmtk: new package
Date: Wed, 18 Jun 2014 09:05:19 +0900
Sender: buildroot-bounces at busybox.net
X-Mailer: git-send-email 1.8.1.4

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#4 lore raw

PATCH v3 1/1 dcmtk: new package

In reply to William Frost

Dear William Frost,

Quoted 9 lines · William Frost

[PATCH] Changes v2 -> v3: (suggested by Thomas De Schampheleire):
- removed version selection option, only stable release is used
- added an empty new line between the comment header and the first variable definition
- fixed license file reference
- reduced and cleaning DCMTK_CFLAGS and DCMTK_CXXFLAGS declarations
- removed DCMTK_INSTALL_STAGING_OPT and DCMTK_INSTALL_TARGET_OPT
- unconditionally use --with-zlib
- removed duplicated build commands

All this text should not go into the commit log (otherwise it remains forever in the git history of the project). Instead, such changelog information should be...

Quoted 3 lines
Signed-off-by William Frost <[email protected]>

---

... here, i.e after the "---", or in a separate cover letter e-mail (see the Buildroot manual for more details about this).

Quoted 5 lines

+++ b/package/dcmtk/Config.in

package/dcmtk/Config.in new file +3 -0
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_DCMTK
+	bool "dcmtk"
+	help

package/dcmtk/Config.in line 12

Quoted 10 lines
package/dcmtk/Config.in new file +9 -0
+	  DCMTK is a collection of libraries and applications implementing 
+	  large parts the DICOM standard. It includes software for examining, 
+	  constructing and converting DICOM image files, handling offline 
+	  media, sending and receiving images over a network connection, as 
+	  well as demonstrative image storage and worklist servers. DCMTK is 
+	  is written in a mixture of ANSI C and C++. It comes in complete 
+	  source code and is made available as "open source" software.
+
+	  http://dicom.offis.de/dcmtk.php.en
\ No newline at end of file

There a missing newline at end of file, no?

package/dcmtk/dcmtk.mk line 7

Quoted 13 lines
package/dcmtk/dcmtk.mk new file +7 -0
new file mode 100644
index 0000000..ae2c265
@@ -0,0 +1,23 @@
+################################################################################
+#
+# dcmtk
+#
+################################################################################
+
+DCMTK_VERSION = $(call qstrip,"3.6.0")

Huh, why would we have this qstrip here? Why not just:

DCMTK_VERSION = 3.6.0

package/dcmtk/dcmtk.mk line 15

Quoted 8 lines
package/dcmtk/dcmtk.mk new file +8 -0
+DCMTK_SITE = http://dicom.offis.de/download/dcmtk/dcmtk360
+
+DCMTK_LICENSE = BSD
+DCMTK_LICENSE_FILES = COPYRIGHT
+DCMTK_INSTALL_STAGING = YES
+
+DCMTK_CFLAGS = $(TARGET_CFLAGS) -O -Wall
+DCMTK_CXXFLAGS = $(TARGET_CXXFLAGS) -O  -Wall

These definitions are useless. <pkg>_CFLAGS and <pkg>_CXXFLAGS are not used by the package infrastructure.

package/dcmtk/dcmtk.mk line 17

Quoted 2 lines
package/dcmtk/dcmtk.mk new file +2 -0
+DCMTK_CONF_OPT = \
+	--disable-rpath --with-zlib \

One line per option:

DCMTK_CONF_OPT = \
	--disable-rpath \
	--with-zlib

package/dcmtk/dcmtk.mk line 18

Quoted 1 line
package/dcmtk/dcmtk.mk new file +1 -0
+	ac_cv_my_c_rightshift_unsigned=no

This should be in DCMTK_CONF_ENV.

package/dcmtk/dcmtk.mk line 20

Quoted 1 line
package/dcmtk/dcmtk.mk new file +1 -0
+DCMTK_CONF_ENV = ARFLAGS=cru

Maybe a short comment explaining why it's needed would be useful.

package/dcmtk/dcmtk.mk line 21

Quoted 1 line
package/dcmtk/dcmtk.mk new file +1 -0
+DCMTK_MAKE_OPT	= DESTDIR=$(STAGING_DIR) install-lib

Useless spaces before the equal sign. Also, this should be:

DCMTK_INSTALL_STAGING_OPT = DESTDIR=$(STAGING_DIR) install-lib

Thought in this case, I wonder why we don't have a similar thing for the target installation.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com